Map OpenTelemetry environment variables to their Datadog equivalents#7184
Conversation
…r Datadog equivalents
3c092fc to
0d6eb3f
Compare
|
|
||
| @Override | ||
| public ConfigOrigin origin() { | ||
| return ConfigOrigin.ENV; |
There was a problem hiding this comment.
ENV will be reported where values can come from either ENV or JVM_PROP (and OTel config file)
There was a problem hiding this comment.
Correct, this is acceptable given the current way we layer configuration in Java
The alternative would be to split this into several sources - but that then explodes the number of sources which could be a performance issue. You would also be repeating the conflicting definition checks exponentially (because of how that's defined you cannot wait to be called, because if there's a Datadog config setting the later source would never be queried.)
So this is a pragmatic choice, given the current config design.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 16 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064963
Total [baseline] (8.573 s) : 0, 8572695
Agent [candidate] (1.062 s) : 0, 1062068
Total [candidate] (8.55 s) : 0, 8549980
section iast
Agent [baseline] (1.18 s) : 0, 1179652
Total [baseline] (9.045 s) : 0, 9044690
Agent [candidate] (1.169 s) : 0, 1169389
Total [candidate] (9.037 s) : 0, 9036900
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1168612
Total [baseline] (9.019 s) : 0, 9018929
Agent [candidate] (1.17 s) : 0, 1169539
Total [candidate] (8.972 s) : 0, 8972492
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1163761
Total [baseline] (8.995 s) : 0, 8995197
Agent [candidate] (1.178 s) : 0, 1177751
Total [candidate] (9.031 s) : 0, 9030775
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.233 ms) : 0, 666233
BytebuddyAgent [candidate] (665.785 ms) : 0, 665785
GlobalTracer [baseline] (305.586 ms) : 0, 305586
GlobalTracer [candidate] (303.291 ms) : 0, 303291
AppSec [baseline] (50.17 ms) : 0, 50170
AppSec [candidate] (49.941 ms) : 0, 49941
Logs Intake [baseline] (396.474 µs) : 0, 396
Logs Intake [candidate] (422.646 µs) : 0, 423
Remote Config [baseline] (684.13 µs) : 0, 684
Remote Config [candidate] (662.648 µs) : 0, 663
Telemetry [baseline] (7.53 ms) : 0, 7530
Telemetry [candidate] (7.53 ms) : 0, 7530
section iast
BytebuddyAgent [baseline] (786.712 ms) : 0, 786712
BytebuddyAgent [candidate] (779.081 ms) : 0, 779081
GlobalTracer [baseline] (295.591 ms) : 0, 295591
GlobalTracer [candidate] (293.03 ms) : 0, 293030
AppSec [baseline] (47.129 ms) : 0, 47129
AppSec [candidate] (46.971 ms) : 0, 46971
Logs Intake [baseline] (307.893 µs) : 0, 308
Logs Intake [candidate] (306.363 µs) : 0, 306
Remote Config [baseline] (583.247 µs) : 0, 583
Remote Config [candidate] (584.302 µs) : 0, 584
Telemetry [baseline] (7.685 ms) : 0, 7685
Telemetry [candidate] (7.805 ms) : 0, 7805
IAST [baseline] (28.221 ms) : 0, 28221
IAST [candidate] (28.32 ms) : 0, 28320
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.69 ms) : 0, 778690
BytebuddyAgent [candidate] (780.91 ms) : 0, 780910
GlobalTracer [baseline] (293.35 ms) : 0, 293350
GlobalTracer [candidate] (294.46 ms) : 0, 294460
AppSec [baseline] (46.649 ms) : 0, 46649
AppSec [candidate] (46.657 ms) : 0, 46657
Logs Intake [baseline] (302.615 µs) : 0, 303
Logs Intake [candidate] (301.937 µs) : 0, 302
Remote Config [baseline] (578.806 µs) : 0, 579
Remote Config [candidate] (576.377 µs) : 0, 576
Telemetry [baseline] (7.698 ms) : 0, 7698
Telemetry [candidate] (6.953 ms) : 0, 6953
IAST [baseline] (28.027 ms) : 0, 28027
IAST [candidate] (26.293 ms) : 0, 26293
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.406 ms) : 0, 776406
BytebuddyAgent [candidate] (783.48 ms) : 0, 783480
GlobalTracer [baseline] (293.553 ms) : 0, 293553
GlobalTracer [candidate] (297.808 ms) : 0, 297808
AppSec [baseline] (47.888 ms) : 0, 47888
AppSec [candidate] (50.79 ms) : 0, 50790
Logs Intake [baseline] (300.645 µs) : 0, 301
Logs Intake [candidate] (302.648 µs) : 0, 303
Remote Config [baseline] (566.183 µs) : 0, 566
Remote Config [candidate] (575.382 µs) : 0, 575
Telemetry [baseline] (8.225 ms) : 0, 8225
Telemetry [candidate] (8.414 ms) : 0, 8414
IAST [baseline] (23.485 ms) : 0, 23485
IAST [candidate] (22.95 ms) : 0, 22950
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068659
Total [baseline] (10.456 s) : 0, 10455858
Agent [candidate] (1.073 s) : 0, 1072659
Total [candidate] (10.447 s) : 0, 10447023
section appsec
Agent [baseline] (1.179 s) : 0, 1179117
Total [baseline] (10.499 s) : 0, 10499327
Agent [candidate] (1.183 s) : 0, 1182888
Total [candidate] (10.473 s) : 0, 10472537
section iast
Agent [baseline] (1.178 s) : 0, 1177674
Total [baseline] (10.756 s) : 0, 10755565
Agent [candidate] (1.176 s) : 0, 1175532
Total [candidate] (10.769 s) : 0, 10769450
section profiling
Agent [baseline] (1.261 s) : 0, 1260512
Total [baseline] (10.667 s) : 0, 10666704
Agent [candidate] (1.261 s) : 0, 1261288
Total [candidate] (10.686 s) : 0, 10686401
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.483 ms) : 0, 669483
BytebuddyAgent [candidate] (671.119 ms) : 0, 671119
GlobalTracer [baseline] (305.748 ms) : 0, 305748
GlobalTracer [candidate] (307.565 ms) : 0, 307565
AppSec [baseline] (50.302 ms) : 0, 50302
AppSec [candidate] (50.516 ms) : 0, 50516
Logs Intake [baseline] (408.448 µs) : 0, 408
Logs Intake [candidate] (427.741 µs) : 0, 428
Remote Config [baseline] (663.104 µs) : 0, 663
Remote Config [candidate] (673.122 µs) : 0, 673
Telemetry [baseline] (7.546 ms) : 0, 7546
Telemetry [candidate] (7.681 ms) : 0, 7681
section appsec
BytebuddyAgent [baseline] (674.543 ms) : 0, 674543
BytebuddyAgent [candidate] (677.474 ms) : 0, 677474
GlobalTracer [baseline] (297.409 ms) : 0, 297409
GlobalTracer [candidate] (297.697 ms) : 0, 297697
AppSec [baseline] (153.391 ms) : 0, 153391
AppSec [candidate] (153.013 ms) : 0, 153013
Logs Intake [baseline] (322.416 µs) : 0, 322
Logs Intake [candidate] (320.899 µs) : 0, 321
Remote Config [baseline] (658.858 µs) : 0, 659
Remote Config [candidate] (664.764 µs) : 0, 665
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.829 ms) : 0, 7829
IAST [baseline] (21.777 ms) : 0, 21777
IAST [candidate] (22.915 ms) : 0, 22915
section iast
BytebuddyAgent [baseline] (784.69 ms) : 0, 784690
BytebuddyAgent [candidate] (782.821 ms) : 0, 782821
GlobalTracer [baseline] (295.741 ms) : 0, 295741
GlobalTracer [candidate] (295.326 ms) : 0, 295326
AppSec [baseline] (47.265 ms) : 0, 47265
AppSec [candidate] (47.321 ms) : 0, 47321
Logs Intake [baseline] (304.915 µs) : 0, 305
Logs Intake [candidate] (309.135 µs) : 0, 309
Remote Config [baseline] (578.72 µs) : 0, 579
Remote Config [candidate] (577.052 µs) : 0, 577
Telemetry [baseline] (10.716 ms) : 0, 10716
Telemetry [candidate] (7.721 ms) : 0, 7721
IAST [baseline] (25.035 ms) : 0, 25035
IAST [candidate] (28.16 ms) : 0, 28160
section profiling
ProfilingAgent [baseline] (96.343 ms) : 0, 96343
ProfilingAgent [candidate] (95.583 ms) : 0, 95583
BytebuddyAgent [baseline] (662.095 ms) : 0, 662095
BytebuddyAgent [candidate] (663.883 ms) : 0, 663883
GlobalTracer [baseline] (386.115 ms) : 0, 386115
GlobalTracer [candidate] (385.755 ms) : 0, 385755
AppSec [baseline] (51.005 ms) : 0, 51005
AppSec [candidate] (50.566 ms) : 0, 50566
Logs Intake [baseline] (329.684 µs) : 0, 330
Logs Intake [candidate] (342.978 µs) : 0, 343
Remote Config [baseline] (734.827 µs) : 0, 735
Remote Config [candidate] (733.84 µs) : 0, 734
Telemetry [baseline] (7.309 ms) : 0, 7309
Telemetry [candidate] (7.375 ms) : 0, 7375
Profiling [baseline] (96.368 ms) : 0, 96368
Profiling [candidate] (95.608 ms) : 0, 95608
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (369.859 µs) : 350, 389
. : milestone, 370,
iast (479.849 µs) : 459, 501
. : milestone, 480,
iast_FULL (550.691 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (503.317 µs) : 482, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (480.781 µs) : 460, 502
. : milestone, 481,
iast_INACTIVE (458.693 µs) : 437, 480
. : milestone, 459,
iast_TELEMETRY_OFF (473.377 µs) : 452, 494
. : milestone, 473,
tracing (449.653 µs) : 427, 473
. : milestone, 450,
section candidate
no_agent (373.287 µs) : 354, 393
. : milestone, 373,
iast (480.208 µs) : 459, 502
. : milestone, 480,
iast_FULL (553.549 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (502.487 µs) : 482, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (487.635 µs) : 466, 509
. : milestone, 488,
iast_INACTIVE (456.289 µs) : 435, 478
. : milestone, 456,
iast_TELEMETRY_OFF (471.515 µs) : 450, 493
. : milestone, 472,
tracing (444.902 µs) : 424, 466
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1357
. : milestone, 1339,
appsec (1.736 ms) : 1712, 1760
. : milestone, 1736,
appsec_no_iast (1.721 ms) : 1697, 1746
. : milestone, 1721,
iast (1.467 ms) : 1443, 1491
. : milestone, 1467,
profiling (1.503 ms) : 1477, 1529
. : milestone, 1503,
tracing (1.476 ms) : 1450, 1502
. : milestone, 1476,
section candidate
no_agent (1.36 ms) : 1341, 1378
. : milestone, 1360,
appsec (1.725 ms) : 1699, 1750
. : milestone, 1725,
appsec_no_iast (1.729 ms) : 1704, 1753
. : milestone, 1729,
iast (1.47 ms) : 1448, 1493
. : milestone, 1470,
profiling (1.475 ms) : 1450, 1499
. : milestone, 1475,
tracing (1.466 ms) : 1441, 1490
. : milestone, 1466,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
. : milestone, 1460,
appsec (2.188 ms) : 2153, 2222
. : milestone, 2188,
iast (1.963 ms) : 1922, 2005
. : milestone, 1963,
iast_GLOBAL (1.999 ms) : 1958, 2039
. : milestone, 1999,
profiling (1.842 ms) : 1809, 1875
. : milestone, 1842,
tracing (1.84 ms) : 1807, 1873
. : milestone, 1840,
section candidate
no_agent (1.457 ms) : 1446, 1469
. : milestone, 1457,
appsec (2.202 ms) : 2168, 2237
. : milestone, 2202,
iast (1.963 ms) : 1922, 2005
. : milestone, 1963,
iast_GLOBAL (1.998 ms) : 1956, 2039
. : milestone, 1998,
profiling (1.841 ms) : 1808, 1873
. : milestone, 1841,
tracing (1.818 ms) : 1786, 1849
. : milestone, 1818,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~138a373b38, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (15.307 s) : 15307000, 15307000
. : milestone, 15307000,
appsec (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
iast (18.739 s) : 18739000, 18739000
. : milestone, 18739000,
iast_GLOBAL (17.894 s) : 17894000, 17894000
. : milestone, 17894000,
profiling (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
tracing (15.178 s) : 15178000, 15178000
. : milestone, 15178000,
section candidate
no_agent (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
appsec (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
iast (19.083 s) : 19083000, 19083000
. : milestone, 19083000,
iast_GLOBAL (17.849 s) : 17849000, 17849000
. : milestone, 17849000,
profiling (15.418 s) : 15418000, 15418000
. : milestone, 15418000,
tracing (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
|
What Does This Do
Warns when both are set, preferring the Datadog configuration.
Additional Notes
Also checks system properties and OpenTelemetry's optional configuration file.
Jira ticket: AIT-9801