Skip to content

Add grpc.server.method to WAF addresses with FQN of the grpc method#7079

Merged
manuel-alvarez-alvarez merged 5 commits into
masterfrom
malvarez/waf-add-grpc-server-method
Jun 14, 2024
Merged

Add grpc.server.method to WAF addresses with FQN of the grpc method#7079
manuel-alvarez-alvarez merged 5 commits into
masterfrom
malvarez/waf-add-grpc-server-method

Conversation

@manuel-alvarez-alvarez

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented May 28, 2024 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Member

What Does This Do

Adds a new WAF address named grpc.server.method with the FQN of the grpc method

Motivation

Additional Notes

Jira ticket: APPSEC-51748

@manuel-alvarez-alvarez manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label May 28, 2024
@manuel-alvarez-alvarez
manuel-alvarez-alvarez force-pushed the malvarez/waf-add-grpc-server-method branch from a68ee7e to 9cc79fe Compare May 28, 2024 08:34
@manuel-alvarez-alvarez
manuel-alvarez-alvarez marked this pull request as ready for review May 28, 2024 08:35
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested review from a team as code owners May 28, 2024 08:35
@pr-commenter

pr-commenter Bot commented May 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-add-grpc-server-method
git_commit_date 1718302534 1718353688
git_commit_sha 38271ed df37e7a
release_version 1.36.0-SNAPSHOT~38271eda58 1.36.0-SNAPSHOT~df37e7acb3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718356624 1718356624
ci_job_id 543359162 543359162
ci_pipeline_id 36756092 36756092
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060978
Total [baseline] (10.308 s) : 0, 10308306
Agent [candidate] (1.062 s) : 0, 1062367
Total [candidate] (10.258 s) : 0, 10257660
section appsec
Agent [baseline] (1.186 s) : 0, 1186224
Total [baseline] (10.478 s) : 0, 10478015
Agent [candidate] (1.184 s) : 0, 1183789
Total [candidate] (10.452 s) : 0, 10452199
section iast
Agent [baseline] (1.168 s) : 0, 1168348
Total [baseline] (10.616 s) : 0, 10615695
Agent [candidate] (1.168 s) : 0, 1167709
Total [candidate] (10.724 s) : 0, 10724285
section profiling
Agent [baseline] (1.269 s) : 0, 1268723
Total [baseline] (10.688 s) : 0, 10688221
Agent [candidate] (1.278 s) : 0, 1278017
Total [candidate] (10.783 s) : 0, 10783385
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.186 s 125.246 ms (11.8%)
Agent iast 1.168 s 107.369 ms (10.1%)
Agent profiling 1.269 s 207.745 ms (19.6%)
Total tracing 10.308 s -
Total appsec 10.478 s 169.708 ms (1.6%)
Total iast 10.616 s 307.389 ms (3.0%)
Total profiling 10.688 s 379.915 ms (3.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.184 s 121.422 ms (11.4%)
Agent iast 1.168 s 105.342 ms (9.9%)
Agent profiling 1.278 s 215.649 ms (20.3%)
Total tracing 10.258 s -
Total appsec 10.452 s 194.538 ms (1.9%)
Total iast 10.724 s 466.625 ms (4.5%)
Total profiling 10.783 s 525.724 ms (5.1%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.705 ms) : 0, 664705
BytebuddyAgent [candidate] (665.228 ms) : 0, 665228
GlobalTracer [baseline] (303.132 ms) : 0, 303132
GlobalTracer [candidate] (303.66 ms) : 0, 303660
AppSec [baseline] (50.151 ms) : 0, 50151
AppSec [candidate] (50.612 ms) : 0, 50612
Logs Intake [baseline] (388.098 µs) : 0, 388
Logs Intake [candidate] (338.259 µs) : 0, 338
Remote Config [baseline] (676.399 µs) : 0, 676
Remote Config [candidate] (679.593 µs) : 0, 680
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.541 ms) : 0, 7541
section appsec
BytebuddyAgent [baseline] (680.245 ms) : 0, 680245
BytebuddyAgent [candidate] (677.525 ms) : 0, 677525
GlobalTracer [baseline] (298.318 ms) : 0, 298318
GlobalTracer [candidate] (297.713 ms) : 0, 297713
AppSec [baseline] (152.914 ms) : 0, 152914
AppSec [candidate] (153.294 ms) : 0, 153294
Logs Intake [baseline] (324.51 µs) : 0, 325
Logs Intake [candidate] (332.604 µs) : 0, 333
Remote Config [baseline] (649.709 µs) : 0, 650
Remote Config [candidate] (652.291 µs) : 0, 652
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (8.477 ms) : 0, 8477
IAST [baseline] (21.661 ms) : 0, 21661
IAST [candidate] (22.554 ms) : 0, 22554
section iast
BytebuddyAgent [baseline] (779.333 ms) : 0, 779333
BytebuddyAgent [candidate] (778.497 ms) : 0, 778497
GlobalTracer [baseline] (292.701 ms) : 0, 292701
GlobalTracer [candidate] (293.235 ms) : 0, 293235
AppSec [baseline] (46.696 ms) : 0, 46696
AppSec [candidate] (47.335 ms) : 0, 47335
Logs Intake [baseline] (301.002 µs) : 0, 301
Logs Intake [candidate] (298.328 µs) : 0, 298
Remote Config [baseline] (564.748 µs) : 0, 565
Remote Config [candidate] (574.785 µs) : 0, 575
Telemetry [baseline] (8.486 ms) : 0, 8486
Telemetry [candidate] (9.91 ms) : 0, 9910
IAST [baseline] (27.001 ms) : 0, 27001
IAST [candidate] (24.583 ms) : 0, 24583
section profiling
ProfilingAgent [baseline] (97.148 ms) : 0, 97148
ProfilingAgent [candidate] (97.262 ms) : 0, 97262
BytebuddyAgent [baseline] (667.025 ms) : 0, 667025
BytebuddyAgent [candidate] (672.412 ms) : 0, 672412
GlobalTracer [baseline] (387.753 ms) : 0, 387753
GlobalTracer [candidate] (390.197 ms) : 0, 390197
AppSec [baseline] (50.981 ms) : 0, 50981
AppSec [candidate] (51.641 ms) : 0, 51641
Logs Intake [baseline] (333.468 µs) : 0, 333
Logs Intake [candidate] (344.909 µs) : 0, 345
Remote Config [baseline] (744.597 µs) : 0, 745
Remote Config [candidate] (713.652 µs) : 0, 714
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.45 ms) : 0, 7450
Profiling [baseline] (97.174 ms) : 0, 97174
Profiling [candidate] (97.287 ms) : 0, 97287
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060153
Total [baseline] (8.533 s) : 0, 8532578
Agent [candidate] (1.062 s) : 0, 1061988
Total [candidate] (8.559 s) : 0, 8559137
section iast
Agent [baseline] (1.166 s) : 0, 1166310
Total [baseline] (8.958 s) : 0, 8957942
Agent [candidate] (1.166 s) : 0, 1165591
Total [candidate] (8.986 s) : 0, 8986154
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1168279
Total [baseline] (8.994 s) : 0, 8994174
Agent [candidate] (1.17 s) : 0, 1169789
Total [candidate] (8.964 s) : 0, 8963747
section iast_TELEMETRY_OFF
Agent [baseline] (1.162 s) : 0, 1162169
Total [baseline] (8.969 s) : 0, 8969028
Agent [candidate] (1.169 s) : 0, 1168987
Total [candidate] (8.973 s) : 0, 8973248
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.166 s 106.157 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 108.126 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.162 s 102.016 ms (9.6%)
Total tracing 8.533 s -
Total iast 8.958 s 425.363 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.994 s 461.596 ms (5.4%)
Total iast_TELEMETRY_OFF 8.969 s 436.45 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.166 s 103.603 ms (9.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 107.802 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.169 s 106.999 ms (10.1%)
Total tracing 8.559 s -
Total iast 8.986 s 427.017 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.964 s 404.61 ms (4.7%)
Total iast_TELEMETRY_OFF 8.973 s 414.111 ms (4.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.306 ms) : 0, 664306
BytebuddyAgent [candidate] (665.116 ms) : 0, 665116
GlobalTracer [baseline] (302.885 ms) : 0, 302885
GlobalTracer [candidate] (303.608 ms) : 0, 303608
AppSec [baseline] (50.003 ms) : 0, 50003
AppSec [candidate] (50.382 ms) : 0, 50382
Logs Intake [baseline] (400.298 µs) : 0, 400
Logs Intake [candidate] (334.289 µs) : 0, 334
Remote Config [baseline] (664.637 µs) : 0, 665
Remote Config [candidate] (678.95 µs) : 0, 679
Telemetry [baseline] (7.534 ms) : 0, 7534
Telemetry [candidate] (7.491 ms) : 0, 7491
section iast
BytebuddyAgent [baseline] (777.741 ms) : 0, 777741
BytebuddyAgent [candidate] (777.828 ms) : 0, 777828
GlobalTracer [baseline] (292.693 ms) : 0, 292693
GlobalTracer [candidate] (292.61 ms) : 0, 292610
AppSec [baseline] (46.92 ms) : 0, 46920
AppSec [candidate] (47.104 ms) : 0, 47104
IAST [baseline] (26.483 ms) : 0, 26483
IAST [candidate] (26.26 ms) : 0, 26260
Logs Intake [baseline] (301.974 µs) : 0, 302
Logs Intake [candidate] (297.63 µs) : 0, 298
Remote Config [baseline] (568.474 µs) : 0, 568
Remote Config [candidate] (574.252 µs) : 0, 574
Telemetry [baseline] (8.325 ms) : 0, 8325
Telemetry [candidate] (7.631 ms) : 0, 7631
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.648 ms) : 0, 778648
BytebuddyAgent [candidate] (779.469 ms) : 0, 779469
GlobalTracer [baseline] (293.052 ms) : 0, 293052
GlobalTracer [candidate] (294.092 ms) : 0, 294092
AppSec [baseline] (46.663 ms) : 0, 46663
AppSec [candidate] (46.677 ms) : 0, 46677
IAST [baseline] (27.933 ms) : 0, 27933
IAST [candidate] (28.524 ms) : 0, 28524
Logs Intake [baseline] (301.777 µs) : 0, 302
Logs Intake [candidate] (302.972 µs) : 0, 303
Remote Config [baseline] (583.422 µs) : 0, 583
Remote Config [candidate] (555.981 µs) : 0, 556
Telemetry [baseline] (7.739 ms) : 0, 7739
Telemetry [candidate] (6.78 ms) : 0, 6780
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.844 ms) : 0, 774844
BytebuddyAgent [candidate] (780.823 ms) : 0, 780823
GlobalTracer [baseline] (292.615 ms) : 0, 292615
GlobalTracer [candidate] (293.308 ms) : 0, 293308
AppSec [baseline] (47.235 ms) : 0, 47235
AppSec [candidate] (46.472 ms) : 0, 46472
IAST [baseline] (25.765 ms) : 0, 25765
IAST [candidate] (26.543 ms) : 0, 26543
Logs Intake [baseline] (302.316 µs) : 0, 302
Logs Intake [candidate] (296.725 µs) : 0, 297
Remote Config [baseline] (567.319 µs) : 0, 567
Remote Config [candidate] (560.548 µs) : 0, 561
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.535 ms) : 0, 7535
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-14T08:49:48 2024-06-14T08:56:37
git_branch master malvarez/waf-add-grpc-server-method
git_commit_date 1718302534 1718353688
git_commit_sha 38271ed df37e7a
release_version 1.36.0-SNAPSHOT~38271eda58 1.36.0-SNAPSHOT~df37e7acb3
start_time 2024-06-14T08:49:35 2024-06-14T08:56:24
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718355741 1718355741
ci_job_id 543359163 543359163
ci_pipeline_id 36756092 36756092
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.53 µs) : 358, 397
.   : milestone, 378,
iast (478.858 µs) : 458, 500
.   : milestone, 479,
iast_FULL (548.642 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (504.89 µs) : 483, 526
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (480.628 µs) : 459, 502
.   : milestone, 481,
iast_INACTIVE (449.874 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (470.43 µs) : 449, 492
.   : milestone, 470,
tracing (437.361 µs) : 417, 458
.   : milestone, 437,
section candidate
no_agent (377.027 µs) : 357, 397
.   : milestone, 377,
iast (481.713 µs) : 461, 503
.   : milestone, 482,
iast_FULL (546.861 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (516.032 µs) : 493, 539
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (481.667 µs) : 460, 503
.   : milestone, 482,
iast_INACTIVE (450.427 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (468.961 µs) : 448, 490
.   : milestone, 469,
tracing (439.74 µs) : 417, 463
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.53 µs [357.812 µs, 397.248 µs] -
iast 478.858 µs [457.511 µs, 500.205 µs] 101.328 µs (26.8%)
iast_FULL 548.642 µs [527.619 µs, 569.665 µs] 171.112 µs (45.3%)
iast_GLOBAL 504.89 µs [483.32 µs, 526.461 µs] 127.36 µs (33.7%)
iast_HARDCODED_SECRET_DISABLED 480.628 µs [459.453 µs, 501.803 µs] 103.098 µs (27.3%)
iast_INACTIVE 449.874 µs [428.782 µs, 470.965 µs] 72.344 µs (19.2%)
iast_TELEMETRY_OFF 470.43 µs [449.076 µs, 491.784 µs] 92.9 µs (24.6%)
tracing 437.361 µs [417.171 µs, 457.55 µs] 59.83 µs (15.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.027 µs [357.11 µs, 396.944 µs] -
iast 481.713 µs [460.566 µs, 502.86 µs] 104.685 µs (27.8%)
iast_FULL 546.861 µs [525.925 µs, 567.797 µs] 169.834 µs (45.0%)
iast_GLOBAL 516.032 µs [492.643 µs, 539.422 µs] 139.005 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 481.667 µs [460.244 µs, 503.09 µs] 104.64 µs (27.8%)
iast_INACTIVE 450.427 µs [429.232 µs, 471.622 µs] 73.4 µs (19.5%)
iast_TELEMETRY_OFF 468.961 µs [447.833 µs, 490.089 µs] 91.934 µs (24.4%)
tracing 439.74 µs [416.899 µs, 462.581 µs] 62.713 µs (16.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1371
.   : milestone, 1350,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.717 ms) : 1692, 1741
.   : milestone, 1717,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.485 ms) : 1461, 1509
.   : milestone, 1485,
tracing (1.469 ms) : 1445, 1493
.   : milestone, 1469,
section candidate
no_agent (1.339 ms) : 1320, 1359
.   : milestone, 1339,
appsec (1.718 ms) : 1694, 1742
.   : milestone, 1718,
appsec_no_iast (1.738 ms) : 1713, 1763
.   : milestone, 1738,
iast (1.464 ms) : 1442, 1487
.   : milestone, 1464,
profiling (1.47 ms) : 1445, 1494
.   : milestone, 1470,
tracing (1.472 ms) : 1449, 1496
.   : milestone, 1472,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.33 ms, 1.371 ms] -
appsec 1.732 ms [1.708 ms, 1.756 ms] 381.558 µs (28.3%)
appsec_no_iast 1.717 ms [1.692 ms, 1.741 ms] 366.449 µs (27.1%)
iast 1.481 ms [1.458 ms, 1.504 ms] 130.886 µs (9.7%)
profiling 1.485 ms [1.461 ms, 1.509 ms] 134.683 µs (10.0%)
tracing 1.469 ms [1.445 ms, 1.493 ms] 118.59 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.359 ms] -
appsec 1.718 ms [1.694 ms, 1.742 ms] 378.301 µs (28.2%)
appsec_no_iast 1.738 ms [1.713 ms, 1.763 ms] 398.392 µs (29.7%)
iast 1.464 ms [1.442 ms, 1.487 ms] 125.045 µs (9.3%)
profiling 1.47 ms [1.445 ms, 1.494 ms] 130.268 µs (9.7%)
tracing 1.472 ms [1.449 ms, 1.496 ms] 132.81 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-add-grpc-server-method
git_commit_date 1718302534 1718353688
git_commit_sha 38271ed df37e7a
release_version 1.36.0-SNAPSHOT~38271eda58 1.36.0-SNAPSHOT~df37e7acb3
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718356128 1718356128
ci_job_id 543359164 543359164
ci_pipeline_id 36756092 36756092
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
appsec (14.878 s) : 14878000, 14878000
.   : milestone, 14878000,
iast (18.821 s) : 18821000, 18821000
.   : milestone, 18821000,
iast_GLOBAL (17.713 s) : 17713000, 17713000
.   : milestone, 17713000,
profiling (15.542 s) : 15542000, 15542000
.   : milestone, 15542000,
tracing (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
section candidate
no_agent (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
appsec (15.257 s) : 15257000, 15257000
.   : milestone, 15257000,
iast (18.728 s) : 18728000, 18728000
.   : milestone, 18728000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
.   : milestone, 17958000,
profiling (15.966 s) : 15966000, 15966000
.   : milestone, 15966000,
tracing (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.947 s [14.947 s, 14.947 s] -
appsec 14.878 s [14.878 s, 14.878 s] -69.0 ms (-0.5%)
iast 18.821 s [18.821 s, 18.821 s] 3.874 s (25.9%)
iast_GLOBAL 17.713 s [17.713 s, 17.713 s] 2.766 s (18.5%)
profiling 15.542 s [15.542 s, 15.542 s] 595.0 ms (4.0%)
tracing 15.178 s [15.178 s, 15.178 s] 231.0 ms (1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.939 s [14.939 s, 14.939 s] -
appsec 15.257 s [15.257 s, 15.257 s] 318.0 ms (2.1%)
iast 18.728 s [18.728 s, 18.728 s] 3.789 s (25.4%)
iast_GLOBAL 17.958 s [17.958 s, 17.958 s] 3.019 s (20.2%)
profiling 15.966 s [15.966 s, 15.966 s] 1.027 s (6.9%)
tracing 15.015 s [15.015 s, 15.015 s] 76.0 ms (0.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~df37e7acb3, baseline=1.36.0-SNAPSHOT~38271eda58
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.215 ms) : 2181, 2249
.   : milestone, 2215,
iast (1.962 ms) : 1921, 2003
.   : milestone, 1962,
iast_GLOBAL (2.016 ms) : 1974, 2057
.   : milestone, 2016,
profiling (1.854 ms) : 1821, 1888
.   : milestone, 1854,
tracing (1.821 ms) : 1789, 1852
.   : milestone, 1821,
section candidate
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.203 ms) : 2169, 2237
.   : milestone, 2203,
iast (1.974 ms) : 1932, 2016
.   : milestone, 1974,
iast_GLOBAL (2.022 ms) : 1980, 2064
.   : milestone, 2022,
profiling (1.856 ms) : 1822, 1889
.   : milestone, 1856,
tracing (1.826 ms) : 1794, 1859
.   : milestone, 1826,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.215 ms [2.181 ms, 2.249 ms] 755.208 µs (51.7%)
iast 1.962 ms [1.921 ms, 2.003 ms] 502.329 µs (34.4%)
iast_GLOBAL 2.016 ms [1.974 ms, 2.057 ms] 555.96 µs (38.1%)
profiling 1.854 ms [1.821 ms, 1.888 ms] 394.775 µs (27.0%)
tracing 1.821 ms [1.789 ms, 1.852 ms] 361.075 µs (24.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.203 ms [2.169 ms, 2.237 ms] 739.458 µs (50.5%)
iast 1.974 ms [1.932 ms, 2.016 ms] 510.103 µs (34.8%)
iast_GLOBAL 2.022 ms [1.98 ms, 2.064 ms] 558.284 µs (38.1%)
profiling 1.856 ms [1.822 ms, 1.889 ms] 391.863 µs (26.8%)
tracing 1.826 ms [1.794 ms, 1.859 ms] 362.61 µs (24.8%)

@manuel-alvarez-alvarez
manuel-alvarez-alvarez force-pushed the malvarez/waf-add-grpc-server-method branch from 8d780d6 to 191ce47 Compare May 28, 2024 10:09
@smola smola mentioned this pull request May 29, 2024
Merged
@manuel-alvarez-alvarez
manuel-alvarez-alvarez force-pushed the malvarez/waf-add-grpc-server-method branch from bb966e9 to a32ae9a Compare June 5, 2024 07:06
@manuel-alvarez-alvarez
manuel-alvarez-alvarez force-pushed the malvarez/waf-add-grpc-server-method branch from 4f24a27 to dfaca4b Compare June 12, 2024 11:29
@manuel-alvarez-alvarez
manuel-alvarez-alvarez force-pushed the malvarez/waf-add-grpc-server-method branch from dfaca4b to df37e7a Compare June 14, 2024 08:28
@manuel-alvarez-alvarez
manuel-alvarez-alvarez merged commit ca01312 into master Jun 14, 2024
@manuel-alvarez-alvarez
manuel-alvarez-alvarez deleted the malvarez/waf-add-grpc-server-method branch June 14, 2024 10:02
@github-actions github-actions Bot added this to the 1.35.1 milestone Jun 14, 2024
@mcculls mcculls modified the milestones: 1.35.1, 1.36.0 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes
@dougqh dougqh dougqh approved these changes
@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes
@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF)

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

5 participants

@manuel-alvarez-alvarez @smola @dougqh @ValentinZakharov @mcculls