Disable URL instrumentation by default#7073
Merged
Conversation
Avoids creating unnecessary spans when exceptions occur during custom non-HTTP connections, like the custom Jar connection recently added in #7049. Note the respective instrumentation in OpenTelemetry was also removed for the same reason. Exceptions during HTTP connections are already captured by HttpUrlConnectionInstrumentation. The URL instrumentation can be re-enabled with `DD_INTEGRATION_URLCONNECTION_ENABLED=true`
mcculls
force-pushed
the
mcculls/disable-url-instrumentation
branch
from
2f54d8d to
1ae652a
Compare
PerfectSlayer
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Exceptions during HTTP connections are already captured by
HttpUrlConnectionInstrumentationso we don't need to also instrument the genericURLconnection code.The alternative would be to have an allow (or deny) list of protocols to decide when to report URL connection exceptions as spans.
Motivation
Avoids creating unnecessary spans when exceptions occur during custom non-HTTP connections, like the custom Jar connection recently added in #7049.
Additional Notes
DD_INTEGRATION_URLCONNECTION_ENABLED=true