Improve custom Instrumenter Gradle plugin#6965
Merged
PerfectSlayer merged 4 commits intomasterfrom Apr 30, 2024
Merged
Conversation
mcculls
approved these changes
Apr 29, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077580
Total [baseline] (10.411 s) : 0, 10410731
Agent [candidate] (1.082 s) : 0, 1081532
Total [candidate] (10.525 s) : 0, 10525456
section appsec
Agent [baseline] (1.197 s) : 0, 1197446
Total [baseline] (10.493 s) : 0, 10493057
Agent [candidate] (1.194 s) : 0, 1194059
Total [candidate] (10.491 s) : 0, 10490530
section iast
Agent [baseline] (1.209 s) : 0, 1209084
Total [baseline] (10.724 s) : 0, 10723889
Agent [candidate] (1.199 s) : 0, 1198576
Total [candidate] (10.714 s) : 0, 10714069
section profiling
Agent [baseline] (1.267 s) : 0, 1267287
Total [baseline] (10.638 s) : 0, 10637791
Agent [candidate] (1.269 s) : 0, 1268976
Total [candidate] (10.587 s) : 0, 10586540
gantt
title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.276 ms) : 0, 675276
BytebuddyAgent [candidate] (678.862 ms) : 0, 678862
GlobalTracer [baseline] (310.202 ms) : 0, 310202
GlobalTracer [candidate] (310.119 ms) : 0, 310119
AppSec [baseline] (49.549 ms) : 0, 49549
AppSec [candidate] (49.635 ms) : 0, 49635
Remote Config [baseline] (662.578 µs) : 0, 663
Remote Config [candidate] (657.359 µs) : 0, 657
Telemetry [baseline] (7.549 ms) : 0, 7549
Telemetry [candidate] (7.564 ms) : 0, 7564
section appsec
BytebuddyAgent [baseline] (700.516 ms) : 0, 700516
BytebuddyAgent [candidate] (698.466 ms) : 0, 698466
GlobalTracer [baseline] (293.369 ms) : 0, 293369
GlobalTracer [candidate] (292.796 ms) : 0, 292796
AppSec [baseline] (149.952 ms) : 0, 149952
AppSec [candidate] (149.451 ms) : 0, 149451
Remote Config [baseline] (624.22 µs) : 0, 624
Remote Config [candidate] (619.884 µs) : 0, 620
Telemetry [baseline] (8.795 ms) : 0, 8795
Telemetry [candidate] (8.503 ms) : 0, 8503
IAST [baseline] (19.173 ms) : 0, 19173
IAST [candidate] (19.269 ms) : 0, 19269
section iast
BytebuddyAgent [baseline] (800.543 ms) : 0, 800543
BytebuddyAgent [candidate] (793.893 ms) : 0, 793893
GlobalTracer [baseline] (290.526 ms) : 0, 290526
GlobalTracer [candidate] (287.819 ms) : 0, 287819
AppSec [baseline] (51.746 ms) : 0, 51746
AppSec [candidate] (51.191 ms) : 0, 51191
Remote Config [baseline] (647.719 µs) : 0, 648
Remote Config [candidate] (570.684 µs) : 0, 571
Telemetry [baseline] (7.437 ms) : 0, 7437
Telemetry [candidate] (6.632 ms) : 0, 6632
IAST [baseline] (23.427 ms) : 0, 23427
IAST [candidate] (24.074 ms) : 0, 24074
section profiling
ProfilingAgent [baseline] (95.339 ms) : 0, 95339
ProfilingAgent [candidate] (95.621 ms) : 0, 95621
BytebuddyAgent [baseline] (677.024 ms) : 0, 677024
BytebuddyAgent [candidate] (677.579 ms) : 0, 677579
GlobalTracer [baseline] (380.15 ms) : 0, 380150
GlobalTracer [candidate] (380.944 ms) : 0, 380944
AppSec [baseline] (50.337 ms) : 0, 50337
AppSec [candidate] (50.188 ms) : 0, 50188
Remote Config [baseline] (700.823 µs) : 0, 701
Remote Config [candidate] (710.634 µs) : 0, 711
Telemetry [baseline] (7.435 ms) : 0, 7435
Telemetry [candidate] (7.488 ms) : 0, 7488
Profiling [baseline] (95.362 ms) : 0, 95362
Profiling [candidate] (95.645 ms) : 0, 95645
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074958
Total [baseline] (8.537 s) : 0, 8536716
Agent [candidate] (1.083 s) : 0, 1082722
Total [candidate] (8.539 s) : 0, 8539180
section iast
Agent [baseline] (1.203 s) : 0, 1203248
Total [baseline] (9.001 s) : 0, 9000900
Agent [candidate] (1.2 s) : 0, 1199873
Total [candidate] (8.989 s) : 0, 8989488
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1206499
Total [baseline] (9.02 s) : 0, 9019591
Agent [candidate] (1.197 s) : 0, 1196822
Total [candidate] (9.056 s) : 0, 9056134
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1193401
Total [baseline] (9.017 s) : 0, 9017157
Agent [candidate] (1.196 s) : 0, 1196159
Total [candidate] (8.991 s) : 0, 8991231
gantt
title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.546 ms) : 0, 673546
BytebuddyAgent [candidate] (678.687 ms) : 0, 678687
GlobalTracer [baseline] (309.561 ms) : 0, 309561
GlobalTracer [candidate] (311.186 ms) : 0, 311186
AppSec [baseline] (49.26 ms) : 0, 49260
AppSec [candidate] (49.754 ms) : 0, 49754
Remote Config [baseline] (666.826 µs) : 0, 667
Remote Config [candidate] (663.891 µs) : 0, 664
Telemetry [baseline] (7.626 ms) : 0, 7626
Telemetry [candidate] (7.661 ms) : 0, 7661
section iast
BytebuddyAgent [baseline] (795.615 ms) : 0, 795615
BytebuddyAgent [candidate] (794.559 ms) : 0, 794559
GlobalTracer [baseline] (290.18 ms) : 0, 290180
GlobalTracer [candidate] (288.535 ms) : 0, 288535
AppSec [baseline] (51.589 ms) : 0, 51589
AppSec [candidate] (51.847 ms) : 0, 51847
IAST [baseline] (24.215 ms) : 0, 24215
IAST [candidate] (23.327 ms) : 0, 23327
Remote Config [baseline] (586.792 µs) : 0, 587
Remote Config [candidate] (568.128 µs) : 0, 568
Telemetry [baseline] (6.654 ms) : 0, 6654
Telemetry [candidate] (6.63 ms) : 0, 6630
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.584 ms) : 0, 798584
BytebuddyAgent [candidate] (792.13 ms) : 0, 792130
GlobalTracer [baseline] (289.243 ms) : 0, 289243
GlobalTracer [candidate] (287.553 ms) : 0, 287553
AppSec [baseline] (50.515 ms) : 0, 50515
AppSec [candidate] (51.573 ms) : 0, 51573
IAST [baseline] (25.4 ms) : 0, 25400
IAST [candidate] (24.084 ms) : 0, 24084
Remote Config [baseline] (1.442 ms) : 0, 1442
Remote Config [candidate] (585.39 µs) : 0, 585
Telemetry [baseline] (6.76 ms) : 0, 6760
Telemetry [candidate] (6.578 ms) : 0, 6578
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.031 ms) : 0, 790031
BytebuddyAgent [candidate] (791.361 ms) : 0, 791361
GlobalTracer [baseline] (287.901 ms) : 0, 287901
GlobalTracer [candidate] (288.386 ms) : 0, 288386
AppSec [baseline] (50.395 ms) : 0, 50395
AppSec [candidate] (49.525 ms) : 0, 49525
IAST [baseline] (22.868 ms) : 0, 22868
IAST [candidate] (23.814 ms) : 0, 23814
Remote Config [baseline] (582.673 µs) : 0, 583
Remote Config [candidate] (584.998 µs) : 0, 585
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (8.05 ms) : 0, 8050
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section baseline
no_agent (1.351 ms) : 1331, 1370
. : milestone, 1351,
appsec (1.715 ms) : 1691, 1739
. : milestone, 1715,
appsec_no_iast (1.701 ms) : 1676, 1726
. : milestone, 1701,
iast (1.485 ms) : 1462, 1508
. : milestone, 1485,
profiling (1.48 ms) : 1455, 1505
. : milestone, 1480,
tracing (1.475 ms) : 1451, 1499
. : milestone, 1475,
section candidate
no_agent (1.344 ms) : 1324, 1364
. : milestone, 1344,
appsec (1.721 ms) : 1698, 1745
. : milestone, 1721,
appsec_no_iast (1.711 ms) : 1686, 1735
. : milestone, 1711,
iast (1.478 ms) : 1456, 1501
. : milestone, 1478,
profiling (1.494 ms) : 1470, 1519
. : milestone, 1494,
tracing (1.476 ms) : 1452, 1501
. : milestone, 1476,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section baseline
no_agent (370.649 µs) : 349, 392
. : milestone, 371,
iast (470.888 µs) : 450, 492
. : milestone, 471,
iast_FULL (539.003 µs) : 518, 560
. : milestone, 539,
iast_GLOBAL (510.955 µs) : 488, 534
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (468.179 µs) : 447, 490
. : milestone, 468,
iast_INACTIVE (451.701 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (470.72 µs) : 450, 492
. : milestone, 471,
tracing (445.275 µs) : 424, 466
. : milestone, 445,
section candidate
no_agent (367.732 µs) : 348, 388
. : milestone, 368,
iast (470.618 µs) : 450, 491
. : milestone, 471,
iast_FULL (541.309 µs) : 520, 563
. : milestone, 541,
iast_GLOBAL (492.656 µs) : 472, 513
. : milestone, 493,
iast_HARDCODED_SECRET_DISABLED (468.074 µs) : 447, 489
. : milestone, 468,
iast_INACTIVE (452.226 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (471.192 µs) : 450, 493
. : milestone, 471,
tracing (444.275 µs) : 423, 465
. : milestone, 444,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section baseline
no_agent (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
appsec (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
iast (18.573 s) : 18573000, 18573000
. : milestone, 18573000,
iast_GLOBAL (17.784 s) : 17784000, 17784000
. : milestone, 17784000,
profiling (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
tracing (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
section candidate
no_agent (15.429 s) : 15429000, 15429000
. : milestone, 15429000,
appsec (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
iast (18.525 s) : 18525000, 18525000
. : milestone, 18525000,
iast_GLOBAL (17.942 s) : 17942000, 17942000
. : milestone, 17942000,
profiling (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
tracing (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~40bfa2f926, baseline=1.34.0-SNAPSHOT~58cddb6937
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1476
. : milestone, 1464,
appsec (2.188 ms) : 2154, 2222
. : milestone, 2188,
iast (1.891 ms) : 1855, 1927
. : milestone, 1891,
iast_GLOBAL (1.909 ms) : 1873, 1944
. : milestone, 1909,
profiling (1.844 ms) : 1811, 1877
. : milestone, 1844,
tracing (1.825 ms) : 1792, 1857
. : milestone, 1825,
section candidate
no_agent (1.457 ms) : 1446, 1468
. : milestone, 1457,
appsec (2.196 ms) : 2162, 2230
. : milestone, 2196,
iast (1.879 ms) : 1844, 1914
. : milestone, 1879,
iast_GLOBAL (1.924 ms) : 1887, 1960
. : milestone, 1924,
profiling (1.84 ms) : 1807, 1872
. : milestone, 1840,
tracing (1.823 ms) : 1791, 1855
. : milestone, 1823,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR improves our custom Instrumer plugin by using Gradle plugin development conventions like:
ProjectandConfigurationMotivation
This improves our build performance and cache. It also make the plugin compatible with Gradle configuration cache feature.
Additional Notes
The commits will be squashed when merging.
Jira ticket: [PROJ-IDENT]