Skip to content

Refactor propagation module to introduce better naming for methods#6945

Merged
manuel-alvarez-alvarez merged 1 commit intomasterfrom
malvarez/iast-refactor-propagation-methods
Apr 30, 2024
Merged

Refactor propagation module to introduce better naming for methods#6945
manuel-alvarez-alvarez merged 1 commit intomasterfrom
malvarez/iast-refactor-propagation-methods

Conversation

@manuel-alvarez-alvarez
Copy link
Copy Markdown
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Apr 25, 2024 •
edited
Loading

What Does This Do

Renames the methods in the PropagationModule so they adhere to the following patterns:

  • taintObject/taintString: taints an object/string specifying its source properties
  • taintObjectRange/taintStringRange: taints a range of an object/string or appends a new range if already tainted
  • taintObjectIfTainted/taintStringIfTainted: taints an object/string if the input argument is tainted
  • taintObjectIfAnyTainted/taintStringIfAnyTainted: taints an object/string if the any of the input arguments is tainted
  • taintObjectIfRangeTainted/taintStringIfRangeTainted: taints an object/string if the input argument has a tainted range that intersects
  • taintObjectDeeply: visits an object and taints its properties

There are no other changes in this PR but the rename of the previous methods.

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: refactoring comp: asm iast Application Security Management (IAST) labels Apr 25, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-refactor-propagation-methods branch from 04f9ff5 to 47747c1 Compare April 25, 2024 10:55
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 25, 2024 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-refactor-propagation-methods
git_commit_date 1714454806 1714461973
git_commit_sha 3293d86 7ee59e4
See matching parameters
Baseline Candidate
ci_job_date 1714463410 1714463410
ci_job_id 500448565 500448565
ci_pipeline_id 33224784 33224784
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce unsure
[-4822.521op/s; -22.058op/s] or [-3.944%; -0.018%]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 25, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-refactor-propagation-methods
git_commit_date 1714454806 1714461973
git_commit_sha 3293d86 7ee59e4
release_version 1.34.0-SNAPSHOT~3293d86cd4 1.34.0-SNAPSHOT~7ee59e445f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714464746 1714464746
ci_job_id 500448561 500448561
ci_pipeline_id 33224784 33224784
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083575
Total [baseline] (8.561 s) : 0, 8561266
Agent [candidate] (1.076 s) : 0, 1076203
Total [candidate] (8.535 s) : 0, 8535149
section iast
Agent [baseline] (1.201 s) : 0, 1201012
Total [baseline] (9.02 s) : 0, 9020440
Agent [candidate] (1.2 s) : 0, 1200094
Total [candidate] (8.979 s) : 0, 8979030
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1198711
Total [baseline] (8.938 s) : 0, 8937942
Agent [candidate] (1.207 s) : 0, 1206910
Total [candidate] (9.001 s) : 0, 9001231
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197369
Total [baseline] (9.004 s) : 0, 9003940
Agent [candidate] (1.198 s) : 0, 1198360
Total [candidate] (8.982 s) : 0, 8982460
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.201 s 117.436 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 115.135 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.197 s 113.793 ms (10.5%)
Total tracing 8.561 s -
Total iast 9.02 s 459.175 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.938 s 376.676 ms (4.4%)
Total iast_TELEMETRY_OFF 9.004 s 442.674 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.2 s 123.891 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 130.707 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.198 s 122.157 ms (11.4%)
Total tracing 8.535 s -
Total iast 8.979 s 443.882 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.001 s 466.082 ms (5.5%)
Total iast_TELEMETRY_OFF 8.982 s 447.311 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.883 ms) : 0, 678883
BytebuddyAgent [candidate] (674.03 ms) : 0, 674030
GlobalTracer [baseline] (311.729 ms) : 0, 311729
GlobalTracer [candidate] (310.091 ms) : 0, 310091
AppSec [baseline] (49.881 ms) : 0, 49881
AppSec [candidate] (49.482 ms) : 0, 49482
Remote Config [baseline] (668.94 µs) : 0, 669
Remote Config [candidate] (656.99 µs) : 0, 657
Telemetry [baseline] (7.734 ms) : 0, 7734
Telemetry [candidate] (7.524 ms) : 0, 7524
section iast
BytebuddyAgent [baseline] (795.753 ms) : 0, 795753
BytebuddyAgent [candidate] (795.122 ms) : 0, 795122
GlobalTracer [baseline] (288.5 ms) : 0, 288500
GlobalTracer [candidate] (288.469 ms) : 0, 288469
AppSec [baseline] (51.089 ms) : 0, 51089
AppSec [candidate] (51.723 ms) : 0, 51723
Remote Config [baseline] (587.064 µs) : 0, 587
Remote Config [candidate] (555.597 µs) : 0, 556
Telemetry [baseline] (6.62 ms) : 0, 6620
Telemetry [candidate] (6.559 ms) : 0, 6559
IAST [baseline] (24.098 ms) : 0, 24098
IAST [candidate] (23.163 ms) : 0, 23163
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.888 ms) : 0, 794888
BytebuddyAgent [candidate] (800.3 ms) : 0, 800300
GlobalTracer [baseline] (287.4 ms) : 0, 287400
GlobalTracer [candidate] (289.965 ms) : 0, 289965
AppSec [baseline] (49.882 ms) : 0, 49882
AppSec [candidate] (52.363 ms) : 0, 52363
Remote Config [baseline] (634.033 µs) : 0, 634
Remote Config [candidate] (645.616 µs) : 0, 646
Telemetry [baseline] (6.576 ms) : 0, 6576
Telemetry [candidate] (6.74 ms) : 0, 6740
IAST [baseline] (24.924 ms) : 0, 24924
IAST [candidate] (22.258 ms) : 0, 22258
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.861 ms) : 0, 793861
BytebuddyAgent [candidate] (794.579 ms) : 0, 794579
GlobalTracer [baseline] (288.165 ms) : 0, 288165
GlobalTracer [candidate] (288.104 ms) : 0, 288104
AppSec [baseline] (49.725 ms) : 0, 49725
AppSec [candidate] (53.042 ms) : 0, 53042
Remote Config [baseline] (585.393 µs) : 0, 585
Remote Config [candidate] (569.889 µs) : 0, 570
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.337 ms) : 0, 7337
IAST [baseline] (23.138 ms) : 0, 23138
IAST [candidate] (20.32 ms) : 0, 20320
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075499
Total [baseline] (10.394 s) : 0, 10393543
Agent [candidate] (1.076 s) : 0, 1076096
Total [candidate] (10.385 s) : 0, 10385059
section appsec
Agent [baseline] (1.191 s) : 0, 1190658
Total [baseline] (10.446 s) : 0, 10445945
Agent [candidate] (1.189 s) : 0, 1189046
Total [candidate] (10.44 s) : 0, 10440401
section iast
Agent [baseline] (1.2 s) : 0, 1200491
Total [baseline] (10.724 s) : 0, 10723735
Agent [candidate] (1.202 s) : 0, 1202396
Total [candidate] (10.76 s) : 0, 10760063
section profiling
Agent [baseline] (1.27 s) : 0, 1270214
Total [baseline] (10.64 s) : 0, 10640040
Agent [candidate] (1.276 s) : 0, 1275894
Total [candidate] (10.663 s) : 0, 10662767
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.191 s 115.159 ms (10.7%)
Agent iast 1.2 s 124.992 ms (11.6%)
Agent profiling 1.27 s 194.715 ms (18.1%)
Total tracing 10.394 s -
Total appsec 10.446 s 52.402 ms (0.5%)
Total iast 10.724 s 330.192 ms (3.2%)
Total profiling 10.64 s 246.497 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.189 s 112.95 ms (10.5%)
Agent iast 1.202 s 126.3 ms (11.7%)
Agent profiling 1.276 s 199.798 ms (18.6%)
Total tracing 10.385 s -
Total appsec 10.44 s 55.342 ms (0.5%)
Total iast 10.76 s 375.005 ms (3.6%)
Total profiling 10.663 s 277.708 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.818 ms) : 0, 673818
BytebuddyAgent [candidate] (674.259 ms) : 0, 674259
GlobalTracer [baseline] (309.648 ms) : 0, 309648
GlobalTracer [candidate] (309.849 ms) : 0, 309849
AppSec [baseline] (49.518 ms) : 0, 49518
AppSec [candidate] (49.296 ms) : 0, 49296
Remote Config [baseline] (653.479 µs) : 0, 653
Remote Config [candidate] (654.439 µs) : 0, 654
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.631 ms) : 0, 7631
section appsec
BytebuddyAgent [baseline] (696.196 ms) : 0, 696196
BytebuddyAgent [candidate] (695.932 ms) : 0, 695932
GlobalTracer [baseline] (291.738 ms) : 0, 291738
GlobalTracer [candidate] (291.536 ms) : 0, 291536
AppSec [baseline] (149.643 ms) : 0, 149643
AppSec [candidate] (148.863 ms) : 0, 148863
Remote Config [baseline] (617.268 µs) : 0, 617
Remote Config [candidate] (615.482 µs) : 0, 615
Telemetry [baseline] (8.405 ms) : 0, 8405
Telemetry [candidate] (8.136 ms) : 0, 8136
IAST [baseline] (19.253 ms) : 0, 19253
IAST [candidate] (19.174 ms) : 0, 19174
section iast
BytebuddyAgent [baseline] (795.027 ms) : 0, 795027
BytebuddyAgent [candidate] (795.251 ms) : 0, 795251
GlobalTracer [baseline] (288.276 ms) : 0, 288276
GlobalTracer [candidate] (288.875 ms) : 0, 288875
AppSec [baseline] (52.365 ms) : 0, 52365
AppSec [candidate] (49.648 ms) : 0, 49648
Remote Config [baseline] (565.255 µs) : 0, 565
Remote Config [candidate] (574.116 µs) : 0, 574
Telemetry [baseline] (6.601 ms) : 0, 6601
Telemetry [candidate] (6.645 ms) : 0, 6645
IAST [baseline] (23.301 ms) : 0, 23301
IAST [candidate] (26.945 ms) : 0, 26945
section profiling
ProfilingAgent [baseline] (95.707 ms) : 0, 95707
ProfilingAgent [candidate] (96.801 ms) : 0, 96801
BytebuddyAgent [baseline] (679.344 ms) : 0, 679344
BytebuddyAgent [candidate] (682.238 ms) : 0, 682238
GlobalTracer [baseline] (380.564 ms) : 0, 380564
GlobalTracer [candidate] (381.82 ms) : 0, 381820
AppSec [baseline] (49.952 ms) : 0, 49952
AppSec [candidate] (50.127 ms) : 0, 50127
Remote Config [baseline] (709.704 µs) : 0, 710
Remote Config [candidate] (711.22 µs) : 0, 711
Telemetry [baseline] (7.468 ms) : 0, 7468
Telemetry [candidate] (7.521 ms) : 0, 7521
Profiling [baseline] (95.731 ms) : 0, 95731
Profiling [candidate] (96.825 ms) : 0, 96825
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-30T07:43:19 2024-04-30T07:50:08
git_branch master malvarez/iast-refactor-propagation-methods
git_commit_date 1714454806 1714461973
git_commit_sha 3293d86 7ee59e4
release_version 1.34.0-SNAPSHOT~3293d86cd4 1.34.0-SNAPSHOT~7ee59e445f
start_time 2024-04-30T07:43:06 2024-04-30T07:49:55
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714463752 1714463752
ci_job_id 500448562 500448562
ci_pipeline_id 33224784 33224784
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.894 µs) : 350, 389
.   : milestone, 370,
iast (480.426 µs) : 460, 501
.   : milestone, 480,
iast_FULL (539.917 µs) : 518, 562
.   : milestone, 540,
iast_GLOBAL (499.882 µs) : 478, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (473.975 µs) : 452, 496
.   : milestone, 474,
iast_INACTIVE (446.1 µs) : 426, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (476.424 µs) : 454, 499
.   : milestone, 476,
tracing (450.964 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (372.109 µs) : 353, 392
.   : milestone, 372,
iast (473.576 µs) : 453, 494
.   : milestone, 474,
iast_FULL (545.823 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (501.661 µs) : 481, 522
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (479.196 µs) : 458, 501
.   : milestone, 479,
iast_INACTIVE (446.24 µs) : 426, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (469.767 µs) : 448, 491
.   : milestone, 470,
tracing (448.103 µs) : 427, 469
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.894 µs [350.335 µs, 389.454 µs] -
iast 480.426 µs [459.947 µs, 500.906 µs] 110.532 µs (29.9%)
iast_FULL 539.917 µs [518.332 µs, 561.501 µs] 170.022 µs (46.0%)
iast_GLOBAL 499.882 µs [478.454 µs, 521.31 µs] 129.988 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 473.975 µs [452.188 µs, 495.762 µs] 104.081 µs (28.1%)
iast_INACTIVE 446.1 µs [425.746 µs, 466.453 µs] 76.205 µs (20.6%)
iast_TELEMETRY_OFF 476.424 µs [454.284 µs, 498.565 µs] 106.53 µs (28.8%)
tracing 450.964 µs [429.502 µs, 472.427 µs] 81.07 µs (21.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.109 µs [352.694 µs, 391.524 µs] -
iast 473.576 µs [453.001 µs, 494.151 µs] 101.467 µs (27.3%)
iast_FULL 545.823 µs [524.538 µs, 567.107 µs] 173.714 µs (46.7%)
iast_GLOBAL 501.661 µs [480.853 µs, 522.47 µs] 129.553 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 479.196 µs [457.79 µs, 500.601 µs] 107.087 µs (28.8%)
iast_INACTIVE 446.24 µs [425.711 µs, 466.769 µs] 74.131 µs (19.9%)
iast_TELEMETRY_OFF 469.767 µs [448.45 µs, 491.084 µs] 97.658 µs (26.2%)
tracing 448.103 µs [427.5 µs, 468.706 µs] 75.994 µs (20.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1360
.   : milestone, 1341,
appsec (1.704 ms) : 1679, 1729
.   : milestone, 1704,
appsec_no_iast (1.73 ms) : 1706, 1754
.   : milestone, 1730,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.546 ms) : 1520, 1573
.   : milestone, 1546,
tracing (1.503 ms) : 1480, 1527
.   : milestone, 1503,
section candidate
no_agent (1.33 ms) : 1311, 1350
.   : milestone, 1330,
appsec (1.712 ms) : 1687, 1737
.   : milestone, 1712,
appsec_no_iast (1.737 ms) : 1713, 1762
.   : milestone, 1737,
iast (1.476 ms) : 1453, 1499
.   : milestone, 1476,
profiling (1.492 ms) : 1468, 1516
.   : milestone, 1492,
tracing (1.499 ms) : 1475, 1523
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.36 ms] -
appsec 1.704 ms [1.679 ms, 1.729 ms] 363.324 µs (27.1%)
appsec_no_iast 1.73 ms [1.706 ms, 1.754 ms] 389.352 µs (29.0%)
iast 1.481 ms [1.458 ms, 1.504 ms] 140.02 µs (10.4%)
profiling 1.546 ms [1.52 ms, 1.573 ms] 205.62 µs (15.3%)
tracing 1.503 ms [1.48 ms, 1.527 ms] 162.248 µs (12.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.33 ms [1.311 ms, 1.35 ms] -
appsec 1.712 ms [1.687 ms, 1.737 ms] 381.827 µs (28.7%)
appsec_no_iast 1.737 ms [1.713 ms, 1.762 ms] 406.876 µs (30.6%)
iast 1.476 ms [1.453 ms, 1.499 ms] 145.561 µs (10.9%)
profiling 1.492 ms [1.468 ms, 1.516 ms] 161.554 µs (12.1%)
tracing 1.499 ms [1.475 ms, 1.523 ms] 168.726 µs (12.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-refactor-propagation-methods
git_commit_date 1714454806 1714461973
git_commit_sha 3293d86 7ee59e4
release_version 1.34.0-SNAPSHOT~3293d86cd4 1.34.0-SNAPSHOT~7ee59e445f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714464265 1714464265
ci_job_id 500448563 500448563
ci_pipeline_id 33224784 33224784
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.205 ms) : 2172, 2239
.   : milestone, 2205,
iast (1.894 ms) : 1858, 1929
.   : milestone, 1894,
iast_GLOBAL (1.935 ms) : 1899, 1970
.   : milestone, 1935,
profiling (1.855 ms) : 1821, 1888
.   : milestone, 1855,
tracing (1.833 ms) : 1801, 1865
.   : milestone, 1833,
section candidate
no_agent (1.467 ms) : 1456, 1478
.   : milestone, 1467,
appsec (2.22 ms) : 2186, 2255
.   : milestone, 2220,
iast (1.89 ms) : 1855, 1925
.   : milestone, 1890,
iast_GLOBAL (1.929 ms) : 1894, 1964
.   : milestone, 1929,
profiling (1.851 ms) : 1819, 1884
.   : milestone, 1851,
tracing (1.835 ms) : 1803, 1867
.   : milestone, 1835,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.205 ms [2.172 ms, 2.239 ms] 742.98 µs (50.8%)
iast 1.894 ms [1.858 ms, 1.929 ms] 431.264 µs (29.5%)
iast_GLOBAL 1.935 ms [1.899 ms, 1.97 ms] 472.387 µs (32.3%)
profiling 1.855 ms [1.821 ms, 1.888 ms] 392.304 µs (26.8%)
tracing 1.833 ms [1.801 ms, 1.865 ms] 370.425 µs (25.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.478 ms] -
appsec 2.22 ms [2.186 ms, 2.255 ms] 753.233 µs (51.3%)
iast 1.89 ms [1.855 ms, 1.925 ms] 423.091 µs (28.8%)
iast_GLOBAL 1.929 ms [1.894 ms, 1.964 ms] 462.142 µs (31.5%)
profiling 1.851 ms [1.819 ms, 1.884 ms] 384.448 µs (26.2%)
tracing 1.835 ms [1.803 ms, 1.867 ms] 368.271 µs (25.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~7ee59e445f, baseline=1.34.0-SNAPSHOT~3293d86cd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.866 s) : 14866000, 14866000
.   : milestone, 14866000,
appsec (14.905 s) : 14905000, 14905000
.   : milestone, 14905000,
iast (18.772 s) : 18772000, 18772000
.   : milestone, 18772000,
iast_GLOBAL (17.642 s) : 17642000, 17642000
.   : milestone, 17642000,
profiling (15.293 s) : 15293000, 15293000
.   : milestone, 15293000,
tracing (14.827 s) : 14827000, 14827000
.   : milestone, 14827000,
section candidate
no_agent (15.351 s) : 15351000, 15351000
.   : milestone, 15351000,
appsec (15.068 s) : 15068000, 15068000
.   : milestone, 15068000,
iast (18.718 s) : 18718000, 18718000
.   : milestone, 18718000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
.   : milestone, 17952000,
profiling (15.243 s) : 15243000, 15243000
.   : milestone, 15243000,
tracing (14.761 s) : 14761000, 14761000
.   : milestone, 14761000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.866 s [14.866 s, 14.866 s] -
appsec 14.905 s [14.905 s, 14.905 s] 39.0 ms (0.3%)
iast 18.772 s [18.772 s, 18.772 s] 3.906 s (26.3%)
iast_GLOBAL 17.642 s [17.642 s, 17.642 s] 2.776 s (18.7%)
profiling 15.293 s [15.293 s, 15.293 s] 427.0 ms (2.9%)
tracing 14.827 s [14.827 s, 14.827 s] -39.0 ms (-0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.351 s [15.351 s, 15.351 s] -
appsec 15.068 s [15.068 s, 15.068 s] -283.0 ms (-1.8%)
iast 18.718 s [18.718 s, 18.718 s] 3.367 s (21.9%)
iast_GLOBAL 17.952 s [17.952 s, 17.952 s] 2.601 s (16.9%)
profiling 15.243 s [15.243 s, 15.243 s] -108.0 ms (-0.7%)
tracing 14.761 s [14.761 s, 14.761 s] -590.0 ms (-3.8%)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 25, 2024 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-refactor-propagation-methods
git_commit_date 1714454806 1714461973
git_commit_sha 3293d86 7ee59e4
See matching parameters
Baseline Candidate
ci_job_date 1714463534 1714463534
ci_job_id 500448566 500448566
ci_pipeline_id 33224784 33224784
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-refactor-propagation-methods branch 2 times, most recently from 08ed35f to 7a7725f Compare April 26, 2024 11:08
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Refactor propagation module to introduce better naming schemas Refactor propagation module to introduce better naming for methods Apr 26, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez added the tag: no release notes Changes to exclude from release notes label Apr 26, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-refactor-propagation-methods branch from 7a7725f to 5276f58 Compare April 26, 2024 11:47
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review April 26, 2024 15:44
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from a team as code owners April 26, 2024 15:44
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-refactor-propagation-methods branch 3 times, most recently from cfbb6c3 to d30675f Compare April 29, 2024 17:13
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-refactor-propagation-methods branch from d30675f to 7ee59e4 Compare April 30, 2024 07:26
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit d3eae46 into master Apr 30, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-refactor-propagation-methods branch April 30, 2024 08:44
@github-actions github-actions Bot added this to the 1.34.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@jandro996 jandro996 jandro996 approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.34.0

Development

Successfully merging this pull request may close these issues.

3 participants

@manuel-alvarez-alvarez @ValentinZakharov @jandro996