Ensure time waiting for `CyclicBarrier` and `CountDownLatch` is eligible for wallclock profiling by richardstartin · Pull Request #6941 · DataDog/dd-trace-java

richardstartin · 2024-04-24T12:07:21Z

What Does This Do

add instrumentation to make sure the wallclock profiler can sample CyclicBarrier and CountDownLatch waiting time, regardless of whether there is an active trace
Consolidate existing similar instrumentation for netty event loops into new instrumentation

Motivation

More complete wallclock profiling

Additional Notes

jbachorik · 2024-04-24T15:02:07Z

I assume super.isEnabled() will return true by default? Eg. it is not necessary to enable the integration by adding a config option?

Exactly, we want to bypass the tracer based enablement mechanism and use our own. Maybe we can refactor this at a later date so we don't need to do this, but this was just carried over from the instrumentation being generalised.

pr-commenter · 2024-04-25T12:09:19Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/cyclic-barrier-wallclock
git_commit_date	1714049499	1714125156
git_commit_sha	`ae1c4c9`	`a06db62`
release_version	1.34.0-SNAPSHOT~ae1c4c9475	1.34.0-SNAPSHOT~a06db6224e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714127640	1714127640
ci_job_id	498074880	498074880
ci_pipeline_id	33001892	33001892
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075406
Total [baseline] (10.456 s) : 0, 10456231
Agent [candidate] (1.076 s) : 0, 1076079
Total [candidate] (10.414 s) : 0, 10414422
section appsec
Agent [baseline] (1.192 s) : 0, 1192258
Total [baseline] (10.502 s) : 0, 10501904
Agent [candidate] (1.188 s) : 0, 1188032
Total [candidate] (10.482 s) : 0, 10482406
section iast
Agent [baseline] (1.206 s) : 0, 1205807
Total [baseline] (10.801 s) : 0, 10800907
Agent [candidate] (1.202 s) : 0, 1201961
Total [candidate] (10.787 s) : 0, 10787170
section profiling
Agent [baseline] (1.268 s) : 0, 1268394
Total [baseline] (10.743 s) : 0, 10743100
Agent [candidate] (1.278 s) : 0, 1277738
Total [candidate] (10.634 s) : 0, 10634385

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.075 s	-
Agent	appsec	1.192 s	116.852 ms (10.9%)
Agent	iast	1.206 s	130.401 ms (12.1%)
Agent	profiling	1.268 s	192.988 ms (17.9%)
Total	tracing	10.456 s	-
Total	appsec	10.502 s	45.673 ms (0.4%)
Total	iast	10.801 s	344.676 ms (3.3%)
Total	profiling	10.743 s	286.869 ms (2.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	appsec	1.188 s	111.953 ms (10.4%)
Agent	iast	1.202 s	125.882 ms (11.7%)
Agent	profiling	1.278 s	201.659 ms (18.7%)
Total	tracing	10.414 s	-
Total	appsec	10.482 s	67.984 ms (0.7%)
Total	iast	10.787 s	372.749 ms (3.6%)
Total	profiling	10.634 s	219.964 ms (2.1%)

gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.622 ms) : 0, 673622
BytebuddyAgent [candidate] (673.584 ms) : 0, 673584
GlobalTracer [baseline] (309.667 ms) : 0, 309667
GlobalTracer [candidate] (310.198 ms) : 0, 310198
AppSec [baseline] (49.506 ms) : 0, 49506
AppSec [candidate] (49.543 ms) : 0, 49543
Remote Config [baseline] (650.923 µs) : 0, 651
Remote Config [candidate] (659.743 µs) : 0, 660
Telemetry [baseline] (7.573 ms) : 0, 7573
Telemetry [candidate] (7.69 ms) : 0, 7690
section appsec
BytebuddyAgent [baseline] (697.264 ms) : 0, 697264
BytebuddyAgent [candidate] (694.904 ms) : 0, 694904
GlobalTracer [baseline] (292.168 ms) : 0, 292168
GlobalTracer [candidate] (291.191 ms) : 0, 291191
AppSec [baseline] (149.818 ms) : 0, 149818
AppSec [candidate] (149.369 ms) : 0, 149369
IAST [baseline] (19.435 ms) : 0, 19435
IAST [candidate] (19.3 ms) : 0, 19300
Remote Config [baseline] (623.262 µs) : 0, 623
Remote Config [candidate] (615.747 µs) : 0, 616
Telemetry [baseline] (8.174 ms) : 0, 8174
Telemetry [candidate] (7.849 ms) : 0, 7849
section iast
BytebuddyAgent [baseline] (799.275 ms) : 0, 799275
BytebuddyAgent [candidate] (794.647 ms) : 0, 794647
GlobalTracer [baseline] (289.391 ms) : 0, 289391
GlobalTracer [candidate] (289.868 ms) : 0, 289868
AppSec [baseline] (50.402 ms) : 0, 50402
AppSec [candidate] (50.721 ms) : 0, 50721
IAST [baseline] (24.165 ms) : 0, 24165
IAST [candidate] (23.663 ms) : 0, 23663
Remote Config [baseline] (577.982 µs) : 0, 578
Remote Config [candidate] (573.753 µs) : 0, 574
Telemetry [baseline] (7.399 ms) : 0, 7399
Telemetry [candidate] (8.175 ms) : 0, 8175
section profiling
BytebuddyAgent [baseline] (677.431 ms) : 0, 677431
BytebuddyAgent [candidate] (683.021 ms) : 0, 683021
GlobalTracer [baseline] (380.489 ms) : 0, 380489
GlobalTracer [candidate] (382.598 ms) : 0, 382598
AppSec [baseline] (50.395 ms) : 0, 50395
AppSec [candidate] (50.643 ms) : 0, 50643
Remote Config [baseline] (719.204 µs) : 0, 719
Remote Config [candidate] (711.347 µs) : 0, 711
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (7.542 ms) : 0, 7542
ProfilingAgent [baseline] (95.431 ms) : 0, 95431
ProfilingAgent [candidate] (96.356 ms) : 0, 96356
Profiling [baseline] (95.455 ms) : 0, 95455
Profiling [candidate] (96.38 ms) : 0, 96380

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075971
Total [baseline] (8.562 s) : 0, 8562399
Agent [candidate] (1.094 s) : 0, 1093850
Total [candidate] (8.582 s) : 0, 8581660
section iast
Agent [baseline] (1.2 s) : 0, 1200363
Total [baseline] (9.017 s) : 0, 9016975
Agent [candidate] (1.212 s) : 0, 1211701
Total [candidate] (9.082 s) : 0, 9081938
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.197 s) : 0, 1196805
Total [baseline] (8.973 s) : 0, 8973479
Agent [candidate] (1.198 s) : 0, 1198440
Total [candidate] (9.021 s) : 0, 9020912
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1207086
Total [baseline] (9.017 s) : 0, 9017244
Agent [candidate] (1.198 s) : 0, 1198279
Total [candidate] (9.006 s) : 0, 9006115

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	iast	1.2 s	124.392 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.197 s	120.834 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.207 s	131.115 ms (12.2%)
Total	tracing	8.562 s	-
Total	iast	9.017 s	454.576 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.973 s	411.08 ms (4.8%)
Total	iast_TELEMETRY_OFF	9.017 s	454.845 ms (5.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	iast	1.212 s	117.85 ms (10.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.198 s	104.59 ms (9.6%)
Agent	iast_TELEMETRY_OFF	1.198 s	104.429 ms (9.5%)
Total	tracing	8.582 s	-
Total	iast	9.082 s	500.278 ms (5.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.021 s	439.253 ms (5.1%)
Total	iast_TELEMETRY_OFF	9.006 s	424.455 ms (4.9%)

gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.838 ms) : 0, 673838
BytebuddyAgent [candidate] (686.928 ms) : 0, 686928
GlobalTracer [baseline] (309.687 ms) : 0, 309687
GlobalTracer [candidate] (313.687 ms) : 0, 313687
AppSec [baseline] (49.695 ms) : 0, 49695
AppSec [candidate] (49.834 ms) : 0, 49834
Remote Config [baseline] (659.848 µs) : 0, 660
Remote Config [candidate] (662.845 µs) : 0, 663
Telemetry [baseline] (7.692 ms) : 0, 7692
Telemetry [candidate] (7.667 ms) : 0, 7667
section iast
BytebuddyAgent [baseline] (795.114 ms) : 0, 795114
BytebuddyAgent [candidate] (801.241 ms) : 0, 801241
GlobalTracer [baseline] (288.37 ms) : 0, 288370
GlobalTracer [candidate] (292.094 ms) : 0, 292094
AppSec [baseline] (50.441 ms) : 0, 50441
AppSec [candidate] (50.857 ms) : 0, 50857
IAST [baseline] (24.849 ms) : 0, 24849
IAST [candidate] (24.455 ms) : 0, 24455
Remote Config [baseline] (567.415 µs) : 0, 567
Remote Config [candidate] (1.479 ms) : 0, 1479
Telemetry [baseline] (6.615 ms) : 0, 6615
Telemetry [candidate] (6.816 ms) : 0, 6816
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.16 ms) : 0, 793160
BytebuddyAgent [candidate] (794.069 ms) : 0, 794069
GlobalTracer [baseline] (287.61 ms) : 0, 287610
GlobalTracer [candidate] (288.087 ms) : 0, 288087
AppSec [baseline] (52.109 ms) : 0, 52109
AppSec [candidate] (50.962 ms) : 0, 50962
IAST [baseline] (21.609 ms) : 0, 21609
IAST [candidate] (22.851 ms) : 0, 22851
Remote Config [baseline] (578.124 µs) : 0, 578
Remote Config [candidate] (586.116 µs) : 0, 586
Telemetry [baseline] (7.45 ms) : 0, 7450
Telemetry [candidate] (7.5 ms) : 0, 7500
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.074 ms) : 0, 799074
BytebuddyAgent [candidate] (792.928 ms) : 0, 792928
GlobalTracer [baseline] (290.601 ms) : 0, 290601
GlobalTracer [candidate] (288.944 ms) : 0, 288944
AppSec [baseline] (50.547 ms) : 0, 50547
AppSec [candidate] (48.705 ms) : 0, 48705
IAST [baseline] (22.593 ms) : 0, 22593
IAST [candidate] (23.729 ms) : 0, 23729
Remote Config [baseline] (588.76 µs) : 0, 589
Remote Config [candidate] (588.006 µs) : 0, 588
Telemetry [baseline] (9.026 ms) : 0, 9026
Telemetry [candidate] (8.866 ms) : 0, 8866

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-04-26T10:06:41	2024-04-26T10:13:29
git_branch	master	rgs/cyclic-barrier-wallclock
git_commit_date	1714049499	1714125156
git_commit_sha	`ae1c4c9`	`a06db62`
release_version	1.34.0-SNAPSHOT~ae1c4c9475	1.34.0-SNAPSHOT~a06db6224e
start_time	2024-04-26T10:06:28	2024-04-26T10:13:16

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714126754	1714126754
ci_job_id	498074881	498074881
ci_pipeline_id	33001892	33001892
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1319, 1359
.   : milestone, 1339,
appsec (1.727 ms) : 1703, 1751
.   : milestone, 1727,
appsec_no_iast (1.727 ms) : 1702, 1751
.   : milestone, 1727,
iast (1.484 ms) : 1461, 1507
.   : milestone, 1484,
profiling (1.5 ms) : 1475, 1525
.   : milestone, 1500,
tracing (1.486 ms) : 1462, 1509
.   : milestone, 1486,
section candidate
no_agent (1.358 ms) : 1339, 1378
.   : milestone, 1358,
appsec (1.736 ms) : 1712, 1760
.   : milestone, 1736,
appsec_no_iast (1.701 ms) : 1676, 1726
.   : milestone, 1701,
iast (1.496 ms) : 1473, 1519
.   : milestone, 1496,
profiling (1.532 ms) : 1507, 1557
.   : milestone, 1532,
tracing (1.462 ms) : 1437, 1487
.   : milestone, 1462,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.339 ms [1.319 ms, 1.359 ms]	-
appsec	1.727 ms [1.703 ms, 1.751 ms]	388.038 µs (29.0%)
appsec_no_iast	1.727 ms [1.702 ms, 1.751 ms]	387.663 µs (29.0%)
iast	1.484 ms [1.461 ms, 1.507 ms]	144.824 µs (10.8%)
profiling	1.5 ms [1.475 ms, 1.525 ms]	161.191 µs (12.0%)
tracing	1.486 ms [1.462 ms, 1.509 ms]	146.532 µs (10.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.378 ms]	-
appsec	1.736 ms [1.712 ms, 1.76 ms]	377.903 µs (27.8%)
appsec_no_iast	1.701 ms [1.676 ms, 1.726 ms]	342.525 µs (25.2%)
iast	1.496 ms [1.473 ms, 1.519 ms]	137.375 µs (10.1%)
profiling	1.532 ms [1.507 ms, 1.557 ms]	173.775 µs (12.8%)
tracing	1.462 ms [1.437 ms, 1.487 ms]	103.876 µs (7.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.868 µs) : 354, 393
.   : milestone, 374,
iast (473.283 µs) : 453, 494
.   : milestone, 473,
iast_FULL (541.387 µs) : 520, 563
.   : milestone, 541,
iast_GLOBAL (498.682 µs) : 477, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (475.238 µs) : 455, 496
.   : milestone, 475,
iast_INACTIVE (452.65 µs) : 431, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (468.506 µs) : 448, 489
.   : milestone, 469,
tracing (442.237 µs) : 422, 463
.   : milestone, 442,
section candidate
no_agent (382.027 µs) : 361, 403
.   : milestone, 382,
iast (476.308 µs) : 455, 498
.   : milestone, 476,
iast_FULL (541.91 µs) : 521, 563
.   : milestone, 542,
iast_GLOBAL (500.119 µs) : 479, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (477.636 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (457.907 µs) : 438, 478
.   : milestone, 458,
iast_TELEMETRY_OFF (469.264 µs) : 448, 490
.   : milestone, 469,
tracing (445.754 µs) : 426, 466
.   : milestone, 446,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.868 µs [354.408 µs, 393.327 µs]	-
iast	473.283 µs [452.662 µs, 493.903 µs]	99.415 µs (26.6%)
iast_FULL	541.387 µs [519.913 µs, 562.86 µs]	167.519 µs (44.8%)
iast_GLOBAL	498.682 µs [477.031 µs, 520.334 µs]	124.815 µs (33.4%)
iast_HARDCODED_SECRET_DISABLED	475.238 µs [454.733 µs, 495.743 µs]	101.37 µs (27.1%)
iast_INACTIVE	452.65 µs [431.23 µs, 474.071 µs]	78.782 µs (21.1%)
iast_TELEMETRY_OFF	468.506 µs [447.645 µs, 489.368 µs]	94.638 µs (25.3%)
tracing	442.237 µs [421.97 µs, 462.503 µs]	68.369 µs (18.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.027 µs [361.13 µs, 402.924 µs]	-
iast	476.308 µs [455.081 µs, 497.536 µs]	94.281 µs (24.7%)
iast_FULL	541.91 µs [520.668 µs, 563.152 µs]	159.883 µs (41.9%)
iast_GLOBAL	500.119 µs [478.62 µs, 521.617 µs]	118.092 µs (30.9%)
iast_HARDCODED_SECRET_DISABLED	477.636 µs [456.505 µs, 498.767 µs]	95.609 µs (25.0%)
iast_INACTIVE	457.907 µs [437.505 µs, 478.309 µs]	75.88 µs (19.9%)
iast_TELEMETRY_OFF	469.264 µs [448.418 µs, 490.11 µs]	87.237 µs (22.8%)
tracing	445.754 µs [425.799 µs, 465.71 µs]	63.727 µs (16.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/cyclic-barrier-wallclock
git_commit_date	1714049499	1714125156
git_commit_sha	`ae1c4c9`	`a06db62`
release_version	1.34.0-SNAPSHOT~ae1c4c9475	1.34.0-SNAPSHOT~a06db6224e

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1714127251	1714127251
ci_job_id	498074882	498074882
ci_pipeline_id	33001892	33001892
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.545 s) : 15545000, 15545000
.   : milestone, 15545000,
appsec (14.943 s) : 14943000, 14943000
.   : milestone, 14943000,
iast (18.682 s) : 18682000, 18682000
.   : milestone, 18682000,
iast_GLOBAL (17.901 s) : 17901000, 17901000
.   : milestone, 17901000,
profiling (15.285 s) : 15285000, 15285000
.   : milestone, 15285000,
tracing (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
section candidate
no_agent (15.139 s) : 15139000, 15139000
.   : milestone, 15139000,
appsec (15.153 s) : 15153000, 15153000
.   : milestone, 15153000,
iast (19.023 s) : 19023000, 19023000
.   : milestone, 19023000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
.   : milestone, 17946000,
profiling (15.829 s) : 15829000, 15829000
.   : milestone, 15829000,
tracing (15.074 s) : 15074000, 15074000
.   : milestone, 15074000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.545 s [15.545 s, 15.545 s]	-
appsec	14.943 s [14.943 s, 14.943 s]	-602.0 ms (-3.9%)
iast	18.682 s [18.682 s, 18.682 s]	3.137 s (20.2%)
iast_GLOBAL	17.901 s [17.901 s, 17.901 s]	2.356 s (15.2%)
profiling	15.285 s [15.285 s, 15.285 s]	-260.0 ms (-1.7%)
tracing	15.033 s [15.033 s, 15.033 s]	-512.0 ms (-3.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.139 s [15.139 s, 15.139 s]	-
appsec	15.153 s [15.153 s, 15.153 s]	14.0 ms (0.1%)
iast	19.023 s [19.023 s, 19.023 s]	3.884 s (25.7%)
iast_GLOBAL	17.946 s [17.946 s, 17.946 s]	2.807 s (18.5%)
profiling	15.829 s [15.829 s, 15.829 s]	690.0 ms (4.6%)
tracing	15.074 s [15.074 s, 15.074 s]	-65.0 ms (-0.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~a06db6224e, baseline=1.34.0-SNAPSHOT~ae1c4c9475
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.455 ms) : 1444, 1466
.   : milestone, 1455,
appsec (2.189 ms) : 2156, 2222
.   : milestone, 2189,
iast (1.884 ms) : 1849, 1919
.   : milestone, 1884,
iast_GLOBAL (1.92 ms) : 1885, 1954
.   : milestone, 1920,
profiling (1.84 ms) : 1807, 1874
.   : milestone, 1840,
tracing (1.824 ms) : 1793, 1856
.   : milestone, 1824,
section candidate
no_agent (1.455 ms) : 1443, 1466
.   : milestone, 1455,
appsec (2.186 ms) : 2153, 2220
.   : milestone, 2186,
iast (1.87 ms) : 1836, 1905
.   : milestone, 1870,
iast_GLOBAL (1.909 ms) : 1874, 1944
.   : milestone, 1909,
profiling (1.84 ms) : 1808, 1873
.   : milestone, 1840,
tracing (1.824 ms) : 1792, 1856
.   : milestone, 1824,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.455 ms [1.444 ms, 1.466 ms]	-
appsec	2.189 ms [2.156 ms, 2.222 ms]	734.12 µs (50.5%)
iast	1.884 ms [1.849 ms, 1.919 ms]	429.227 µs (29.5%)
iast_GLOBAL	1.92 ms [1.885 ms, 1.954 ms]	464.736 µs (31.9%)
profiling	1.84 ms [1.807 ms, 1.874 ms]	385.533 µs (26.5%)
tracing	1.824 ms [1.793 ms, 1.856 ms]	369.603 µs (25.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.455 ms [1.443 ms, 1.466 ms]	-
appsec	2.186 ms [2.153 ms, 2.22 ms]	731.558 µs (50.3%)
iast	1.87 ms [1.836 ms, 1.905 ms]	415.891 µs (28.6%)
iast_GLOBAL	1.909 ms [1.874 ms, 1.944 ms]	454.551 µs (31.2%)
profiling	1.84 ms [1.808 ms, 1.873 ms]	385.569 µs (26.5%)
tracing	1.824 ms [1.792 ms, 1.856 ms]	369.401 µs (25.4%)

…ock profiling

richardstartin added the comp: profiling Profiling label Apr 24, 2024

richardstartin requested a review from a team April 24, 2024 12:07

richardstartin force-pushed the rgs/cyclic-barrier-wallclock branch 3 times, most recently from 01016ec to 7a32cbe Compare April 24, 2024 12:33

richardstartin marked this pull request as ready for review April 24, 2024 12:42

richardstartin requested a review from a team as a code owner April 24, 2024 12:42

richardstartin requested review from dougqh and nayeem-kamal April 24, 2024 12:42

richardstartin force-pushed the rgs/cyclic-barrier-wallclock branch from 7a32cbe to 37c38e5 Compare April 24, 2024 13:10

jbachorik reviewed Apr 24, 2024

View reviewed changes

jbachorik approved these changes Apr 24, 2024

View reviewed changes

richardstartin force-pushed the rgs/cyclic-barrier-wallclock branch 2 times, most recently from 425e1ff to 0192701 Compare April 25, 2024 11:10

richardstartin force-pushed the rgs/cyclic-barrier-wallclock branch 2 times, most recently from 8dd8a8f to 7db9e25 Compare April 26, 2024 09:22

add instrumentation for making the current thread eligible for wallcl…

a06db62

…ock profiling

richardstartin force-pushed the rgs/cyclic-barrier-wallclock branch from 7db9e25 to a06db62 Compare April 26, 2024 09:52

richardstartin merged commit a481d0b into master Apr 26, 2024

richardstartin deleted the rgs/cyclic-barrier-wallclock branch April 26, 2024 13:35

github-actions Bot added this to the 1.34.0 milestone Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure time waiting for `CyclicBarrier` and `CountDownLatch` is eligible for wallclock profiling#6941

Ensure time waiting for `CyclicBarrier` and `CountDownLatch` is eligible for wallclock profiling#6941
richardstartin merged 1 commit intomasterfrom
rgs/cyclic-barrier-wallclock

richardstartin commented Apr 24, 2024 •

edited by atlassian Bot

Loading

Uh oh!

jbachorik Apr 24, 2024

Uh oh!

richardstartin Apr 25, 2024

Uh oh!

pr-commenter Bot commented Apr 25, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

richardstartin commented Apr 24, 2024 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

jbachorik Apr 24, 2024

Choose a reason for hiding this comment

Uh oh!

richardstartin Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

pr-commenter Bot commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

richardstartin commented Apr 24, 2024 •

edited by atlassian Bot

Loading

pr-commenter Bot commented Apr 25, 2024 •

edited

Loading