Skip to content

Lint produced deb and rpm packages#6932

Merged
spencergilbert merged 1 commit intomasterfrom
spencergilbert/use-dd-pkg-for-package-linting
Apr 25, 2024
Merged

Lint produced deb and rpm packages#6932
spencergilbert merged 1 commit intomasterfrom
spencergilbert/use-dd-pkg-for-package-linting

Conversation

@spencergilbert
Copy link
Copy Markdown

@spencergilbert spencergilbert commented Apr 22, 2024 •
edited by atlassian Bot
Loading

What Does This Do

The latest stable version of the packaging template now includes a tool dd-pkg. This PR uses this tool to lint the produced DEB and RPM packages.

Motivation

This lint has been run at the time of package promotion, this change moves this step to the left and lets teams identify issues before they're trying to release to production.

Additional Notes

Jira ticket: BARX-245

@spencergilbert spencergilbert self-assigned this Apr 22, 2024
@spencergilbert spencergilbert requested a review from a team as a code owner April 22, 2024 11:07
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 22, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master spencergilbert/use-dd-pkg-for-package-linting
git_commit_date 1713776106 1713783015
git_commit_sha 8c37f09 1237bc7
release_version 1.34.0-SNAPSHOT~8c37f09d8c 1.34.0-SNAPSHOT~1237bc7c60
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713785339 1713785339
ci_job_id 492800669 492800669
ci_pipeline_id 32581982 32581982
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081303
Total [baseline] (10.331 s) : 0, 10331454
Agent [candidate] (1.083 s) : 0, 1082745
Total [candidate] (10.492 s) : 0, 10492487
section appsec
Agent [baseline] (1.195 s) : 0, 1194762
Total [baseline] (10.506 s) : 0, 10506240
Agent [candidate] (1.19 s) : 0, 1190005
Total [candidate] (10.468 s) : 0, 10467575
section iast
Agent [baseline] (1.2 s) : 0, 1199536
Total [baseline] (10.768 s) : 0, 10768209
Agent [candidate] (1.201 s) : 0, 1201463
Total [candidate] (10.746 s) : 0, 10745815
section profiling
Agent [baseline] (1.268 s) : 0, 1267729
Total [baseline] (10.571 s) : 0, 10570552
Agent [candidate] (1.269 s) : 0, 1268662
Total [candidate] (10.608 s) : 0, 10608429
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.195 s 113.459 ms (10.5%)
Agent iast 1.2 s 118.233 ms (10.9%)
Agent profiling 1.268 s 186.426 ms (17.2%)
Total tracing 10.331 s -
Total appsec 10.506 s 174.786 ms (1.7%)
Total iast 10.768 s 436.755 ms (4.2%)
Total profiling 10.571 s 239.098 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.19 s 107.26 ms (9.9%)
Agent iast 1.201 s 118.719 ms (11.0%)
Agent profiling 1.269 s 185.917 ms (17.2%)
Total tracing 10.492 s -
Total appsec 10.468 s -24.913 ms (-0.2%)
Total iast 10.746 s 253.328 ms (2.4%)
Total profiling 10.608 s 115.942 ms (1.1%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (677.938 ms) : 0, 677938
BytebuddyAgent [candidate] (677.844 ms) : 0, 677844
GlobalTracer [baseline] (311.031 ms) : 0, 311031
GlobalTracer [candidate] (312.218 ms) : 0, 312218
AppSec [baseline] (49.384 ms) : 0, 49384
AppSec [candidate] (49.77 ms) : 0, 49770
Remote Config [baseline] (661.557 µs) : 0, 662
Remote Config [candidate] (665.733 µs) : 0, 666
Telemetry [baseline] (7.64 ms) : 0, 7640
Telemetry [candidate] (7.622 ms) : 0, 7622
section appsec
BytebuddyAgent [baseline] (699.662 ms) : 0, 699662
BytebuddyAgent [candidate] (695.876 ms) : 0, 695876
GlobalTracer [baseline] (292.392 ms) : 0, 292392
GlobalTracer [candidate] (291.718 ms) : 0, 291718
AppSec [baseline] (149.648 ms) : 0, 149648
AppSec [candidate] (149.414 ms) : 0, 149414
Remote Config [baseline] (619.145 µs) : 0, 619
Remote Config [candidate] (619.231 µs) : 0, 619
Telemetry [baseline] (8.143 ms) : 0, 8143
Telemetry [candidate] (8.416 ms) : 0, 8416
IAST [baseline] (19.178 ms) : 0, 19178
IAST [candidate] (19.143 ms) : 0, 19143
section iast
BytebuddyAgent [baseline] (795.094 ms) : 0, 795094
BytebuddyAgent [candidate] (796.029 ms) : 0, 796029
GlobalTracer [baseline] (288.438 ms) : 0, 288438
GlobalTracer [candidate] (288.751 ms) : 0, 288751
AppSec [baseline] (50.468 ms) : 0, 50468
AppSec [candidate] (49.64 ms) : 0, 49640
Remote Config [baseline] (570.938 µs) : 0, 571
Remote Config [candidate] (562.13 µs) : 0, 562
Telemetry [baseline] (7.367 ms) : 0, 7367
Telemetry [candidate] (6.591 ms) : 0, 6591
IAST [baseline] (23.172 ms) : 0, 23172
IAST [candidate] (25.38 ms) : 0, 25380
section profiling
BytebuddyAgent [baseline] (677.17 ms) : 0, 677170
BytebuddyAgent [candidate] (677.751 ms) : 0, 677751
GlobalTracer [baseline] (380.275 ms) : 0, 380275
GlobalTracer [candidate] (380.676 ms) : 0, 380676
AppSec [baseline] (50.14 ms) : 0, 50140
AppSec [candidate] (50.085 ms) : 0, 50085
Remote Config [baseline] (714.145 µs) : 0, 714
Remote Config [candidate] (709.526 µs) : 0, 710
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.511 ms) : 0, 7511
ProfilingAgent [baseline] (95.734 ms) : 0, 95734
ProfilingAgent [candidate] (95.526 ms) : 0, 95526
Profiling [baseline] (95.758 ms) : 0, 95758
Profiling [candidate] (95.55 ms) : 0, 95550
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080182
Total [baseline] (8.556 s) : 0, 8555729
Agent [candidate] (1.084 s) : 0, 1083853
Total [candidate] (8.572 s) : 0, 8571535
section iast
Agent [baseline] (1.198 s) : 0, 1198016
Total [baseline] (8.999 s) : 0, 8999381
Agent [candidate] (1.2 s) : 0, 1200222
Total [candidate] (8.993 s) : 0, 8993438
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1207385
Total [baseline] (9.023 s) : 0, 9022655
Agent [candidate] (1.209 s) : 0, 1209110
Total [candidate] (9.049 s) : 0, 9048572
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1203280
Total [baseline] (9.013 s) : 0, 9013264
Agent [candidate] (1.196 s) : 0, 1196345
Total [candidate] (8.998 s) : 0, 8998474
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.198 s 117.834 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 127.202 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.203 s 123.097 ms (11.4%)
Total tracing 8.556 s -
Total iast 8.999 s 443.652 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.023 s 466.926 ms (5.5%)
Total iast_TELEMETRY_OFF 9.013 s 457.535 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.2 s 116.368 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 125.256 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.196 s 112.492 ms (10.4%)
Total tracing 8.572 s -
Total iast 8.993 s 421.903 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.049 s 477.037 ms (5.6%)
Total iast_TELEMETRY_OFF 8.998 s 426.939 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.857 ms) : 0, 676857
BytebuddyAgent [candidate] (679.177 ms) : 0, 679177
GlobalTracer [baseline] (310.697 ms) : 0, 310697
GlobalTracer [candidate] (311.985 ms) : 0, 311985
AppSec [baseline] (49.69 ms) : 0, 49690
AppSec [candidate] (49.717 ms) : 0, 49717
Remote Config [baseline] (674.327 µs) : 0, 674
Remote Config [candidate] (664.213 µs) : 0, 664
Telemetry [baseline] (7.665 ms) : 0, 7665
Telemetry [candidate] (7.61 ms) : 0, 7610
section iast
BytebuddyAgent [baseline] (794.534 ms) : 0, 794534
BytebuddyAgent [candidate] (795.458 ms) : 0, 795458
GlobalTracer [baseline] (287.65 ms) : 0, 287650
GlobalTracer [candidate] (288.234 ms) : 0, 288234
AppSec [baseline] (49.394 ms) : 0, 49394
AppSec [candidate] (49.989 ms) : 0, 49989
IAST [baseline] (24.734 ms) : 0, 24734
IAST [candidate] (21.694 ms) : 0, 21694
Remote Config [baseline] (569.714 µs) : 0, 570
Remote Config [candidate] (575.159 µs) : 0, 575
Telemetry [baseline] (6.684 ms) : 0, 6684
Telemetry [candidate] (9.69 ms) : 0, 9690
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.501 ms) : 0, 801501
BytebuddyAgent [candidate] (799.658 ms) : 0, 799658
GlobalTracer [baseline] (290.295 ms) : 0, 290295
GlobalTracer [candidate] (291.353 ms) : 0, 291353
AppSec [baseline] (49.761 ms) : 0, 49761
AppSec [candidate] (49.998 ms) : 0, 49998
IAST [baseline] (23.116 ms) : 0, 23116
IAST [candidate] (25.433 ms) : 0, 25433
Remote Config [baseline] (576.852 µs) : 0, 577
Remote Config [candidate] (586.659 µs) : 0, 587
Telemetry [baseline] (7.434 ms) : 0, 7434
Telemetry [candidate] (7.509 ms) : 0, 7509
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.946 ms) : 0, 796946
BytebuddyAgent [candidate] (791.154 ms) : 0, 791154
GlobalTracer [baseline] (289.879 ms) : 0, 289879
GlobalTracer [candidate] (288.573 ms) : 0, 288573
AppSec [baseline] (51.101 ms) : 0, 51101
AppSec [candidate] (48.853 ms) : 0, 48853
IAST [baseline] (23.452 ms) : 0, 23452
IAST [candidate] (25.381 ms) : 0, 25381
Remote Config [baseline] (589.305 µs) : 0, 589
Remote Config [candidate] (572.07 µs) : 0, 572
Telemetry [baseline] (6.625 ms) : 0, 6625
Telemetry [candidate] (7.347 ms) : 0, 7347
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-22T10:59:42 2024-04-22T11:06:30
git_branch master spencergilbert/use-dd-pkg-for-package-linting
git_commit_date 1713776106 1713783015
git_commit_sha 8c37f09 1237bc7
release_version 1.34.0-SNAPSHOT~8c37f09d8c 1.34.0-SNAPSHOT~1237bc7c60
start_time 2024-04-22T10:59:29 2024-04-22T11:06:17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713784334 1713784334
ci_job_id 492800670 492800670
ci_pipeline_id 32581982 32581982
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.261 µs) : 341, 384
.   : milestone, 362,
iast (473.294 µs) : 452, 494
.   : milestone, 473,
iast_FULL (542.882 µs) : 522, 564
.   : milestone, 543,
iast_GLOBAL (490.038 µs) : 468, 512
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (474.849 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (449.94 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (478.175 µs) : 456, 500
.   : milestone, 478,
tracing (440.696 µs) : 420, 461
.   : milestone, 441,
section candidate
no_agent (361.776 µs) : 342, 381
.   : milestone, 362,
iast (478.772 µs) : 458, 500
.   : milestone, 479,
iast_FULL (536.543 µs) : 516, 557
.   : milestone, 537,
iast_GLOBAL (506.833 µs) : 484, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (473.488 µs) : 453, 494
.   : milestone, 473,
iast_INACTIVE (445.261 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (463.852 µs) : 443, 484
.   : milestone, 464,
tracing (441.526 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.261 µs [341.002 µs, 383.519 µs] -
iast 473.294 µs [452.313 µs, 494.274 µs] 111.033 µs (30.7%)
iast_FULL 542.882 µs [521.525 µs, 564.24 µs] 180.622 µs (49.9%)
iast_GLOBAL 490.038 µs [468.429 µs, 511.646 µs] 127.777 µs (35.3%)
iast_HARDCODED_SECRET_DISABLED 474.849 µs [453.771 µs, 495.927 µs] 112.589 µs (31.1%)
iast_INACTIVE 449.94 µs [428.8 µs, 471.08 µs] 87.679 µs (24.2%)
iast_TELEMETRY_OFF 478.175 µs [455.874 µs, 500.477 µs] 115.915 µs (32.0%)
tracing 440.696 µs [420.419 µs, 460.974 µs] 78.436 µs (21.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.776 µs [342.133 µs, 381.418 µs] -
iast 478.772 µs [457.59 µs, 499.954 µs] 116.996 µs (32.3%)
iast_FULL 536.543 µs [515.667 µs, 557.42 µs] 174.767 µs (48.3%)
iast_GLOBAL 506.833 µs [484.283 µs, 529.382 µs] 145.057 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED 473.488 µs [452.779 µs, 494.196 µs] 111.712 µs (30.9%)
iast_INACTIVE 445.261 µs [424.184 µs, 466.338 µs] 83.485 µs (23.1%)
iast_TELEMETRY_OFF 463.852 µs [443.495 µs, 484.209 µs] 102.076 µs (28.2%)
tracing 441.526 µs [421.131 µs, 461.921 µs] 79.751 µs (22.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1360
.   : milestone, 1341,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.728 ms) : 1704, 1751
.   : milestone, 1728,
iast (1.489 ms) : 1466, 1511
.   : milestone, 1489,
profiling (1.499 ms) : 1475, 1523
.   : milestone, 1499,
tracing (1.49 ms) : 1467, 1514
.   : milestone, 1490,
section candidate
no_agent (1.342 ms) : 1323, 1361
.   : milestone, 1342,
appsec (1.71 ms) : 1685, 1734
.   : milestone, 1710,
appsec_no_iast (1.737 ms) : 1713, 1761
.   : milestone, 1737,
iast (1.499 ms) : 1477, 1522
.   : milestone, 1499,
profiling (1.49 ms) : 1466, 1515
.   : milestone, 1490,
tracing (1.48 ms) : 1456, 1504
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.36 ms] -
appsec 1.732 ms [1.708 ms, 1.756 ms] 390.948 µs (29.1%)
appsec_no_iast 1.728 ms [1.704 ms, 1.751 ms] 386.321 µs (28.8%)
iast 1.489 ms [1.466 ms, 1.511 ms] 147.285 µs (11.0%)
profiling 1.499 ms [1.475 ms, 1.523 ms] 157.749 µs (11.8%)
tracing 1.49 ms [1.467 ms, 1.514 ms] 149.166 µs (11.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.361 ms] -
appsec 1.71 ms [1.685 ms, 1.734 ms] 367.935 µs (27.4%)
appsec_no_iast 1.737 ms [1.713 ms, 1.761 ms] 395.557 µs (29.5%)
iast 1.499 ms [1.477 ms, 1.522 ms] 157.556 µs (11.7%)
profiling 1.49 ms [1.466 ms, 1.515 ms] 148.613 µs (11.1%)
tracing 1.48 ms [1.456 ms, 1.504 ms] 138.083 µs (10.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master spencergilbert/use-dd-pkg-for-package-linting
git_commit_date 1713776106 1713783015
git_commit_sha 8c37f09 1237bc7
release_version 1.34.0-SNAPSHOT~8c37f09d8c 1.34.0-SNAPSHOT~1237bc7c60
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1713784843 1713784843
ci_job_id 492800671 492800671
ci_pipeline_id 32581982 32581982
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.399 s) : 15399000, 15399000
.   : milestone, 15399000,
appsec (15.182 s) : 15182000, 15182000
.   : milestone, 15182000,
iast (18.752 s) : 18752000, 18752000
.   : milestone, 18752000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
.   : milestone, 18003000,
profiling (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,
tracing (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
section candidate
no_agent (15.364 s) : 15364000, 15364000
.   : milestone, 15364000,
appsec (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,
iast (18.68 s) : 18680000, 18680000
.   : milestone, 18680000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
.   : milestone, 18003000,
profiling (15.43 s) : 15430000, 15430000
.   : milestone, 15430000,
tracing (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.399 s [15.399 s, 15.399 s] -
appsec 15.182 s [15.182 s, 15.182 s] -217.0 ms (-1.4%)
iast 18.752 s [18.752 s, 18.752 s] 3.353 s (21.8%)
iast_GLOBAL 18.003 s [18.003 s, 18.003 s] 2.604 s (16.9%)
profiling 15.054 s [15.054 s, 15.054 s] -345.0 ms (-2.2%)
tracing 15.063 s [15.063 s, 15.063 s] -336.0 ms (-2.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.364 s [15.364 s, 15.364 s] -
appsec 15.142 s [15.142 s, 15.142 s] -222.0 ms (-1.4%)
iast 18.68 s [18.68 s, 18.68 s] 3.316 s (21.6%)
iast_GLOBAL 18.003 s [18.003 s, 18.003 s] 2.639 s (17.2%)
profiling 15.43 s [15.43 s, 15.43 s] 66.0 ms (0.4%)
tracing 15.01 s [15.01 s, 15.01 s] -354.0 ms (-2.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~1237bc7c60, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.224 ms) : 2190, 2257
.   : milestone, 2224,
iast (1.897 ms) : 1862, 1933
.   : milestone, 1897,
iast_GLOBAL (1.923 ms) : 1888, 1958
.   : milestone, 1923,
profiling (1.862 ms) : 1829, 1895
.   : milestone, 1862,
tracing (1.84 ms) : 1808, 1872
.   : milestone, 1840,
section candidate
no_agent (1.47 ms) : 1458, 1482
.   : milestone, 1470,
appsec (2.204 ms) : 2171, 2238
.   : milestone, 2204,
iast (1.906 ms) : 1870, 1942
.   : milestone, 1906,
iast_GLOBAL (1.922 ms) : 1887, 1958
.   : milestone, 1922,
profiling (2.314 ms) : 2139, 2489
.   : milestone, 2314,
tracing (1.84 ms) : 1807, 1872
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.224 ms [2.19 ms, 2.257 ms] 755.019 µs (51.4%)
iast 1.897 ms [1.862 ms, 1.933 ms] 428.66 µs (29.2%)
iast_GLOBAL 1.923 ms [1.888 ms, 1.958 ms] 454.158 µs (30.9%)
profiling 1.862 ms [1.829 ms, 1.895 ms] 393.549 µs (26.8%)
tracing 1.84 ms [1.808 ms, 1.872 ms] 371.672 µs (25.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.482 ms] -
appsec 2.204 ms [2.171 ms, 2.238 ms] 734.371 µs (50.0%)
iast 1.906 ms [1.87 ms, 1.942 ms] 436.438 µs (29.7%)
iast_GLOBAL 1.922 ms [1.887 ms, 1.958 ms] 452.355 µs (30.8%)
profiling 2.314 ms [2.139 ms, 2.489 ms] 844.375 µs (57.4%)
tracing 1.84 ms [1.807 ms, 1.872 ms] 369.672 µs (25.1%)

@PerfectSlayer
Copy link
Copy Markdown
Contributor

PerfectSlayer commented Apr 22, 2024

lets teams identify issues before they're trying to release to production

What kind of issues dd-pkg lint can raise? And who’s behind teams?

@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Apr 22, 2024
@PerfectSlayer PerfectSlayer changed the title test: Lint produced deb and rpm packages Lint produced deb and rpm packages Apr 22, 2024
@spencergilbert
Copy link
Copy Markdown
Author

spencergilbert commented Apr 22, 2024 •
edited
Loading

What kind of issues dd-pkg lint can raise?

Today the only lint is checking that the package has no world-writeable files, though we do have some mid/long term plans to add additional checks around the package metadata, the 3rd party license file is included, among other policy/security style checks.

And who’s behind teams?

Agent Build and Releases (BaRX) owns the tool, and the package release pipelines/tooling - and the "teams" that would use dd-pkg is anyone who produces a deb/linux package for customers.

Let me know if I can go into more detail on anything, or if something doesn't make sense.

@PerfectSlayer
Copy link
Copy Markdown
Contributor

PerfectSlayer commented Apr 25, 2024

Thanks for the details. I just wanted to make sure of who has to act on it if it starts to block the build process 👍

@spencergilbert spencergilbert merged commit ae1c4c9 into master Apr 25, 2024
@spencergilbert spencergilbert deleted the spencergilbert/use-dd-pkg-for-package-linting branch April 25, 2024 12:51
@github-actions github-actions Bot added this to the 1.34.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree was automatically assigned from DataDog/apm-java

Assignees

@spencergilbert spencergilbert

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.34.0

Development

Successfully merging this pull request may close these issues.

2 participants

@spencergilbert @PerfectSlayer