Skip to content

Report via telemetry if _dd.iast.json tag exceeds max tag size#6930

Merged
jandro996 merged 8 commits intomasterfrom
alejandro.gonzalez/add-telemetry-to-truncated-json
Apr 24, 2024
Merged

Report via telemetry if _dd.iast.json tag exceeds max tag size#6930
jandro996 merged 8 commits intomasterfrom
alejandro.gonzalez/add-telemetry-to-truncated-json

Conversation

@jandro996
Copy link
Copy Markdown
Member

@jandro996 jandro996 commented Apr 22, 2024 •
edited by smola
Loading

What Does This Do

Add a new telemetry metric (iast.json.tag.size.exceeded) to measure how many times _dd.iast.json tag exceeds max tag size

Motivation

We need metrics related with how many times source code vulnerabilities information exceeds the maximum size allowed

Additional Notes

Jira ticket: APPSEC-11540

@smola smola changed the title Report via telemetry if iast-json tag exceeds max tag size Report via telemetry if _dd.iast.json tag exceeds max tag size Apr 22, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 22, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/add-telemetry-to-truncated-json
git_commit_date 1713776106 1713780187
git_commit_sha 8c37f09 1aceb39
release_version 1.34.0-SNAPSHOT~8c37f09d8c 1.34.0-SNAPSHOT~1aceb39018
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713782529 1713782529
ci_job_id 492759541 492759541
ci_pipeline_id 32579913 32579913
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089816
Total [baseline] (8.583 s) : 0, 8582756
Agent [candidate] (1.075 s) : 0, 1074810
Total [candidate] (8.553 s) : 0, 8552958
section iast
Agent [baseline] (1.204 s) : 0, 1204497
Total [baseline] (9.048 s) : 0, 9047617
Agent [candidate] (1.196 s) : 0, 1196447
Total [candidate] (9.013 s) : 0, 9013118
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1205289
Total [baseline] (8.99 s) : 0, 8989812
Agent [candidate] (1.197 s) : 0, 1196859
Total [candidate] (9.022 s) : 0, 9022471
section iast_TELEMETRY_OFF
Agent [baseline] (1.195 s) : 0, 1195330
Total [baseline] (9.023 s) : 0, 9022539
Agent [candidate] (1.196 s) : 0, 1195692
Total [candidate] (8.995 s) : 0, 8995263
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.204 s 114.681 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 115.473 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.195 s 105.514 ms (9.7%)
Total tracing 8.583 s -
Total iast 9.048 s 464.861 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.99 s 407.056 ms (4.7%)
Total iast_TELEMETRY_OFF 9.023 s 439.783 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.196 s 121.637 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 122.049 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.196 s 120.882 ms (11.2%)
Total tracing 8.553 s -
Total iast 9.013 s 460.16 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.022 s 469.514 ms (5.5%)
Total iast_TELEMETRY_OFF 8.995 s 442.305 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.618 ms) : 0, 682618
BytebuddyAgent [candidate] (672.532 ms) : 0, 672532
GlobalTracer [baseline] (313.583 ms) : 0, 313583
GlobalTracer [candidate] (309.993 ms) : 0, 309993
AppSec [baseline] (50.204 ms) : 0, 50204
AppSec [candidate] (49.734 ms) : 0, 49734
Remote Config [baseline] (671.621 µs) : 0, 672
Remote Config [candidate] (658.506 µs) : 0, 659
Telemetry [baseline] (7.723 ms) : 0, 7723
Telemetry [candidate] (7.558 ms) : 0, 7558
section iast
BytebuddyAgent [baseline] (798.389 ms) : 0, 798389
BytebuddyAgent [candidate] (792.393 ms) : 0, 792393
GlobalTracer [baseline] (289.484 ms) : 0, 289484
GlobalTracer [candidate] (287.441 ms) : 0, 287441
AppSec [baseline] (50.623 ms) : 0, 50623
AppSec [candidate] (51.115 ms) : 0, 51115
IAST [baseline] (22.506 ms) : 0, 22506
IAST [candidate] (23.027 ms) : 0, 23027
Remote Config [baseline] (579.495 µs) : 0, 579
Remote Config [candidate] (573.439 µs) : 0, 573
Telemetry [baseline] (8.36 ms) : 0, 8360
Telemetry [candidate] (7.45 ms) : 0, 7450
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.915 ms) : 0, 798915
BytebuddyAgent [candidate] (793.371 ms) : 0, 793371
GlobalTracer [baseline] (289.27 ms) : 0, 289270
GlobalTracer [candidate] (287.692 ms) : 0, 287692
AppSec [baseline] (49.582 ms) : 0, 49582
AppSec [candidate] (49.723 ms) : 0, 49723
IAST [baseline] (24.115 ms) : 0, 24115
IAST [candidate] (24.602 ms) : 0, 24602
Remote Config [baseline] (579.413 µs) : 0, 579
Remote Config [candidate] (555.389 µs) : 0, 555
Telemetry [baseline] (8.143 ms) : 0, 8143
Telemetry [candidate] (6.543 ms) : 0, 6543
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.759 ms) : 0, 791759
BytebuddyAgent [candidate] (791.371 ms) : 0, 791371
GlobalTracer [baseline] (288.178 ms) : 0, 288178
GlobalTracer [candidate] (287.899 ms) : 0, 287899
AppSec [baseline] (48.785 ms) : 0, 48785
AppSec [candidate] (48.053 ms) : 0, 48053
IAST [baseline] (23.609 ms) : 0, 23609
IAST [candidate] (25.168 ms) : 0, 25168
Remote Config [baseline] (589.218 µs) : 0, 589
Remote Config [candidate] (589.906 µs) : 0, 590
Telemetry [baseline] (8.064 ms) : 0, 8064
Telemetry [candidate] (8.083 ms) : 0, 8083
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073228
Total [baseline] (10.459 s) : 0, 10458854
Agent [candidate] (1.078 s) : 0, 1077692
Total [candidate] (10.438 s) : 0, 10437536
section appsec
Agent [baseline] (1.192 s) : 0, 1192103
Total [baseline] (10.509 s) : 0, 10509043
Agent [candidate] (1.188 s) : 0, 1188370
Total [candidate] (10.46 s) : 0, 10460025
section iast
Agent [baseline] (1.199 s) : 0, 1198800
Total [baseline] (10.759 s) : 0, 10759206
Agent [candidate] (1.196 s) : 0, 1196042
Total [candidate] (10.807 s) : 0, 10806876
section profiling
Agent [baseline] (1.272 s) : 0, 1271757
Total [baseline] (10.669 s) : 0, 10668888
Agent [candidate] (1.267 s) : 0, 1267451
Total [candidate] (10.59 s) : 0, 10589594
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.192 s 118.875 ms (11.1%)
Agent iast 1.199 s 125.572 ms (11.7%)
Agent profiling 1.272 s 198.53 ms (18.5%)
Total tracing 10.459 s -
Total appsec 10.509 s 50.19 ms (0.5%)
Total iast 10.759 s 300.353 ms (2.9%)
Total profiling 10.669 s 210.035 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.188 s 110.678 ms (10.3%)
Agent iast 1.196 s 118.35 ms (11.0%)
Agent profiling 1.267 s 189.76 ms (17.6%)
Total tracing 10.438 s -
Total appsec 10.46 s 22.49 ms (0.2%)
Total iast 10.807 s 369.341 ms (3.5%)
Total profiling 10.59 s 152.058 ms (1.5%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.308 ms) : 0, 672308
BytebuddyAgent [candidate] (675.958 ms) : 0, 675958
GlobalTracer [baseline] (308.78 ms) : 0, 308780
GlobalTracer [candidate] (309.406 ms) : 0, 309406
AppSec [baseline] (49.459 ms) : 0, 49459
AppSec [candidate] (49.527 ms) : 0, 49527
Remote Config [baseline] (661.002 µs) : 0, 661
Remote Config [candidate] (657.341 µs) : 0, 657
Telemetry [baseline] (7.63 ms) : 0, 7630
Telemetry [candidate] (7.554 ms) : 0, 7554
section appsec
BytebuddyAgent [baseline] (696.066 ms) : 0, 696066
BytebuddyAgent [candidate] (694.532 ms) : 0, 694532
GlobalTracer [baseline] (292.638 ms) : 0, 292638
GlobalTracer [candidate] (291.057 ms) : 0, 291057
AppSec [baseline] (149.812 ms) : 0, 149812
AppSec [candidate] (149.7 ms) : 0, 149700
IAST [baseline] (19.442 ms) : 0, 19442
IAST [candidate] (19.144 ms) : 0, 19144
Remote Config [baseline] (619.548 µs) : 0, 620
Remote Config [candidate] (617.013 µs) : 0, 617
Telemetry [baseline] (8.811 ms) : 0, 8811
Telemetry [candidate] (8.419 ms) : 0, 8419
section iast
BytebuddyAgent [baseline] (794.635 ms) : 0, 794635
BytebuddyAgent [candidate] (791.568 ms) : 0, 791568
GlobalTracer [baseline] (288.475 ms) : 0, 288475
GlobalTracer [candidate] (287.878 ms) : 0, 287878
AppSec [baseline] (48.959 ms) : 0, 48959
AppSec [candidate] (49.62 ms) : 0, 49620
IAST [baseline] (24.953 ms) : 0, 24953
IAST [candidate] (25.493 ms) : 0, 25493
Remote Config [baseline] (576.418 µs) : 0, 576
Remote Config [candidate] (576.779 µs) : 0, 577
Telemetry [baseline] (6.629 ms) : 0, 6629
Telemetry [candidate] (6.581 ms) : 0, 6581
section profiling
BytebuddyAgent [baseline] (678.072 ms) : 0, 678072
BytebuddyAgent [candidate] (676.433 ms) : 0, 676433
GlobalTracer [baseline] (381.958 ms) : 0, 381958
GlobalTracer [candidate] (380.171 ms) : 0, 380171
AppSec [baseline] (50.536 ms) : 0, 50536
AppSec [candidate] (50.228 ms) : 0, 50228
Remote Config [baseline] (710.063 µs) : 0, 710
Remote Config [candidate] (724.418 µs) : 0, 724
Telemetry [baseline] (7.512 ms) : 0, 7512
Telemetry [candidate] (7.464 ms) : 0, 7464
ProfilingAgent [baseline] (96.551 ms) : 0, 96551
ProfilingAgent [candidate] (95.967 ms) : 0, 95967
Profiling [baseline] (96.574 ms) : 0, 96574
Profiling [candidate] (95.991 ms) : 0, 95991
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-22T10:12:53 2024-04-22T10:19:43
git_branch master alejandro.gonzalez/add-telemetry-to-truncated-json
git_commit_date 1713776106 1713780187
git_commit_sha 8c37f09 1aceb39
release_version 1.34.0-SNAPSHOT~8c37f09d8c 1.34.0-SNAPSHOT~1aceb39018
start_time 2024-04-22T10:12:40 2024-04-22T10:19:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713781530 1713781530
ci_job_id 492759542 492759542
ci_pipeline_id 32579913 32579913
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+34.501µs; +87.565µs] or [+2.305%; +5.850%]		 unstable
[-540.356op/s; +540.356op/s] or [-17.562%; +17.562%]		 1.558ms 3076.923op/s 1.497ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.204 µs) : 359, 398
.   : milestone, 378,
iast (478.093 µs) : 457, 499
.   : milestone, 478,
iast_FULL (550.731 µs) : 529, 572
.   : milestone, 551,
iast_GLOBAL (516.008 µs) : 494, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (482.796 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (460.667 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (472.31 µs) : 452, 493
.   : milestone, 472,
tracing (453.953 µs) : 433, 475
.   : milestone, 454,
section candidate
no_agent (370.649 µs) : 351, 390
.   : milestone, 371,
iast (481.43 µs) : 461, 502
.   : milestone, 481,
iast_FULL (548.009 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (504.367 µs) : 483, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (481.745 µs) : 461, 502
.   : milestone, 482,
iast_INACTIVE (450.617 µs) : 430, 471
.   : milestone, 451,
iast_TELEMETRY_OFF (483.964 µs) : 463, 505
.   : milestone, 484,
tracing (443.726 µs) : 424, 464
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.204 µs [358.696 µs, 397.712 µs] -
iast 478.093 µs [456.981 µs, 499.204 µs] 99.889 µs (26.4%)
iast_FULL 550.731 µs [529.018 µs, 572.444 µs] 172.527 µs (45.6%)
iast_GLOBAL 516.008 µs [493.784 µs, 538.233 µs] 137.804 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 482.796 µs [461.548 µs, 504.045 µs] 104.592 µs (27.7%)
iast_INACTIVE 460.667 µs [439.205 µs, 482.128 µs] 82.463 µs (21.8%)
iast_TELEMETRY_OFF 472.31 µs [451.783 µs, 492.837 µs] 94.106 µs (24.9%)
tracing 453.953 µs [433.288 µs, 474.617 µs] 75.749 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.649 µs [350.84 µs, 390.458 µs] -
iast 481.43 µs [460.598 µs, 502.262 µs] 110.781 µs (29.9%)
iast_FULL 548.009 µs [527.234 µs, 568.783 µs] 177.36 µs (47.9%)
iast_GLOBAL 504.367 µs [483.052 µs, 525.681 µs] 133.718 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 481.745 µs [461.227 µs, 502.263 µs] 111.096 µs (30.0%)
iast_INACTIVE 450.617 µs [430.18 µs, 471.055 µs] 79.968 µs (21.6%)
iast_TELEMETRY_OFF 483.964 µs [462.664 µs, 505.264 µs] 113.315 µs (30.6%)
tracing 443.726 µs [423.937 µs, 463.514 µs] 73.077 µs (19.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1383
.   : milestone, 1362,
appsec (1.732 ms) : 1708, 1755
.   : milestone, 1732,
appsec_no_iast (1.741 ms) : 1717, 1766
.   : milestone, 1741,
iast (1.485 ms) : 1461, 1508
.   : milestone, 1485,
profiling (1.497 ms) : 1473, 1521
.   : milestone, 1497,
tracing (1.492 ms) : 1467, 1516
.   : milestone, 1492,
section candidate
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.726 ms) : 1701, 1751
.   : milestone, 1726,
appsec_no_iast (1.727 ms) : 1702, 1752
.   : milestone, 1727,
iast (1.479 ms) : 1455, 1502
.   : milestone, 1479,
profiling (1.558 ms) : 1533, 1583
.   : milestone, 1558,
tracing (1.499 ms) : 1475, 1523
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.383 ms] -
appsec 1.732 ms [1.708 ms, 1.755 ms] 369.23 µs (27.1%)
appsec_no_iast 1.741 ms [1.717 ms, 1.766 ms] 378.921 µs (27.8%)
iast 1.485 ms [1.461 ms, 1.508 ms] 122.223 µs (9.0%)
profiling 1.497 ms [1.473 ms, 1.521 ms] 134.471 µs (9.9%)
tracing 1.492 ms [1.467 ms, 1.516 ms] 129.172 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.374 ms] -
appsec 1.726 ms [1.701 ms, 1.751 ms] 370.805 µs (27.4%)
appsec_no_iast 1.727 ms [1.702 ms, 1.752 ms] 371.636 µs (27.4%)
iast 1.479 ms [1.455 ms, 1.502 ms] 123.421 µs (9.1%)
profiling 1.558 ms [1.533 ms, 1.583 ms] 202.632 µs (15.0%)
tracing 1.499 ms [1.475 ms, 1.523 ms] 143.54 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/add-telemetry-to-truncated-json
git_commit_date 1713776106 1713780187
git_commit_sha 8c37f09 1aceb39
release_version 1.34.0-SNAPSHOT~8c37f09d8c 1.34.0-SNAPSHOT~1aceb39018
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1713782026 1713782026
ci_job_id 492759543 492759543
ci_pipeline_id 32579913 32579913
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.18 ms) : 2147, 2214
.   : milestone, 2180,
iast (1.869 ms) : 1835, 1904
.   : milestone, 1869,
iast_GLOBAL (1.911 ms) : 1875, 1946
.   : milestone, 1911,
profiling (1.836 ms) : 1803, 1870
.   : milestone, 1836,
tracing (1.823 ms) : 1791, 1855
.   : milestone, 1823,
section candidate
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.188 ms) : 2155, 2222
.   : milestone, 2188,
iast (1.866 ms) : 1831, 1900
.   : milestone, 1866,
iast_GLOBAL (1.903 ms) : 1869, 1938
.   : milestone, 1903,
profiling (1.841 ms) : 1807, 1875
.   : milestone, 1841,
tracing (1.825 ms) : 1793, 1857
.   : milestone, 1825,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.18 ms [2.147 ms, 2.214 ms] 720.783 µs (49.4%)
iast 1.869 ms [1.835 ms, 1.904 ms] 409.924 µs (28.1%)
iast_GLOBAL 1.911 ms [1.875 ms, 1.946 ms] 451.168 µs (30.9%)
profiling 1.836 ms [1.803 ms, 1.87 ms] 377.007 µs (25.8%)
tracing 1.823 ms [1.791 ms, 1.855 ms] 363.469 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.188 ms [2.155 ms, 2.222 ms] 725.573 µs (49.6%)
iast 1.866 ms [1.831 ms, 1.9 ms] 402.7 µs (27.5%)
iast_GLOBAL 1.903 ms [1.869 ms, 1.938 ms] 440.652 µs (30.1%)
profiling 1.841 ms [1.807 ms, 1.875 ms] 377.943 µs (25.8%)
tracing 1.825 ms [1.793 ms, 1.857 ms] 361.955 µs (24.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~1aceb39018, baseline=1.34.0-SNAPSHOT~8c37f09d8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
appsec (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
iast (18.936 s) : 18936000, 18936000
.   : milestone, 18936000,
iast_GLOBAL (17.817 s) : 17817000, 17817000
.   : milestone, 17817000,
profiling (15.508 s) : 15508000, 15508000
.   : milestone, 15508000,
tracing (14.883 s) : 14883000, 14883000
.   : milestone, 14883000,
section candidate
no_agent (15.021 s) : 15021000, 15021000
.   : milestone, 15021000,
appsec (14.909 s) : 14909000, 14909000
.   : milestone, 14909000,
iast (18.858 s) : 18858000, 18858000
.   : milestone, 18858000,
iast_GLOBAL (18.013 s) : 18013000, 18013000
.   : milestone, 18013000,
profiling (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
tracing (15.251 s) : 15251000, 15251000
.   : milestone, 15251000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.13 s [15.13 s, 15.13 s] -
appsec 15.009 s [15.009 s, 15.009 s] -121.0 ms (-0.8%)
iast 18.936 s [18.936 s, 18.936 s] 3.806 s (25.2%)
iast_GLOBAL 17.817 s [17.817 s, 17.817 s] 2.687 s (17.8%)
profiling 15.508 s [15.508 s, 15.508 s] 378.0 ms (2.5%)
tracing 14.883 s [14.883 s, 14.883 s] -247.0 ms (-1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.021 s [15.021 s, 15.021 s] -
appsec 14.909 s [14.909 s, 14.909 s] -112.0 ms (-0.7%)
iast 18.858 s [18.858 s, 18.858 s] 3.837 s (25.5%)
iast_GLOBAL 18.013 s [18.013 s, 18.013 s] 2.992 s (19.9%)
profiling 15.166 s [15.166 s, 15.166 s] 145.0 ms (1.0%)
tracing 15.251 s [15.251 s, 15.251 s] 230.0 ms (1.5%)

smola
smola approved these changes Apr 22, 2024
View reviewed changes
Comment thread internal-api/src/main/java/datadog/trace/api/iast/telemetry/IastMetric.java Outdated
manuel-alvarez-alvarez
manuel-alvarez-alvarez reviewed Apr 22, 2024
View reviewed changes
Comment thread internal-api/src/main/java/datadog/trace/api/iast/telemetry/IastMetric.java Outdated
@jandro996 jandro996 marked this pull request as ready for review April 23, 2024 06:27
@jandro996 jandro996 requested a review from a team as a code owner April 23, 2024 06:27
@jandro996 jandro996 merged commit ff3a8ed into master Apr 24, 2024
@jandro996 jandro996 deleted the alejandro.gonzalez/add-telemetry-to-truncated-json branch April 24, 2024 07:59
@github-actions github-actions Bot added this to the 1.34.0 milestone Apr 24, 2024
@PerfectSlayer PerfectSlayer added tag: diagnostics Diagnostics related changes comp: asm iast Application Security Management (IAST) labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

comp: asm iast Application Security Management (IAST) tag: diagnostics Diagnostics related changes

Projects

None yet

Milestone

1.34.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jandro996 @smola @manuel-alvarez-alvarez @PerfectSlayer