Skip to content

Disable retry instrumentations if both Early Flakiness Detection and Flaky Test Retries are turned off#6925

Merged
nikita-tkachenko-datadog merged 1 commit intomasterfrom
nikita-tkachenko/disable-redundant-retry-instrumentations
Apr 17, 2024
Merged

Disable retry instrumentations if both Early Flakiness Detection and Flaky Test Retries are turned off#6925
nikita-tkachenko-datadog merged 1 commit intomasterfrom
nikita-tkachenko/disable-redundant-retry-instrumentations

Conversation

@nikita-tkachenko-datadog
Copy link
Copy Markdown
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Apr 17, 2024 •
edited
Loading

What Does This Do

Disables instrumentations that are related to CI Visibility's test retry functionality in case both test retry features (Early Flakiness Detection and Failed Test Retries) are turned off.

Motivation

Applying those instrumentations if test retries are disabled is redundant: even though it does not break anything, it adds some unnecessary overhead.

Jira ticket: CIVIS-9800

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Apr 17, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review April 17, 2024 10:52
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner April 17, 2024 10:52
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 17, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/disable-redundant-retry-instrumentations
git_commit_date 1713338255 1713349948
git_commit_sha 34e7066 78ae2bd
release_version 1.33.0-SNAPSHOT~34e706697c 1.33.0-SNAPSHOT~78ae2bdf91
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713352384 1713352384
ci_job_id 488993640 488993640
ci_pipeline_id 32293274 32293274
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082928
Total [baseline] (8.587 s) : 0, 8586816
Agent [candidate] (1.074 s) : 0, 1074127
Total [candidate] (8.561 s) : 0, 8561140
section iast
Agent [baseline] (1.2 s) : 0, 1200055
Total [baseline] (9.044 s) : 0, 9044220
Agent [candidate] (1.207 s) : 0, 1207145
Total [candidate] (9.053 s) : 0, 9053310
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1197937
Total [baseline] (8.975 s) : 0, 8975495
Agent [candidate] (1.197 s) : 0, 1196624
Total [candidate] (8.993 s) : 0, 8992971
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1204982
Total [baseline] (9.008 s) : 0, 9007957
Agent [candidate] (1.196 s) : 0, 1195914
Total [candidate] (9.006 s) : 0, 9005739
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent iast 1.2 s 117.127 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 115.008 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.205 s 122.054 ms (11.3%)
Total tracing 8.587 s -
Total iast 9.044 s 457.404 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.975 s 388.68 ms (4.5%)
Total iast_TELEMETRY_OFF 9.008 s 421.142 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.207 s 133.017 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 122.496 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.196 s 121.787 ms (11.3%)
Total tracing 8.561 s -
Total iast 9.053 s 492.17 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.993 s 431.831 ms (5.0%)
Total iast_TELEMETRY_OFF 9.006 s 444.599 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.225 ms) : 0, 678225
BytebuddyAgent [candidate] (672.813 ms) : 0, 672813
GlobalTracer [baseline] (311.65 ms) : 0, 311650
GlobalTracer [candidate] (309.413 ms) : 0, 309413
AppSec [baseline] (49.866 ms) : 0, 49866
AppSec [candidate] (49.411 ms) : 0, 49411
Remote Config [baseline] (673.912 µs) : 0, 674
Remote Config [candidate] (668.463 µs) : 0, 668
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (7.587 ms) : 0, 7587
section iast
BytebuddyAgent [baseline] (795.511 ms) : 0, 795511
BytebuddyAgent [candidate] (800.337 ms) : 0, 800337
GlobalTracer [baseline] (288.432 ms) : 0, 288432
GlobalTracer [candidate] (289.887 ms) : 0, 289887
AppSec [baseline] (49.664 ms) : 0, 49664
AppSec [candidate] (51.353 ms) : 0, 51353
IAST [baseline] (23.95 ms) : 0, 23950
IAST [candidate] (23.02 ms) : 0, 23020
Remote Config [baseline] (582.269 µs) : 0, 582
Remote Config [candidate] (575.479 µs) : 0, 575
Telemetry [baseline] (7.456 ms) : 0, 7456
Telemetry [candidate] (7.479 ms) : 0, 7479
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.648 ms) : 0, 793648
BytebuddyAgent [candidate] (793.146 ms) : 0, 793146
GlobalTracer [baseline] (287.878 ms) : 0, 287878
GlobalTracer [candidate] (287.677 ms) : 0, 287677
AppSec [baseline] (50.408 ms) : 0, 50408
AppSec [candidate] (51.307 ms) : 0, 51307
IAST [baseline] (23.013 ms) : 0, 23013
IAST [candidate] (22.88 ms) : 0, 22880
Remote Config [baseline] (583.055 µs) : 0, 583
Remote Config [candidate] (575.872 µs) : 0, 576
Telemetry [baseline] (8.109 ms) : 0, 8109
Telemetry [candidate] (6.673 ms) : 0, 6673
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.052 ms) : 0, 799052
BytebuddyAgent [candidate] (791.655 ms) : 0, 791655
GlobalTracer [baseline] (289.992 ms) : 0, 289992
GlobalTracer [candidate] (288.309 ms) : 0, 288309
AppSec [baseline] (48.673 ms) : 0, 48673
AppSec [candidate] (49.514 ms) : 0, 49514
IAST [baseline] (25.455 ms) : 0, 25455
IAST [candidate] (24.114 ms) : 0, 24114
Remote Config [baseline] (580.317 µs) : 0, 580
Remote Config [candidate] (585.494 µs) : 0, 585
Telemetry [baseline] (6.531 ms) : 0, 6531
Telemetry [candidate] (7.357 ms) : 0, 7357
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073513
Total [baseline] (10.354 s) : 0, 10353646
Agent [candidate] (1.074 s) : 0, 1074285
Total [candidate] (10.521 s) : 0, 10521400
section appsec
Agent [baseline] (1.19 s) : 0, 1189742
Total [baseline] (10.551 s) : 0, 10551013
Agent [candidate] (1.187 s) : 0, 1186578
Total [candidate] (10.491 s) : 0, 10491334
section iast
Agent [baseline] (1.208 s) : 0, 1207731
Total [baseline] (10.781 s) : 0, 10780505
Agent [candidate] (1.203 s) : 0, 1203108
Total [candidate] (10.834 s) : 0, 10833766
section profiling
Agent [baseline] (1.276 s) : 0, 1276131
Total [baseline] (10.623 s) : 0, 10623145
Agent [candidate] (1.284 s) : 0, 1283716
Total [candidate] (10.698 s) : 0, 10698397
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.19 s 116.229 ms (10.8%)
Agent iast 1.208 s 134.218 ms (12.5%)
Agent profiling 1.276 s 202.618 ms (18.9%)
Total tracing 10.354 s -
Total appsec 10.551 s 197.368 ms (1.9%)
Total iast 10.781 s 426.859 ms (4.1%)
Total profiling 10.623 s 269.499 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.187 s 112.293 ms (10.5%)
Agent iast 1.203 s 128.823 ms (12.0%)
Agent profiling 1.284 s 209.431 ms (19.5%)
Total tracing 10.521 s -
Total appsec 10.491 s -30.066 ms (-0.3%)
Total iast 10.834 s 312.366 ms (3.0%)
Total profiling 10.698 s 176.997 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.727 ms) : 0, 672727
BytebuddyAgent [candidate] (673.004 ms) : 0, 673004
GlobalTracer [baseline] (308.815 ms) : 0, 308815
GlobalTracer [candidate] (309.397 ms) : 0, 309397
AppSec [baseline] (49.386 ms) : 0, 49386
AppSec [candidate] (49.226 ms) : 0, 49226
Remote Config [baseline] (662.646 µs) : 0, 663
Remote Config [candidate] (659.465 µs) : 0, 659
Telemetry [baseline] (7.634 ms) : 0, 7634
Telemetry [candidate] (7.62 ms) : 0, 7620
section appsec
BytebuddyAgent [baseline] (696.129 ms) : 0, 696129
BytebuddyAgent [candidate] (694.717 ms) : 0, 694717
GlobalTracer [baseline] (291.632 ms) : 0, 291632
GlobalTracer [candidate] (291.147 ms) : 0, 291147
AppSec [baseline] (149.888 ms) : 0, 149888
AppSec [candidate] (149.113 ms) : 0, 149113
IAST [baseline] (18.936 ms) : 0, 18936
IAST [candidate] (18.83 ms) : 0, 18830
Remote Config [baseline] (628.118 µs) : 0, 628
Remote Config [candidate] (616.376 µs) : 0, 616
Telemetry [baseline] (7.543 ms) : 0, 7543
Telemetry [candidate] (7.18 ms) : 0, 7180
section iast
BytebuddyAgent [baseline] (801.069 ms) : 0, 801069
BytebuddyAgent [candidate] (795.78 ms) : 0, 795780
GlobalTracer [baseline] (289.931 ms) : 0, 289931
GlobalTracer [candidate] (290.323 ms) : 0, 290323
AppSec [baseline] (51.611 ms) : 0, 51611
AppSec [candidate] (52.051 ms) : 0, 52051
IAST [baseline] (22.393 ms) : 0, 22393
IAST [candidate] (23.314 ms) : 0, 23314
Remote Config [baseline] (583.826 µs) : 0, 584
Remote Config [candidate] (574.228 µs) : 0, 574
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (6.66 ms) : 0, 6660
section profiling
BytebuddyAgent [baseline] (682.194 ms) : 0, 682194
BytebuddyAgent [candidate] (686.478 ms) : 0, 686478
GlobalTracer [baseline] (381.853 ms) : 0, 381853
GlobalTracer [candidate] (384.496 ms) : 0, 384496
AppSec [baseline] (50.294 ms) : 0, 50294
AppSec [candidate] (50.762 ms) : 0, 50762
Remote Config [baseline] (714.074 µs) : 0, 714
Remote Config [candidate] (712.133 µs) : 0, 712
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (7.538 ms) : 0, 7538
ProfilingAgent [baseline] (96.843 ms) : 0, 96843
ProfilingAgent [candidate] (96.6 ms) : 0, 96600
Profiling [baseline] (96.867 ms) : 0, 96867
Profiling [candidate] (96.624 ms) : 0, 96624
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-17T10:43:50 2024-04-17T10:50:42
git_branch master nikita-tkachenko/disable-redundant-retry-instrumentations
git_commit_date 1713338255 1713349948
git_commit_sha 34e7066 78ae2bd
release_version 1.33.0-SNAPSHOT~34e706697c 1.33.0-SNAPSHOT~78ae2bdf91
start_time 2024-04-17T10:43:37 2024-04-17T10:50:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713351389 1713351389
ci_job_id 488993641 488993641
ci_pipeline_id 32293274 32293274
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.72 ms) : 1695, 1745
.   : milestone, 1720,
appsec_no_iast (1.741 ms) : 1716, 1765
.   : milestone, 1741,
iast (1.515 ms) : 1492, 1537
.   : milestone, 1515,
profiling (1.554 ms) : 1528, 1579
.   : milestone, 1554,
tracing (1.494 ms) : 1469, 1519
.   : milestone, 1494,
section candidate
no_agent (1.352 ms) : 1332, 1371
.   : milestone, 1352,
appsec (1.739 ms) : 1715, 1762
.   : milestone, 1739,
appsec_no_iast (1.73 ms) : 1706, 1753
.   : milestone, 1730,
iast (1.512 ms) : 1490, 1535
.   : milestone, 1512,
profiling (1.536 ms) : 1510, 1562
.   : milestone, 1536,
tracing (1.487 ms) : 1464, 1511
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.375 ms] -
appsec 1.72 ms [1.695 ms, 1.745 ms] 364.721 µs (26.9%)
appsec_no_iast 1.741 ms [1.716 ms, 1.765 ms] 385.7 µs (28.5%)
iast 1.515 ms [1.492 ms, 1.537 ms] 159.492 µs (11.8%)
profiling 1.554 ms [1.528 ms, 1.579 ms] 198.417 µs (14.6%)
tracing 1.494 ms [1.469 ms, 1.519 ms] 138.778 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.332 ms, 1.371 ms] -
appsec 1.739 ms [1.715 ms, 1.762 ms] 387.036 µs (28.6%)
appsec_no_iast 1.73 ms [1.706 ms, 1.753 ms] 377.915 µs (28.0%)
iast 1.512 ms [1.49 ms, 1.535 ms] 160.749 µs (11.9%)
profiling 1.536 ms [1.51 ms, 1.562 ms] 184.197 µs (13.6%)
tracing 1.487 ms [1.464 ms, 1.511 ms] 135.66 µs (10.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.11 µs) : 350, 392
.   : milestone, 371,
iast (488.455 µs) : 466, 511
.   : milestone, 488,
iast_FULL (545.303 µs) : 524, 566
.   : milestone, 545,
iast_GLOBAL (497.103 µs) : 476, 519
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (478.326 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (460.413 µs) : 439, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (479.265 µs) : 458, 501
.   : milestone, 479,
tracing (445.712 µs) : 425, 466
.   : milestone, 446,
section candidate
no_agent (373.775 µs) : 354, 393
.   : milestone, 374,
iast (472.647 µs) : 452, 493
.   : milestone, 473,
iast_FULL (549.991 µs) : 529, 571
.   : milestone, 550,
iast_GLOBAL (502.078 µs) : 481, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (487.641 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (449.993 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (471.996 µs) : 451, 493
.   : milestone, 472,
tracing (447.938 µs) : 427, 469
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.11 µs [350.262 µs, 391.958 µs] -
iast 488.455 µs [466.041 µs, 510.87 µs] 117.346 µs (31.6%)
iast_FULL 545.303 µs [524.466 µs, 566.14 µs] 174.193 µs (46.9%)
iast_GLOBAL 497.103 µs [475.634 µs, 518.571 µs] 125.993 µs (34.0%)
iast_HARDCODED_SECRET_DISABLED 478.326 µs [457.368 µs, 499.284 µs] 107.216 µs (28.9%)
iast_INACTIVE 460.413 µs [438.949 µs, 481.878 µs] 89.303 µs (24.1%)
iast_TELEMETRY_OFF 479.265 µs [457.985 µs, 500.545 µs] 108.155 µs (29.1%)
tracing 445.712 µs [425.43 µs, 465.993 µs] 74.602 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.775 µs [354.061 µs, 393.489 µs] -
iast 472.647 µs [452.342 µs, 492.951 µs] 98.872 µs (26.5%)
iast_FULL 549.991 µs [528.702 µs, 571.28 µs] 176.216 µs (47.1%)
iast_GLOBAL 502.078 µs [480.548 µs, 523.609 µs] 128.303 µs (34.3%)
iast_HARDCODED_SECRET_DISABLED 487.641 µs [466.251 µs, 509.031 µs] 113.866 µs (30.5%)
iast_INACTIVE 449.993 µs [429.251 µs, 470.735 µs] 76.218 µs (20.4%)
iast_TELEMETRY_OFF 471.996 µs [450.973 µs, 493.019 µs] 98.221 µs (26.3%)
tracing 447.938 µs [427.227 µs, 468.649 µs] 74.163 µs (19.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/disable-redundant-retry-instrumentations
git_commit_date 1713338255 1713349948
git_commit_sha 34e7066 78ae2bd
release_version 1.33.0-SNAPSHOT~34e706697c 1.33.0-SNAPSHOT~78ae2bdf91
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1713351902 1713351902
ci_job_id 488993642 488993642
ci_pipeline_id 32293274 32293274
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.197 ms) : 2164, 2231
.   : milestone, 2197,
iast (1.866 ms) : 1831, 1901
.   : milestone, 1866,
iast_GLOBAL (1.914 ms) : 1878, 1949
.   : milestone, 1914,
profiling (1.849 ms) : 1815, 1883
.   : milestone, 1849,
tracing (1.813 ms) : 1782, 1845
.   : milestone, 1813,
section candidate
no_agent (1.455 ms) : 1443, 1466
.   : milestone, 1455,
appsec (2.19 ms) : 2157, 2224
.   : milestone, 2190,
iast (1.873 ms) : 1838, 1908
.   : milestone, 1873,
iast_GLOBAL (1.906 ms) : 1872, 1941
.   : milestone, 1906,
profiling (1.839 ms) : 1806, 1873
.   : milestone, 1839,
tracing (1.814 ms) : 1782, 1845
.   : milestone, 1814,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.197 ms [2.164 ms, 2.231 ms] 740.886 µs (50.9%)
iast 1.866 ms [1.831 ms, 1.901 ms] 409.336 µs (28.1%)
iast_GLOBAL 1.914 ms [1.878 ms, 1.949 ms] 457.068 µs (31.4%)
profiling 1.849 ms [1.815 ms, 1.883 ms] 392.654 µs (27.0%)
tracing 1.813 ms [1.782 ms, 1.845 ms] 356.719 µs (24.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.443 ms, 1.466 ms] -
appsec 2.19 ms [2.157 ms, 2.224 ms] 735.227 µs (50.5%)
iast 1.873 ms [1.838 ms, 1.908 ms] 418.136 µs (28.7%)
iast_GLOBAL 1.906 ms [1.872 ms, 1.941 ms] 451.3 µs (31.0%)
profiling 1.839 ms [1.806 ms, 1.873 ms] 384.453 µs (26.4%)
tracing 1.814 ms [1.782 ms, 1.845 ms] 359.049 µs (24.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.33.0-SNAPSHOT~78ae2bdf91, baseline=1.33.0-SNAPSHOT~34e706697c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.385 s) : 15385000, 15385000
.   : milestone, 15385000,
appsec (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
iast (18.892 s) : 18892000, 18892000
.   : milestone, 18892000,
iast_GLOBAL (17.851 s) : 17851000, 17851000
.   : milestone, 17851000,
profiling (15.34 s) : 15340000, 15340000
.   : milestone, 15340000,
tracing (14.861 s) : 14861000, 14861000
.   : milestone, 14861000,
section candidate
no_agent (15.333 s) : 15333000, 15333000
.   : milestone, 15333000,
appsec (14.835 s) : 14835000, 14835000
.   : milestone, 14835000,
iast (18.974 s) : 18974000, 18974000
.   : milestone, 18974000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
.   : milestone, 18100000,
profiling (15.519 s) : 15519000, 15519000
.   : milestone, 15519000,
tracing (15.025 s) : 15025000, 15025000
.   : milestone, 15025000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.385 s [15.385 s, 15.385 s] -
appsec 15.073 s [15.073 s, 15.073 s] -312.0 ms (-2.0%)
iast 18.892 s [18.892 s, 18.892 s] 3.507 s (22.8%)
iast_GLOBAL 17.851 s [17.851 s, 17.851 s] 2.466 s (16.0%)
profiling 15.34 s [15.34 s, 15.34 s] -45.0 ms (-0.3%)
tracing 14.861 s [14.861 s, 14.861 s] -524.0 ms (-3.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.333 s [15.333 s, 15.333 s] -
appsec 14.835 s [14.835 s, 14.835 s] -498.0 ms (-3.2%)
iast 18.974 s [18.974 s, 18.974 s] 3.641 s (23.7%)
iast_GLOBAL 18.1 s [18.1 s, 18.1 s] 2.767 s (18.0%)
profiling 15.519 s [15.519 s, 15.519 s] 186.0 ms (1.2%)
tracing 15.025 s [15.025 s, 15.025 s] -308.0 ms (-2.0%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 40edb59 into master Apr 17, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/disable-redundant-retry-instrumentations branch April 17, 2024 12:19
@github-actions github-actions Bot added this to the 1.33.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

+1 more reviewer

@romainkomorn-exdatadog romainkomorn-exdatadog romainkomorn-exdatadog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility

Projects

None yet

Milestone

1.33.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nikita-tkachenko-datadog @anmarchenko @romainkomorn-exdatadog