Skip to content

Remove redundant use of DECORATE in TraceDecorator#6877

Merged
mcculls merged 1 commit intomasterfrom
mcculls/trace-decorator-redundant-instance
Apr 3, 2024
Merged

Remove redundant use of DECORATE in TraceDecorator#6877
mcculls merged 1 commit intomasterfrom
mcculls/trace-decorator-redundant-instance

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Apr 3, 2024 •
edited
Loading

since DECORATE just points to itself (this is leftover from when that code was moved from the advice to the decorator)

@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring labels Apr 3, 2024
@mcculls mcculls marked this pull request as ready for review April 3, 2024 12:59
@mcculls mcculls requested a review from a team as a code owner April 3, 2024 12:59
@mcculls mcculls requested review from dougqh and nayeem-kamal April 3, 2024 12:59
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 3, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/trace-decorator-redundant-instance
git_commit_date 1712101337 1712147181
git_commit_sha ca680ba 2d90218
release_version 1.32.0-SNAPSHOT~ca680ba8a3 1.32.0-SNAPSHOT~2d9021855b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1712150498 1712150498
ci_job_id 476655043 476655043
ci_pipeline_id 31345690 31345690
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~2d9021855b, baseline=1.32.0-SNAPSHOT~ca680ba8a3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076900
Total [baseline] (10.376 s) : 0, 10376145
Agent [candidate] (1.078 s) : 0, 1078371
Total [candidate] (10.398 s) : 0, 10397650
section appsec
Agent [baseline] (1.193 s) : 0, 1193078
Total [baseline] (10.453 s) : 0, 10453067
Agent [candidate] (1.202 s) : 0, 1202161
Total [candidate] (10.519 s) : 0, 10519193
section iast
Agent [baseline] (1.21 s) : 0, 1210382
Total [baseline] (10.816 s) : 0, 10816237
Agent [candidate] (1.203 s) : 0, 1202523
Total [candidate] (10.807 s) : 0, 10807410
section profiling
Agent [baseline] (1.267 s) : 0, 1266601
Total [baseline] (10.602 s) : 0, 10601982
Agent [candidate] (1.275 s) : 0, 1274568
Total [candidate] (10.559 s) : 0, 10558823
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.193 s 116.178 ms (10.8%)
Agent iast 1.21 s 133.482 ms (12.4%)
Agent profiling 1.267 s 189.701 ms (17.6%)
Total tracing 10.376 s -
Total appsec 10.453 s 76.922 ms (0.7%)
Total iast 10.816 s 440.092 ms (4.2%)
Total profiling 10.602 s 225.837 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.202 s 123.79 ms (11.5%)
Agent iast 1.203 s 124.152 ms (11.5%)
Agent profiling 1.275 s 196.196 ms (18.2%)
Total tracing 10.398 s -
Total appsec 10.519 s 121.543 ms (1.2%)
Total iast 10.807 s 409.76 ms (3.9%)
Total profiling 10.559 s 161.173 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~2d9021855b, baseline=1.32.0-SNAPSHOT~ca680ba8a3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.765 ms) : 0, 674765
BytebuddyAgent [candidate] (674.699 ms) : 0, 674699
GlobalTracer [baseline] (310.002 ms) : 0, 310002
GlobalTracer [candidate] (311.23 ms) : 0, 311230
AppSec [baseline] (49.438 ms) : 0, 49438
AppSec [candidate] (49.668 ms) : 0, 49668
Remote Config [baseline] (654.306 µs) : 0, 654
Remote Config [candidate] (660.598 µs) : 0, 661
Telemetry [baseline] (7.543 ms) : 0, 7543
Telemetry [candidate] (7.624 ms) : 0, 7624
section appsec
BytebuddyAgent [baseline] (693.061 ms) : 0, 693061
BytebuddyAgent [candidate] (698.367 ms) : 0, 698367
GlobalTracer [baseline] (290.389 ms) : 0, 290389
GlobalTracer [candidate] (291.919 ms) : 0, 291919
AppSec [baseline] (149.156 ms) : 0, 149156
AppSec [candidate] (149.794 ms) : 0, 149794
IAST [baseline] (18.736 ms) : 0, 18736
IAST [candidate] (18.804 ms) : 0, 18804
Remote Config [baseline] (606.69 µs) : 0, 607
Remote Config [candidate] (598.255 µs) : 0, 598
Telemetry [baseline] (6.781 ms) : 0, 6781
Telemetry [candidate] (8.036 ms) : 0, 8036
section iast
BytebuddyAgent [baseline] (803.109 ms) : 0, 803109
BytebuddyAgent [candidate] (796.165 ms) : 0, 796165
GlobalTracer [baseline] (290.129 ms) : 0, 290129
GlobalTracer [candidate] (289.701 ms) : 0, 289701
AppSec [baseline] (50.202 ms) : 0, 50202
AppSec [candidate] (49.78 ms) : 0, 49780
IAST [baseline] (23.21 ms) : 0, 23210
IAST [candidate] (23.761 ms) : 0, 23761
Remote Config [baseline] (593.145 µs) : 0, 593
Remote Config [candidate] (577.539 µs) : 0, 578
Telemetry [baseline] (8.263 ms) : 0, 8263
Telemetry [candidate] (8.069 ms) : 0, 8069
section profiling
BytebuddyAgent [baseline] (676.172 ms) : 0, 676172
BytebuddyAgent [candidate] (682.016 ms) : 0, 682016
GlobalTracer [baseline] (379.956 ms) : 0, 379956
GlobalTracer [candidate] (381.613 ms) : 0, 381613
AppSec [baseline] (50.244 ms) : 0, 50244
AppSec [candidate] (50.094 ms) : 0, 50094
Remote Config [baseline] (690.865 µs) : 0, 691
Remote Config [candidate] (710.074 µs) : 0, 710
Telemetry [baseline] (7.407 ms) : 0, 7407
Telemetry [candidate] (7.513 ms) : 0, 7513
ProfilingAgent [baseline] (95.993 ms) : 0, 95993
ProfilingAgent [candidate] (95.879 ms) : 0, 95879
Profiling [baseline] (96.016 ms) : 0, 96016
Profiling [candidate] (95.903 ms) : 0, 95903
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~2d9021855b, baseline=1.32.0-SNAPSHOT~ca680ba8a3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081229
Total [baseline] (8.558 s) : 0, 8557636
Agent [candidate] (1.085 s) : 0, 1084891
Total [candidate] (8.568 s) : 0, 8568132
section iast
Agent [baseline] (1.197 s) : 0, 1196731
Total [baseline] (9.047 s) : 0, 9047236
Agent [candidate] (1.209 s) : 0, 1208509
Total [candidate] (9.04 s) : 0, 9040152
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.213 s) : 0, 1213109
Total [baseline] (9.051 s) : 0, 9050584
Agent [candidate] (1.198 s) : 0, 1197700
Total [candidate] (8.98 s) : 0, 8979657
section iast_TELEMETRY_OFF
Agent [baseline] (1.21 s) : 0, 1210250
Total [baseline] (9.04 s) : 0, 9040422
Agent [candidate] (1.199 s) : 0, 1199169
Total [candidate] (9.022 s) : 0, 9021736
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.197 s 115.502 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.213 s 131.881 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.21 s 129.021 ms (11.9%)
Total tracing 8.558 s -
Total iast 9.047 s 489.599 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.051 s 492.947 ms (5.8%)
Total iast_TELEMETRY_OFF 9.04 s 482.785 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.209 s 123.618 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 112.809 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.199 s 114.277 ms (10.5%)
Total tracing 8.568 s -
Total iast 9.04 s 472.02 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.98 s 411.525 ms (4.8%)
Total iast_TELEMETRY_OFF 9.022 s 453.604 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~2d9021855b, baseline=1.32.0-SNAPSHOT~ca680ba8a3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (677.164 ms) : 0, 677164
BytebuddyAgent [candidate] (679.157 ms) : 0, 679157
GlobalTracer [baseline] (311.315 ms) : 0, 311315
GlobalTracer [candidate] (312.636 ms) : 0, 312636
AppSec [baseline] (49.729 ms) : 0, 49729
AppSec [candidate] (49.949 ms) : 0, 49949
Remote Config [baseline] (672.268 µs) : 0, 672
Remote Config [candidate] (671.004 µs) : 0, 671
Telemetry [baseline] (7.682 ms) : 0, 7682
Telemetry [candidate] (7.755 ms) : 0, 7755
section iast
BytebuddyAgent [baseline] (793.741 ms) : 0, 793741
BytebuddyAgent [candidate] (800.351 ms) : 0, 800351
GlobalTracer [baseline] (287.461 ms) : 0, 287461
GlobalTracer [candidate] (291.363 ms) : 0, 291363
AppSec [baseline] (51.374 ms) : 0, 51374
AppSec [candidate] (50.602 ms) : 0, 50602
IAST [baseline] (21.856 ms) : 0, 21856
IAST [candidate] (22.625 ms) : 0, 22625
Remote Config [baseline] (569.834 µs) : 0, 570
Remote Config [candidate] (589.081 µs) : 0, 589
Telemetry [baseline] (7.344 ms) : 0, 7344
Telemetry [candidate] (8.222 ms) : 0, 8222
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.531 ms) : 0, 804531
BytebuddyAgent [candidate] (792.996 ms) : 0, 792996
GlobalTracer [baseline] (291.763 ms) : 0, 291763
GlobalTracer [candidate] (288.636 ms) : 0, 288636
AppSec [baseline] (50.781 ms) : 0, 50781
AppSec [candidate] (49.344 ms) : 0, 49344
IAST [baseline] (23.915 ms) : 0, 23915
IAST [candidate] (25.16 ms) : 0, 25160
Remote Config [baseline] (597.179 µs) : 0, 597
Remote Config [candidate] (573.635 µs) : 0, 574
Telemetry [baseline] (6.657 ms) : 0, 6657
Telemetry [candidate] (6.601 ms) : 0, 6601
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.961 ms) : 0, 801961
BytebuddyAgent [candidate] (793.685 ms) : 0, 793685
GlobalTracer [baseline] (290.991 ms) : 0, 290991
GlobalTracer [candidate] (289.854 ms) : 0, 289854
AppSec [baseline] (49.577 ms) : 0, 49577
AppSec [candidate] (50.107 ms) : 0, 50107
IAST [baseline] (25.007 ms) : 0, 25007
IAST [candidate] (21.654 ms) : 0, 21654
Remote Config [baseline] (591.766 µs) : 0, 592
Remote Config [candidate] (579.221 µs) : 0, 579
Telemetry [baseline] (7.309 ms) : 0, 7309
Telemetry [candidate] (8.827 ms) : 0, 8827
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-03T12:53:53 2024-04-03T13:15:51
git_branch master mcculls/trace-decorator-redundant-instance
git_commit_date 1712101337 1712147181
git_commit_sha ca680ba 2d90218
release_version 1.32.0-SNAPSHOT~ca680ba8a3 1.32.0-SNAPSHOT~2d9021855b
start_time 2024-04-03T12:53:40 2024-04-03T13:15:38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1712150498 1712150498
ci_job_id 476655043 476655043
ci_pipeline_id 31345690 31345690
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~2d9021855b, baseline=1.32.0-SNAPSHOT~ca680ba8a3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1324, 1363
.   : milestone, 1344,
appsec (1.73 ms) : 1706, 1755
.   : milestone, 1730,
appsec_no_iast (1.732 ms) : 1707, 1757
.   : milestone, 1732,
iast (1.487 ms) : 1464, 1509
.   : milestone, 1487,
profiling (1.546 ms) : 1521, 1571
.   : milestone, 1546,
tracing (1.479 ms) : 1454, 1503
.   : milestone, 1479,
section candidate
no_agent (1.338 ms) : 1318, 1357
.   : milestone, 1338,
appsec (1.717 ms) : 1693, 1741
.   : milestone, 1717,
appsec_no_iast (1.749 ms) : 1725, 1773
.   : milestone, 1749,
iast (1.492 ms) : 1469, 1515
.   : milestone, 1492,
profiling (1.565 ms) : 1540, 1591
.   : milestone, 1565,
tracing (1.504 ms) : 1479, 1528
.   : milestone, 1504,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.324 ms, 1.363 ms] -
appsec 1.73 ms [1.706 ms, 1.755 ms] 386.602 µs (28.8%)
appsec_no_iast 1.732 ms [1.707 ms, 1.757 ms] 388.147 µs (28.9%)
iast 1.487 ms [1.464 ms, 1.509 ms] 142.979 µs (10.6%)
profiling 1.546 ms [1.521 ms, 1.571 ms] 202.483 µs (15.1%)
tracing 1.479 ms [1.454 ms, 1.503 ms] 134.939 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.357 ms] -
appsec 1.717 ms [1.693 ms, 1.741 ms] 379.189 µs (28.4%)
appsec_no_iast 1.749 ms [1.725 ms, 1.773 ms] 411.591 µs (30.8%)
iast 1.492 ms [1.469 ms, 1.515 ms] 154.56 µs (11.6%)
profiling 1.565 ms [1.54 ms, 1.591 ms] 227.68 µs (17.0%)
tracing 1.504 ms [1.479 ms, 1.528 ms] 166.02 µs (12.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~2d9021855b, baseline=1.32.0-SNAPSHOT~ca680ba8a3
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.781 µs) : 344, 384
.   : milestone, 364,
iast (481.34 µs) : 460, 503
.   : milestone, 481,
iast_FULL (542.561 µs) : 522, 563
.   : milestone, 543,
iast_GLOBAL (499.921 µs) : 478, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (474.324 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (450.02 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (469.294 µs) : 448, 490
.   : milestone, 469,
tracing (443.229 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (365.474 µs) : 346, 385
.   : milestone, 365,
iast (478.233 µs) : 457, 499
.   : milestone, 478,
iast_FULL (545.213 µs) : 524, 566
.   : milestone, 545,
iast_GLOBAL (500.489 µs) : 479, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (475.74 µs) : 454, 497
.   : milestone, 476,
iast_INACTIVE (453.631 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (474.515 µs) : 453, 496
.   : milestone, 475,
tracing (442.491 µs) : 422, 463
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.781 µs [343.641 µs, 383.922 µs] -
iast 481.34 µs [460.15 µs, 502.529 µs] 117.558 µs (32.3%)
iast_FULL 542.561 µs [521.807 µs, 563.314 µs] 178.779 µs (49.1%)
iast_GLOBAL 499.921 µs [478.143 µs, 521.698 µs] 136.139 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 474.324 µs [453.182 µs, 495.466 µs] 110.542 µs (30.4%)
iast_INACTIVE 450.02 µs [428.975 µs, 471.064 µs] 86.239 µs (23.7%)
iast_TELEMETRY_OFF 469.294 µs [448.455 µs, 490.134 µs] 105.513 µs (29.0%)
tracing 443.229 µs [422.436 µs, 464.021 µs] 79.448 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.474 µs [346.302 µs, 384.647 µs] -
iast 478.233 µs [457.074 µs, 499.391 µs] 112.758 µs (30.9%)
iast_FULL 545.213 µs [524.044 µs, 566.382 µs] 179.739 µs (49.2%)
iast_GLOBAL 500.489 µs [478.793 µs, 522.185 µs] 135.015 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 475.74 µs [454.454 µs, 497.027 µs] 110.266 µs (30.2%)
iast_INACTIVE 453.631 µs [432.571 µs, 474.691 µs] 88.157 µs (24.1%)
iast_TELEMETRY_OFF 474.515 µs [453.344 µs, 495.685 µs] 109.04 µs (29.8%)
tracing 442.491 µs [422.036 µs, 462.946 µs] 77.017 µs (21.1%)

@mcculls mcculls enabled auto-merge (squash) April 3, 2024 13:49
@mcculls mcculls merged commit 396fcca into master Apr 3, 2024
@mcculls mcculls deleted the mcculls/trace-decorator-redundant-instance branch April 3, 2024 16:47
@github-actions github-actions Bot added this to the 1.32.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougqh dougqh dougqh approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.32.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @dougqh