Unwrap ForkJoinTask$AdaptedInterruptibleCallable by richardstartin · Pull Request #6830 · DataDog/dd-trace-java

richardstartin · 2024-03-21T12:15:09Z

What Does This Do

Unwraps another adapter so we can get to the underlying task name for queueing in the FJP.

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-03-21T12:58:58Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/unwrap-fjt-aic
git_commit_date	1711021673	1711022785
git_commit_sha	`7160117`	7a6f782e39
release_version	1.32.0-SNAPSHOT~7160117940	1.32.0-SNAPSHOT~7a6f782e39

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1711025880	1711025880
ci_job_id	465716855	465716855
ci_pipeline_id	30537897	30537897
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 12 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:appsec:IAST	better [-1.658ms; -1.024ms] or [-8.593%; -5.307%]	17.955ms	19.296ms

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~7a6f782e39, baseline=1.32.0-SNAPSHOT~7160117940

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091893
Total [baseline] (9.192 s) : 0, 9192093
Agent [candidate] (1.084 s) : 0, 1083556
Total [candidate] (9.246 s) : 0, 9245587
section appsec
Agent [baseline] (1.202 s) : 0, 1202080
Total [baseline] (9.28 s) : 0, 9279938
Agent [candidate] (1.211 s) : 0, 1210560
Total [candidate] (9.309 s) : 0, 9309246
section iast
Agent [baseline] (1.206 s) : 0, 1205905
Total [baseline] (9.399 s) : 0, 9399495
Agent [candidate] (1.209 s) : 0, 1209130
Total [candidate] (9.461 s) : 0, 9461296
section profiling
Agent [baseline] (1.27 s) : 0, 1270199
Total [baseline] (9.395 s) : 0, 9394683
Agent [candidate] (1.277 s) : 0, 1276522
Total [candidate] (9.424 s) : 0, 9424332

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	appsec	1.202 s	110.186 ms (10.1%)
Agent	iast	1.206 s	114.012 ms (10.4%)
Agent	profiling	1.27 s	178.305 ms (16.3%)
Total	tracing	9.192 s	-
Total	appsec	9.28 s	87.845 ms (1.0%)
Total	iast	9.399 s	207.402 ms (2.3%)
Total	profiling	9.395 s	202.59 ms (2.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.084 s	-
Agent	appsec	1.211 s	127.004 ms (11.7%)
Agent	iast	1.209 s	125.575 ms (11.6%)
Agent	profiling	1.277 s	192.966 ms (17.8%)
Total	tracing	9.246 s	-
Total	appsec	9.309 s	63.659 ms (0.7%)
Total	iast	9.461 s	215.709 ms (2.3%)
Total	profiling	9.424 s	178.745 ms (1.9%)

gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~7a6f782e39, baseline=1.32.0-SNAPSHOT~7160117940

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.779 ms) : 0, 696779
BytebuddyAgent [candidate] (698.489 ms) : 0, 698489
GlobalTracer [baseline] (301.821 ms) : 0, 301821
GlobalTracer [candidate] (292.762 ms) : 0, 292762
AppSec [baseline] (49.885 ms) : 0, 49885
AppSec [candidate] (49.368 ms) : 0, 49368
Remote Config [baseline] (1.072 ms) : 0, 1072
Remote Config [candidate] (1.084 ms) : 0, 1084
Telemetry [baseline] (7.479 ms) : 0, 7479
Telemetry [candidate] (7.54 ms) : 0, 7540
section appsec
BytebuddyAgent [baseline] (695.985 ms) : 0, 695985
BytebuddyAgent [candidate] (702.184 ms) : 0, 702184
GlobalTracer [baseline] (291.938 ms) : 0, 291938
GlobalTracer [candidate] (294.239 ms) : 0, 294239
AppSec [baseline] (153.185 ms) : 0, 153185
AppSec [candidate] (153.956 ms) : 0, 153956
IAST [baseline] (19.296 ms) : 0, 19296
IAST [candidate] (17.955 ms) : 0, 17955
Remote Config [baseline] (603.397 µs) : 0, 603
Remote Config [candidate] (614.654 µs) : 0, 615
Telemetry [baseline] (6.783 ms) : 0, 6783
Telemetry [candidate] (6.965 ms) : 0, 6965
section iast
BytebuddyAgent [baseline] (799.891 ms) : 0, 799891
BytebuddyAgent [candidate] (803.273 ms) : 0, 803273
GlobalTracer [baseline] (289.241 ms) : 0, 289241
GlobalTracer [candidate] (290.412 ms) : 0, 290412
AppSec [baseline] (49.064 ms) : 0, 49064
AppSec [candidate] (52.356 ms) : 0, 52356
IAST [baseline] (26.091 ms) : 0, 26091
IAST [candidate] (20.583 ms) : 0, 20583
Remote Config [baseline] (579.726 µs) : 0, 580
Remote Config [candidate] (571.861 µs) : 0, 572
Telemetry [baseline] (6.553 ms) : 0, 6553
Telemetry [candidate] (7.42 ms) : 0, 7420
section profiling
BytebuddyAgent [baseline] (678.596 ms) : 0, 678596
BytebuddyAgent [candidate] (691.099 ms) : 0, 691099
GlobalTracer [baseline] (381.53 ms) : 0, 381530
GlobalTracer [candidate] (376.72 ms) : 0, 376720
AppSec [baseline] (49.785 ms) : 0, 49785
AppSec [candidate] (49.749 ms) : 0, 49749
Remote Config [baseline] (882.596 µs) : 0, 883
Remote Config [candidate] (908.29 µs) : 0, 908
Telemetry [baseline] (7.456 ms) : 0, 7456
Telemetry [candidate] (7.311 ms) : 0, 7311
ProfilingAgent [baseline] (95.802 ms) : 0, 95802
ProfilingAgent [candidate] (94.323 ms) : 0, 94323
Profiling [baseline] (95.826 ms) : 0, 95826
Profiling [candidate] (94.346 ms) : 0, 94346

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~7a6f782e39, baseline=1.32.0-SNAPSHOT~7160117940

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082376
Total [baseline] (8.562 s) : 0, 8561625
Agent [candidate] (1.088 s) : 0, 1088048
Total [candidate] (8.59 s) : 0, 8589917
section iast
Agent [baseline] (1.211 s) : 0, 1210649
Total [baseline] (9.119 s) : 0, 9119408
Agent [candidate] (1.215 s) : 0, 1214947
Total [candidate] (9.12 s) : 0, 9119707
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203993
Total [baseline] (9.044 s) : 0, 9043713
Agent [candidate] (1.209 s) : 0, 1209444
Total [candidate] (9.053 s) : 0, 9052777
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1198216
Total [baseline] (9.093 s) : 0, 9093027
Agent [candidate] (1.204 s) : 0, 1204350
Total [candidate] (9.064 s) : 0, 9063968

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	iast	1.211 s	128.273 ms (11.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.204 s	121.617 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.198 s	115.84 ms (10.7%)
Total	tracing	8.562 s	-
Total	iast	9.119 s	557.783 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.044 s	482.088 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.093 s	531.402 ms (6.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	iast	1.215 s	126.899 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.209 s	121.396 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.204 s	116.302 ms (10.7%)
Total	tracing	8.59 s	-
Total	iast	9.12 s	529.79 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.053 s	462.859 ms (5.4%)
Total	iast_TELEMETRY_OFF	9.064 s	474.05 ms (5.5%)

gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~7a6f782e39, baseline=1.32.0-SNAPSHOT~7160117940

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.973 ms) : 0, 691973
BytebuddyAgent [candidate] (702.888 ms) : 0, 702888
GlobalTracer [baseline] (297.866 ms) : 0, 297866
GlobalTracer [candidate] (292.932 ms) : 0, 292932
AppSec [baseline] (49.449 ms) : 0, 49449
AppSec [candidate] (49.062 ms) : 0, 49062
Remote Config [baseline] (1.082 ms) : 0, 1082
Remote Config [candidate] (1.09 ms) : 0, 1090
Telemetry [baseline] (7.387 ms) : 0, 7387
Telemetry [candidate] (7.463 ms) : 0, 7463
section iast
BytebuddyAgent [baseline] (803.253 ms) : 0, 803253
BytebuddyAgent [candidate] (807.814 ms) : 0, 807814
GlobalTracer [baseline] (290.612 ms) : 0, 290612
GlobalTracer [candidate] (291.573 ms) : 0, 291573
AppSec [baseline] (52.621 ms) : 0, 52621
AppSec [candidate] (51.315 ms) : 0, 51315
IAST [baseline] (22.407 ms) : 0, 22407
IAST [candidate] (22.209 ms) : 0, 22209
Remote Config [baseline] (587.847 µs) : 0, 588
Remote Config [candidate] (573.597 µs) : 0, 574
Telemetry [baseline] (6.6 ms) : 0, 6600
Telemetry [candidate] (6.753 ms) : 0, 6753
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.69 ms) : 0, 797690
BytebuddyAgent [candidate] (803.057 ms) : 0, 803057
GlobalTracer [baseline] (289.743 ms) : 0, 289743
GlobalTracer [candidate] (290.37 ms) : 0, 290370
AppSec [baseline] (49.018 ms) : 0, 49018
AppSec [candidate] (51.896 ms) : 0, 51896
IAST [baseline] (25.961 ms) : 0, 25961
IAST [candidate] (22.372 ms) : 0, 22372
Remote Config [baseline] (574.521 µs) : 0, 575
Remote Config [candidate] (579.457 µs) : 0, 579
Telemetry [baseline] (6.561 ms) : 0, 6561
Telemetry [candidate] (6.672 ms) : 0, 6672
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.737 ms) : 0, 792737
BytebuddyAgent [candidate] (797.096 ms) : 0, 797096
GlobalTracer [baseline] (289.79 ms) : 0, 289790
GlobalTracer [candidate] (291.261 ms) : 0, 291261
AppSec [baseline] (50.967 ms) : 0, 50967
AppSec [candidate] (49.618 ms) : 0, 49618
IAST [baseline] (22.494 ms) : 0, 22494
IAST [candidate] (24.157 ms) : 0, 24157
Remote Config [baseline] (588.971 µs) : 0, 589
Remote Config [candidate] (570.025 µs) : 0, 570
Telemetry [baseline] (7.307 ms) : 0, 7307
Telemetry [candidate] (7.31 ms) : 0, 7310

Load

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~7a6f782e39, baseline=1.32.0-SNAPSHOT~7160117940
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1388
.   : milestone, 1369,
appsec (1.811 ms) : 1787, 1834
.   : milestone, 1811,
iast (1.532 ms) : 1509, 1555
.   : milestone, 1532,
profiling (1.534 ms) : 1510, 1557
.   : milestone, 1534,
tracing (1.498 ms) : 1474, 1522
.   : milestone, 1498,
section candidate
no_agent (1.339 ms) : 1320, 1358
.   : milestone, 1339,
appsec (1.767 ms) : 1743, 1791
.   : milestone, 1767,
iast (1.537 ms) : 1514, 1560
.   : milestone, 1537,
profiling (1.519 ms) : 1495, 1543
.   : milestone, 1519,
tracing (1.485 ms) : 1461, 1509
.   : milestone, 1485,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.369 ms [1.35 ms, 1.388 ms]	-
appsec	1.811 ms [1.787 ms, 1.834 ms]	441.499 µs (32.2%)
iast	1.532 ms [1.509 ms, 1.555 ms]	163.126 µs (11.9%)
profiling	1.534 ms [1.51 ms, 1.557 ms]	164.642 µs (12.0%)
tracing	1.498 ms [1.474 ms, 1.522 ms]	129.063 µs (9.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.339 ms [1.32 ms, 1.358 ms]	-
appsec	1.767 ms [1.743 ms, 1.791 ms]	428.084 µs (32.0%)
iast	1.537 ms [1.514 ms, 1.56 ms]	198.368 µs (14.8%)
profiling	1.519 ms [1.495 ms, 1.543 ms]	180.205 µs (13.5%)
tracing	1.485 ms [1.461 ms, 1.509 ms]	145.921 µs (10.9%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~7a6f782e39, baseline=1.32.0-SNAPSHOT~7160117940
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.32 µs) : 351, 392
.   : milestone, 371,
iast (473.033 µs) : 453, 493
.   : milestone, 473,
iast_FULL (544.113 µs) : 524, 565
.   : milestone, 544,
iast_GLOBAL (501.529 µs) : 480, 523
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (477.018 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (456.134 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (468.315 µs) : 448, 489
.   : milestone, 468,
tracing (453.734 µs) : 433, 474
.   : milestone, 454,
section candidate
no_agent (371.103 µs) : 351, 391
.   : milestone, 371,
iast (480.336 µs) : 460, 501
.   : milestone, 480,
iast_FULL (549.717 µs) : 529, 570
.   : milestone, 550,
iast_GLOBAL (494.874 µs) : 474, 516
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (474.488 µs) : 454, 495
.   : milestone, 474,
iast_INACTIVE (452.285 µs) : 432, 472
.   : milestone, 452,
iast_TELEMETRY_OFF (468.028 µs) : 448, 488
.   : milestone, 468,
tracing (443.116 µs) : 422, 464
.   : milestone, 443,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.32 µs [351.137 µs, 391.502 µs]	-
iast	473.033 µs [452.634 µs, 493.431 µs]	101.713 µs (27.4%)
iast_FULL	544.113 µs [523.526 µs, 564.7 µs]	172.793 µs (46.5%)
iast_GLOBAL	501.529 µs [480.018 µs, 523.04 µs]	130.21 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED	477.018 µs [456.043 µs, 497.994 µs]	105.699 µs (28.5%)
iast_INACTIVE	456.134 µs [435.257 µs, 477.011 µs]	84.814 µs (22.8%)
iast_TELEMETRY_OFF	468.315 µs [447.654 µs, 488.975 µs]	96.995 µs (26.1%)
tracing	453.734 µs [433.062 µs, 474.406 µs]	82.414 µs (22.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.103 µs [351.131 µs, 391.074 µs]	-
iast	480.336 µs [459.647 µs, 501.025 µs]	109.233 µs (29.4%)
iast_FULL	549.717 µs [528.979 µs, 570.454 µs]	178.614 µs (48.1%)
iast_GLOBAL	494.874 µs [473.694 µs, 516.055 µs]	123.771 µs (33.4%)
iast_HARDCODED_SECRET_DISABLED	474.488 µs [454.235 µs, 494.741 µs]	103.385 µs (27.9%)
iast_INACTIVE	452.285 µs [432.118 µs, 472.453 µs]	81.182 µs (21.9%)
iast_TELEMETRY_OFF	468.028 µs [447.705 µs, 488.351 µs]	96.925 µs (26.1%)
tracing	443.116 µs [422.292 µs, 463.94 µs]	72.013 µs (19.4%)

unwrap ForkJoinTask.AdaptedInterruptibleCallable

898f4e4

richardstartin added the comp: profiling Profiling label Mar 21, 2024

richardstartin requested a review from a team as a code owner March 21, 2024 12:15

richardstartin requested review from am312 and dougqh March 21, 2024 12:15

mcculls approved these changes Mar 21, 2024

View reviewed changes

richardstartin merged commit 45ff2b9 into master Mar 21, 2024

richardstartin deleted the rgs/unwrap-fjt-aic branch March 21, 2024 13:04

github-actions Bot added this to the 1.32.0 milestone Mar 21, 2024

PerfectSlayer changed the title ~~unwrap ForkJoinTask$AdaptedInterruptibleCallable~~ Unwrap ForkJoinTask$AdaptedInterruptibleCallable Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unwrap ForkJoinTask$AdaptedInterruptibleCallable#6830

Unwrap ForkJoinTask$AdaptedInterruptibleCallable#6830
richardstartin merged 1 commit into
masterfrom
rgs/unwrap-fjt-aic

richardstartin commented Mar 21, 2024

Uh oh!

pr-commenter Bot commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

richardstartin commented Mar 21, 2024

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenter Bot commented Mar 21, 2024

Benchmarks

Startup

Parameters

Summary

Load

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants