Fix intake telemetry client URL for EU site by nikita-tkachenko-datadog · Pull Request #6683 · DataDog/dd-trace-java

nikita-tkachenko-datadog · 2024-02-15T09:46:27Z

What Does This Do

Fixes URL that is used by intake telemetry client when the tracer is configured to work with EU Datadog site.

Additional Notes

The list of possible site parameters can be found here.
The list of agentless telemetry URLs for different sites can be found here.

Jira ticket: CIVIS-2427

pr-commenter · 2024-02-15T10:32:58Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nikita-tkachenko/fix-intake-telemetry-url-for-eu
git_commit_date	1707943509	1707990161
git_commit_sha	`da71297`	`997a8a1`
release_version	1.31.0-SNAPSHOT~da71297afd	1.31.0-SNAPSHOT~997a8a142f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1707993131	1707993131
ci_job_id	434781834	434781834
ci_pipeline_id	28343455	28343455
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~997a8a142f, baseline=1.31.0-SNAPSHOT~da71297afd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062091
Total [baseline] (9.347 s) : 0, 9347063
Agent [candidate] (1.068 s) : 0, 1068360
Total [candidate] (9.373 s) : 0, 9372747
section appsec
Agent [baseline] (1.159 s) : 0, 1158892
Total [baseline] (9.454 s) : 0, 9453547
Agent [candidate] (1.162 s) : 0, 1162126
Total [candidate] (9.462 s) : 0, 9461805
section iast
Agent [baseline] (1.195 s) : 0, 1194768
Total [baseline] (9.716 s) : 0, 9715790
Agent [candidate] (1.197 s) : 0, 1196724
Total [candidate] (9.718 s) : 0, 9718396
section profiling
Agent [baseline] (1.286 s) : 0, 1286208
Total [baseline] (9.607 s) : 0, 9607434
Agent [candidate] (1.277 s) : 0, 1276623
Total [candidate] (9.557 s) : 0, 9556505

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	appsec	1.159 s	96.8 ms (9.1%)
Agent	iast	1.195 s	132.676 ms (12.5%)
Agent	profiling	1.286 s	224.117 ms (21.1%)
Total	tracing	9.347 s	-
Total	appsec	9.454 s	106.484 ms (1.1%)
Total	iast	9.716 s	368.727 ms (3.9%)
Total	profiling	9.607 s	260.371 ms (2.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.068 s	-
Agent	appsec	1.162 s	93.765 ms (8.8%)
Agent	iast	1.197 s	128.364 ms (12.0%)
Agent	profiling	1.277 s	208.263 ms (19.5%)
Total	tracing	9.373 s	-
Total	appsec	9.462 s	89.058 ms (1.0%)
Total	iast	9.718 s	345.649 ms (3.7%)
Total	profiling	9.557 s	183.758 ms (2.0%)

gantt
    title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~997a8a142f, baseline=1.31.0-SNAPSHOT~da71297afd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.723 ms) : 0, 668723
BytebuddyAgent [candidate] (672.81 ms) : 0, 672810
GlobalTracer [baseline] (299.02 ms) : 0, 299020
GlobalTracer [candidate] (300.441 ms) : 0, 300441
AppSec [baseline] (51.755 ms) : 0, 51755
AppSec [candidate] (52.257 ms) : 0, 52257
Remote Config [baseline] (711.856 µs) : 0, 712
Remote Config [candidate] (702.585 µs) : 0, 703
Telemetry [baseline] (7.602 ms) : 0, 7602
Telemetry [candidate] (7.62 ms) : 0, 7620
section appsec
BytebuddyAgent [baseline] (667.977 ms) : 0, 667977
BytebuddyAgent [candidate] (669.042 ms) : 0, 669042
GlobalTracer [baseline] (298.358 ms) : 0, 298358
GlobalTracer [candidate] (299.636 ms) : 0, 299636
AppSec [baseline] (150.82 ms) : 0, 150820
AppSec [candidate] (151.625 ms) : 0, 151625
Remote Config [baseline] (638.236 µs) : 0, 638
Remote Config [candidate] (634.298 µs) : 0, 634
Telemetry [baseline] (6.838 ms) : 0, 6838
Telemetry [candidate] (6.835 ms) : 0, 6835
section iast
BytebuddyAgent [baseline] (785.414 ms) : 0, 785414
BytebuddyAgent [candidate] (786.881 ms) : 0, 786881
GlobalTracer [baseline] (291.847 ms) : 0, 291847
GlobalTracer [candidate] (292.521 ms) : 0, 292521
AppSec [baseline] (54.97 ms) : 0, 54970
AppSec [candidate] (52.21 ms) : 0, 52210
Remote Config [baseline] (611.919 µs) : 0, 612
Remote Config [candidate] (620.649 µs) : 0, 621
Telemetry [baseline] (6.622 ms) : 0, 6622
Telemetry [candidate] (7.376 ms) : 0, 7376
IAST [baseline] (20.692 ms) : 0, 20692
IAST [candidate] (22.374 ms) : 0, 22374
section profiling
BytebuddyAgent [baseline] (670.762 ms) : 0, 670762
BytebuddyAgent [candidate] (665.869 ms) : 0, 665869
GlobalTracer [baseline] (383.86 ms) : 0, 383860
GlobalTracer [candidate] (381.986 ms) : 0, 381986
AppSec [baseline] (52.418 ms) : 0, 52418
AppSec [candidate] (51.88 ms) : 0, 51880
Remote Config [baseline] (662.582 µs) : 0, 663
Remote Config [candidate] (650.348 µs) : 0, 650
Telemetry [baseline] (12.2 ms) : 0, 12200
Telemetry [candidate] (11.491 ms) : 0, 11491
ProfilingAgent [baseline] (111.406 ms) : 0, 111406
ProfilingAgent [candidate] (110.257 ms) : 0, 110257
Profiling [baseline] (111.43 ms) : 0, 111430
Profiling [candidate] (110.281 ms) : 0, 110281

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-02-15T10:08:16	2024-02-15T10:27:09
git_branch	master	nikita-tkachenko/fix-intake-telemetry-url-for-eu
git_commit_date	1707943509	1707990161
git_commit_sha	`da71297`	`997a8a1`
release_version	1.31.0-SNAPSHOT~da71297afd	1.31.0-SNAPSHOT~997a8a142f
start_time	2024-02-15T10:08:03	2024-02-15T10:26:56

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1707993131	1707993131
ci_job_id	434781834	434781834
ci_pipeline_id	28343455	28343455
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~997a8a142f, baseline=1.31.0-SNAPSHOT~da71297afd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1366
.   : milestone, 1347,
appsec (1.773 ms) : 1748, 1799
.   : milestone, 1773,
iast (1.509 ms) : 1484, 1534
.   : milestone, 1509,
profiling (1.521 ms) : 1496, 1546
.   : milestone, 1521,
tracing (1.488 ms) : 1462, 1513
.   : milestone, 1488,
section candidate
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.764 ms) : 1739, 1789
.   : milestone, 1764,
iast (1.5 ms) : 1476, 1525
.   : milestone, 1500,
profiling (1.546 ms) : 1519, 1572
.   : milestone, 1546,
tracing (1.482 ms) : 1456, 1507
.   : milestone, 1482,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.347 ms [1.328 ms, 1.366 ms]	-
appsec	1.773 ms [1.748 ms, 1.799 ms]	426.442 µs (31.7%)
iast	1.509 ms [1.484 ms, 1.534 ms]	162.248 µs (12.0%)
profiling	1.521 ms [1.496 ms, 1.546 ms]	174.408 µs (12.9%)
tracing	1.488 ms [1.462 ms, 1.513 ms]	140.837 µs (10.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.337 ms, 1.375 ms]	-
appsec	1.764 ms [1.739 ms, 1.789 ms]	407.688 µs (30.1%)
iast	1.5 ms [1.476 ms, 1.525 ms]	144.171 µs (10.6%)
profiling	1.546 ms [1.519 ms, 1.572 ms]	189.406 µs (14.0%)
tracing	1.482 ms [1.456 ms, 1.507 ms]	125.37 µs (9.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~997a8a142f, baseline=1.31.0-SNAPSHOT~da71297afd
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.776 µs) : 341, 380
.   : milestone, 361,
iast (474.485 µs) : 453, 496
.   : milestone, 474,
iast_FULL (528.869 µs) : 508, 550
.   : milestone, 529,
iast_GLOBAL (486.507 µs) : 466, 507
.   : milestone, 487,
iast_HARDCODED_SECRET_DISABLED (472.05 µs) : 451, 493
.   : milestone, 472,
iast_INACTIVE (439.468 µs) : 419, 460
.   : milestone, 439,
iast_TELEMETRY_OFF (463.12 µs) : 442, 484
.   : milestone, 463,
tracing (436.03 µs) : 415, 457
.   : milestone, 436,
section candidate
no_agent (368.869 µs) : 348, 390
.   : milestone, 369,
iast (475.181 µs) : 453, 497
.   : milestone, 475,
iast_FULL (528.718 µs) : 508, 549
.   : milestone, 529,
iast_GLOBAL (486.204 µs) : 466, 507
.   : milestone, 486,
iast_HARDCODED_SECRET_DISABLED (470.608 µs) : 450, 491
.   : milestone, 471,
iast_INACTIVE (451.71 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (469.541 µs) : 448, 491
.   : milestone, 470,
tracing (438.215 µs) : 417, 459
.   : milestone, 438,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	360.776 µs [341.335 µs, 380.216 µs]	-
iast	474.485 µs [453.38 µs, 495.591 µs]	113.71 µs (31.5%)
iast_FULL	528.869 µs [508.144 µs, 549.594 µs]	168.093 µs (46.6%)
iast_GLOBAL	486.507 µs [465.897 µs, 507.117 µs]	125.732 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED	472.05 µs [451.378 µs, 492.721 µs]	111.274 µs (30.8%)
iast_INACTIVE	439.468 µs [418.984 µs, 459.951 µs]	78.692 µs (21.8%)
iast_TELEMETRY_OFF	463.12 µs [442.247 µs, 483.993 µs]	102.344 µs (28.4%)
tracing	436.03 µs [415.185 µs, 456.875 µs]	75.254 µs (20.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	368.869 µs [348.162 µs, 389.577 µs]	-
iast	475.181 µs [453.136 µs, 497.226 µs]	106.311 µs (28.8%)
iast_FULL	528.718 µs [508.179 µs, 549.258 µs]	159.849 µs (43.3%)
iast_GLOBAL	486.204 µs [465.686 µs, 506.723 µs]	117.335 µs (31.8%)
iast_HARDCODED_SECRET_DISABLED	470.608 µs [449.807 µs, 491.409 µs]	101.738 µs (27.6%)
iast_INACTIVE	451.71 µs [430.223 µs, 473.198 µs]	82.841 µs (22.5%)
iast_TELEMETRY_OFF	469.541 µs [448.328 µs, 490.755 µs]	100.672 µs (27.3%)
tracing	438.215 µs [417.355 µs, 459.076 µs]	69.346 µs (18.8%)

Fix intake telemetry client URL for EU site

997a8a1

nikita-tkachenko-datadog added type: bug Bug report and fix comp: telemetry Telemetry labels Feb 15, 2024

nikita-tkachenko-datadog marked this pull request as ready for review February 15, 2024 10:55

nikita-tkachenko-datadog requested a review from a team as a code owner February 15, 2024 10:55

nikita-tkachenko-datadog requested review from PerfectSlayer and ygree February 15, 2024 10:55

smola approved these changes Feb 15, 2024

View reviewed changes

nikita-tkachenko-datadog merged commit d57f54b into master Feb 15, 2024

nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-intake-telemetry-url-for-eu branch February 15, 2024 16:36

github-actions Bot added this to the 1.30.0 milestone Feb 15, 2024

jandro996 pushed a commit that referenced this pull request Feb 16, 2024

Fix intake telemetry client URL for EU site (#6683)

0073ebb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix intake telemetry client URL for EU site#6683

Fix intake telemetry client URL for EU site#6683
nikita-tkachenko-datadog merged 1 commit intomasterfrom
nikita-tkachenko/fix-intake-telemetry-url-for-eu

nikita-tkachenko-datadog commented Feb 15, 2024 •

edited

Loading

Uh oh!

pr-commenter Bot commented Feb 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nikita-tkachenko-datadog commented Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Additional Notes

Uh oh!

pr-commenter Bot commented Feb 15, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nikita-tkachenko-datadog commented Feb 15, 2024 •

edited

Loading