Implement a mechanism for adding ad-hoc listeners to OKHTTP requests#6660
Merged
nikita-tkachenko-datadog merged 3 commits intomasterfrom Feb 14, 2024
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 14 unstable metrics. |
jandro996
pushed a commit
that referenced
this pull request
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds a mechanism for registering ad-hoc event listeners for okhttp requests.
A listener can be registered when building a request:
Motivation
This is needed for CI Visibility telemetry. There are metrics like requests count, errors count, request size, etc for events/coverages intake, CI Visibility Git API and other endpoitns.
Additional Notes
EventListener.NONEis what all the requests are using by default: it is a listener that has an empty handler for every event.With the new mechanism this "empty" listener is replaced with a custom one for those requests that have the corresponding tag.
This PR only adds the means for registering custom listeners. Actual listeners will be added in a separate PR.
Jira ticket: CIVIS-2427