Skip to content

Fix remote config activation configuration name#6642

Merged
PerfectSlayer merged 1 commit intomasterfrom
bbujon/remote-config-config
Feb 9, 2024
Merged

Fix remote config activation configuration name#6642
PerfectSlayer merged 1 commit intomasterfrom
bbujon/remote-config-config

Conversation

@PerfectSlayer
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer commented Feb 8, 2024 •
edited
Loading

What Does This Do

Fix remote config activation configuration name according to the RFC from DD_REMOTE_CONFIG_ENABLED to DD_REMOTE_CONFIGURATION_ENABLED.

Motivation

This is a follow up fix for the issue #6640

Additional Notes

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added type: bug Bug report and fix comp: remote config Configuration at Runtime labels Feb 8, 2024
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner February 8, 2024 10:58
mcculls
mcculls reviewed Feb 8, 2024
View reviewed changes
Comment thread dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java Outdated
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 8, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/remote-config-config
git_commit_date 1707427027 1707466151
git_commit_sha f5119f8 f63a396
release_version 1.30.0-RC1~f5119f85c8 1.30.0-SNAPSHOT~f63a396e2b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707469246 1707469246
ci_job_id 430134648 430134648
ci_pipeline_id 28009752 28009752
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-09T08:36:53 2024-02-09T08:55:45
git_branch master bbujon/remote-config-config
git_commit_date 1707427027 1707466151
git_commit_sha f5119f8 f63a396
release_version 1.30.0-RC1~f5119f85c8 1.30.0-SNAPSHOT~f63a396e2b
start_time 2024-02-09T08:36:40 2024-02-09T08:55:32
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707469246 1707469246
ci_job_id 430134648 430134648
ci_pipeline_id 28009752 28009752
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.30.0-SNAPSHOT~f63a396e2b, baseline=1.30.0-RC1~f5119f85c8
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.186 µs) : 347, 387
.   : milestone, 367,
iast (470.223 µs) : 449, 491
.   : milestone, 470,
iast_FULL (537.474 µs) : 517, 558
.   : milestone, 537,
iast_GLOBAL (501.45 µs) : 480, 523
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (474.122 µs) : 453, 496
.   : milestone, 474,
iast_INACTIVE (440.467 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (472.089 µs) : 451, 494
.   : milestone, 472,
tracing (442.563 µs) : 422, 463
.   : milestone, 443,
section candidate
no_agent (364.405 µs) : 344, 385
.   : milestone, 364,
iast (472.912 µs) : 452, 494
.   : milestone, 473,
iast_FULL (531.772 µs) : 511, 552
.   : milestone, 532,
iast_GLOBAL (496.695 µs) : 476, 518
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (473.77 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (442.258 µs) : 421, 463
.   : milestone, 442,
iast_TELEMETRY_OFF (466.862 µs) : 446, 488
.   : milestone, 467,
tracing (439.381 µs) : 419, 460
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.186 µs [347.216 µs, 387.157 µs] -
iast 470.223 µs [449.293 µs, 491.153 µs] 103.037 µs (28.1%)
iast_FULL 537.474 µs [516.527 µs, 558.421 µs] 170.288 µs (46.4%)
iast_GLOBAL 501.45 µs [480.223 µs, 522.677 µs] 134.264 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 474.122 µs [452.649 µs, 495.594 µs] 106.936 µs (29.1%)
iast_INACTIVE 440.467 µs [419.951 µs, 460.983 µs] 73.281 µs (20.0%)
iast_TELEMETRY_OFF 472.089 µs [450.549 µs, 493.63 µs] 104.903 µs (28.6%)
tracing 442.563 µs [422.331 µs, 462.794 µs] 75.377 µs (20.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.405 µs [344.142 µs, 384.667 µs] -
iast 472.912 µs [452.045 µs, 493.779 µs] 108.508 µs (29.8%)
iast_FULL 531.772 µs [511.227 µs, 552.318 µs] 167.368 µs (45.9%)
iast_GLOBAL 496.695 µs [475.68 µs, 517.71 µs] 132.29 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED 473.77 µs [452.767 µs, 494.772 µs] 109.365 µs (30.0%)
iast_INACTIVE 442.258 µs [421.297 µs, 463.22 µs] 77.854 µs (21.4%)
iast_TELEMETRY_OFF 466.862 µs [445.992 µs, 487.733 µs] 102.458 µs (28.1%)
tracing 439.381 µs [418.55 µs, 460.212 µs] 74.976 µs (20.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.30.0-SNAPSHOT~f63a396e2b, baseline=1.30.0-RC1~f5119f85c8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1366
.   : milestone, 1347,
appsec (1.748 ms) : 1722, 1774
.   : milestone, 1748,
iast (1.528 ms) : 1504, 1552
.   : milestone, 1528,
profiling (1.507 ms) : 1482, 1532
.   : milestone, 1507,
tracing (1.487 ms) : 1462, 1513
.   : milestone, 1487,
section candidate
no_agent (1.334 ms) : 1316, 1353
.   : milestone, 1334,
appsec (1.773 ms) : 1748, 1799
.   : milestone, 1773,
iast (1.524 ms) : 1500, 1548
.   : milestone, 1524,
profiling (1.51 ms) : 1483, 1536
.   : milestone, 1510,
tracing (1.487 ms) : 1461, 1513
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.366 ms] -
appsec 1.748 ms [1.722 ms, 1.774 ms] 401.449 µs (29.8%)
iast 1.528 ms [1.504 ms, 1.552 ms] 181.318 µs (13.5%)
profiling 1.507 ms [1.482 ms, 1.532 ms] 160.444 µs (11.9%)
tracing 1.487 ms [1.462 ms, 1.513 ms] 140.724 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.316 ms, 1.353 ms] -
appsec 1.773 ms [1.748 ms, 1.799 ms] 439.043 µs (32.9%)
iast 1.524 ms [1.5 ms, 1.548 ms] 189.67 µs (14.2%)
profiling 1.51 ms [1.483 ms, 1.536 ms] 175.37 µs (13.1%)
tracing 1.487 ms [1.461 ms, 1.513 ms] 152.561 µs (11.4%)

@JeanFred JeanFred mentioned this pull request Feb 8, 2024
Closed
@PerfectSlayer PerfectSlayer force-pushed the bbujon/remote-config-config branch from bd756c1 to f63a396 Compare February 9, 2024 08:10
@PerfectSlayer PerfectSlayer merged commit 80420af into master Feb 9, 2024
@PerfectSlayer PerfectSlayer deleted the bbujon/remote-config-config branch February 9, 2024 11:41
@github-actions github-actions Bot added this to the 1.30.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola left review comments

@mcculls mcculls mcculls approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: remote config Configuration at Runtime type: bug Bug report and fix

Projects

None yet

Milestone

1.30.0

Development

Successfully merging this pull request may close these issues.

3 participants

@PerfectSlayer @smola @mcculls