Skip to content

Align apache http client 5 instrumentation names#6596

Merged
amarziali merged 1 commit intomasterfrom
andrea.marziali/httpclient5
Feb 6, 2024
Merged

Align apache http client 5 instrumentation names#6596
amarziali merged 1 commit intomasterfrom
andrea.marziali/httpclient5

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

@amarziali amarziali commented Feb 1, 2024

What Does This Do

Align the instrumentation names used for apache http client 5 with the one expected according to the documentation

image

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added the inst: others All other instrumentations label Feb 1, 2024
@amarziali amarziali requested a review from a team as a code owner February 1, 2024 09:55
@amarziali amarziali enabled auto-merge (squash) February 1, 2024 09:55
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 1, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/httpclient5
git_commit_date 1706733504 1706781215
git_commit_sha 54cb5c9 03a57f4
release_version 1.29.0-SNAPSHOT~54cb5c9369 1.29.0-SNAPSHOT~03a57f4778
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706784523 1706784523
ci_job_id 423515725 423515725
ci_pipeline_id 27524033 27524033
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.29.0-SNAPSHOT~03a57f4778, baseline=1.29.0-SNAPSHOT~54cb5c9369

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055762
Total [baseline] (9.331 s) : 0, 9331268
Agent [candidate] (1.063 s) : 0, 1063264
Total [candidate] (9.332 s) : 0, 9331621
section appsec
Agent [baseline] (1.158 s) : 0, 1158465
Total [baseline] (9.563 s) : 0, 9562898
Agent [candidate] (1.157 s) : 0, 1157167
Total [candidate] (9.513 s) : 0, 9512704
section iast
Agent [baseline] (1.181 s) : 0, 1181255
Total [baseline] (9.658 s) : 0, 9658193
Agent [candidate] (1.184 s) : 0, 1184302
Total [candidate] (9.706 s) : 0, 9705892
section profiling
Agent [baseline] (1.277 s) : 0, 1277311
Total [baseline] (9.633 s) : 0, 9632617
Agent [candidate] (1.276 s) : 0, 1276116
Total [candidate] (9.591 s) : 0, 9591402
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.158 s 102.704 ms (9.7%)
Agent iast 1.181 s 125.493 ms (11.9%)
Agent profiling 1.277 s 221.55 ms (21.0%)
Total tracing 9.331 s -
Total appsec 9.563 s 231.63 ms (2.5%)
Total iast 9.658 s 326.925 ms (3.5%)
Total profiling 9.633 s 301.349 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.157 s 93.903 ms (8.8%)
Agent iast 1.184 s 121.038 ms (11.4%)
Agent profiling 1.276 s 212.852 ms (20.0%)
Total tracing 9.332 s -
Total appsec 9.513 s 181.082 ms (1.9%)
Total iast 9.706 s 374.271 ms (4.0%)
Total profiling 9.591 s 259.781 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.29.0-SNAPSHOT~03a57f4778, baseline=1.29.0-SNAPSHOT~54cb5c9369

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.316 ms) : 0, 665316
BytebuddyAgent [candidate] (671.152 ms) : 0, 671152
GlobalTracer [baseline] (296.121 ms) : 0, 296121
GlobalTracer [candidate] (297.269 ms) : 0, 297269
AppSec [baseline] (51.926 ms) : 0, 51926
AppSec [candidate] (52.187 ms) : 0, 52187
Remote Config [baseline] (684.556 µs) : 0, 685
Remote Config [candidate] (685.381 µs) : 0, 685
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.541 ms) : 0, 7541
section appsec
BytebuddyAgent [baseline] (668.309 ms) : 0, 668309
BytebuddyAgent [candidate] (667.239 ms) : 0, 667239
GlobalTracer [baseline] (297.934 ms) : 0, 297934
GlobalTracer [candidate] (297.456 ms) : 0, 297456
AppSec [baseline] (150.519 ms) : 0, 150519
AppSec [candidate] (150.864 ms) : 0, 150864
Remote Config [baseline] (654.157 µs) : 0, 654
Remote Config [candidate] (647.387 µs) : 0, 647
Telemetry [baseline] (6.747 ms) : 0, 6747
Telemetry [candidate] (6.73 ms) : 0, 6730
section iast
BytebuddyAgent [baseline] (777.358 ms) : 0, 777358
BytebuddyAgent [candidate] (778.463 ms) : 0, 778463
GlobalTracer [baseline] (287.934 ms) : 0, 287934
GlobalTracer [candidate] (288.597 ms) : 0, 288597
AppSec [baseline] (55.152 ms) : 0, 55152
AppSec [candidate] (54.073 ms) : 0, 54073
Remote Config [baseline] (616.279 µs) : 0, 616
Remote Config [candidate] (614.074 µs) : 0, 614
Telemetry [baseline] (7.275 ms) : 0, 7275
Telemetry [candidate] (7.192 ms) : 0, 7192
IAST [baseline] (18.618 ms) : 0, 18618
IAST [candidate] (21.049 ms) : 0, 21049
section profiling
ProfilingAgent [baseline] (115.181 ms) : 0, 115181
ProfilingAgent [candidate] (114.38 ms) : 0, 114380
BytebuddyAgent [baseline] (666.13 ms) : 0, 666130
BytebuddyAgent [candidate] (665.891 ms) : 0, 665891
GlobalTracer [baseline] (381.163 ms) : 0, 381163
GlobalTracer [candidate] (380.981 ms) : 0, 380981
AppSec [baseline] (52.35 ms) : 0, 52350
AppSec [candidate] (52.247 ms) : 0, 52247
Remote Config [baseline] (661.285 µs) : 0, 661
Remote Config [candidate] (658.266 µs) : 0, 658
Telemetry [baseline] (7.494 ms) : 0, 7494
Telemetry [candidate] (7.487 ms) : 0, 7487
Profiling [baseline] (115.205 ms) : 0, 115205
Profiling [candidate] (114.404 ms) : 0, 114404
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-01T10:24:43 2024-02-01T10:43:41
git_branch master andrea.marziali/httpclient5
git_commit_date 1706733504 1706781215
git_commit_sha 54cb5c9 03a57f4
release_version 1.29.0-SNAPSHOT~54cb5c9369 1.29.0-SNAPSHOT~03a57f4778
start_time 2024-02-01T10:24:30 2024-02-01T10:43:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706784523 1706784523
ci_job_id 423515725 423515725
ci_pipeline_id 27524033 27524033
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~03a57f4778, baseline=1.29.0-SNAPSHOT~54cb5c9369
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.367 ms) : 1348, 1386
.   : milestone, 1367,
appsec (1.747 ms) : 1721, 1773
.   : milestone, 1747,
iast (1.519 ms) : 1494, 1543
.   : milestone, 1519,
profiling (1.538 ms) : 1513, 1562
.   : milestone, 1538,
tracing (1.531 ms) : 1506, 1556
.   : milestone, 1531,
section candidate
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.769 ms) : 1744, 1793
.   : milestone, 1769,
iast (1.522 ms) : 1498, 1547
.   : milestone, 1522,
profiling (1.543 ms) : 1516, 1569
.   : milestone, 1543,
tracing (1.499 ms) : 1475, 1524
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.367 ms [1.348 ms, 1.386 ms] -
appsec 1.747 ms [1.721 ms, 1.773 ms] 379.329 µs (27.7%)
iast 1.519 ms [1.494 ms, 1.543 ms] 151.324 µs (11.1%)
profiling 1.538 ms [1.513 ms, 1.562 ms] 170.446 µs (12.5%)
tracing 1.531 ms [1.506 ms, 1.556 ms] 163.424 µs (12.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.769 ms [1.744 ms, 1.793 ms] 418.663 µs (31.0%)
iast 1.522 ms [1.498 ms, 1.547 ms] 172.248 µs (12.8%)
profiling 1.543 ms [1.516 ms, 1.569 ms] 192.666 µs (14.3%)
tracing 1.499 ms [1.475 ms, 1.524 ms] 149.489 µs (11.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~03a57f4778, baseline=1.29.0-SNAPSHOT~54cb5c9369
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.656 µs) : 349, 390
.   : milestone, 370,
iast (475.693 µs) : 455, 496
.   : milestone, 476,
iast_FULL (542.469 µs) : 522, 563
.   : milestone, 542,
iast_GLOBAL (503.268 µs) : 482, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (478.874 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (446.647 µs) : 425, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (484.553 µs) : 464, 505
.   : milestone, 485,
tracing (439.708 µs) : 419, 460
.   : milestone, 440,
section candidate
no_agent (370.758 µs) : 350, 391
.   : milestone, 371,
iast (476.682 µs) : 456, 498
.   : milestone, 477,
iast_FULL (538.339 µs) : 518, 559
.   : milestone, 538,
iast_GLOBAL (503.854 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (473.307 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (443.245 µs) : 423, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (466.129 µs) : 445, 487
.   : milestone, 466,
tracing (445.854 µs) : 424, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.656 µs [349.279 µs, 390.033 µs] -
iast 475.693 µs [455.201 µs, 496.186 µs] 106.038 µs (28.7%)
iast_FULL 542.469 µs [521.993 µs, 562.946 µs] 172.814 µs (46.7%)
iast_GLOBAL 503.268 µs [482.003 µs, 524.532 µs] 133.612 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 478.874 µs [457.626 µs, 500.121 µs] 109.218 µs (29.5%)
iast_INACTIVE 446.647 µs [425.403 µs, 467.89 µs] 76.991 µs (20.8%)
iast_TELEMETRY_OFF 484.553 µs [463.901 µs, 505.204 µs] 114.897 µs (31.1%)
tracing 439.708 µs [419.154 µs, 460.263 µs] 70.053 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.758 µs [350.263 µs, 391.254 µs] -
iast 476.682 µs [455.696 µs, 497.668 µs] 105.924 µs (28.6%)
iast_FULL 538.339 µs [517.66 µs, 559.017 µs] 167.58 µs (45.2%)
iast_GLOBAL 503.854 µs [482.965 µs, 524.743 µs] 133.096 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 473.307 µs [452.348 µs, 494.266 µs] 102.549 µs (27.7%)
iast_INACTIVE 443.245 µs [422.532 µs, 463.957 µs] 72.486 µs (19.6%)
iast_TELEMETRY_OFF 466.129 µs [445.352 µs, 486.907 µs] 95.371 µs (25.7%)
tracing 445.854 µs [424.448 µs, 467.261 µs] 75.096 µs (20.3%)

nayeem-kamal
nayeem-kamal reviewed Feb 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nayeem-kamal nayeem-kamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PerfectSlayer
PerfectSlayer approved these changes Feb 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayeem-kamal Despite your comment, it looks like you commented only.

@amarziali amarziali merged commit 04b123e into master Feb 6, 2024
@amarziali amarziali deleted the andrea.marziali/httpclient5 branch February 6, 2024 09:45
@github-actions github-actions Bot added this to the 1.30.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

+1 more reviewer

@nayeem-kamal nayeem-kamal nayeem-kamal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inst: others All other instrumentations

Projects

None yet

Milestone

1.30.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @PerfectSlayer @nayeem-kamal