Skip to content

Fix reporting httpResourceRemoveTrailingSlash config in the New instance: Config log#6571

Merged
bm1549 merged 1 commit into
masterfrom
wantsui/fix-config-httpResourceRemoveTrailingSlash
Mar 6, 2024
Merged

Fix reporting httpResourceRemoveTrailingSlash config in the New instance: Config log#6571
bm1549 merged 1 commit into
masterfrom
wantsui/fix-config-httpResourceRemoveTrailingSlash

Conversation

@wantsui

@wantsui wantsui commented Jan 26, 2024 •
edited by am312
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Adds an equal sign after httpResourceRemoveTrailingSlashfalse in the New instance: Config log

Expected values: httpResourceRemoveTrailingSlash=false or httpResourceRemoveTrailingSlash=true

Motivation

At the moment, the log looks like this:

httpClientTagQueryString=false, httpClientSplitByDomain=false, httpResourceRemoveTrailingSlashfalse

Compared to other configs, httpResourceRemoveTrailingSlash is missing an = sign.

This means the value would be

  • httpResourceRemoveTrailingSlashfalse or
  • httpResourceRemoveTrailingSlashtrue

This PR would make it

  • httpResourceRemoveTrailingSlash=false or
  • httpResourceRemoveTrailingSlash=true

To make it easier to parse when reviewing, this PR adds a missing equal sign

@am312 am312 added the tag: no release notes Changes to exclude from release notes label Jan 26, 2024
@pr-commenter

pr-commenter Bot commented Jan 26, 2024

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master wantsui/fix-config-httpResourceRemoveTrailingSlash
git_commit_date 1706287891 1706298485
git_commit_sha 7f977d8 957a4db
release_version 1.29.0-SNAPSHOT~7f977d8e06 1.29.0-SNAPSHOT~957a4db47d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706301421 1706301421
ci_job_id 419874686 419874686
ci_pipeline_id 27271031 27271031
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 8 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-01-26T20:13:02 2024-01-26T20:32:00
git_branch master wantsui/fix-config-httpResourceRemoveTrailingSlash
git_commit_date 1706287891 1706298485
git_commit_sha 7f977d8 957a4db
release_version 1.29.0-SNAPSHOT~7f977d8e06 1.29.0-SNAPSHOT~957a4db47d
start_time 2024-01-26T20:12:49 2024-01-26T20:31:47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706301421 1706301421
ci_job_id 419874686 419874686
ci_pipeline_id 27271031 27271031
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~957a4db47d, baseline=1.29.0-SNAPSHOT~7f977d8e06
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.338 µs) : 341, 381
.   : milestone, 361,
iast (476.305 µs) : 455, 498
.   : milestone, 476,
iast_FULL (534.745 µs) : 514, 555
.   : milestone, 535,
iast_GLOBAL (514.767 µs) : 493, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (469.736 µs) : 449, 490
.   : milestone, 470,
iast_INACTIVE (444.734 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (464.26 µs) : 444, 485
.   : milestone, 464,
tracing (431.807 µs) : 411, 452
.   : milestone, 432,
section candidate
no_agent (368.72 µs) : 348, 389
.   : milestone, 369,
iast (470.657 µs) : 450, 491
.   : milestone, 471,
iast_FULL (536.227 µs) : 516, 557
.   : milestone, 536,
iast_GLOBAL (494.421 µs) : 474, 515
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (472.904 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (440.353 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (465.516 µs) : 445, 487
.   : milestone, 466,
tracing (437.379 µs) : 416, 459
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.338 µs [341.396 µs, 381.28 µs] -
iast 476.305 µs [454.851 µs, 497.758 µs] 114.967 µs (31.8%)
iast_FULL 534.745 µs [514.274 µs, 555.215 µs] 173.407 µs (48.0%)
iast_GLOBAL 514.767 µs [492.724 µs, 536.81 µs] 153.429 µs (42.5%)
iast_HARDCODED_SECRET_DISABLED 469.736 µs [449.367 µs, 490.105 µs] 108.398 µs (30.0%)
iast_INACTIVE 444.734 µs [423.57 µs, 465.898 µs] 83.396 µs (23.1%)
iast_TELEMETRY_OFF 464.26 µs [443.602 µs, 484.917 µs] 102.922 µs (28.5%)
tracing 431.807 µs [411.296 µs, 452.318 µs] 70.469 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.72 µs [348.43 µs, 389.011 µs] -
iast 470.657 µs [450.228 µs, 491.085 µs] 101.936 µs (27.6%)
iast_FULL 536.227 µs [515.535 µs, 556.919 µs] 167.507 µs (45.4%)
iast_GLOBAL 494.421 µs [474.014 µs, 514.827 µs] 125.7 µs (34.1%)
iast_HARDCODED_SECRET_DISABLED 472.904 µs [451.791 µs, 494.018 µs] 104.184 µs (28.3%)
iast_INACTIVE 440.353 µs [419.828 µs, 460.878 µs] 71.633 µs (19.4%)
iast_TELEMETRY_OFF 465.516 µs [444.52 µs, 486.512 µs] 96.796 µs (26.3%)
tracing 437.379 µs [416.193 µs, 458.565 µs] 68.659 µs (18.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~957a4db47d, baseline=1.29.0-SNAPSHOT~7f977d8e06
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.763 ms) : 1737, 1788
.   : milestone, 1763,
iast (1.505 ms) : 1480, 1529
.   : milestone, 1505,
profiling (1.529 ms) : 1504, 1554
.   : milestone, 1529,
tracing (1.515 ms) : 1489, 1540
.   : milestone, 1515,
section candidate
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.761 ms) : 1736, 1786
.   : milestone, 1761,
iast (1.523 ms) : 1499, 1548
.   : milestone, 1523,
profiling (1.504 ms) : 1479, 1529
.   : milestone, 1504,
tracing (1.487 ms) : 1461, 1512
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.367 ms] -
appsec 1.763 ms [1.737 ms, 1.788 ms] 414.809 µs (30.8%)
iast 1.505 ms [1.48 ms, 1.529 ms] 156.958 µs (11.6%)
profiling 1.529 ms [1.504 ms, 1.554 ms] 181.439 µs (13.5%)
tracing 1.515 ms [1.489 ms, 1.54 ms] 166.954 µs (12.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.374 ms] -
appsec 1.761 ms [1.736 ms, 1.786 ms] 405.815 µs (29.9%)
iast 1.523 ms [1.499 ms, 1.548 ms] 168.204 µs (12.4%)
profiling 1.504 ms [1.479 ms, 1.529 ms] 148.756 µs (11.0%)
tracing 1.487 ms [1.461 ms, 1.512 ms] 131.762 µs (9.7%)

@wantsui
wantsui marked this pull request as ready for review January 26, 2024 20:47
@wantsui
wantsui requested a review from a team as a code owner January 26, 2024 20:47
@wantsui
wantsui requested review from am312 and dougqh January 26, 2024 20:47
@bm1549
bm1549 merged commit d20df91 into master Mar 6, 2024
@bm1549
bm1549 deleted the wantsui/fix-config-httpResourceRemoveTrailingSlash branch March 6, 2024 16:23
@github-actions github-actions Bot added this to the 1.32.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougqh dougqh dougqh approved these changes
+1 more reviewer
@am312 am312 am312 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.32.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wantsui @dougqh @am312 @bm1549