Skip to content

exclude spring-kafka runnables from spring scheduling wrapping#6388

Merged
amarziali merged 1 commit into
masterfrom
andrea.marziali/spring-schedulign
Dec 18, 2023
Merged

exclude spring-kafka runnables from spring scheduling wrapping#6388
amarziali merged 1 commit into
masterfrom
andrea.marziali/spring-schedulign

Conversation

@amarziali

@amarziali amarziali commented Dec 18, 2023 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Do not wrap org.springframework.kafka.listener.KafkaMessageListenerContainer$ListenerConsumer$... (inner class and lambdas) when advice spring scheduling schdule(atFixedRate)

Motivation

Additional Notes

Jira ticket: APMS-10946

@amarziali
amarziali requested a review from a team as a code owner December 18, 2023 16:10
@amarziali
amarziali enabled auto-merge (squash) December 18, 2023 16:21
@bantonsson bantonsson added inst: spring Spring instrumentation inst: kafka Kafka instrumentation tag: performance Performance related changes and removed inst: kafka Kafka instrumentation tag: performance Performance related changes labels Dec 18, 2023
@pr-commenter

pr-commenter Bot commented Dec 18, 2023

Copy link
Copy Markdown

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/spring-schedulign
git_commit_date 1702911170 1702915707
git_commit_sha 73d8647 ae694ad
See matching parameters
Baseline Candidate
ci_job_date 1702916871 1702916871
ci_job_id 392098745 392098745
ci_pipeline_id 25257448 25257448
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario Δ mean throughput
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce worse
[-6399.659op/s; -2019.809op/s] or [-4.804%; -1.516%]
See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce unsure
[+1749.284op/s; +87907.873op/s] or [+0.098%; +4.926%]
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter

pr-commenter Bot commented Dec 18, 2023

Copy link
Copy Markdown

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/spring-schedulign
git_commit_date 1702911170 1702915707
git_commit_sha 73d8647 ae694ad
See matching parameters
Baseline Candidate
ci_job_date 1702916906 1702916906
ci_job_id 392098746 392098746
ci_pipeline_id 25257448 25257448
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@amarziali
amarziali merged commit df9ada3 into master Dec 18, 2023
@amarziali
amarziali deleted the andrea.marziali/spring-schedulign branch December 18, 2023 17:49
@github-actions github-actions Bot added this to the 1.26.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bantonsson bantonsson bantonsson approved these changes
@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

inst: spring Spring instrumentation

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@amarziali @bantonsson