Skip to content

Accept any config id from Remote Config#6384

Merged
jpbempel merged 1 commit into
masterfrom
jpbempel/config-prefixes
Dec 18, 2023
Merged

Accept any config id from Remote Config#6384
jpbempel merged 1 commit into
masterfrom
jpbempel/config-prefixes

Conversation

@jpbempel

@jpbempel jpbempel commented Dec 18, 2023 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Member

What Does This Do

For supporting compatibility with new config ids, don't throw exception of an actual non supporting id format.

Motivation

Compatibility

Additional Notes

Jira ticket: DEBUG-1793

@jpbempel
Accept any config id from Remote Config
9dfea60 
For supporting compatibility with new config ids, don't throw
exception of an actual non supporting id format.
@jpbempel
jpbempel requested a review from a team as a code owner December 18, 2023 10:00
@jpbempel
jpbempel requested review from cimi and removed request for a team December 18, 2023 10:00
@pr-commenter

pr-commenter Bot commented Dec 18, 2023

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/config-prefixes
git_commit_date 1702892336 1702893577
git_commit_sha cbaf43b 9dfea60
release_version 1.26.0-SNAPSHOT~cbaf43b0c9 1.26.0-SNAPSHOT~9dfea609c4
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702896206 1702896206
ci_job_id 391638581 391638581
ci_pipeline_id 25229286 25229286
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 5 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.26.0-SNAPSHOT~9dfea609c4, baseline=1.26.0-SNAPSHOT~cbaf43b0c9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044795
Total [baseline] (8.716 s) : 0, 8715810
Agent [candidate] (1.049 s) : 0, 1049205
Total [candidate] (8.727 s) : 0, 8727447
section iast
Agent [baseline] (1.162 s) : 0, 1161730
Total [baseline] (9.247 s) : 0, 9246942
Agent [candidate] (1.166 s) : 0, 1165930
Total [candidate] (9.266 s) : 0, 9266495
section iast_TELEMETRY_OFF
Agent [baseline] (1.158 s) : 0, 1157959
Total [baseline] (9.236 s) : 0, 9236257
Agent [candidate] (1.159 s) : 0, 1159127
Total [candidate] (9.257 s) : 0, 9257255
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.162 s 116.935 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.158 s 113.164 ms (10.8%)
Total tracing 8.716 s -
Total iast 9.247 s 531.132 ms (6.1%)
Total iast_TELEMETRY_OFF 9.236 s 520.447 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.166 s 116.725 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.159 s 109.921 ms (10.5%)
Total tracing 8.727 s -
Total iast 9.266 s 539.049 ms (6.2%)
Total iast_TELEMETRY_OFF 9.257 s 529.808 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.26.0-SNAPSHOT~9dfea609c4, baseline=1.26.0-SNAPSHOT~cbaf43b0c9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (645.68 ms) : 0, 645680
BytebuddyAgent [candidate] (647.714 ms) : 0, 647714
GlobalTracer [baseline] (305.931 ms) : 0, 305931
GlobalTracer [candidate] (308.089 ms) : 0, 308089
AppSec [baseline] (51.047 ms) : 0, 51047
AppSec [candidate] (51.262 ms) : 0, 51262
Remote Config [baseline] (674.898 µs) : 0, 675
Remote Config [candidate] (672.574 µs) : 0, 673
Telemetry [baseline] (7.212 ms) : 0, 7212
Telemetry [candidate] (7.243 ms) : 0, 7243
section iast
BytebuddyAgent [baseline] (766.329 ms) : 0, 766329
BytebuddyAgent [candidate] (768.564 ms) : 0, 768564
GlobalTracer [baseline] (284.548 ms) : 0, 284548
GlobalTracer [candidate] (285.345 ms) : 0, 285345
AppSec [baseline] (49.071 ms) : 0, 49071
AppSec [candidate] (49.161 ms) : 0, 49161
IAST [baseline] (18.816 ms) : 0, 18816
IAST [candidate] (20.579 ms) : 0, 20579
Remote Config [baseline] (610.466 µs) : 0, 610
Remote Config [candidate] (600.227 µs) : 0, 600
Telemetry [baseline] (8.092 ms) : 0, 8092
Telemetry [candidate] (7.31 ms) : 0, 7310
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (760.566 ms) : 0, 760566
BytebuddyAgent [candidate] (761.139 ms) : 0, 761139
GlobalTracer [baseline] (285.754 ms) : 0, 285754
GlobalTracer [candidate] (285.981 ms) : 0, 285981
AppSec [baseline] (49.395 ms) : 0, 49395
AppSec [candidate] (49.666 ms) : 0, 49666
IAST [baseline] (20.738 ms) : 0, 20738
IAST [candidate] (20.861 ms) : 0, 20861
Remote Config [baseline] (618.617 µs) : 0, 619
Remote Config [candidate] (627.255 µs) : 0, 627
Telemetry [baseline] (6.605 ms) : 0, 6605
Telemetry [candidate] (6.564 ms) : 0, 6564
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.26.0-SNAPSHOT~9dfea609c4, baseline=1.26.0-SNAPSHOT~cbaf43b0c9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045313
Total [baseline] (9.349 s) : 0, 9349016
Agent [candidate] (1.058 s) : 0, 1057561
Total [candidate] (9.365 s) : 0, 9365227
section appsec
Agent [baseline] (1.146 s) : 0, 1145783
Total [baseline] (9.508 s) : 0, 9507989
Agent [candidate] (1.158 s) : 0, 1157875
Total [candidate] (9.526 s) : 0, 9526160
section iast
Agent [baseline] (1.173 s) : 0, 1172514
Total [baseline] (9.61 s) : 0, 9609738
Agent [candidate] (1.167 s) : 0, 1166717
Total [candidate] (9.565 s) : 0, 9565042
section profiling
Agent [baseline] (1.255 s) : 0, 1255379
Total [baseline] (9.77 s) : 0, 9769524
Agent [candidate] (1.253 s) : 0, 1252881
Total [candidate] (9.692 s) : 0, 9692191
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.146 s 100.47 ms (9.6%)
Agent iast 1.173 s 127.201 ms (12.2%)
Agent profiling 1.255 s 210.066 ms (20.1%)
Total tracing 9.349 s -
Total appsec 9.508 s 158.973 ms (1.7%)
Total iast 9.61 s 260.722 ms (2.8%)
Total profiling 9.77 s 420.508 ms (4.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.158 s 100.315 ms (9.5%)
Agent iast 1.167 s 109.157 ms (10.3%)
Agent profiling 1.253 s 195.32 ms (18.5%)
Total tracing 9.365 s -
Total appsec 9.526 s 160.933 ms (1.7%)
Total iast 9.565 s 199.815 ms (2.1%)
Total profiling 9.692 s 326.964 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.26.0-SNAPSHOT~9dfea609c4, baseline=1.26.0-SNAPSHOT~cbaf43b0c9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (646.607 ms) : 0, 646607
BytebuddyAgent [candidate] (653.578 ms) : 0, 653578
GlobalTracer [baseline] (305.663 ms) : 0, 305663
GlobalTracer [candidate] (309.979 ms) : 0, 309979
AppSec [baseline] (50.99 ms) : 0, 50990
AppSec [candidate] (51.493 ms) : 0, 51493
Remote Config [baseline] (666.245 µs) : 0, 666
Remote Config [candidate] (681.799 µs) : 0, 682
Telemetry [baseline] (7.154 ms) : 0, 7154
Telemetry [candidate] (7.286 ms) : 0, 7286
section appsec
BytebuddyAgent [baseline] (647.952 ms) : 0, 647952
BytebuddyAgent [candidate] (654.179 ms) : 0, 654179
GlobalTracer [baseline] (306.772 ms) : 0, 306772
GlobalTracer [candidate] (311.088 ms) : 0, 311088
AppSec [baseline] (149.335 ms) : 0, 149335
AppSec [candidate] (150.506 ms) : 0, 150506
Remote Config [baseline] (648.467 µs) : 0, 648
Remote Config [candidate] (658.498 µs) : 0, 658
Telemetry [baseline] (6.828 ms) : 0, 6828
Telemetry [candidate] (6.939 ms) : 0, 6939
section iast
BytebuddyAgent [baseline] (773.21 ms) : 0, 773210
BytebuddyAgent [candidate] (769.088 ms) : 0, 769088
GlobalTracer [baseline] (286.365 ms) : 0, 286365
GlobalTracer [candidate] (285.957 ms) : 0, 285957
AppSec [baseline] (49.269 ms) : 0, 49269
AppSec [candidate] (49.064 ms) : 0, 49064
Remote Config [baseline] (610.472 µs) : 0, 610
Remote Config [candidate] (619.468 µs) : 0, 619
Telemetry [baseline] (7.188 ms) : 0, 7188
Telemetry [candidate] (7.201 ms) : 0, 7201
IAST [baseline] (21.317 ms) : 0, 21317
IAST [candidate] (20.374 ms) : 0, 20374
section profiling
ProfilingAgent [baseline] (95.795 ms) : 0, 95795
ProfilingAgent [candidate] (94.015 ms) : 0, 94015
BytebuddyAgent [baseline] (663.099 ms) : 0, 663099
BytebuddyAgent [candidate] (664.584 ms) : 0, 664584
GlobalTracer [baseline] (381.647 ms) : 0, 381647
GlobalTracer [candidate] (379.725 ms) : 0, 379725
AppSec [baseline] (51.857 ms) : 0, 51857
AppSec [candidate] (51.633 ms) : 0, 51633
Remote Config [baseline] (676.114 µs) : 0, 676
Remote Config [candidate] (675.057 µs) : 0, 675
Telemetry [baseline] (7.582 ms) : 0, 7582
Telemetry [candidate] (7.522 ms) : 0, 7522
Profiling [baseline] (95.82 ms) : 0, 95820
Profiling [candidate] (94.04 ms) : 0, 94040
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2023-12-18T10:22:39 2023-12-18T10:39:13
git_branch master jpbempel/config-prefixes
git_commit_date 1702892336 1702893577
git_commit_sha cbaf43b 9dfea60
release_version 1.26.0-SNAPSHOT~cbaf43b0c9 1.26.0-SNAPSHOT~9dfea609c4
start_time 2023-12-18T10:22:26 2023-12-18T10:39:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702896206 1702896206
ci_job_id 391638581 391638581
ci_pipeline_id 25229286 25229286
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 14 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~9dfea609c4, baseline=1.26.0-SNAPSHOT~cbaf43b0c9
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.216 µs) : 342, 382
.   : milestone, 362,
iast (474.117 µs) : 453, 495
.   : milestone, 474,
iast_FULL (539.022 µs) : 519, 559
.   : milestone, 539,
iast_INACTIVE (441.073 µs) : 420, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (466.329 µs) : 446, 487
.   : milestone, 466,
tracing (442.533 µs) : 422, 463
.   : milestone, 443,
section candidate
no_agent (372.908 µs) : 352, 393
.   : milestone, 373,
iast (476.51 µs) : 456, 497
.   : milestone, 477,
iast_FULL (533.326 µs) : 513, 554
.   : milestone, 533,
iast_INACTIVE (448.428 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (475.428 µs) : 454, 496
.   : milestone, 475,
tracing (444.247 µs) : 424, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.216 µs [342.223 µs, 382.21 µs] -
iast 474.117 µs [453.43 µs, 494.804 µs] 111.901 µs (30.9%)
iast_FULL 539.022 µs [518.692 µs, 559.352 µs] 176.805 µs (48.8%)
iast_INACTIVE 441.073 µs [420.461 µs, 461.685 µs] 78.856 µs (21.8%)
iast_TELEMETRY_OFF 466.329 µs [445.928 µs, 486.73 µs] 104.112 µs (28.7%)
tracing 442.533 µs [421.665 µs, 463.401 µs] 80.316 µs (22.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.908 µs [352.465 µs, 393.351 µs] -
iast 476.51 µs [455.919 µs, 497.1 µs] 103.601 µs (27.8%)
iast_FULL 533.326 µs [512.918 µs, 553.735 µs] 160.418 µs (43.0%)
iast_INACTIVE 448.428 µs [427.368 µs, 469.487 µs] 75.52 µs (20.3%)
iast_TELEMETRY_OFF 475.428 µs [454.441 µs, 496.414 µs] 102.52 µs (27.5%)
tracing 444.247 µs [423.566 µs, 464.927 µs] 71.338 µs (19.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~9dfea609c4, baseline=1.26.0-SNAPSHOT~cbaf43b0c9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.352 ms) : 1333, 1371
.   : milestone, 1352,
appsec (1.739 ms) : 1714, 1765
.   : milestone, 1739,
iast (1.512 ms) : 1487, 1536
.   : milestone, 1512,
profiling (1.51 ms) : 1484, 1535
.   : milestone, 1510,
tracing (1.497 ms) : 1473, 1522
.   : milestone, 1497,
section candidate
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.759 ms) : 1734, 1784
.   : milestone, 1759,
iast (1.516 ms) : 1492, 1540
.   : milestone, 1516,
profiling (1.53 ms) : 1505, 1556
.   : milestone, 1530,
tracing (1.477 ms) : 1452, 1502
.   : milestone, 1477,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.371 ms] -
appsec 1.739 ms [1.714 ms, 1.765 ms] 387.408 µs (28.7%)
iast 1.512 ms [1.487 ms, 1.536 ms] 159.454 µs (11.8%)
profiling 1.51 ms [1.484 ms, 1.535 ms] 157.633 µs (11.7%)
tracing 1.497 ms [1.473 ms, 1.522 ms] 145.046 µs (10.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.759 ms [1.734 ms, 1.784 ms] 408.517 µs (30.3%)
iast 1.516 ms [1.492 ms, 1.54 ms] 165.705 µs (12.3%)
profiling 1.53 ms [1.505 ms, 1.556 ms] 180.205 µs (13.3%)
tracing 1.477 ms [1.452 ms, 1.502 ms] 126.765 µs (9.4%)

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Dec 18, 2023
ojung
ojung approved these changes Dec 18, 2023
View reviewed changes

@ojung ojung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpbempel
jpbempel merged commit 04b0430 into master Dec 18, 2023
@jpbempel
jpbempel deleted the jpbempel/config-prefixes branch December 18, 2023 16:12
@github-actions github-actions Bot added this to the 1.26.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ojung ojung ojung approved these changes
@cimi cimi Awaiting requested review from cimi cimi is a code owner automatically assigned from DataDog/debugger-java

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jpbempel @ojung