Skip to content

cleanup crashtracking#6363

Merged
richardstartin merged 1 commit into
masterfrom
rgs/crash-tracking-cleanup
Dec 15, 2023
Merged

cleanup crashtracking#6363
richardstartin merged 1 commit into
masterfrom
rgs/crash-tracking-cleanup

Conversation

@richardstartin

@richardstartin richardstartin commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

What Does This Do

  • set the language tag to "jvm"
  • add redacted stack traces to telemetry requests

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@richardstartin
richardstartin requested a review from a team as a code owner December 14, 2023 12:44
@pr-commenter

pr-commenter Bot commented Dec 14, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/crash-tracking-cleanup
git_commit_date 1702604902 1702633725
git_commit_sha 014b4e9 ed847ca
release_version 1.26.0-SNAPSHOT~014b4e998e 1.26.0-SNAPSHOT~ed847ca9b4
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702636377 1702636377
ci_job_id 390590042 390590042
ci_pipeline_id 25144170 25144170
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 6 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.26.0-SNAPSHOT~ed847ca9b4, baseline=1.26.0-SNAPSHOT~014b4e998e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045814
Total [baseline] (8.732 s) : 0, 8732323
Agent [candidate] (1.057 s) : 0, 1057475
Total [candidate] (8.728 s) : 0, 8728334
section iast
Agent [baseline] (1.166 s) : 0, 1166134
Total [baseline] (9.287 s) : 0, 9287425
Agent [candidate] (1.174 s) : 0, 1174312
Total [candidate] (9.307 s) : 0, 9306878
section iast_TELEMETRY_OFF
Agent [baseline] (1.161 s) : 0, 1161000
Total [baseline] (9.247 s) : 0, 9247285
Agent [candidate] (1.159 s) : 0, 1159312
Total [candidate] (9.279 s) : 0, 9279203
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.166 s 120.32 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.161 s 115.186 ms (11.0%)
Total tracing 8.732 s -
Total iast 9.287 s 555.102 ms (6.4%)
Total iast_TELEMETRY_OFF 9.247 s 514.962 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.174 s 116.837 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.159 s 101.837 ms (9.6%)
Total tracing 8.728 s -
Total iast 9.307 s 578.544 ms (6.6%)
Total iast_TELEMETRY_OFF 9.279 s 550.869 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.26.0-SNAPSHOT~ed847ca9b4, baseline=1.26.0-SNAPSHOT~014b4e998e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (646.681 ms) : 0, 646681
BytebuddyAgent [candidate] (653.646 ms) : 0, 653646
GlobalTracer [baseline] (305.983 ms) : 0, 305983
GlobalTracer [candidate] (309.587 ms) : 0, 309587
AppSec [baseline] (51.167 ms) : 0, 51167
AppSec [candidate] (51.772 ms) : 0, 51772
Remote Config [baseline] (671.203 µs) : 0, 671
Remote Config [candidate] (692.254 µs) : 0, 692
Telemetry [baseline] (7.207 ms) : 0, 7207
Telemetry [candidate] (7.28 ms) : 0, 7280
section iast
BytebuddyAgent [baseline] (769.77 ms) : 0, 769770
BytebuddyAgent [candidate] (774.966 ms) : 0, 774966
GlobalTracer [baseline] (285.186 ms) : 0, 285186
GlobalTracer [candidate] (287.862 ms) : 0, 287862
AppSec [baseline] (49.101 ms) : 0, 49101
AppSec [candidate] (49.801 ms) : 0, 49801
IAST [baseline] (20.534 ms) : 0, 20534
IAST [candidate] (19.805 ms) : 0, 19805
Remote Config [baseline] (607.072 µs) : 0, 607
Remote Config [candidate] (621.775 µs) : 0, 622
Telemetry [baseline] (6.542 ms) : 0, 6542
Telemetry [candidate] (6.589 ms) : 0, 6589
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (762.83 ms) : 0, 762830
BytebuddyAgent [candidate] (761.814 ms) : 0, 761814
GlobalTracer [baseline] (286.247 ms) : 0, 286247
GlobalTracer [candidate] (286.12 ms) : 0, 286120
AppSec [baseline] (49.304 ms) : 0, 49304
AppSec [candidate] (48.995 ms) : 0, 48995
IAST [baseline] (20.216 ms) : 0, 20216
IAST [candidate] (19.423 ms) : 0, 19423
Remote Config [baseline] (617.843 µs) : 0, 618
Remote Config [candidate] (614.045 µs) : 0, 614
Telemetry [baseline] (7.378 ms) : 0, 7378
Telemetry [candidate] (8.081 ms) : 0, 8081
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.26.0-SNAPSHOT~ed847ca9b4, baseline=1.26.0-SNAPSHOT~014b4e998e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052110
Total [baseline] (9.412 s) : 0, 9412142
Agent [candidate] (1.048 s) : 0, 1048434
Total [candidate] (9.317 s) : 0, 9317125
section appsec
Agent [baseline] (1.147 s) : 0, 1147364
Total [baseline] (9.46 s) : 0, 9460048
Agent [candidate] (1.147 s) : 0, 1147253
Total [candidate] (9.46 s) : 0, 9459660
section iast
Agent [baseline] (1.176 s) : 0, 1176071
Total [baseline] (9.578 s) : 0, 9578234
Agent [candidate] (1.168 s) : 0, 1167726
Total [candidate] (9.585 s) : 0, 9584849
section profiling
Agent [baseline] (1.253 s) : 0, 1252673
Total [baseline] (9.617 s) : 0, 9616807
Agent [candidate] (1.241 s) : 0, 1241020
Total [candidate] (9.61 s) : 0, 9609811
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.147 s 95.253 ms (9.1%)
Agent iast 1.176 s 123.961 ms (11.8%)
Agent profiling 1.253 s 200.563 ms (19.1%)
Total tracing 9.412 s -
Total appsec 9.46 s 47.906 ms (0.5%)
Total iast 9.578 s 166.091 ms (1.8%)
Total profiling 9.617 s 204.664 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.147 s 98.82 ms (9.4%)
Agent iast 1.168 s 119.292 ms (11.4%)
Agent profiling 1.241 s 192.586 ms (18.4%)
Total tracing 9.317 s -
Total appsec 9.46 s 142.536 ms (1.5%)
Total iast 9.585 s 267.724 ms (2.9%)
Total profiling 9.61 s 292.687 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.26.0-SNAPSHOT~ed847ca9b4, baseline=1.26.0-SNAPSHOT~014b4e998e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (648.997 ms) : 0, 648997
BytebuddyAgent [candidate] (646.942 ms) : 0, 646942
GlobalTracer [baseline] (309.309 ms) : 0, 309309
GlobalTracer [candidate] (307.727 ms) : 0, 307727
AppSec [baseline] (51.604 ms) : 0, 51604
AppSec [candidate] (51.59 ms) : 0, 51590
Remote Config [baseline] (674.818 µs) : 0, 675
Remote Config [candidate] (673.725 µs) : 0, 674
Telemetry [baseline] (7.237 ms) : 0, 7237
Telemetry [candidate] (7.193 ms) : 0, 7193
section appsec
BytebuddyAgent [baseline] (648.318 ms) : 0, 648318
BytebuddyAgent [candidate] (647.592 ms) : 0, 647592
GlobalTracer [baseline] (307.053 ms) : 0, 307053
GlobalTracer [candidate] (308.061 ms) : 0, 308061
AppSec [baseline] (149.59 ms) : 0, 149590
AppSec [candidate] (149.738 ms) : 0, 149738
Remote Config [baseline] (648.242 µs) : 0, 648
Remote Config [candidate] (646.202 µs) : 0, 646
Telemetry [baseline] (7.459 ms) : 0, 7459
Telemetry [candidate] (6.862 ms) : 0, 6862
section iast
BytebuddyAgent [baseline] (775.38 ms) : 0, 775380
BytebuddyAgent [candidate] (769.117 ms) : 0, 769117
GlobalTracer [baseline] (287.629 ms) : 0, 287629
GlobalTracer [candidate] (286.411 ms) : 0, 286411
AppSec [baseline] (49.816 ms) : 0, 49816
AppSec [candidate] (49.493 ms) : 0, 49493
Remote Config [baseline] (618.903 µs) : 0, 619
Remote Config [candidate] (634.393 µs) : 0, 634
Telemetry [baseline] (6.568 ms) : 0, 6568
Telemetry [candidate] (7.295 ms) : 0, 7295
IAST [baseline] (21.379 ms) : 0, 21379
IAST [candidate] (20.485 ms) : 0, 20485
section profiling
BytebuddyAgent [baseline] (662.913 ms) : 0, 662913
BytebuddyAgent [candidate] (658.122 ms) : 0, 658122
GlobalTracer [baseline] (379.775 ms) : 0, 379775
GlobalTracer [candidate] (376.278 ms) : 0, 376278
AppSec [baseline] (51.934 ms) : 0, 51934
AppSec [candidate] (50.549 ms) : 0, 50549
Remote Config [baseline] (670.161 µs) : 0, 670
Remote Config [candidate] (664.225 µs) : 0, 664
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.45 ms) : 0, 7450
ProfilingAgent [baseline] (95.155 ms) : 0, 95155
ProfilingAgent [candidate] (93.725 ms) : 0, 93725
Profiling [baseline] (95.181 ms) : 0, 95181
Profiling [candidate] (93.751 ms) : 0, 93751
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2023-12-15T10:12:05 2023-12-15T10:28:42
git_branch master rgs/crash-tracking-cleanup
git_commit_date 1702604902 1702633725
git_commit_sha 014b4e9 ed847ca
release_version 1.26.0-SNAPSHOT~014b4e998e 1.26.0-SNAPSHOT~ed847ca9b4
start_time 2023-12-15T10:11:52 2023-12-15T10:28:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702636377 1702636377
ci_job_id 390590042 390590042
ci_pipeline_id 25144170 25144170
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 13 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-87.512µs; -32.253µs] or [-5.515%; -2.032%]		 unstable
[-420.608op/s; +648.528op/s] or [-14.196%; +21.888%]		 1.527ms 3076.923op/s 1.587ms 2962.963op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~ed847ca9b4, baseline=1.26.0-SNAPSHOT~014b4e998e
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.127 µs) : 345, 388
.   : milestone, 366,
iast (476.904 µs) : 456, 498
.   : milestone, 477,
iast_FULL (537.902 µs) : 518, 558
.   : milestone, 538,
iast_INACTIVE (446.583 µs) : 426, 467
.   : milestone, 447,
iast_TELEMETRY_OFF (457.174 µs) : 437, 478
.   : milestone, 457,
tracing (449.44 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (364.993 µs) : 345, 385
.   : milestone, 365,
iast (473.099 µs) : 452, 494
.   : milestone, 473,
iast_FULL (533.724 µs) : 513, 554
.   : milestone, 534,
iast_INACTIVE (443.361 µs) : 422, 465
.   : milestone, 443,
iast_TELEMETRY_OFF (462.799 µs) : 442, 483
.   : milestone, 463,
tracing (449.66 µs) : 429, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.127 µs [344.648 µs, 387.607 µs] -
iast 476.904 µs [455.974 µs, 497.835 µs] 110.777 µs (30.3%)
iast_FULL 537.902 µs [517.505 µs, 558.299 µs] 171.774 µs (46.9%)
iast_INACTIVE 446.583 µs [425.677 µs, 467.489 µs] 80.455 µs (22.0%)
iast_TELEMETRY_OFF 457.174 µs [436.767 µs, 477.582 µs] 91.047 µs (24.9%)
tracing 449.44 µs [428.41 µs, 470.471 µs] 83.313 µs (22.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.993 µs [345.346 µs, 384.641 µs] -
iast 473.099 µs [452.488 µs, 493.709 µs] 108.105 µs (29.6%)
iast_FULL 533.724 µs [513.23 µs, 554.219 µs] 168.731 µs (46.2%)
iast_INACTIVE 443.361 µs [422.037 µs, 464.685 µs] 78.368 µs (21.5%)
iast_TELEMETRY_OFF 462.799 µs [442.215 µs, 483.383 µs] 97.806 µs (26.8%)
tracing 449.66 µs [429.5 µs, 469.82 µs] 84.667 µs (23.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~ed847ca9b4, baseline=1.26.0-SNAPSHOT~014b4e998e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1372
.   : milestone, 1353,
appsec (1.771 ms) : 1746, 1797
.   : milestone, 1771,
iast (1.53 ms) : 1506, 1554
.   : milestone, 1530,
profiling (1.587 ms) : 1561, 1613
.   : milestone, 1587,
tracing (1.495 ms) : 1469, 1520
.   : milestone, 1495,
section candidate
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.782 ms) : 1757, 1808
.   : milestone, 1782,
iast (1.5 ms) : 1476, 1525
.   : milestone, 1500,
profiling (1.527 ms) : 1502, 1552
.   : milestone, 1527,
tracing (1.51 ms) : 1485, 1535
.   : milestone, 1510,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.334 ms, 1.372 ms] -
appsec 1.771 ms [1.746 ms, 1.797 ms] 418.348 µs (30.9%)
iast 1.53 ms [1.506 ms, 1.554 ms] 177.318 µs (13.1%)
profiling 1.587 ms [1.561 ms, 1.613 ms] 233.895 µs (17.3%)
tracing 1.495 ms [1.469 ms, 1.52 ms] 141.738 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.782 ms [1.757 ms, 1.808 ms] 432.159 µs (32.0%)
iast 1.5 ms [1.476 ms, 1.525 ms] 149.829 µs (11.1%)
profiling 1.527 ms [1.502 ms, 1.552 ms] 176.783 µs (13.1%)
tracing 1.51 ms [1.485 ms, 1.535 ms] 159.916 µs (11.8%)

@richardstartin
richardstartin force-pushed the rgs/crash-tracking-cleanup branch from 8328533 to ed847ca Compare December 15, 2023 09:49
@richardstartin richardstartin added the comp: crash tracking Crash Tracking label Dec 15, 2023
@richardstartin
richardstartin merged commit 31eeb71 into master Dec 15, 2023
@richardstartin
richardstartin deleted the rgs/crash-tracking-cleanup branch December 15, 2023 10:51
@github-actions github-actions Bot added this to the 1.26.0 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbachorik jbachorik jbachorik approved these changes

Assignees

No one assigned

Labels

comp: crash tracking Crash Tracking

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@richardstartin @jbachorik