Skip to content

Update ASM event rules to v1.10.0#6349

Merged
smola merged 2 commits into
masterfrom
smola/APPSEC-16714-asm-rules-1.10.0
Dec 13, 2023
Merged

Update ASM event rules to v1.10.0#6349
smola merged 2 commits into
masterfrom
smola/APPSEC-16714-asm-rules-1.10.0

Conversation

@smola

@smola smola commented Dec 12, 2023 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Member

@smola smola added the comp: asm waf Application Security Management (WAF) label Dec 12, 2023
@smola
smola requested a review from a team as a code owner December 12, 2023 13:37
@smola smola mentioned this pull request Dec 12, 2023
Merged
@pr-commenter

pr-commenter Bot commented Dec 12, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/APPSEC-16714-asm-rules-1.10.0
git_commit_date 1702409587 1702458496
git_commit_sha 1878db6 375c9ff
release_version 1.26.0-SNAPSHOT~1878db6329 1.26.0-SNAPSHOT~375c9ff2da
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702461368 1702461368
ci_job_id 388561009 388561009
ci_pipeline_id 25000537 25000537
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 8 performance regressions! Performance is the same for 39 metrics, 7 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:AppSec worse
[+2.873ms; +3.853ms] or [+6.216%; +8.336%]		 49.586ms 46.223ms
scenario:startup:insecure-bank:iast:Remote Config worse
[+17.722µs; +42.038µs] or [+2.968%; +7.040%]		 627.005µs 597.125µs
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Remote Config worse
[+12.354µs; +59.455µs] or [+2.123%; +10.215%]		 617.918µs 582.014µs
scenario:startup:insecure-bank:tracing:AppSec worse
[+2.291ms; +3.353ms] or [+4.717%; +6.904%]		 51.392ms 48.569ms
scenario:startup:petclinic:appsec:AppSec worse
[+12.481ms; +13.830ms] or [+9.123%; +10.109%]		 149.963ms 136.807ms
scenario:startup:petclinic:iast:AppSec worse
[+2.223ms; +3.267ms] or [+4.758%; +6.993%]		 49.457ms 46.712ms
scenario:startup:petclinic:profiling:AppSec worse
[+1.369ms; +2.657ms] or [+2.800%; +5.431%]		 50.923ms 48.910ms
scenario:startup:petclinic:tracing:AppSec worse
[+3.047ms; +4.388ms] or [+6.310%; +9.088%]		 52.000ms 48.283ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.26.0-SNAPSHOT~375c9ff2da, baseline=1.26.0-SNAPSHOT~1878db6329

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042111
Total [baseline] (8.728 s) : 0, 8728406
Agent [candidate] (1.046 s) : 0, 1046495
Total [candidate] (8.764 s) : 0, 8764193
section iast
Agent [baseline] (1.156 s) : 0, 1155936
Total [baseline] (9.238 s) : 0, 9238392
Agent [candidate] (1.163 s) : 0, 1163299
Total [candidate] (9.242 s) : 0, 9241708
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163091
Total [baseline] (9.253 s) : 0, 9253168
Agent [candidate] (1.164 s) : 0, 1164310
Total [candidate] (9.292 s) : 0, 9292455
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.156 s 113.825 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.163 s 120.98 ms (11.6%)
Total tracing 8.728 s -
Total iast 9.238 s 509.986 ms (5.8%)
Total iast_TELEMETRY_OFF 9.253 s 524.762 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.163 s 116.804 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.164 s 117.815 ms (11.3%)
Total tracing 8.764 s -
Total iast 9.242 s 477.516 ms (5.4%)
Total iast_TELEMETRY_OFF 9.292 s 528.262 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.26.0-SNAPSHOT~375c9ff2da, baseline=1.26.0-SNAPSHOT~1878db6329

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (644.92 ms) : 0, 644920
BytebuddyAgent [candidate] (645.068 ms) : 0, 645068
GlobalTracer [baseline] (306.585 ms) : 0, 306585
GlobalTracer [candidate] (307.895 ms) : 0, 307895
AppSec [baseline] (48.569 ms) : 0, 48569
AppSec [candidate] (51.392 ms) : 0, 51392
Remote Config [baseline] (671.181 µs) : 0, 671
Remote Config [candidate] (673.667 µs) : 0, 674
Telemetry [baseline] (7.163 ms) : 0, 7163
Telemetry [candidate] (7.227 ms) : 0, 7227
section iast
BytebuddyAgent [baseline] (763.679 ms) : 0, 763679
BytebuddyAgent [candidate] (765.414 ms) : 0, 765414
GlobalTracer [baseline] (284.508 ms) : 0, 284508
GlobalTracer [candidate] (285.088 ms) : 0, 285088
AppSec [baseline] (46.223 ms) : 0, 46223
AppSec [candidate] (49.586 ms) : 0, 49586
IAST [baseline] (19.38 ms) : 0, 19380
IAST [candidate] (21.058 ms) : 0, 21058
Remote Config [baseline] (597.125 µs) : 0, 597
Remote Config [candidate] (627.005 µs) : 0, 627
Telemetry [baseline] (7.3 ms) : 0, 7300
Telemetry [candidate] (7.257 ms) : 0, 7257
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (766.005 ms) : 0, 766005
BytebuddyAgent [candidate] (764.252 ms) : 0, 764252
GlobalTracer [baseline] (287.299 ms) : 0, 287299
GlobalTracer [candidate] (287.66 ms) : 0, 287660
AppSec [baseline] (48.995 ms) : 0, 48995
AppSec [candidate] (49.36 ms) : 0, 49360
IAST [baseline] (15.578 ms) : 0, 15578
IAST [candidate] (21.226 ms) : 0, 21226
Remote Config [baseline] (582.014 µs) : 0, 582
Remote Config [candidate] (617.918 µs) : 0, 618
Telemetry [baseline] (10.083 ms) : 0, 10083
Telemetry [candidate] (6.709 ms) : 0, 6709
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.26.0-SNAPSHOT~375c9ff2da, baseline=1.26.0-SNAPSHOT~1878db6329

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041930
Total [baseline] (9.357 s) : 0, 9357051
Agent [candidate] (1.051 s) : 0, 1051271
Total [candidate] (9.323 s) : 0, 9323287
section appsec
Agent [baseline] (1.133 s) : 0, 1132592
Total [baseline] (9.431 s) : 0, 9431422
Agent [candidate] (1.147 s) : 0, 1146639
Total [candidate] (9.455 s) : 0, 9454969
section iast
Agent [baseline] (1.16 s) : 0, 1159759
Total [baseline] (9.561 s) : 0, 9561368
Agent [candidate] (1.171 s) : 0, 1170555
Total [candidate] (9.57 s) : 0, 9569628
section profiling
Agent [baseline] (1.232 s) : 0, 1232001
Total [baseline] (9.592 s) : 0, 9592139
Agent [candidate] (1.232 s) : 0, 1231634
Total [candidate] (9.585 s) : 0, 9584831
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.133 s 90.662 ms (8.7%)
Agent iast 1.16 s 117.829 ms (11.3%)
Agent profiling 1.232 s 190.071 ms (18.2%)
Total tracing 9.357 s -
Total appsec 9.431 s 74.371 ms (0.8%)
Total iast 9.561 s 204.317 ms (2.2%)
Total profiling 9.592 s 235.088 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.147 s 95.369 ms (9.1%)
Agent iast 1.171 s 119.284 ms (11.3%)
Agent profiling 1.232 s 180.363 ms (17.2%)
Total tracing 9.323 s -
Total appsec 9.455 s 131.682 ms (1.4%)
Total iast 9.57 s 246.341 ms (2.6%)
Total profiling 9.585 s 261.544 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.26.0-SNAPSHOT~375c9ff2da, baseline=1.26.0-SNAPSHOT~1878db6329

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (645.214 ms) : 0, 645214
BytebuddyAgent [candidate] (648.512 ms) : 0, 648512
GlobalTracer [baseline] (306.451 ms) : 0, 306451
GlobalTracer [candidate] (308.406 ms) : 0, 308406
AppSec [baseline] (48.283 ms) : 0, 48283
AppSec [candidate] (52.0 ms) : 0, 52000
Remote Config [baseline] (667.943 µs) : 0, 668
Remote Config [candidate] (683.069 µs) : 0, 683
Telemetry [baseline] (7.136 ms) : 0, 7136
Telemetry [candidate] (7.304 ms) : 0, 7304
section appsec
BytebuddyAgent [baseline] (646.739 ms) : 0, 646739
BytebuddyAgent [candidate] (646.887 ms) : 0, 646887
GlobalTracer [baseline] (307.386 ms) : 0, 307386
GlobalTracer [candidate] (307.99 ms) : 0, 307990
AppSec [baseline] (136.807 ms) : 0, 136807
AppSec [candidate] (149.963 ms) : 0, 149963
Remote Config [baseline] (639.629 µs) : 0, 640
Remote Config [candidate] (639.541 µs) : 0, 640
Telemetry [baseline] (6.832 ms) : 0, 6832
Telemetry [candidate] (6.865 ms) : 0, 6865
section iast
BytebuddyAgent [baseline] (766.105 ms) : 0, 766105
BytebuddyAgent [candidate] (771.75 ms) : 0, 771750
GlobalTracer [baseline] (284.6 ms) : 0, 284600
GlobalTracer [candidate] (287.482 ms) : 0, 287482
AppSec [baseline] (46.712 ms) : 0, 46712
AppSec [candidate] (49.457 ms) : 0, 49457
Remote Config [baseline] (610.9 µs) : 0, 611
Remote Config [candidate] (609.253 µs) : 0, 609
Telemetry [baseline] (7.341 ms) : 0, 7341
Telemetry [candidate] (7.297 ms) : 0, 7297
IAST [baseline] (20.126 ms) : 0, 20126
IAST [candidate] (19.478 ms) : 0, 19478
section profiling
BytebuddyAgent [baseline] (655.343 ms) : 0, 655343
BytebuddyAgent [candidate] (655.365 ms) : 0, 655365
GlobalTracer [baseline] (376.9 ms) : 0, 376900
GlobalTracer [candidate] (376.196 ms) : 0, 376196
AppSec [baseline] (48.91 ms) : 0, 48910
AppSec [candidate] (50.923 ms) : 0, 50923
Remote Config [baseline] (664.674 µs) : 0, 665
Remote Config [candidate] (688.554 µs) : 0, 689
Telemetry [baseline] (7.374 ms) : 0, 7374
Telemetry [candidate] (7.409 ms) : 0, 7409
ProfilingAgent [baseline] (88.69 ms) : 0, 88690
ProfilingAgent [candidate] (86.971 ms) : 0, 86971
Profiling [baseline] (88.716 ms) : 0, 88716
Profiling [candidate] (86.996 ms) : 0, 86996
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2023-12-13T09:35:22 2023-12-13T09:51:56
git_branch master smola/APPSEC-16714-asm-rules-1.10.0
git_commit_date 1702409587 1702458496
git_commit_sha 1878db6 375c9ff
release_version 1.26.0-SNAPSHOT~1878db6329 1.26.0-SNAPSHOT~375c9ff2da
start_time 2023-12-13T09:35:09 2023-12-13T09:51:43
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702461368 1702461368
ci_job_id 388561009 388561009
ci_pipeline_id 25000537 25000537
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 13 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~375c9ff2da, baseline=1.26.0-SNAPSHOT~1878db6329
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.45 µs) : 343, 382
.   : milestone, 362,
iast (483.647 µs) : 463, 504
.   : milestone, 484,
iast_FULL (535.154 µs) : 514, 556
.   : milestone, 535,
iast_INACTIVE (444.834 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (466.205 µs) : 446, 487
.   : milestone, 466,
tracing (451.459 µs) : 430, 473
.   : milestone, 451,
section candidate
no_agent (372.38 µs) : 351, 394
.   : milestone, 372,
iast (470.279 µs) : 450, 491
.   : milestone, 470,
iast_FULL (536.285 µs) : 516, 557
.   : milestone, 536,
iast_INACTIVE (438.272 µs) : 418, 459
.   : milestone, 438,
iast_TELEMETRY_OFF (469.003 µs) : 448, 490
.   : milestone, 469,
tracing (437.524 µs) : 417, 458
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.45 µs [342.709 µs, 382.192 µs] -
iast 483.647 µs [463.094 µs, 504.2 µs] 121.197 µs (33.4%)
iast_FULL 535.154 µs [514.415 µs, 555.893 µs] 172.704 µs (47.6%)
iast_INACTIVE 444.834 µs [423.804 µs, 465.865 µs] 82.384 µs (22.7%)
iast_TELEMETRY_OFF 466.205 µs [445.672 µs, 486.738 µs] 103.755 µs (28.6%)
tracing 451.459 µs [430.155 µs, 472.762 µs] 89.008 µs (24.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.38 µs [350.615 µs, 394.144 µs] -
iast 470.279 µs [449.877 µs, 490.681 µs] 97.9 µs (26.3%)
iast_FULL 536.285 µs [515.775 µs, 556.795 µs] 163.906 µs (44.0%)
iast_INACTIVE 438.272 µs [418.018 µs, 458.526 µs] 65.893 µs (17.7%)
iast_TELEMETRY_OFF 469.003 µs [447.764 µs, 490.243 µs] 96.624 µs (25.9%)
tracing 437.524 µs [416.803 µs, 458.246 µs] 65.145 µs (17.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~375c9ff2da, baseline=1.26.0-SNAPSHOT~1878db6329
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1342, 1380
.   : milestone, 1361,
appsec (1.747 ms) : 1722, 1772
.   : milestone, 1747,
iast (1.524 ms) : 1500, 1548
.   : milestone, 1524,
profiling (1.52 ms) : 1495, 1546
.   : milestone, 1520,
tracing (1.511 ms) : 1486, 1536
.   : milestone, 1511,
section candidate
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.757 ms) : 1732, 1783
.   : milestone, 1757,
iast (1.519 ms) : 1494, 1544
.   : milestone, 1519,
profiling (1.512 ms) : 1486, 1539
.   : milestone, 1512,
tracing (1.465 ms) : 1440, 1489
.   : milestone, 1465,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.342 ms, 1.38 ms] -
appsec 1.747 ms [1.722 ms, 1.772 ms] 385.79 µs (28.3%)
iast 1.524 ms [1.5 ms, 1.548 ms] 162.53 µs (11.9%)
profiling 1.52 ms [1.495 ms, 1.546 ms] 159.098 µs (11.7%)
tracing 1.511 ms [1.486 ms, 1.536 ms] 149.969 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.337 ms, 1.375 ms] -
appsec 1.757 ms [1.732 ms, 1.783 ms] 401.389 µs (29.6%)
iast 1.519 ms [1.494 ms, 1.544 ms] 162.917 µs (12.0%)
profiling 1.512 ms [1.486 ms, 1.539 ms] 156.441 µs (11.5%)
tracing 1.465 ms [1.44 ms, 1.489 ms] 108.855 µs (8.0%)

@smola
smola enabled auto-merge (squash) December 12, 2023 16:06
@smola
smola disabled auto-merge December 12, 2023 16:06
@smola
smola merged commit 66e927b into master Dec 13, 2023
@smola
smola deleted the smola/APPSEC-16714-asm-rules-1.10.0 branch December 13, 2023 14:51
@github-actions github-actions Bot added this to the 1.26.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes
@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF)

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@smola @manuel-alvarez-alvarez