Remove warning about unknown graphql.server.all_resolvers by smola · Pull Request #6344 · DataDog/dd-trace-java

smola · 2023-12-11T14:22:08Z

What Does This Do

Avoid the following warning:

WAF has rule against unknown address graphql.server.all_resolvers

Motivation

Additional Notes

Jira ticket: APPSEC-16696

pr-commenter · 2023-12-11T15:05:35Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/APPSEC-16696-graphql-warning
git_commit_date	1702298139	1702304400
git_commit_sha	`00358aa`	`6d9dc02`
release_version	1.26.0-SNAPSHOT~00358aaa1a	1.26.0-SNAPSHOT~6d9dc02a0b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1702307092	1702307092
ci_job_id	386563491	386563491
ci_pipeline_id	24789404	24789404
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.26.0-SNAPSHOT~6d9dc02a0b, baseline=1.26.0-SNAPSHOT~00358aaa1a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040760
Total [baseline] (9.324 s) : 0, 9324177
Agent [candidate] (1.045 s) : 0, 1045307
Total [candidate] (9.324 s) : 0, 9324217
section appsec
Agent [baseline] (1.13 s) : 0, 1130409
Total [baseline] (9.436 s) : 0, 9436453
Agent [candidate] (1.132 s) : 0, 1131930
Total [candidate] (9.393 s) : 0, 9392999
section iast
Agent [baseline] (1.175 s) : 0, 1174557
Total [baseline] (9.641 s) : 0, 9641080
Agent [candidate] (1.161 s) : 0, 1161056
Total [candidate] (9.6 s) : 0, 9599843
section profiling
Agent [baseline] (1.233 s) : 0, 1233156
Total [baseline] (9.61 s) : 0, 9609868
Agent [candidate] (1.24 s) : 0, 1239791
Total [candidate] (9.677 s) : 0, 9677424

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	appsec	1.13 s	89.649 ms (8.6%)
Agent	iast	1.175 s	133.797 ms (12.9%)
Agent	profiling	1.233 s	192.396 ms (18.5%)
Total	tracing	9.324 s	-
Total	appsec	9.436 s	112.276 ms (1.2%)
Total	iast	9.641 s	316.903 ms (3.4%)
Total	profiling	9.61 s	285.691 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	appsec	1.132 s	86.624 ms (8.3%)
Agent	iast	1.161 s	115.75 ms (11.1%)
Agent	profiling	1.24 s	194.484 ms (18.6%)
Total	tracing	9.324 s	-
Total	appsec	9.393 s	68.782 ms (0.7%)
Total	iast	9.6 s	275.626 ms (3.0%)
Total	profiling	9.677 s	353.208 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.26.0-SNAPSHOT~6d9dc02a0b, baseline=1.26.0-SNAPSHOT~00358aaa1a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (644.264 ms) : 0, 644264
BytebuddyAgent [candidate] (646.769 ms) : 0, 646769
GlobalTracer [baseline] (305.706 ms) : 0, 305706
GlobalTracer [candidate] (307.561 ms) : 0, 307561
AppSec [baseline] (48.806 ms) : 0, 48806
AppSec [candidate] (48.898 ms) : 0, 48898
Remote Config [baseline] (665.042 µs) : 0, 665
Remote Config [candidate] (675.378 µs) : 0, 675
Telemetry [baseline] (7.065 ms) : 0, 7065
Telemetry [candidate] (7.164 ms) : 0, 7164
section appsec
BytebuddyAgent [baseline] (645.183 ms) : 0, 645183
BytebuddyAgent [candidate] (645.985 ms) : 0, 645985
GlobalTracer [baseline] (306.24 ms) : 0, 306240
GlobalTracer [candidate] (307.164 ms) : 0, 307164
AppSec [baseline] (136.69 ms) : 0, 136690
AppSec [candidate] (136.432 ms) : 0, 136432
Remote Config [baseline] (639.733 µs) : 0, 640
Remote Config [candidate] (642.265 µs) : 0, 642
Telemetry [baseline] (7.444 ms) : 0, 7444
Telemetry [candidate] (7.436 ms) : 0, 7436
section iast
BytebuddyAgent [baseline] (776.002 ms) : 0, 776002
BytebuddyAgent [candidate] (767.426 ms) : 0, 767426
GlobalTracer [baseline] (288.271 ms) : 0, 288271
GlobalTracer [candidate] (286.216 ms) : 0, 286216
AppSec [baseline] (47.067 ms) : 0, 47067
AppSec [candidate] (46.372 ms) : 0, 46372
IAST [baseline] (21.156 ms) : 0, 21156
IAST [candidate] (17.966 ms) : 0, 17966
Remote Config [baseline] (616.694 µs) : 0, 617
Remote Config [candidate] (610.973 µs) : 0, 611
Telemetry [baseline] (6.631 ms) : 0, 6631
Telemetry [candidate] (8.059 ms) : 0, 8059
section profiling
BytebuddyAgent [baseline] (656.225 ms) : 0, 656225
BytebuddyAgent [candidate] (661.027 ms) : 0, 661027
GlobalTracer [baseline] (377.228 ms) : 0, 377228
GlobalTracer [candidate] (378.84 ms) : 0, 378840
AppSec [baseline] (48.579 ms) : 0, 48579
AppSec [candidate] (48.696 ms) : 0, 48696
Remote Config [baseline] (679.66 µs) : 0, 680
Remote Config [candidate] (660.744 µs) : 0, 661
Telemetry [baseline] (7.318 ms) : 0, 7318
Telemetry [candidate] (7.375 ms) : 0, 7375
ProfilingAgent [baseline] (89.033 ms) : 0, 89033
ProfilingAgent [candidate] (88.614 ms) : 0, 88614
Profiling [baseline] (89.058 ms) : 0, 89058
Profiling [candidate] (88.64 ms) : 0, 88640

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.26.0-SNAPSHOT~6d9dc02a0b, baseline=1.26.0-SNAPSHOT~00358aaa1a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042612
Total [baseline] (8.714 s) : 0, 8714256
Agent [candidate] (1.044 s) : 0, 1043502
Total [candidate] (8.735 s) : 0, 8734662
section iast
Agent [baseline] (1.169 s) : 0, 1168587
Total [baseline] (9.27 s) : 0, 9269594
Agent [candidate] (1.163 s) : 0, 1163116
Total [candidate] (9.287 s) : 0, 9287456
section iast_TELEMETRY_OFF
Agent [baseline] (1.153 s) : 0, 1152750
Total [baseline] (9.214 s) : 0, 9214459
Agent [candidate] (1.156 s) : 0, 1155782
Total [candidate] (9.287 s) : 0, 9286828

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.169 s	125.975 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.153 s	110.138 ms (10.6%)
Total	tracing	8.714 s	-
Total	iast	9.27 s	555.338 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.214 s	500.203 ms (5.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.163 s	119.615 ms (11.5%)
Agent	iast_TELEMETRY_OFF	1.156 s	112.28 ms (10.8%)
Total	tracing	8.735 s	-
Total	iast	9.287 s	552.794 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.287 s	552.166 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.26.0-SNAPSHOT~6d9dc02a0b, baseline=1.26.0-SNAPSHOT~00358aaa1a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (644.734 ms) : 0, 644734
BytebuddyAgent [candidate] (645.366 ms) : 0, 645366
GlobalTracer [baseline] (307.388 ms) : 0, 307388
GlobalTracer [candidate] (307.338 ms) : 0, 307338
AppSec [baseline] (48.509 ms) : 0, 48509
AppSec [candidate] (48.701 ms) : 0, 48701
Remote Config [baseline] (669.663 µs) : 0, 670
Remote Config [candidate] (665.922 µs) : 0, 666
Telemetry [baseline] (7.056 ms) : 0, 7056
Telemetry [candidate] (7.183 ms) : 0, 7183
section iast
BytebuddyAgent [baseline] (771.346 ms) : 0, 771346
BytebuddyAgent [candidate] (768.116 ms) : 0, 768116
GlobalTracer [baseline] (287.483 ms) : 0, 287483
GlobalTracer [candidate] (286.053 ms) : 0, 286053
AppSec [baseline] (46.907 ms) : 0, 46907
AppSec [candidate] (46.367 ms) : 0, 46367
IAST [baseline] (20.281 ms) : 0, 20281
IAST [candidate] (20.92 ms) : 0, 20920
Remote Config [baseline] (610.743 µs) : 0, 611
Remote Config [candidate] (609.006 µs) : 0, 609
Telemetry [baseline] (7.366 ms) : 0, 7366
Telemetry [candidate] (6.626 ms) : 0, 6626
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (759.158 ms) : 0, 759158
BytebuddyAgent [candidate] (760.643 ms) : 0, 760643
GlobalTracer [baseline] (285.447 ms) : 0, 285447
GlobalTracer [candidate] (286.455 ms) : 0, 286455
AppSec [baseline] (46.27 ms) : 0, 46270
AppSec [candidate] (47.092 ms) : 0, 47092
IAST [baseline] (17.631 ms) : 0, 17631
IAST [candidate] (17.904 ms) : 0, 17904
Remote Config [baseline] (581.947 µs) : 0, 582
Remote Config [candidate] (616.538 µs) : 0, 617
Telemetry [baseline] (9.316 ms) : 0, 9316
Telemetry [candidate] (8.72 ms) : 0, 8720

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2023-12-11T14:44:05	2023-12-11T15:00:39
git_branch	master	smola/APPSEC-16696-graphql-warning
git_commit_date	1702298139	1702304400
git_commit_sha	`00358aa`	`6d9dc02`
release_version	1.26.0-SNAPSHOT~00358aaa1a	1.26.0-SNAPSHOT~6d9dc02a0b
start_time	2023-12-11T14:43:52	2023-12-11T15:00:26

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1702307092	1702307092
ci_job_id	386563491	386563491
ci_pipeline_id	24789404	24789404
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 14 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~6d9dc02a0b, baseline=1.26.0-SNAPSHOT~00358aaa1a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1383
.   : milestone, 1364,
appsec (1.785 ms) : 1760, 1810
.   : milestone, 1785,
iast (1.535 ms) : 1510, 1559
.   : milestone, 1535,
profiling (1.568 ms) : 1542, 1595
.   : milestone, 1568,
tracing (1.487 ms) : 1462, 1512
.   : milestone, 1487,
section candidate
no_agent (1.373 ms) : 1353, 1392
.   : milestone, 1373,
appsec (1.73 ms) : 1704, 1755
.   : milestone, 1730,
iast (1.525 ms) : 1501, 1549
.   : milestone, 1525,
profiling (1.546 ms) : 1519, 1573
.   : milestone, 1546,
tracing (1.505 ms) : 1480, 1530
.   : milestone, 1505,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.364 ms [1.345 ms, 1.383 ms]	-
appsec	1.785 ms [1.76 ms, 1.81 ms]	420.515 µs (30.8%)
iast	1.535 ms [1.51 ms, 1.559 ms]	170.503 µs (12.5%)
profiling	1.568 ms [1.542 ms, 1.595 ms]	204.238 µs (15.0%)
tracing	1.487 ms [1.462 ms, 1.512 ms]	122.771 µs (9.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.373 ms [1.353 ms, 1.392 ms]	-
appsec	1.73 ms [1.704 ms, 1.755 ms]	357.016 µs (26.0%)
iast	1.525 ms [1.501 ms, 1.549 ms]	152.452 µs (11.1%)
profiling	1.546 ms [1.519 ms, 1.573 ms]	173.71 µs (12.7%)
tracing	1.505 ms [1.48 ms, 1.53 ms]	132.067 µs (9.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~6d9dc02a0b, baseline=1.26.0-SNAPSHOT~00358aaa1a
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.039 µs) : 345, 385
.   : milestone, 365,
iast (471.801 µs) : 451, 492
.   : milestone, 472,
iast_FULL (535.036 µs) : 515, 555
.   : milestone, 535,
iast_INACTIVE (442.964 µs) : 422, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (469.652 µs) : 449, 491
.   : milestone, 470,
tracing (434.573 µs) : 414, 455
.   : milestone, 435,
section candidate
no_agent (365.402 µs) : 346, 385
.   : milestone, 365,
iast (468.998 µs) : 449, 489
.   : milestone, 469,
iast_FULL (534.671 µs) : 514, 555
.   : milestone, 535,
iast_INACTIVE (439.022 µs) : 419, 459
.   : milestone, 439,
iast_TELEMETRY_OFF (463.747 µs) : 443, 484
.   : milestone, 464,
tracing (440.257 µs) : 420, 461
.   : milestone, 440,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.039 µs [344.756 µs, 385.323 µs]	-
iast	471.801 µs [451.309 µs, 492.292 µs]	106.761 µs (29.2%)
iast_FULL	535.036 µs [514.667 µs, 555.405 µs]	169.997 µs (46.6%)
iast_INACTIVE	442.964 µs [422.058 µs, 463.869 µs]	77.924 µs (21.3%)
iast_TELEMETRY_OFF	469.652 µs [448.803 µs, 490.501 µs]	104.612 µs (28.7%)
tracing	434.573 µs [414.026 µs, 455.119 µs]	69.533 µs (19.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.402 µs [345.647 µs, 385.158 µs]	-
iast	468.998 µs [448.767 µs, 489.23 µs]	103.596 µs (28.4%)
iast_FULL	534.671 µs [514.151 µs, 555.192 µs]	169.269 µs (46.3%)
iast_INACTIVE	439.022 µs [418.614 µs, 459.43 µs]	73.62 µs (20.1%)
iast_TELEMETRY_OFF	463.747 µs [443.07 µs, 484.425 µs]	98.345 µs (26.9%)
tracing	440.257 µs [419.861 µs, 460.652 µs]	74.854 µs (20.5%)

Remove warning about unknown graphql.server.all_resolvers

6d9dc02

smola added the comp: asm waf Application Security Management (WAF) label Dec 11, 2023

smola requested a review from a team as a code owner December 11, 2023 14:22

smola requested review from ValentinZakharov and manuel-alvarez-alvarez December 11, 2023 14:22

manuel-alvarez-alvarez approved these changes Dec 11, 2023

View reviewed changes

smola merged commit c056a84 into master Dec 12, 2023

smola deleted the smola/APPSEC-16696-graphql-warning branch December 12, 2023 13:33

github-actions Bot added this to the 1.26.0 milestone Dec 12, 2023

smola mentioned this pull request Dec 12, 2023

Add graphql.server.resolver to known WAF addresses #6350

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove warning about unknown graphql.server.all_resolvers#6344

Remove warning about unknown graphql.server.all_resolvers#6344
smola merged 1 commit into
masterfrom
smola/APPSEC-16696-graphql-warning

smola commented Dec 11, 2023 •

edited by atlassian Bot

Loading

Uh oh!

pr-commenter Bot commented Dec 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

smola commented Dec 11, 2023 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenter Bot commented Dec 11, 2023

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smola commented Dec 11, 2023 •

edited by atlassian Bot

Loading