Skip to content

Preserve tracer's default metrics namespace as "datadog.tracer" in dd-trace-ot#5810

Merged
mcculls merged 1 commit into
masterfrom
mcculls/fix-dd-trace-ot-core-tracer-metrics-namespace
Aug 30, 2023
Merged

Preserve tracer's default metrics namespace as "datadog.tracer" in dd-trace-ot#5810
mcculls merged 1 commit into
masterfrom
mcculls/fix-dd-trace-ot-core-tracer-metrics-namespace

Conversation

@mcculls

@mcculls mcculls commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

What Does This Do

Stops the CoreTracer's default statsd namespace from being changed by dd-trace-ot's relocation rules

Motivation

Otherwise tracer metrics collected when using dd-trace-ot end up prefixed with ddtrot.dd.tracer as reported in #5808

@mcculls mcculls added the comp: metrics Metrics label Aug 30, 2023
@mcculls
mcculls requested a review from a team as a code owner August 30, 2023 10:12
@pr-commenter

pr-commenter Bot commented Aug 30, 2023

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~3bd19babdf 1.20.0-SNAPSHOT~3a0098e7d2
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~3a0098e7d2, baseline=1.20.0-SNAPSHOT~3bd19babdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (988.313 ms) : 0, 988313
Total [baseline] (9.198 s) : 0, 9198117
Agent [candidate] (990.04 ms) : 0, 990040
Total [candidate] (9.157 s) : 0, 9156875
section appsec
Agent [baseline] (1.073 s) : 0, 1073269
Total [baseline] (9.335 s) : 0, 9334620
Agent [candidate] (1.072 s) : 0, 1072071
Total [candidate] (9.226 s) : 0, 9225718
section iast
Agent [baseline] (1.09 s) : 0, 1090122
Total [baseline] (9.389 s) : 0, 9389296
Agent [candidate] (1.1 s) : 0, 1099918
Total [candidate] (9.48 s) : 0, 9480267
section profiling
Agent [baseline] (1.171 s) : 0, 1171373
Total [baseline] (9.519 s) : 0, 9518764
Agent [candidate] (1.158 s) : 0, 1158032
Total [candidate] (9.44 s) : 0, 9439671
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 988.313 ms -
Agent appsec 1.073 s 84.956 ms (8.6%)
Agent iast 1.09 s 101.809 ms (10.3%)
Agent profiling 1.171 s 183.059 ms (18.5%)
Total tracing 9.198 s -
Total appsec 9.335 s 136.503 ms (1.5%)
Total iast 9.389 s 191.178 ms (2.1%)
Total profiling 9.519 s 320.647 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 990.04 ms -
Agent appsec 1.072 s 82.032 ms (8.3%)
Agent iast 1.1 s 109.878 ms (11.1%)
Agent profiling 1.158 s 167.992 ms (17.0%)
Total tracing 9.157 s -
Total appsec 9.226 s 68.843 ms (0.8%)
Total iast 9.48 s 323.392 ms (3.5%)
Total profiling 9.44 s 282.796 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~3a0098e7d2, baseline=1.20.0-SNAPSHOT~3bd19babdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (612.792 ms) : 0, 612792
BytebuddyAgent [candidate] (613.509 ms) : 0, 613509
GlobalTracer [baseline] (284.285 ms) : 0, 284285
GlobalTracer [candidate] (285.416 ms) : 0, 285416
AppSec [baseline] (50.33 ms) : 0, 50330
AppSec [candidate] (50.053 ms) : 0, 50053
Remote Config [baseline] (664.961 µs) : 0, 665
Remote Config [candidate] (662.705 µs) : 0, 663
Telemetry [baseline] (6.02 ms) : 0, 6020
Telemetry [candidate] (5.988 ms) : 0, 5988
section appsec
BytebuddyAgent [baseline] (613.305 ms) : 0, 613305
BytebuddyAgent [candidate] (612.636 ms) : 0, 612636
GlobalTracer [baseline] (284.159 ms) : 0, 284159
GlobalTracer [candidate] (284.459 ms) : 0, 284459
AppSec [baseline] (135.062 ms) : 0, 135062
AppSec [candidate] (134.351 ms) : 0, 134351
Remote Config [baseline] (732.03 µs) : 0, 732
Remote Config [candidate] (718.861 µs) : 0, 719
Telemetry [baseline] (5.721 ms) : 0, 5721
Telemetry [candidate] (5.716 ms) : 0, 5716
section iast
BytebuddyAgent [baseline] (718.066 ms) : 0, 718066
BytebuddyAgent [candidate] (724.92 ms) : 0, 724920
GlobalTracer [baseline] (270.481 ms) : 0, 270481
GlobalTracer [candidate] (272.093 ms) : 0, 272093
AppSec [baseline] (46.68 ms) : 0, 46680
AppSec [candidate] (47.408 ms) : 0, 47408
Remote Config [baseline] (565.358 µs) : 0, 565
Remote Config [candidate] (578.353 µs) : 0, 578
Telemetry [baseline] (5.685 ms) : 0, 5685
Telemetry [candidate] (5.774 ms) : 0, 5774
IAST [baseline] (14.315 ms) : 0, 14315
IAST [candidate] (14.552 ms) : 0, 14552
section profiling
BytebuddyAgent [baseline] (631.447 ms) : 0, 631447
BytebuddyAgent [candidate] (624.893 ms) : 0, 624893
GlobalTracer [baseline] (351.429 ms) : 0, 351429
GlobalTracer [candidate] (347.26 ms) : 0, 347260
AppSec [baseline] (49.78 ms) : 0, 49780
AppSec [candidate] (48.752 ms) : 0, 48752
Remote Config [baseline] (656.432 µs) : 0, 656
Remote Config [candidate] (642.092 µs) : 0, 642
Telemetry [baseline] (6.144 ms) : 0, 6144
Telemetry [candidate] (5.958 ms) : 0, 5958
ProfilingAgent [baseline] (78.613 ms) : 0, 78613
ProfilingAgent [candidate] (77.805 ms) : 0, 77805
Profiling [baseline] (78.637 ms) : 0, 78637
Profiling [candidate] (77.83 ms) : 0, 77830
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~3a0098e7d2, baseline=1.20.0-SNAPSHOT~3bd19babdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1001958
Total [baseline] (8.635 s) : 0, 8634930
Agent [candidate] (1.003 s) : 0, 1002554
Total [candidate] (8.673 s) : 0, 8672645
section appsec
Agent [baseline] (1.073 s) : 0, 1073204
Total [baseline] (8.702 s) : 0, 8701789
Agent [candidate] (1.079 s) : 0, 1079493
Total [candidate] (8.706 s) : 0, 8706417
section iast
Agent [baseline] (1.092 s) : 0, 1091853
Total [baseline] (9.16 s) : 0, 9160115
Agent [candidate] (1.091 s) : 0, 1091268
Total [candidate] (9.125 s) : 0, 9124966
section profiling
Agent [baseline] (1.162 s) : 0, 1161589
Total [baseline] (8.896 s) : 0, 8895853
Agent [candidate] (1.186 s) : 0, 1185516
Total [candidate] (8.955 s) : 0, 8955473
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.002 s -
Agent appsec 1.073 s 71.246 ms (7.1%)
Agent iast 1.092 s 89.895 ms (9.0%)
Agent profiling 1.162 s 159.631 ms (15.9%)
Total tracing 8.635 s -
Total appsec 8.702 s 66.858 ms (0.8%)
Total iast 9.16 s 525.185 ms (6.1%)
Total profiling 8.896 s 260.923 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.003 s -
Agent appsec 1.079 s 76.939 ms (7.7%)
Agent iast 1.091 s 88.714 ms (8.8%)
Agent profiling 1.186 s 182.961 ms (18.2%)
Total tracing 8.673 s -
Total appsec 8.706 s 33.773 ms (0.4%)
Total iast 9.125 s 452.321 ms (5.2%)
Total profiling 8.955 s 282.828 ms (3.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~3a0098e7d2, baseline=1.20.0-SNAPSHOT~3bd19babdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (621.957 ms) : 0, 621957
BytebuddyAgent [candidate] (621.695 ms) : 0, 621695
GlobalTracer [baseline] (288.492 ms) : 0, 288492
GlobalTracer [candidate] (288.989 ms) : 0, 288989
AppSec [baseline] (49.911 ms) : 0, 49911
AppSec [candidate] (50.299 ms) : 0, 50299
Remote Config [baseline] (670.144 µs) : 0, 670
Remote Config [candidate] (673.28 µs) : 0, 673
Telemetry [baseline] (6.046 ms) : 0, 6046
Telemetry [candidate] (6.038 ms) : 0, 6038
section appsec
BytebuddyAgent [baseline] (612.934 ms) : 0, 612934
BytebuddyAgent [candidate] (617.202 ms) : 0, 617202
GlobalTracer [baseline] (284.232 ms) : 0, 284232
GlobalTracer [candidate] (286.292 ms) : 0, 286292
AppSec [baseline] (135.135 ms) : 0, 135135
AppSec [candidate] (134.971 ms) : 0, 134971
Remote Config [baseline] (730.281 µs) : 0, 730
Remote Config [candidate] (718.246 µs) : 0, 718
Telemetry [baseline] (5.716 ms) : 0, 5716
Telemetry [candidate] (5.754 ms) : 0, 5754
section iast
BytebuddyAgent [baseline] (718.831 ms) : 0, 718831
BytebuddyAgent [candidate] (718.9 ms) : 0, 718900
GlobalTracer [baseline] (270.696 ms) : 0, 270696
GlobalTracer [candidate] (270.613 ms) : 0, 270613
AppSec [baseline] (47.017 ms) : 0, 47017
AppSec [candidate] (46.787 ms) : 0, 46787
Remote Config [baseline] (587.232 µs) : 0, 587
Remote Config [candidate] (575.786 µs) : 0, 576
Telemetry [baseline] (5.817 ms) : 0, 5817
Telemetry [candidate] (5.71 ms) : 0, 5710
IAST [baseline] (14.535 ms) : 0, 14535
IAST [candidate] (14.322 ms) : 0, 14322
section profiling
BytebuddyAgent [baseline] (626.008 ms) : 0, 626008
BytebuddyAgent [candidate] (642.018 ms) : 0, 642018
GlobalTracer [baseline] (348.152 ms) : 0, 348152
GlobalTracer [candidate] (353.964 ms) : 0, 353964
AppSec [baseline] (49.415 ms) : 0, 49415
AppSec [candidate] (49.948 ms) : 0, 49948
Remote Config [baseline] (645.623 µs) : 0, 646
Remote Config [candidate] (665.343 µs) : 0, 665
Telemetry [baseline] (6.015 ms) : 0, 6015
Telemetry [candidate] (6.046 ms) : 0, 6046
ProfilingAgent [baseline] (78.401 ms) : 0, 78401
ProfilingAgent [candidate] (78.628 ms) : 0, 78628
Profiling [baseline] (78.425 ms) : 0, 78425
Profiling [candidate] (78.652 ms) : 0, 78652
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~3bd19babdf 1.20.0-SNAPSHOT~3a0098e7d2
config baseline candidate
end_time 2023-08-30T10:31:46 2023-08-30T10:49:49
start_time 2023-08-30T10:31:29 2023-08-30T10:49:32
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~3a0098e7d2, baseline=1.20.0-SNAPSHOT~3bd19babdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.665 ms) : 1641, 1690
.   : milestone, 1665,
iast (1.471 ms) : 1447, 1494
.   : milestone, 1471,
profiling (1.488 ms) : 1463, 1514
.   : milestone, 1488,
tracing (1.447 ms) : 1422, 1471
.   : milestone, 1447,
section candidate
no_agent (1.33 ms) : 1311, 1349
.   : milestone, 1330,
appsec (1.657 ms) : 1632, 1681
.   : milestone, 1657,
iast (1.448 ms) : 1424, 1472
.   : milestone, 1448,
profiling (1.476 ms) : 1451, 1501
.   : milestone, 1476,
tracing (1.425 ms) : 1401, 1448
.   : milestone, 1425,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.665 ms [1.641 ms, 1.69 ms] 320.537 µs (23.8%)
iast 1.471 ms [1.447 ms, 1.494 ms] 125.749 µs (9.4%)
profiling 1.488 ms [1.463 ms, 1.514 ms] 143.609 µs (10.7%)
tracing 1.447 ms [1.422 ms, 1.471 ms] 101.955 µs (7.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.33 ms [1.311 ms, 1.349 ms] -
appsec 1.657 ms [1.632 ms, 1.681 ms] 326.814 µs (24.6%)
iast 1.448 ms [1.424 ms, 1.472 ms] 118.245 µs (8.9%)
profiling 1.476 ms [1.451 ms, 1.501 ms] 145.869 µs (11.0%)
tracing 1.425 ms [1.401 ms, 1.448 ms] 94.667 µs (7.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~3a0098e7d2, baseline=1.20.0-SNAPSHOT~3bd19babdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (358.033 µs) : 338, 378
.   : milestone, 358,
appsec (653.853 µs) : 633, 674
.   : milestone, 654,
iast (456.586 µs) : 436, 477
.   : milestone, 457,
iast_FULL (514.013 µs) : 493, 535
.   : milestone, 514,
iast_INACTIVE (430.168 µs) : 409, 451
.   : milestone, 430,
profiling (432.844 µs) : 412, 454
.   : milestone, 433,
tracing (422.494 µs) : 402, 443
.   : milestone, 422,
section candidate
no_agent (366.245 µs) : 346, 387
.   : milestone, 366,
appsec (647.799 µs) : 628, 668
.   : milestone, 648,
iast (457.006 µs) : 436, 478
.   : milestone, 457,
iast_FULL (511.284 µs) : 491, 532
.   : milestone, 511,
iast_INACTIVE (434.001 µs) : 413, 455
.   : milestone, 434,
profiling (428.619 µs) : 408, 449
.   : milestone, 429,
tracing (429.113 µs) : 408, 450
.   : milestone, 429,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.033 µs [337.951 µs, 378.115 µs] -
appsec 653.853 µs [633.443 µs, 674.263 µs] 295.82 µs (82.6%)
iast 456.586 µs [435.717 µs, 477.456 µs] 98.554 µs (27.5%)
iast_FULL 514.013 µs [493.336 µs, 534.689 µs] 155.98 µs (43.6%)
iast_INACTIVE 430.168 µs [409.424 µs, 450.912 µs] 72.135 µs (20.1%)
profiling 432.844 µs [411.983 µs, 453.705 µs] 74.811 µs (20.9%)
tracing 422.494 µs [402.167 µs, 442.82 µs] 64.461 µs (18.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.245 µs [345.889 µs, 386.6 µs] -
appsec 647.799 µs [627.655 µs, 667.944 µs] 281.555 µs (76.9%)
iast 457.006 µs [436.183 µs, 477.829 µs] 90.761 µs (24.8%)
iast_FULL 511.284 µs [490.506 µs, 532.062 µs] 145.039 µs (39.6%)
iast_INACTIVE 434.001 µs [412.829 µs, 455.174 µs] 67.757 µs (18.5%)
profiling 428.619 µs [408.22 µs, 449.018 µs] 62.375 µs (17.0%)
tracing 429.113 µs [408.318 µs, 449.908 µs] 62.868 µs (17.2%)

@mcculls
mcculls merged commit 967c9d7 into master Aug 30, 2023
@mcculls
mcculls deleted the mcculls/fix-dd-trace-ot-core-tracer-metrics-namespace branch August 30, 2023 11:00
@github-actions github-actions Bot added this to the 1.20.0 milestone Aug 30, 2023
@mcculls mcculls mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bantonsson bantonsson bantonsson approved these changes
@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: metrics Metrics

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @bantonsson