Skip to content

Add redshift support to JDBC URL parser#5792

Merged
devinsba merged 1 commit into
masterfrom
bds/redshift-support
Aug 28, 2023
Merged

Add redshift support to JDBC URL parser#5792
devinsba merged 1 commit into
masterfrom
bds/redshift-support

Conversation

@devinsba

@devinsba devinsba commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

What Does This Do

Motivation

Additional Notes

@devinsba
devinsba force-pushed the bds/redshift-support branch 2 times, most recently from 62ea365 to ace53ae Compare August 28, 2023 15:31
@pr-commenter

pr-commenter Bot commented Aug 28, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~b603c6e56e 1.20.0-SNAPSHOT~b569d43c00
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~b569d43c00, baseline=1.20.0-SNAPSHOT~b603c6e56e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.003 s) : 0, 1002876
Total [baseline] (8.696 s) : 0, 8696412
Agent [candidate] (987.904 ms) : 0, 987904
Total [candidate] (8.644 s) : 0, 8643502
section appsec
Agent [baseline] (1.072 s) : 0, 1072141
Total [baseline] (8.716 s) : 0, 8716166
Agent [candidate] (1.073 s) : 0, 1073375
Total [candidate] (8.71 s) : 0, 8709639
section iast
Agent [baseline] (1.092 s) : 0, 1092057
Total [baseline] (9.172 s) : 0, 9171538
Agent [candidate] (1.099 s) : 0, 1099277
Total [candidate] (9.199 s) : 0, 9199466
section profiling
Agent [baseline] (1.159 s) : 0, 1159070
Total [baseline] (8.909 s) : 0, 8908669
Agent [candidate] (1.16 s) : 0, 1160332
Total [candidate] (8.857 s) : 0, 8856826
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.003 s -
Agent appsec 1.072 s 69.265 ms (6.9%)
Agent iast 1.092 s 89.18 ms (8.9%)
Agent profiling 1.159 s 156.194 ms (15.6%)
Total tracing 8.696 s -
Total appsec 8.716 s 19.753 ms (0.2%)
Total iast 9.172 s 475.126 ms (5.5%)
Total profiling 8.909 s 212.257 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 987.904 ms -
Agent appsec 1.073 s 85.471 ms (8.7%)
Agent iast 1.099 s 111.373 ms (11.3%)
Agent profiling 1.16 s 172.428 ms (17.5%)
Total tracing 8.644 s -
Total appsec 8.71 s 66.137 ms (0.8%)
Total iast 9.199 s 555.964 ms (6.4%)
Total profiling 8.857 s 213.324 ms (2.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~b569d43c00, baseline=1.20.0-SNAPSHOT~b603c6e56e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (621.627 ms) : 0, 621627
BytebuddyAgent [candidate] (612.692 ms) : 0, 612692
GlobalTracer [baseline] (289.308 ms) : 0, 289308
GlobalTracer [candidate] (284.208 ms) : 0, 284208
AppSec [baseline] (50.341 ms) : 0, 50341
AppSec [candidate] (50.054 ms) : 0, 50054
Remote Config [baseline] (671.439 µs) : 0, 671
Remote Config [candidate] (662.947 µs) : 0, 663
Telemetry [baseline] (6.116 ms) : 0, 6116
Telemetry [candidate] (5.995 ms) : 0, 5995
section appsec
BytebuddyAgent [baseline] (612.314 ms) : 0, 612314
BytebuddyAgent [candidate] (613.261 ms) : 0, 613261
GlobalTracer [baseline] (284.074 ms) : 0, 284074
GlobalTracer [candidate] (284.482 ms) : 0, 284482
AppSec [baseline] (135.002 ms) : 0, 135002
AppSec [candidate] (134.886 ms) : 0, 134886
Remote Config [baseline] (723.072 µs) : 0, 723
Remote Config [candidate] (716.412 µs) : 0, 716
Telemetry [baseline] (5.823 ms) : 0, 5823
Telemetry [candidate] (5.76 ms) : 0, 5760
section iast
BytebuddyAgent [baseline] (719.2 ms) : 0, 719200
BytebuddyAgent [candidate] (724.354 ms) : 0, 724354
GlobalTracer [baseline] (270.839 ms) : 0, 270839
GlobalTracer [candidate] (272.435 ms) : 0, 272435
AppSec [baseline] (47.452 ms) : 0, 47452
AppSec [candidate] (47.565 ms) : 0, 47565
Remote Config [baseline] (547.921 µs) : 0, 548
Remote Config [candidate] (545.277 µs) : 0, 545
Telemetry [baseline] (5.731 ms) : 0, 5731
Telemetry [candidate] (5.698 ms) : 0, 5698
IAST [baseline] (14.039 ms) : 0, 14039
IAST [candidate] (14.162 ms) : 0, 14162
section profiling
BytebuddyAgent [baseline] (624.898 ms) : 0, 624898
BytebuddyAgent [candidate] (625.737 ms) : 0, 625737
GlobalTracer [baseline] (347.798 ms) : 0, 347798
GlobalTracer [candidate] (348.122 ms) : 0, 348122
AppSec [baseline] (49.104 ms) : 0, 49104
AppSec [candidate] (49.214 ms) : 0, 49214
Remote Config [baseline] (636.536 µs) : 0, 637
Remote Config [candidate] (646.228 µs) : 0, 646
Telemetry [baseline] (5.956 ms) : 0, 5956
Telemetry [candidate] (5.965 ms) : 0, 5965
ProfilingAgent [baseline] (77.929 ms) : 0, 77929
ProfilingAgent [candidate] (77.85 ms) : 0, 77850
Profiling [baseline] (77.954 ms) : 0, 77954
Profiling [candidate] (77.874 ms) : 0, 77874
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~b569d43c00, baseline=1.20.0-SNAPSHOT~b603c6e56e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (993.064 ms) : 0, 993064
Total [baseline] (9.197 s) : 0, 9197286
Agent [candidate] (989.184 ms) : 0, 989184
Total [candidate] (9.183 s) : 0, 9182890
section appsec
Agent [baseline] (1.073 s) : 0, 1073153
Total [baseline] (9.265 s) : 0, 9265123
Agent [candidate] (1.074 s) : 0, 1073632
Total [candidate] (9.256 s) : 0, 9256269
section iast
Agent [baseline] (1.089 s) : 0, 1089284
Total [baseline] (9.435 s) : 0, 9434764
Agent [candidate] (1.091 s) : 0, 1090643
Total [candidate] (9.427 s) : 0, 9427453
section profiling
Agent [baseline] (1.18 s) : 0, 1179615
Total [baseline] (9.577 s) : 0, 9577178
Agent [candidate] (1.161 s) : 0, 1161057
Total [candidate] (9.455 s) : 0, 9455221
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 993.064 ms -
Agent appsec 1.073 s 80.09 ms (8.1%)
Agent iast 1.089 s 96.22 ms (9.7%)
Agent profiling 1.18 s 186.552 ms (18.8%)
Total tracing 9.197 s -
Total appsec 9.265 s 67.838 ms (0.7%)
Total iast 9.435 s 237.478 ms (2.6%)
Total profiling 9.577 s 379.892 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 989.184 ms -
Agent appsec 1.074 s 84.448 ms (8.5%)
Agent iast 1.091 s 101.459 ms (10.3%)
Agent profiling 1.161 s 171.873 ms (17.4%)
Total tracing 9.183 s -
Total appsec 9.256 s 73.379 ms (0.8%)
Total iast 9.427 s 244.563 ms (2.7%)
Total profiling 9.455 s 272.332 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~b569d43c00, baseline=1.20.0-SNAPSHOT~b603c6e56e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (616.142 ms) : 0, 616142
BytebuddyAgent [candidate] (613.016 ms) : 0, 613016
GlobalTracer [baseline] (285.918 ms) : 0, 285918
GlobalTracer [candidate] (285.313 ms) : 0, 285313
AppSec [baseline] (49.794 ms) : 0, 49794
AppSec [candidate] (49.892 ms) : 0, 49892
Remote Config [baseline] (666.117 µs) : 0, 666
Remote Config [candidate] (680.68 µs) : 0, 681
Telemetry [baseline] (6.049 ms) : 0, 6049
Telemetry [candidate] (6.001 ms) : 0, 6001
section appsec
BytebuddyAgent [baseline] (612.866 ms) : 0, 612866
BytebuddyAgent [candidate] (613.196 ms) : 0, 613196
GlobalTracer [baseline] (284.306 ms) : 0, 284306
GlobalTracer [candidate] (284.607 ms) : 0, 284607
AppSec [baseline] (135.193 ms) : 0, 135193
AppSec [candidate] (135.177 ms) : 0, 135177
Remote Config [baseline] (741.31 µs) : 0, 741
Remote Config [candidate] (713.417 µs) : 0, 713
Telemetry [baseline] (5.75 ms) : 0, 5750
Telemetry [candidate] (5.753 ms) : 0, 5753
section iast
BytebuddyAgent [baseline] (717.106 ms) : 0, 717106
BytebuddyAgent [candidate] (718.385 ms) : 0, 718385
GlobalTracer [baseline] (270.063 ms) : 0, 270063
GlobalTracer [candidate] (270.498 ms) : 0, 270498
AppSec [baseline] (47.427 ms) : 0, 47427
AppSec [candidate] (47.257 ms) : 0, 47257
Remote Config [baseline] (547.688 µs) : 0, 548
Remote Config [candidate] (540.597 µs) : 0, 541
Telemetry [baseline] (5.693 ms) : 0, 5693
Telemetry [candidate] (5.677 ms) : 0, 5677
IAST [baseline] (14.063 ms) : 0, 14063
IAST [candidate] (13.997 ms) : 0, 13997
section profiling
BytebuddyAgent [baseline] (636.601 ms) : 0, 636601
BytebuddyAgent [candidate] (626.115 ms) : 0, 626115
GlobalTracer [baseline] (353.957 ms) : 0, 353957
GlobalTracer [candidate] (348.042 ms) : 0, 348042
AppSec [baseline] (49.783 ms) : 0, 49783
AppSec [candidate] (49.02 ms) : 0, 49020
Remote Config [baseline] (648.801 µs) : 0, 649
Remote Config [candidate] (640.318 µs) : 0, 640
Telemetry [baseline] (6.061 ms) : 0, 6061
Telemetry [candidate] (5.945 ms) : 0, 5945
ProfilingAgent [baseline] (78.718 ms) : 0, 78718
ProfilingAgent [candidate] (78.499 ms) : 0, 78499
Profiling [baseline] (78.743 ms) : 0, 78743
Profiling [candidate] (78.526 ms) : 0, 78526
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~b603c6e56e 1.20.0-SNAPSHOT~b569d43c00
config baseline candidate
end_time 2023-08-28T17:04:21 2023-08-28T17:22:25
start_time 2023-08-28T17:04:04 2023-08-28T17:22:08
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~b569d43c00, baseline=1.20.0-SNAPSHOT~b603c6e56e
    dateFormat X
    axisFormat %s
section baseline
no_agent (358.336 µs) : 339, 378
.   : milestone, 358,
appsec (656.111 µs) : 636, 676
.   : milestone, 656,
iast (450.668 µs) : 430, 471
.   : milestone, 451,
iast_FULL (517.171 µs) : 496, 538
.   : milestone, 517,
iast_INACTIVE (434.35 µs) : 413, 456
.   : milestone, 434,
profiling (448.527 µs) : 427, 470
.   : milestone, 449,
tracing (428.749 µs) : 408, 449
.   : milestone, 429,
section candidate
no_agent (365.377 µs) : 345, 386
.   : milestone, 365,
appsec (672.559 µs) : 651, 694
.   : milestone, 673,
iast (462.636 µs) : 441, 484
.   : milestone, 463,
iast_FULL (513.726 µs) : 493, 534
.   : milestone, 514,
iast_INACTIVE (440.265 µs) : 419, 461
.   : milestone, 440,
profiling (439.998 µs) : 419, 461
.   : milestone, 440,
tracing (432.79 µs) : 412, 453
.   : milestone, 433,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.336 µs [338.751 µs, 377.921 µs] -
appsec 656.111 µs [635.935 µs, 676.286 µs] 297.774 µs (83.1%)
iast 450.668 µs [430.238 µs, 471.098 µs] 92.332 µs (25.8%)
iast_FULL 517.171 µs [496.371 µs, 537.971 µs] 158.835 µs (44.3%)
iast_INACTIVE 434.35 µs [412.891 µs, 455.809 µs] 76.014 µs (21.2%)
profiling 448.527 µs [427.45 µs, 469.604 µs] 90.191 µs (25.2%)
tracing 428.749 µs [408.141 µs, 449.356 µs] 70.412 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.377 µs [344.59 µs, 386.165 µs] -
appsec 672.559 µs [651.211 µs, 693.907 µs] 307.182 µs (84.1%)
iast 462.636 µs [440.791 µs, 484.482 µs] 97.259 µs (26.6%)
iast_FULL 513.726 µs [493.208 µs, 534.244 µs] 148.349 µs (40.6%)
iast_INACTIVE 440.265 µs [419.075 µs, 461.455 µs] 74.888 µs (20.5%)
profiling 439.998 µs [418.995 µs, 461.001 µs] 74.621 µs (20.4%)
tracing 432.79 µs [412.296 µs, 453.284 µs] 67.413 µs (18.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~b569d43c00, baseline=1.20.0-SNAPSHOT~b603c6e56e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1368
.   : milestone, 1349,
appsec (1.686 ms) : 1662, 1711
.   : milestone, 1686,
iast (1.458 ms) : 1434, 1482
.   : milestone, 1458,
profiling (1.482 ms) : 1456, 1508
.   : milestone, 1482,
tracing (1.447 ms) : 1423, 1472
.   : milestone, 1447,
section candidate
no_agent (1.342 ms) : 1323, 1361
.   : milestone, 1342,
appsec (1.659 ms) : 1634, 1683
.   : milestone, 1659,
iast (1.442 ms) : 1418, 1466
.   : milestone, 1442,
profiling (1.467 ms) : 1442, 1491
.   : milestone, 1467,
tracing (1.459 ms) : 1435, 1484
.   : milestone, 1459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.329 ms, 1.368 ms] -
appsec 1.686 ms [1.662 ms, 1.711 ms] 337.882 µs (25.1%)
iast 1.458 ms [1.434 ms, 1.482 ms] 109.322 µs (8.1%)
profiling 1.482 ms [1.456 ms, 1.508 ms] 133.179 µs (9.9%)
tracing 1.447 ms [1.423 ms, 1.472 ms] 98.795 µs (7.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.361 ms] -
appsec 1.659 ms [1.634 ms, 1.683 ms] 316.823 µs (23.6%)
iast 1.442 ms [1.418 ms, 1.466 ms] 99.878 µs (7.4%)
profiling 1.467 ms [1.442 ms, 1.491 ms] 124.493 µs (9.3%)
tracing 1.459 ms [1.435 ms, 1.484 ms] 117.12 µs (8.7%)

@devinsba
devinsba force-pushed the bds/redshift-support branch from ace53ae to b569d43 Compare August 28, 2023 16:21
@devinsba
devinsba marked this pull request as ready for review August 28, 2023 16:21
@devinsba
devinsba requested a review from a team as a code owner August 28, 2023 16:21
nayeem-kamal
nayeem-kamal approved these changes Aug 28, 2023
View reviewed changes

@nayeem-kamal nayeem-kamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinsba devinsba added type: feature Enhancements and improvements inst: jdbc JDBC instrumentation labels Aug 28, 2023
@devinsba
devinsba merged commit db25ce9 into master Aug 28, 2023
@devinsba
devinsba deleted the bds/redshift-support branch August 28, 2023 19:20
@github-actions github-actions Bot added this to the 1.20.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes
@bantonsson bantonsson Awaiting requested review from bantonsson bantonsson is a code owner automatically assigned from DataDog/apm-java
@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java
+1 more reviewer
@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inst: jdbc JDBC instrumentation type: feature Enhancements and improvements

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

3 participants

@devinsba @mcculls @nayeem-kamal