Skip to content

Update repo URL extraction logic for Bitbucket#5766

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/fix-bitbucket-ci-tests
Aug 24, 2023
Merged

Update repo URL extraction logic for Bitbucket#5766
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/fix-bitbucket-ci-tests

Conversation

@nikita-tkachenko-datadog

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

What Does This Do

Updates CI spec tests fixtures and logic that extracts Git metadata from Bitbucket CI: when no git: repo URL is available but https: one is there, the latter is used as a fallback.

Motivation

Making sure Java tracer behaves in accordance with the CI spec

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Aug 23, 2023
@pr-commenter

pr-commenter Bot commented Aug 23, 2023

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~118962aca3 1.20.0-SNAPSHOT~f12fb46fcd
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~f12fb46fcd, baseline=1.20.0-SNAPSHOT~118962aca3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (987.38 ms) : 0, 987380
Total [baseline] (9.174 s) : 0, 9174442
Agent [candidate] (987.812 ms) : 0, 987812
Total [candidate] (9.161 s) : 0, 9161362
section appsec
Agent [baseline] (1.072 s) : 0, 1072020
Total [baseline] (9.27 s) : 0, 9270471
Agent [candidate] (1.072 s) : 0, 1072401
Total [candidate] (9.338 s) : 0, 9337838
section iast
Agent [baseline] (1.092 s) : 0, 1092154
Total [baseline] (9.421 s) : 0, 9421010
Agent [candidate] (1.092 s) : 0, 1091812
Total [candidate] (9.426 s) : 0, 9425591
section profiling
Agent [baseline] (1.164 s) : 0, 1164170
Total [baseline] (9.445 s) : 0, 9445376
Agent [candidate] (1.164 s) : 0, 1164426
Total [candidate] (9.442 s) : 0, 9442451
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 987.38 ms -
Agent appsec 1.072 s 84.64 ms (8.6%)
Agent iast 1.092 s 104.774 ms (10.6%)
Agent profiling 1.164 s 176.79 ms (17.9%)
Total tracing 9.174 s -
Total appsec 9.27 s 96.029 ms (1.0%)
Total iast 9.421 s 246.568 ms (2.7%)
Total profiling 9.445 s 270.934 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 987.812 ms -
Agent appsec 1.072 s 84.589 ms (8.6%)
Agent iast 1.092 s 104.0 ms (10.5%)
Agent profiling 1.164 s 176.614 ms (17.9%)
Total tracing 9.161 s -
Total appsec 9.338 s 176.476 ms (1.9%)
Total iast 9.426 s 264.229 ms (2.9%)
Total profiling 9.442 s 281.09 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~f12fb46fcd, baseline=1.20.0-SNAPSHOT~118962aca3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (612.456 ms) : 0, 612456
BytebuddyAgent [candidate] (612.43 ms) : 0, 612430
GlobalTracer [baseline] (283.826 ms) : 0, 283826
GlobalTracer [candidate] (284.481 ms) : 0, 284481
AppSec [baseline] (50.178 ms) : 0, 50178
AppSec [candidate] (50.035 ms) : 0, 50035
Remote Config [baseline] (683.74 µs) : 0, 684
Remote Config [candidate] (653.123 µs) : 0, 653
Telemetry [baseline] (5.968 ms) : 0, 5968
Telemetry [candidate] (6.004 ms) : 0, 6004
section appsec
BytebuddyAgent [baseline] (612.216 ms) : 0, 612216
BytebuddyAgent [candidate] (612.125 ms) : 0, 612125
GlobalTracer [baseline] (283.551 ms) : 0, 283551
GlobalTracer [candidate] (284.67 ms) : 0, 284670
AppSec [baseline] (135.516 ms) : 0, 135516
AppSec [candidate] (134.838 ms) : 0, 134838
Remote Config [baseline] (718.719 µs) : 0, 719
Remote Config [candidate] (722.342 µs) : 0, 722
Telemetry [baseline] (5.706 ms) : 0, 5706
Telemetry [candidate] (5.721 ms) : 0, 5721
section iast
BytebuddyAgent [baseline] (719.642 ms) : 0, 719642
BytebuddyAgent [candidate] (718.433 ms) : 0, 718433
GlobalTracer [baseline] (270.849 ms) : 0, 270849
GlobalTracer [candidate] (271.484 ms) : 0, 271484
AppSec [baseline] (47.227 ms) : 0, 47227
AppSec [candidate] (47.513 ms) : 0, 47513
IAST [baseline] (13.796 ms) : 0, 13796
IAST [candidate] (13.846 ms) : 0, 13846
Remote Config [baseline] (552.093 µs) : 0, 552
Remote Config [candidate] (558.903 µs) : 0, 559
Telemetry [baseline] (5.703 ms) : 0, 5703
Telemetry [candidate] (5.728 ms) : 0, 5728
section profiling
BytebuddyAgent [baseline] (629.06 ms) : 0, 629060
BytebuddyAgent [candidate] (629.036 ms) : 0, 629036
GlobalTracer [baseline] (348.054 ms) : 0, 348054
GlobalTracer [candidate] (348.54 ms) : 0, 348540
AppSec [baseline] (49.44 ms) : 0, 49440
AppSec [candidate] (49.12 ms) : 0, 49120
Remote Config [baseline] (657.136 µs) : 0, 657
Remote Config [candidate] (648.432 µs) : 0, 648
Telemetry [baseline] (5.977 ms) : 0, 5977
Telemetry [candidate] (5.953 ms) : 0, 5953
ProfilingAgent [baseline] (77.742 ms) : 0, 77742
ProfilingAgent [candidate] (77.771 ms) : 0, 77771
Profiling [baseline] (77.766 ms) : 0, 77766
Profiling [candidate] (77.795 ms) : 0, 77795
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~f12fb46fcd, baseline=1.20.0-SNAPSHOT~118962aca3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (987.484 ms) : 0, 987484
Total [baseline] (8.636 s) : 0, 8635802
Agent [candidate] (989.413 ms) : 0, 989413
Total [candidate] (8.654 s) : 0, 8653888
section appsec
Agent [baseline] (1.072 s) : 0, 1071655
Total [baseline] (8.716 s) : 0, 8715687
Agent [candidate] (1.073 s) : 0, 1072505
Total [candidate] (8.727 s) : 0, 8727181
section iast
Agent [baseline] (1.088 s) : 0, 1087880
Total [baseline] (9.154 s) : 0, 9153779
Agent [candidate] (1.092 s) : 0, 1091794
Total [candidate] (9.206 s) : 0, 9205765
section profiling
Agent [baseline] (1.157 s) : 0, 1157488
Total [baseline] (8.88 s) : 0, 8880231
Agent [candidate] (1.155 s) : 0, 1155396
Total [candidate] (8.866 s) : 0, 8865580
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 987.484 ms -
Agent appsec 1.072 s 84.171 ms (8.5%)
Agent iast 1.088 s 100.395 ms (10.2%)
Agent profiling 1.157 s 170.004 ms (17.2%)
Total tracing 8.636 s -
Total appsec 8.716 s 79.885 ms (0.9%)
Total iast 9.154 s 517.977 ms (6.0%)
Total profiling 8.88 s 244.429 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 989.413 ms -
Agent appsec 1.073 s 83.092 ms (8.4%)
Agent iast 1.092 s 102.381 ms (10.3%)
Agent profiling 1.155 s 165.983 ms (16.8%)
Total tracing 8.654 s -
Total appsec 8.727 s 73.292 ms (0.8%)
Total iast 9.206 s 551.877 ms (6.4%)
Total profiling 8.866 s 211.692 ms (2.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~f12fb46fcd, baseline=1.20.0-SNAPSHOT~118962aca3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (612.584 ms) : 0, 612584
BytebuddyAgent [candidate] (613.404 ms) : 0, 613404
GlobalTracer [baseline] (283.607 ms) : 0, 283607
GlobalTracer [candidate] (285.016 ms) : 0, 285016
AppSec [baseline] (50.327 ms) : 0, 50327
AppSec [candidate] (50.093 ms) : 0, 50093
Remote Config [baseline] (667.596 µs) : 0, 668
Remote Config [candidate] (658.646 µs) : 0, 659
Telemetry [baseline] (6.016 ms) : 0, 6016
Telemetry [candidate] (5.942 ms) : 0, 5942
section appsec
BytebuddyAgent [baseline] (611.93 ms) : 0, 611930
BytebuddyAgent [candidate] (612.397 ms) : 0, 612397
GlobalTracer [baseline] (283.76 ms) : 0, 283760
GlobalTracer [candidate] (284.392 ms) : 0, 284392
AppSec [baseline] (135.287 ms) : 0, 135287
AppSec [candidate] (134.999 ms) : 0, 134999
Remote Config [baseline] (721.947 µs) : 0, 722
Remote Config [candidate] (714.132 µs) : 0, 714
Telemetry [baseline] (5.747 ms) : 0, 5747
Telemetry [candidate] (5.772 ms) : 0, 5772
section iast
BytebuddyAgent [baseline] (716.576 ms) : 0, 716576
BytebuddyAgent [candidate] (719.146 ms) : 0, 719146
GlobalTracer [baseline] (269.858 ms) : 0, 269858
GlobalTracer [candidate] (271.102 ms) : 0, 271102
AppSec [baseline] (47.334 ms) : 0, 47334
AppSec [candidate] (47.274 ms) : 0, 47274
IAST [baseline] (13.756 ms) : 0, 13756
IAST [candidate] (13.821 ms) : 0, 13821
Remote Config [baseline] (547.414 µs) : 0, 547
Remote Config [candidate] (548.77 µs) : 0, 549
Telemetry [baseline] (5.68 ms) : 0, 5680
Telemetry [candidate] (5.649 ms) : 0, 5649
section profiling
BytebuddyAgent [baseline] (625.083 ms) : 0, 625083
BytebuddyAgent [candidate] (624.705 ms) : 0, 624705
GlobalTracer [baseline] (346.425 ms) : 0, 346425
GlobalTracer [candidate] (345.75 ms) : 0, 345750
AppSec [baseline] (49.099 ms) : 0, 49099
AppSec [candidate] (48.97 ms) : 0, 48970
Remote Config [baseline] (655.119 µs) : 0, 655
Remote Config [candidate] (644.2 µs) : 0, 644
Telemetry [baseline] (5.945 ms) : 0, 5945
Telemetry [candidate] (5.991 ms) : 0, 5991
ProfilingAgent [baseline] (77.517 ms) : 0, 77517
ProfilingAgent [candidate] (76.679 ms) : 0, 76679
Profiling [baseline] (77.541 ms) : 0, 77541
Profiling [candidate] (76.702 ms) : 0, 76702
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~118962aca3 1.20.0-SNAPSHOT~f12fb46fcd
config baseline candidate
end_time 2023-08-23T13:39:49 2023-08-23T13:57:54
start_time 2023-08-23T13:39:31 2023-08-23T13:57:36
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~f12fb46fcd, baseline=1.20.0-SNAPSHOT~118962aca3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1323, 1362
.   : milestone, 1343,
appsec (1.666 ms) : 1641, 1690
.   : milestone, 1666,
iast (1.486 ms) : 1462, 1509
.   : milestone, 1486,
profiling (1.449 ms) : 1424, 1474
.   : milestone, 1449,
tracing (1.473 ms) : 1449, 1497
.   : milestone, 1473,
section candidate
no_agent (1.33 ms) : 1311, 1350
.   : milestone, 1330,
appsec (1.694 ms) : 1670, 1718
.   : milestone, 1694,
iast (1.457 ms) : 1432, 1481
.   : milestone, 1457,
profiling (1.469 ms) : 1445, 1494
.   : milestone, 1469,
tracing (1.453 ms) : 1429, 1477
.   : milestone, 1453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.323 ms, 1.362 ms] -
appsec 1.666 ms [1.641 ms, 1.69 ms] 323.081 µs (24.1%)
iast 1.486 ms [1.462 ms, 1.509 ms] 142.983 µs (10.7%)
profiling 1.449 ms [1.424 ms, 1.474 ms] 106.279 µs (7.9%)
tracing 1.473 ms [1.449 ms, 1.497 ms] 130.535 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.33 ms [1.311 ms, 1.35 ms] -
appsec 1.694 ms [1.67 ms, 1.718 ms] 363.563 µs (27.3%)
iast 1.457 ms [1.432 ms, 1.481 ms] 126.277 µs (9.5%)
profiling 1.469 ms [1.445 ms, 1.494 ms] 139.118 µs (10.5%)
tracing 1.453 ms [1.429 ms, 1.477 ms] 122.813 µs (9.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~f12fb46fcd, baseline=1.20.0-SNAPSHOT~118962aca3
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.995 µs) : 343, 385
.   : milestone, 364,
appsec (670.861 µs) : 649, 692
.   : milestone, 671,
iast (449.191 µs) : 429, 470
.   : milestone, 449,
iast_FULL (523.065 µs) : 502, 544
.   : milestone, 523,
iast_INACTIVE (426.001 µs) : 405, 447
.   : milestone, 426,
profiling (442.818 µs) : 422, 464
.   : milestone, 443,
tracing (436.104 µs) : 415, 457
.   : milestone, 436,
section candidate
no_agent (368.275 µs) : 348, 389
.   : milestone, 368,
appsec (667.0 µs) : 647, 687
.   : milestone, 667,
iast (445.452 µs) : 425, 466
.   : milestone, 445,
iast_FULL (515.216 µs) : 495, 536
.   : milestone, 515,
iast_INACTIVE (425.995 µs) : 406, 446
.   : milestone, 426,
profiling (441.162 µs) : 420, 463
.   : milestone, 441,
tracing (431.325 µs) : 410, 452
.   : milestone, 431,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.995 µs [343.447 µs, 384.543 µs] -
appsec 670.861 µs [649.226 µs, 692.497 µs] 306.866 µs (84.3%)
iast 449.191 µs [428.671 µs, 469.711 µs] 85.196 µs (23.4%)
iast_FULL 523.065 µs [502.214 µs, 543.915 µs] 159.07 µs (43.7%)
iast_INACTIVE 426.001 µs [405.447 µs, 446.555 µs] 62.006 µs (17.0%)
profiling 442.818 µs [421.647 µs, 463.988 µs] 78.823 µs (21.7%)
tracing 436.104 µs [415.282 µs, 456.925 µs] 72.109 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.275 µs [347.654 µs, 388.896 µs] -
appsec 667.0 µs [646.702 µs, 687.298 µs] 298.725 µs (81.1%)
iast 445.452 µs [425.039 µs, 465.866 µs] 77.177 µs (21.0%)
iast_FULL 515.216 µs [494.758 µs, 535.675 µs] 146.941 µs (39.9%)
iast_INACTIVE 425.995 µs [405.593 µs, 446.396 µs] 57.719 µs (15.7%)
profiling 441.162 µs [419.709 µs, 462.615 µs] 72.887 µs (19.8%)
tracing 431.325 µs [410.287 µs, 452.363 µs] 63.05 µs (17.1%)

@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review August 23, 2023 15:09
@nikita-tkachenko-datadog
nikita-tkachenko-datadog requested a review from a team as a code owner August 23, 2023 15:09
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 65849d8 into master Aug 24, 2023
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-bitbucket-ci-tests branch August 24, 2023 07:32
@github-actions github-actions Bot added this to the 1.20.0 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@nikita-tkachenko-datadog @juan-fernandez