Elasticsearch and Opensearch should omit params by default#5749
Merged
Conversation
bm1549
added
tag: breaking change
am312
approved these changes
Aug 21, 2023
Contributor
|
@bm1549 Please use the word |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Makes it so that
elasticsearch.paramsandopensearch.paramsare omitted by defaultThe original behavior can be maintained by setting
trace.elasticsearch.body-and-params.enabledtotrueMotivation
This is beneficial in the case that they contain sensitive information
Also closes #5718
Additional Notes