Skip to content

Reduce log level for WAF timeouts#5733

Merged
cataphract merged 2 commits into
masterfrom
glopes/log-level-waf-timeout
Aug 28, 2023
Merged

Reduce log level for WAF timeouts#5733
cataphract merged 2 commits into
masterfrom
glopes/log-level-waf-timeout

Conversation

@cataphract

@cataphract cataphract commented Aug 16, 2023 •
edited by smola
Loading

Copy link
Copy Markdown
Contributor
  • Reduce log level of WAF timeouts to DEBUG.
  • Make them more explicit with Timeout calling the WAF message instead of Error calling WAF.

@cataphract cataphract added the comp: asm waf Application Security Management (WAF) label Aug 16, 2023
@cataphract
cataphract requested a review from a team as a code owner August 16, 2023 18:32
@cataphract
cataphract requested a review from jandro996 August 16, 2023 18:32
@pr-commenter

pr-commenter Bot commented Aug 16, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~d21bcc70be 1.20.0-SNAPSHOT~300c5980d0
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~300c5980d0, baseline=1.20.0-SNAPSHOT~d21bcc70be

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (987.486 ms) : 0, 987486
Total [baseline] (8.687 s) : 0, 8687465
Agent [candidate] (984.74 ms) : 0, 984740
Total [candidate] (8.627 s) : 0, 8626602
section appsec
Agent [baseline] (1.073 s) : 0, 1072589
Total [baseline] (8.713 s) : 0, 8713181
Agent [candidate] (1.07 s) : 0, 1070461
Total [candidate] (8.72 s) : 0, 8720424
section iast
Agent [baseline] (1.09 s) : 0, 1090168
Total [baseline] (9.171 s) : 0, 9170546
Agent [candidate] (1.089 s) : 0, 1088956
Total [candidate] (9.158 s) : 0, 9157566
section profiling
Agent [baseline] (1.166 s) : 0, 1165685
Total [baseline] (8.907 s) : 0, 8906996
Agent [candidate] (1.157 s) : 0, 1157382
Total [candidate] (8.85 s) : 0, 8849716
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 987.486 ms -
Agent appsec 1.073 s 85.103 ms (8.6%)
Agent iast 1.09 s 102.682 ms (10.4%)
Agent profiling 1.166 s 178.199 ms (18.0%)
Total tracing 8.687 s -
Total appsec 8.713 s 25.716 ms (0.3%)
Total iast 9.171 s 483.081 ms (5.6%)
Total profiling 8.907 s 219.53 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 984.74 ms -
Agent appsec 1.07 s 85.721 ms (8.7%)
Agent iast 1.089 s 104.217 ms (10.6%)
Agent profiling 1.157 s 172.642 ms (17.5%)
Total tracing 8.627 s -
Total appsec 8.72 s 93.822 ms (1.1%)
Total iast 9.158 s 530.964 ms (6.2%)
Total profiling 8.85 s 223.115 ms (2.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~300c5980d0, baseline=1.20.0-SNAPSHOT~d21bcc70be

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (612.62 ms) : 0, 612620
BytebuddyAgent [candidate] (610.427 ms) : 0, 610427
GlobalTracer [baseline] (283.827 ms) : 0, 283827
GlobalTracer [candidate] (283.114 ms) : 0, 283114
AppSec [baseline] (50.095 ms) : 0, 50095
AppSec [candidate] (50.331 ms) : 0, 50331
Remote Config [baseline] (661.422 µs) : 0, 661
Remote Config [candidate] (672.3 µs) : 0, 672
Telemetry [baseline] (5.965 ms) : 0, 5965
Telemetry [candidate] (5.929 ms) : 0, 5929
section appsec
BytebuddyAgent [baseline] (612.493 ms) : 0, 612493
BytebuddyAgent [candidate] (611.254 ms) : 0, 611254
GlobalTracer [baseline] (283.97 ms) : 0, 283970
GlobalTracer [candidate] (283.864 ms) : 0, 283864
AppSec [baseline] (135.335 ms) : 0, 135335
AppSec [candidate] (134.609 ms) : 0, 134609
Remote Config [baseline] (733.869 µs) : 0, 734
Remote Config [candidate] (725.7 µs) : 0, 726
Telemetry [baseline] (5.753 ms) : 0, 5753
Telemetry [candidate] (5.767 ms) : 0, 5767
section iast
BytebuddyAgent [baseline] (718.484 ms) : 0, 718484
BytebuddyAgent [candidate] (716.782 ms) : 0, 716782
GlobalTracer [baseline] (270.164 ms) : 0, 270164
GlobalTracer [candidate] (270.318 ms) : 0, 270318
AppSec [baseline] (47.042 ms) : 0, 47042
AppSec [candidate] (47.152 ms) : 0, 47152
IAST [baseline] (13.926 ms) : 0, 13926
IAST [candidate] (14.098 ms) : 0, 14098
Remote Config [baseline] (537.865 µs) : 0, 538
Remote Config [candidate] (559.096 µs) : 0, 559
Telemetry [baseline] (5.657 ms) : 0, 5657
Telemetry [candidate] (5.759 ms) : 0, 5759
section profiling
BytebuddyAgent [baseline] (629.605 ms) : 0, 629605
BytebuddyAgent [candidate] (623.691 ms) : 0, 623691
GlobalTracer [baseline] (349.645 ms) : 0, 349645
GlobalTracer [candidate] (347.721 ms) : 0, 347721
AppSec [baseline] (49.292 ms) : 0, 49292
AppSec [candidate] (49.013 ms) : 0, 49013
Remote Config [baseline] (652.244 µs) : 0, 652
Remote Config [candidate] (646.714 µs) : 0, 647
Telemetry [baseline] (6.03 ms) : 0, 6030
Telemetry [candidate] (5.97 ms) : 0, 5970
ProfilingAgent [baseline] (77.302 ms) : 0, 77302
ProfilingAgent [candidate] (77.709 ms) : 0, 77709
Profiling [baseline] (77.326 ms) : 0, 77326
Profiling [candidate] (77.733 ms) : 0, 77733
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~300c5980d0, baseline=1.20.0-SNAPSHOT~d21bcc70be

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.0 s) : 0, 1000487
Total [baseline] (9.272 s) : 0, 9271686
Agent [candidate] (989.858 ms) : 0, 989858
Total [candidate] (9.253 s) : 0, 9252800
section appsec
Agent [baseline] (1.081 s) : 0, 1081166
Total [baseline] (9.364 s) : 0, 9364474
Agent [candidate] (1.07 s) : 0, 1070320
Total [candidate] (9.32 s) : 0, 9319546
section iast
Agent [baseline] (1.099 s) : 0, 1099394
Total [baseline] (9.424 s) : 0, 9424193
Agent [candidate] (1.095 s) : 0, 1095453
Total [candidate] (9.401 s) : 0, 9400882
section profiling
Agent [baseline] (1.167 s) : 0, 1166837
Total [baseline] (9.472 s) : 0, 9472101
Agent [candidate] (1.165 s) : 0, 1165430
Total [candidate] (9.414 s) : 0, 9413613
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.0 s -
Agent appsec 1.081 s 80.679 ms (8.1%)
Agent iast 1.099 s 98.907 ms (9.9%)
Agent profiling 1.167 s 166.35 ms (16.6%)
Total tracing 9.272 s -
Total appsec 9.364 s 92.788 ms (1.0%)
Total iast 9.424 s 152.507 ms (1.6%)
Total profiling 9.472 s 200.415 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 989.858 ms -
Agent appsec 1.07 s 80.463 ms (8.1%)
Agent iast 1.095 s 105.595 ms (10.7%)
Agent profiling 1.165 s 175.572 ms (17.7%)
Total tracing 9.253 s -
Total appsec 9.32 s 66.746 ms (0.7%)
Total iast 9.401 s 148.083 ms (1.6%)
Total profiling 9.414 s 160.813 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~300c5980d0, baseline=1.20.0-SNAPSHOT~d21bcc70be

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (620.82 ms) : 0, 620820
BytebuddyAgent [candidate] (612.569 ms) : 0, 612569
GlobalTracer [baseline] (287.769 ms) : 0, 287769
GlobalTracer [candidate] (286.215 ms) : 0, 286215
AppSec [baseline] (50.457 ms) : 0, 50457
AppSec [candidate] (50.092 ms) : 0, 50092
Remote Config [baseline] (671.312 µs) : 0, 671
Remote Config [candidate] (679.852 µs) : 0, 680
Telemetry [baseline] (5.999 ms) : 0, 5999
Telemetry [candidate] (5.991 ms) : 0, 5991
section appsec
BytebuddyAgent [baseline] (617.341 ms) : 0, 617341
BytebuddyAgent [candidate] (610.933 ms) : 0, 610933
GlobalTracer [baseline] (286.537 ms) : 0, 286537
GlobalTracer [candidate] (283.739 ms) : 0, 283739
AppSec [baseline] (136.133 ms) : 0, 136133
AppSec [candidate] (134.981 ms) : 0, 134981
Remote Config [baseline] (732.826 µs) : 0, 733
Remote Config [candidate] (725.06 µs) : 0, 725
Telemetry [baseline] (5.848 ms) : 0, 5848
Telemetry [candidate] (5.736 ms) : 0, 5736
section iast
BytebuddyAgent [baseline] (724.677 ms) : 0, 724677
BytebuddyAgent [candidate] (721.227 ms) : 0, 721227
GlobalTracer [baseline] (271.942 ms) : 0, 271942
GlobalTracer [candidate] (271.856 ms) : 0, 271856
AppSec [baseline] (47.467 ms) : 0, 47467
AppSec [candidate] (47.597 ms) : 0, 47597
IAST [baseline] (14.293 ms) : 0, 14293
IAST [candidate] (14.025 ms) : 0, 14025
Remote Config [baseline] (567.768 µs) : 0, 568
Remote Config [candidate] (544.942 µs) : 0, 545
Telemetry [baseline] (5.793 ms) : 0, 5793
Telemetry [candidate] (5.689 ms) : 0, 5689
section profiling
BytebuddyAgent [baseline] (630.468 ms) : 0, 630468
BytebuddyAgent [candidate] (628.866 ms) : 0, 628866
GlobalTracer [baseline] (349.333 ms) : 0, 349333
GlobalTracer [candidate] (349.283 ms) : 0, 349283
AppSec [baseline] (49.376 ms) : 0, 49376
AppSec [candidate] (49.323 ms) : 0, 49323
Remote Config [baseline] (652.919 µs) : 0, 653
Remote Config [candidate] (646.817 µs) : 0, 647
Telemetry [baseline] (6.034 ms) : 0, 6034
Telemetry [candidate] (6.001 ms) : 0, 6001
ProfilingAgent [baseline] (77.758 ms) : 0, 77758
ProfilingAgent [candidate] (78.123 ms) : 0, 78123
Profiling [baseline] (77.782 ms) : 0, 77782
Profiling [candidate] (78.147 ms) : 0, 78147
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~d21bcc70be 1.20.0-SNAPSHOT~300c5980d0
config baseline candidate
end_time 2023-08-28T11:01:57 2023-08-28T11:20:00
start_time 2023-08-28T11:01:40 2023-08-28T11:19:42
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~300c5980d0, baseline=1.20.0-SNAPSHOT~d21bcc70be
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.11 µs) : 344, 384
.   : milestone, 364,
appsec (659.011 µs) : 638, 680
.   : milestone, 659,
iast (454.659 µs) : 434, 476
.   : milestone, 455,
iast_FULL (524.53 µs) : 503, 546
.   : milestone, 525,
iast_INACTIVE (433.396 µs) : 412, 454
.   : milestone, 433,
profiling (440.053 µs) : 419, 462
.   : milestone, 440,
tracing (429.315 µs) : 409, 450
.   : milestone, 429,
section candidate
no_agent (364.292 µs) : 342, 386
.   : milestone, 364,
appsec (660.029 µs) : 640, 680
.   : milestone, 660,
iast (452.34 µs) : 431, 473
.   : milestone, 452,
iast_FULL (525.538 µs) : 505, 546
.   : milestone, 526,
iast_INACTIVE (435.526 µs) : 414, 457
.   : milestone, 436,
profiling (428.661 µs) : 408, 449
.   : milestone, 429,
tracing (435.133 µs) : 414, 457
.   : milestone, 435,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.11 µs [344.013 µs, 384.206 µs] -
appsec 659.011 µs [638.018 µs, 680.005 µs] 294.902 µs (81.0%)
iast 454.659 µs [433.68 µs, 475.639 µs] 90.55 µs (24.9%)
iast_FULL 524.53 µs [502.735 µs, 546.325 µs] 160.42 µs (44.1%)
iast_INACTIVE 433.396 µs [412.452 µs, 454.34 µs] 69.287 µs (19.0%)
profiling 440.053 µs [418.525 µs, 461.58 µs] 75.943 µs (20.9%)
tracing 429.315 µs [408.85 µs, 449.779 µs] 65.205 µs (17.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.292 µs [342.415 µs, 386.168 µs] -
appsec 660.029 µs [639.621 µs, 680.438 µs] 295.738 µs (81.2%)
iast 452.34 µs [431.414 µs, 473.265 µs] 88.048 µs (24.2%)
iast_FULL 525.538 µs [504.708 µs, 546.368 µs] 161.246 µs (44.3%)
iast_INACTIVE 435.526 µs [414.127 µs, 456.926 µs] 71.235 µs (19.6%)
profiling 428.661 µs [407.981 µs, 449.341 µs] 64.37 µs (17.7%)
tracing 435.133 µs [413.521 µs, 456.745 µs] 70.841 µs (19.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~300c5980d0, baseline=1.20.0-SNAPSHOT~d21bcc70be
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.316 ms) : 1297, 1336
.   : milestone, 1316,
appsec (1.668 ms) : 1644, 1692
.   : milestone, 1668,
iast (1.456 ms) : 1432, 1480
.   : milestone, 1456,
profiling (1.479 ms) : 1453, 1504
.   : milestone, 1479,
tracing (1.448 ms) : 1424, 1472
.   : milestone, 1448,
section candidate
no_agent (1.325 ms) : 1306, 1344
.   : milestone, 1325,
appsec (1.691 ms) : 1667, 1715
.   : milestone, 1691,
iast (1.454 ms) : 1430, 1477
.   : milestone, 1454,
profiling (1.502 ms) : 1476, 1528
.   : milestone, 1502,
tracing (1.436 ms) : 1411, 1460
.   : milestone, 1436,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.316 ms [1.297 ms, 1.336 ms] -
appsec 1.668 ms [1.644 ms, 1.692 ms] 351.428 µs (26.7%)
iast 1.456 ms [1.432 ms, 1.48 ms] 139.602 µs (10.6%)
profiling 1.479 ms [1.453 ms, 1.504 ms] 162.408 µs (12.3%)
tracing 1.448 ms [1.424 ms, 1.472 ms] 131.936 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.325 ms [1.306 ms, 1.344 ms] -
appsec 1.691 ms [1.667 ms, 1.715 ms] 365.861 µs (27.6%)
iast 1.454 ms [1.43 ms, 1.477 ms] 128.653 µs (9.7%)
profiling 1.502 ms [1.476 ms, 1.528 ms] 177.018 µs (13.4%)
tracing 1.436 ms [1.411 ms, 1.46 ms] 110.792 µs (8.4%)

@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Aug 17, 2023
smola
smola requested changes Aug 17, 2023
View reviewed changes
Comment thread dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java Outdated
@cataphract
cataphract force-pushed the glopes/log-level-waf-timeout branch from 0b44959 to 97ca723 Compare August 18, 2023 11:36
@cataphract
cataphract requested a review from smola August 18, 2023 11:36
@cataphract
cataphract enabled auto-merge August 21, 2023 23:39
@smola
smola force-pushed the glopes/log-level-waf-timeout branch from 97ca723 to c8d9afd Compare August 24, 2023 14:59
@smola smola removed the tag: no release notes Changes to exclude from release notes label Aug 24, 2023
@cataphract
cataphract merged commit 0913d1a into master Aug 28, 2023
@cataphract
cataphract deleted the glopes/log-level-waf-timeout branch August 28, 2023 12:30
@github-actions github-actions Bot added this to the 1.20.0 milestone Aug 28, 2023
@ValentinZakharov ValentinZakharov added the tag: no release notes Changes to exclude from release notes label Aug 30, 2023
@smola smola removed the tag: no release notes Changes to exclude from release notes label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes
@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes
@jandro996 jandro996 jandro996 approved these changes

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF)

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cataphract @smola @ValentinZakharov @jandro996 @PerfectSlayer