Skip to content

Unify spark metrics naming#5723

Merged
paul-laffon-dd merged 1 commit into
masterfrom
paul.laffon/unify-spark-metrics-naming
Aug 29, 2023
Merged

Unify spark metrics naming#5723
paul-laffon-dd merged 1 commit into
masterfrom
paul.laffon/unify-spark-metrics-naming

Conversation

@paul-laffon-dd

@paul-laffon-dd paul-laffon-dd commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

What Does This Do

Spark metrics had a separate prefix for each operation (application, job, stage) which turned out to be complicated to use from the UI. This PR unifies the prefix to "spark" for all operations

There is already a processing in the backend to rename those prefix, so spans already appear with the name "spark" in datadog UI

Motivation

Additional Notes

@paul-laffon-dd
Unify spark metrics naming
f427f21 
Spark metrics had a separate prefix for each operation (application, job, stage) which turned out to be complicated to use from the UI. Unify the prefix to "spark" for all operations
@paul-laffon-dd
paul-laffon-dd force-pushed the paul.laffon/unify-spark-metrics-naming branch from bec8c65 to f427f21 Compare August 22, 2023 10:06
@pr-commenter

pr-commenter Bot commented Aug 22, 2023

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~54be81326e 1.20.0-SNAPSHOT~f427f21549
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~f427f21549, baseline=1.20.0-SNAPSHOT~54be81326e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003798
Total [baseline] (9.221 s) : 0, 9220594
Agent [candidate] (987.731 ms) : 0, 987731
Total [candidate] (9.184 s) : 0, 9184327
section appsec
Agent [baseline] (1.074 s) : 0, 1074307
Total [baseline] (9.306 s) : 0, 9305828
Agent [candidate] (1.074 s) : 0, 1073657
Total [candidate] (9.235 s) : 0, 9234959
section iast
Agent [baseline] (1.09 s) : 0, 1089639
Total [baseline] (9.435 s) : 0, 9434851
Agent [candidate] (1.087 s) : 0, 1087128
Total [candidate] (9.421 s) : 0, 9421130
section profiling
Agent [baseline] (1.165 s) : 0, 1164897
Total [baseline] (9.51 s) : 0, 9509680
Agent [candidate] (1.156 s) : 0, 1156269
Total [candidate] (9.49 s) : 0, 9489632
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.004 s -
Agent appsec 1.074 s 70.509 ms (7.0%)
Agent iast 1.09 s 85.841 ms (8.6%)
Agent profiling 1.165 s 161.099 ms (16.0%)
Total tracing 9.221 s -
Total appsec 9.306 s 85.234 ms (0.9%)
Total iast 9.435 s 214.257 ms (2.3%)
Total profiling 9.51 s 289.085 ms (3.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 987.731 ms -
Agent appsec 1.074 s 85.925 ms (8.7%)
Agent iast 1.087 s 99.396 ms (10.1%)
Agent profiling 1.156 s 168.538 ms (17.1%)
Total tracing 9.184 s -
Total appsec 9.235 s 50.633 ms (0.6%)
Total iast 9.421 s 236.803 ms (2.6%)
Total profiling 9.49 s 305.305 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~f427f21549, baseline=1.20.0-SNAPSHOT~54be81326e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (622.147 ms) : 0, 622147
BytebuddyAgent [candidate] (611.77 ms) : 0, 611770
GlobalTracer [baseline] (289.472 ms) : 0, 289472
GlobalTracer [candidate] (285.099 ms) : 0, 285099
AppSec [baseline] (50.571 ms) : 0, 50571
AppSec [candidate] (49.882 ms) : 0, 49882
Remote Config [baseline] (681.698 µs) : 0, 682
Remote Config [candidate] (666.42 µs) : 0, 666
Telemetry [baseline] (6.145 ms) : 0, 6145
Telemetry [candidate] (6.002 ms) : 0, 6002
section appsec
BytebuddyAgent [baseline] (612.376 ms) : 0, 612376
BytebuddyAgent [candidate] (612.365 ms) : 0, 612365
GlobalTracer [baseline] (285.222 ms) : 0, 285222
GlobalTracer [candidate] (285.303 ms) : 0, 285303
AppSec [baseline] (135.837 ms) : 0, 135837
AppSec [candidate] (135.097 ms) : 0, 135097
Remote Config [baseline] (727.316 µs) : 0, 727
Remote Config [candidate] (718.768 µs) : 0, 719
Telemetry [baseline] (5.801 ms) : 0, 5801
Telemetry [candidate] (5.762 ms) : 0, 5762
section iast
BytebuddyAgent [baseline] (717.94 ms) : 0, 717940
BytebuddyAgent [candidate] (715.503 ms) : 0, 715503
GlobalTracer [baseline] (269.804 ms) : 0, 269804
GlobalTracer [candidate] (270.402 ms) : 0, 270402
AppSec [baseline] (47.485 ms) : 0, 47485
AppSec [candidate] (46.797 ms) : 0, 46797
Remote Config [baseline] (567.179 µs) : 0, 567
Remote Config [candidate] (555.27 µs) : 0, 555
Telemetry [baseline] (5.723 ms) : 0, 5723
Telemetry [candidate] (5.72 ms) : 0, 5720
IAST [baseline] (13.854 ms) : 0, 13854
IAST [candidate] (13.896 ms) : 0, 13896
section profiling
BytebuddyAgent [baseline] (625.918 ms) : 0, 625918
BytebuddyAgent [candidate] (622.517 ms) : 0, 622517
GlobalTracer [baseline] (351.48 ms) : 0, 351480
GlobalTracer [candidate] (348.949 ms) : 0, 348949
AppSec [baseline] (49.582 ms) : 0, 49582
AppSec [candidate] (49.257 ms) : 0, 49257
Remote Config [baseline] (656.283 µs) : 0, 656
Remote Config [candidate] (645.916 µs) : 0, 646
Telemetry [baseline] (6.071 ms) : 0, 6071
Telemetry [candidate] (5.954 ms) : 0, 5954
ProfilingAgent [baseline] (78.236 ms) : 0, 78236
ProfilingAgent [candidate] (76.335 ms) : 0, 76335
Profiling [baseline] (78.262 ms) : 0, 78262
Profiling [candidate] (76.359 ms) : 0, 76359
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~f427f21549, baseline=1.20.0-SNAPSHOT~54be81326e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (994.191 ms) : 0, 994191
Total [baseline] (8.629 s) : 0, 8628842
Agent [candidate] (984.55 ms) : 0, 984550
Total [candidate] (8.691 s) : 0, 8690835
section appsec
Agent [baseline] (1.074 s) : 0, 1074091
Total [baseline] (8.743 s) : 0, 8743379
Agent [candidate] (1.077 s) : 0, 1076864
Total [candidate] (8.708 s) : 0, 8708086
section iast
Agent [baseline] (1.087 s) : 0, 1087121
Total [baseline] (9.171 s) : 0, 9171384
Agent [candidate] (1.089 s) : 0, 1089378
Total [candidate] (9.14 s) : 0, 9140363
section profiling
Agent [baseline] (1.159 s) : 0, 1159184
Total [baseline] (8.861 s) : 0, 8860747
Agent [candidate] (1.181 s) : 0, 1181304
Total [candidate] (8.944 s) : 0, 8943811
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 994.191 ms -
Agent appsec 1.074 s 79.9 ms (8.0%)
Agent iast 1.087 s 92.93 ms (9.3%)
Agent profiling 1.159 s 164.993 ms (16.6%)
Total tracing 8.629 s -
Total appsec 8.743 s 114.537 ms (1.3%)
Total iast 9.171 s 542.542 ms (6.3%)
Total profiling 8.861 s 231.905 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 984.55 ms -
Agent appsec 1.077 s 92.314 ms (9.4%)
Agent iast 1.089 s 104.828 ms (10.6%)
Agent profiling 1.181 s 196.755 ms (20.0%)
Total tracing 8.691 s -
Total appsec 8.708 s 17.251 ms (0.2%)
Total iast 9.14 s 449.527 ms (5.2%)
Total profiling 8.944 s 252.976 ms (2.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~f427f21549, baseline=1.20.0-SNAPSHOT~54be81326e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (615.911 ms) : 0, 615911
BytebuddyAgent [candidate] (609.646 ms) : 0, 609646
GlobalTracer [baseline] (286.413 ms) : 0, 286413
GlobalTracer [candidate] (283.526 ms) : 0, 283526
AppSec [baseline] (50.575 ms) : 0, 50575
AppSec [candidate] (50.431 ms) : 0, 50431
Remote Config [baseline] (670.968 µs) : 0, 671
Remote Config [candidate] (664.255 µs) : 0, 664
Telemetry [baseline] (6.104 ms) : 0, 6104
Telemetry [candidate] (5.999 ms) : 0, 5999
section appsec
BytebuddyAgent [baseline] (613.173 ms) : 0, 613173
BytebuddyAgent [candidate] (614.695 ms) : 0, 614695
GlobalTracer [baseline] (284.42 ms) : 0, 284420
GlobalTracer [candidate] (285.922 ms) : 0, 285922
AppSec [baseline] (135.588 ms) : 0, 135588
AppSec [candidate] (135.161 ms) : 0, 135161
Remote Config [baseline] (721.619 µs) : 0, 722
Remote Config [candidate] (721.822 µs) : 0, 722
Telemetry [baseline] (5.803 ms) : 0, 5803
Telemetry [candidate] (5.825 ms) : 0, 5825
section iast
BytebuddyAgent [baseline] (715.074 ms) : 0, 715074
BytebuddyAgent [candidate] (717.606 ms) : 0, 717606
GlobalTracer [baseline] (270.422 ms) : 0, 270422
GlobalTracer [candidate] (270.686 ms) : 0, 270686
AppSec [baseline] (47.169 ms) : 0, 47169
AppSec [candidate] (46.858 ms) : 0, 46858
Remote Config [baseline] (560.689 µs) : 0, 561
Remote Config [candidate] (537.292 µs) : 0, 537
Telemetry [baseline] (5.758 ms) : 0, 5758
Telemetry [candidate] (5.626 ms) : 0, 5626
IAST [baseline] (13.915 ms) : 0, 13915
IAST [candidate] (13.718 ms) : 0, 13718
section profiling
BytebuddyAgent [baseline] (624.395 ms) : 0, 624395
BytebuddyAgent [candidate] (635.959 ms) : 0, 635959
GlobalTracer [baseline] (349.063 ms) : 0, 349063
GlobalTracer [candidate] (355.388 ms) : 0, 355388
AppSec [baseline] (49.46 ms) : 0, 49460
AppSec [candidate] (50.019 ms) : 0, 50019
Remote Config [baseline] (642.381 µs) : 0, 642
Remote Config [candidate] (664.507 µs) : 0, 665
Telemetry [baseline] (5.96 ms) : 0, 5960
Telemetry [candidate] (6.087 ms) : 0, 6087
ProfilingAgent [baseline] (76.86 ms) : 0, 76860
ProfilingAgent [candidate] (79.106 ms) : 0, 79106
Profiling [baseline] (76.886 ms) : 0, 76886
Profiling [candidate] (79.132 ms) : 0, 79132
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~54be81326e 1.20.0-SNAPSHOT~f427f21549
config baseline candidate
end_time 2023-08-22T10:27:22 2023-08-22T10:45:26
start_time 2023-08-22T10:27:05 2023-08-22T10:45:09
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~f427f21549, baseline=1.20.0-SNAPSHOT~54be81326e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1357
.   : milestone, 1339,
appsec (1.668 ms) : 1644, 1692
.   : milestone, 1668,
iast (1.441 ms) : 1416, 1465
.   : milestone, 1441,
profiling (1.467 ms) : 1442, 1491
.   : milestone, 1467,
tracing (1.417 ms) : 1394, 1441
.   : milestone, 1417,
section candidate
no_agent (1.343 ms) : 1323, 1362
.   : milestone, 1343,
appsec (1.657 ms) : 1632, 1682
.   : milestone, 1657,
iast (1.444 ms) : 1419, 1470
.   : milestone, 1444,
profiling (1.486 ms) : 1459, 1512
.   : milestone, 1486,
tracing (1.447 ms) : 1422, 1472
.   : milestone, 1447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.357 ms] -
appsec 1.668 ms [1.644 ms, 1.692 ms] 329.623 µs (24.6%)
iast 1.441 ms [1.416 ms, 1.465 ms] 102.105 µs (7.6%)
profiling 1.467 ms [1.442 ms, 1.491 ms] 128.074 µs (9.6%)
tracing 1.417 ms [1.394 ms, 1.441 ms] 78.927 µs (5.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.323 ms, 1.362 ms] -
appsec 1.657 ms [1.632 ms, 1.682 ms] 314.389 µs (23.4%)
iast 1.444 ms [1.419 ms, 1.47 ms] 101.689 µs (7.6%)
profiling 1.486 ms [1.459 ms, 1.512 ms] 142.875 µs (10.6%)
tracing 1.447 ms [1.422 ms, 1.472 ms] 104.532 µs (7.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~f427f21549, baseline=1.20.0-SNAPSHOT~54be81326e
    dateFormat X
    axisFormat %s
section baseline
no_agent (357.139 µs) : 337, 378
.   : milestone, 357,
appsec (658.494 µs) : 638, 679
.   : milestone, 658,
iast (456.357 µs) : 435, 477
.   : milestone, 456,
iast_FULL (517.372 µs) : 497, 538
.   : milestone, 517,
iast_INACTIVE (438.361 µs) : 417, 460
.   : milestone, 438,
profiling (445.582 µs) : 424, 467
.   : milestone, 446,
tracing (423.835 µs) : 403, 445
.   : milestone, 424,
section candidate
no_agent (359.843 µs) : 339, 380
.   : milestone, 360,
appsec (655.729 µs) : 635, 676
.   : milestone, 656,
iast (449.593 µs) : 429, 470
.   : milestone, 450,
iast_FULL (518.246 µs) : 497, 539
.   : milestone, 518,
iast_INACTIVE (436.494 µs) : 415, 458
.   : milestone, 436,
profiling (443.186 µs) : 421, 465
.   : milestone, 443,
tracing (435.318 µs) : 415, 456
.   : milestone, 435,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 357.139 µs [336.503 µs, 377.776 µs] -
appsec 658.494 µs [637.701 µs, 679.287 µs] 301.354 µs (84.4%)
iast 456.357 µs [435.317 µs, 477.397 µs] 99.217 µs (27.8%)
iast_FULL 517.372 µs [496.816 µs, 537.928 µs] 160.233 µs (44.9%)
iast_INACTIVE 438.361 µs [416.919 µs, 459.804 µs] 81.222 µs (22.7%)
profiling 445.582 µs [423.987 µs, 467.177 µs] 88.442 µs (24.8%)
tracing 423.835 µs [402.966 µs, 444.704 µs] 66.696 µs (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.843 µs [339.27 µs, 380.417 µs] -
appsec 655.729 µs [635.11 µs, 676.348 µs] 295.886 µs (82.2%)
iast 449.593 µs [429.148 µs, 470.037 µs] 89.749 µs (24.9%)
iast_FULL 518.246 µs [497.434 µs, 539.058 µs] 158.403 µs (44.0%)
iast_INACTIVE 436.494 µs [415.06 µs, 457.928 µs] 76.651 µs (21.3%)
profiling 443.186 µs [421.473 µs, 464.898 µs] 83.342 µs (23.2%)
tracing 435.318 µs [414.545 µs, 456.092 µs] 75.475 µs (21.0%)

@paul-laffon-dd paul-laffon-dd added the inst: apache spark Apache Spark instrumentation label Aug 22, 2023
@paul-laffon-dd
paul-laffon-dd marked this pull request as ready for review August 22, 2023 12:25
@paul-laffon-dd
paul-laffon-dd requested a review from a team as a code owner August 22, 2023 12:25
PerfectSlayer
PerfectSlayer approved these changes Aug 29, 2023
View reviewed changes

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-laffon-dd
paul-laffon-dd merged commit 2a72c3b into master Aug 29, 2023
@paul-laffon-dd
paul-laffon-dd deleted the paul.laffon/unify-spark-metrics-naming branch August 29, 2023 08:38
@github-actions github-actions Bot added this to the 1.20.0 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

No one assigned

Labels

inst: apache spark Apache Spark instrumentation

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@paul-laffon-dd @PerfectSlayer