Skip to content

Fix exception in reactor-rabbit#5707

Merged
devinsba merged 1 commit into
masterfrom
bds/reactor-rabbitmq
Aug 10, 2023
Merged

Fix exception in reactor-rabbit#5707
devinsba merged 1 commit into
masterfrom
bds/reactor-rabbitmq

Conversation

@devinsba

@devinsba devinsba commented Aug 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Fixes #5704

Motivation

Additional Notes

@devinsba
devinsba force-pushed the bds/reactor-rabbitmq branch from b43bf5f to a7febc8 Compare August 10, 2023 15:11
@pr-commenter

This comment has been minimized.

Sign in to view
@pr-commenter

This comment has been minimized.

Sign in to view
@devinsba
devinsba force-pushed the bds/reactor-rabbitmq branch from 5b17098 to 3e5e6bf Compare August 10, 2023 16:01
@devinsba devinsba changed the title WIP - Fix reactor-rabbit Fix exception in reactor-rabbit Aug 10, 2023
@devinsba devinsba added type: bug fix Bug fix comp: core Tracer core inst: rabbitmq RabbitMQ instrumentation inst: reactor Reactor instrumentation labels Aug 10, 2023
@devinsba
devinsba marked this pull request as ready for review August 10, 2023 16:03
@devinsba
devinsba requested a review from a team as a code owner August 10, 2023 16:03
@pr-commenter

This comment has been minimized.

Sign in to view
@pr-commenter

pr-commenter Bot commented Aug 10, 2023

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~a748d30c98 1.20.0-SNAPSHOT~3e5e6bf006
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~3e5e6bf006, baseline=1.20.0-SNAPSHOT~a748d30c98

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (986.96 ms) : 0, 986960
Total [baseline] (9.21 s) : 0, 9210484
Agent [candidate] (998.74 ms) : 0, 998740
Total [candidate] (9.266 s) : 0, 9266393
section appsec
Agent [baseline] (1.071 s) : 0, 1070829
Total [baseline] (9.287 s) : 0, 9287046
Agent [candidate] (1.072 s) : 0, 1071676
Total [candidate] (9.256 s) : 0, 9256340
section iast
Agent [baseline] (1.093 s) : 0, 1093237
Total [baseline] (9.45 s) : 0, 9449911
Agent [candidate] (1.087 s) : 0, 1087058
Total [candidate] (9.44 s) : 0, 9440016
section profiling
Agent [baseline] (1.154 s) : 0, 1154384
Total [baseline] (9.484 s) : 0, 9484402
Agent [candidate] (1.157 s) : 0, 1157113
Total [candidate] (9.492 s) : 0, 9491757
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 986.96 ms -
Agent appsec 1.071 s 83.869 ms (8.5%)
Agent iast 1.093 s 106.277 ms (10.8%)
Agent profiling 1.154 s 167.424 ms (17.0%)
Total tracing 9.21 s -
Total appsec 9.287 s 76.562 ms (0.8%)
Total iast 9.45 s 239.427 ms (2.6%)
Total profiling 9.484 s 273.918 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 998.74 ms -
Agent appsec 1.072 s 72.936 ms (7.3%)
Agent iast 1.087 s 88.318 ms (8.8%)
Agent profiling 1.157 s 158.373 ms (15.9%)
Total tracing 9.266 s -
Total appsec 9.256 s -10.053 ms (-0.1%)
Total iast 9.44 s 173.623 ms (1.9%)
Total profiling 9.492 s 225.365 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~3e5e6bf006, baseline=1.20.0-SNAPSHOT~a748d30c98

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (611.516 ms) : 0, 611516
BytebuddyAgent [candidate] (618.527 ms) : 0, 618527
GlobalTracer [baseline] (284.804 ms) : 0, 284804
GlobalTracer [candidate] (289.051 ms) : 0, 289051
AppSec [baseline] (50.206 ms) : 0, 50206
AppSec [candidate] (50.469 ms) : 0, 50469
Remote Config [baseline] (679.769 µs) : 0, 680
Remote Config [candidate] (676.705 µs) : 0, 677
Telemetry [baseline] (5.42 ms) : 0, 5420
Telemetry [candidate] (5.449 ms) : 0, 5449
section appsec
BytebuddyAgent [baseline] (610.776 ms) : 0, 610776
BytebuddyAgent [candidate] (611.048 ms) : 0, 611048
GlobalTracer [baseline] (284.403 ms) : 0, 284403
GlobalTracer [candidate] (284.734 ms) : 0, 284734
AppSec [baseline] (135.468 ms) : 0, 135468
AppSec [candidate] (135.593 ms) : 0, 135593
Remote Config [baseline] (727.809 µs) : 0, 728
Remote Config [candidate] (723.552 µs) : 0, 724
Telemetry [baseline] (5.158 ms) : 0, 5158
Telemetry [candidate] (5.143 ms) : 0, 5143
section iast
BytebuddyAgent [baseline] (718.318 ms) : 0, 718318
BytebuddyAgent [candidate] (714.131 ms) : 0, 714131
GlobalTracer [baseline] (272.837 ms) : 0, 272837
GlobalTracer [candidate] (271.418 ms) : 0, 271418
AppSec [baseline] (47.317 ms) : 0, 47317
AppSec [candidate] (46.935 ms) : 0, 46935
Remote Config [baseline] (638.29 µs) : 0, 638
Remote Config [candidate] (640.461 µs) : 0, 640
Telemetry [baseline] (5.531 ms) : 0, 5531
Telemetry [candidate] (5.576 ms) : 0, 5576
IAST [baseline] (14.014 ms) : 0, 14014
IAST [candidate] (13.985 ms) : 0, 13985
section profiling
ProfilingAgent [baseline] (74.531 ms) : 0, 74531
ProfilingAgent [candidate] (76.112 ms) : 0, 76112
BytebuddyAgent [baseline] (623.127 ms) : 0, 623127
BytebuddyAgent [candidate] (623.305 ms) : 0, 623305
GlobalTracer [baseline] (348.689 ms) : 0, 348689
GlobalTracer [candidate] (349.653 ms) : 0, 349653
AppSec [baseline] (49.276 ms) : 0, 49276
AppSec [candidate] (49.321 ms) : 0, 49321
Remote Config [baseline] (654.204 µs) : 0, 654
Remote Config [candidate] (653.341 µs) : 0, 653
Telemetry [baseline] (5.38 ms) : 0, 5380
Telemetry [candidate] (5.384 ms) : 0, 5384
Profiling [baseline] (74.556 ms) : 0, 74556
Profiling [candidate] (76.136 ms) : 0, 76136
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~3e5e6bf006, baseline=1.20.0-SNAPSHOT~a748d30c98

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1005717
Total [baseline] (8.732 s) : 0, 8732163
Agent [candidate] (992.548 ms) : 0, 992548
Total [candidate] (8.665 s) : 0, 8664882
section appsec
Agent [baseline] (1.069 s) : 0, 1068545
Total [baseline] (8.766 s) : 0, 8766193
Agent [candidate] (1.082 s) : 0, 1082253
Total [candidate] (8.768 s) : 0, 8767703
section iast
Agent [baseline] (1.084 s) : 0, 1083811
Total [baseline] (9.159 s) : 0, 9158936
Agent [candidate] (1.083 s) : 0, 1083279
Total [candidate] (9.146 s) : 0, 9145626
section profiling
Agent [baseline] (1.158 s) : 0, 1158158
Total [baseline] (8.934 s) : 0, 8933540
Agent [candidate] (1.163 s) : 0, 1163466
Total [candidate] (8.923 s) : 0, 8922516
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.006 s -
Agent appsec 1.069 s 62.828 ms (6.2%)
Agent iast 1.084 s 78.094 ms (7.8%)
Agent profiling 1.158 s 152.441 ms (15.2%)
Total tracing 8.732 s -
Total appsec 8.766 s 34.031 ms (0.4%)
Total iast 9.159 s 426.773 ms (4.9%)
Total profiling 8.934 s 201.377 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 992.548 ms -
Agent appsec 1.082 s 89.704 ms (9.0%)
Agent iast 1.083 s 90.73 ms (9.1%)
Agent profiling 1.163 s 170.918 ms (17.2%)
Total tracing 8.665 s -
Total appsec 8.768 s 102.821 ms (1.2%)
Total iast 9.146 s 480.744 ms (5.5%)
Total profiling 8.923 s 257.634 ms (3.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~3e5e6bf006, baseline=1.20.0-SNAPSHOT~a748d30c98

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (624.223 ms) : 0, 624223
BytebuddyAgent [candidate] (615.204 ms) : 0, 615204
GlobalTracer [baseline] (289.714 ms) : 0, 289714
GlobalTracer [candidate] (286.473 ms) : 0, 286473
AppSec [baseline] (50.356 ms) : 0, 50356
AppSec [candidate] (50.269 ms) : 0, 50269
Remote Config [baseline] (679.727 µs) : 0, 680
Remote Config [candidate] (668.964 µs) : 0, 669
Telemetry [baseline] (5.517 ms) : 0, 5517
Telemetry [candidate] (5.408 ms) : 0, 5408
section appsec
BytebuddyAgent [baseline] (610.104 ms) : 0, 610104
BytebuddyAgent [candidate] (617.791 ms) : 0, 617791
GlobalTracer [baseline] (283.708 ms) : 0, 283708
GlobalTracer [candidate] (288.554 ms) : 0, 288554
AppSec [baseline] (134.592 ms) : 0, 134592
AppSec [candidate] (135.299 ms) : 0, 135299
Remote Config [baseline] (738.625 µs) : 0, 739
Remote Config [candidate] (729.802 µs) : 0, 730
Telemetry [baseline] (5.15 ms) : 0, 5150
Telemetry [candidate] (5.182 ms) : 0, 5182
section iast
BytebuddyAgent [baseline] (711.673 ms) : 0, 711673
BytebuddyAgent [candidate] (711.049 ms) : 0, 711049
GlobalTracer [baseline] (270.622 ms) : 0, 270622
GlobalTracer [candidate] (271.012 ms) : 0, 271012
AppSec [baseline] (47.058 ms) : 0, 47058
AppSec [candidate] (47.018 ms) : 0, 47018
Remote Config [baseline] (640.391 µs) : 0, 640
Remote Config [candidate] (659.691 µs) : 0, 660
Telemetry [baseline] (5.575 ms) : 0, 5575
Telemetry [candidate] (5.433 ms) : 0, 5433
IAST [baseline] (13.951 ms) : 0, 13951
IAST [candidate] (13.915 ms) : 0, 13915
section profiling
ProfilingAgent [baseline] (75.053 ms) : 0, 75053
ProfilingAgent [candidate] (75.142 ms) : 0, 75142
BytebuddyAgent [baseline] (623.834 ms) : 0, 623834
BytebuddyAgent [candidate] (627.586 ms) : 0, 627586
GlobalTracer [baseline] (351.039 ms) : 0, 351039
GlobalTracer [candidate] (351.691 ms) : 0, 351691
AppSec [baseline] (49.301 ms) : 0, 49301
AppSec [candidate] (49.708 ms) : 0, 49708
Remote Config [baseline] (662.284 µs) : 0, 662
Remote Config [candidate] (660.547 µs) : 0, 661
Telemetry [baseline] (5.431 ms) : 0, 5431
Telemetry [candidate] (5.406 ms) : 0, 5406
Profiling [baseline] (75.077 ms) : 0, 75077
Profiling [candidate] (75.166 ms) : 0, 75166
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~a748d30c98 1.20.0-SNAPSHOT~3e5e6bf006
config baseline candidate
end_time 2023-08-10T16:22:25 2023-08-10T16:40:32
start_time 2023-08-10T16:22:08 2023-08-10T16:40:14
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~3e5e6bf006, baseline=1.20.0-SNAPSHOT~a748d30c98
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.334 ms) : 1315, 1353
.   : milestone, 1334,
appsec (1.679 ms) : 1654, 1703
.   : milestone, 1679,
iast (1.459 ms) : 1435, 1483
.   : milestone, 1459,
profiling (1.449 ms) : 1425, 1474
.   : milestone, 1449,
tracing (1.445 ms) : 1421, 1469
.   : milestone, 1445,
section candidate
no_agent (1.354 ms) : 1335, 1374
.   : milestone, 1354,
appsec (1.687 ms) : 1662, 1711
.   : milestone, 1687,
iast (1.459 ms) : 1435, 1484
.   : milestone, 1459,
profiling (1.493 ms) : 1467, 1518
.   : milestone, 1493,
tracing (1.451 ms) : 1427, 1476
.   : milestone, 1451,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.353 ms] -
appsec 1.679 ms [1.654 ms, 1.703 ms] 344.715 µs (25.8%)
iast 1.459 ms [1.435 ms, 1.483 ms] 125.281 µs (9.4%)
profiling 1.449 ms [1.425 ms, 1.474 ms] 115.153 µs (8.6%)
tracing 1.445 ms [1.421 ms, 1.469 ms] 110.761 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.374 ms] -
appsec 1.687 ms [1.662 ms, 1.711 ms] 332.367 µs (24.5%)
iast 1.459 ms [1.435 ms, 1.484 ms] 105.126 µs (7.8%)
profiling 1.493 ms [1.467 ms, 1.518 ms] 138.562 µs (10.2%)
tracing 1.451 ms [1.427 ms, 1.476 ms] 97.24 µs (7.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~3e5e6bf006, baseline=1.20.0-SNAPSHOT~a748d30c98
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.837 µs) : 341, 381
.   : milestone, 361,
appsec (661.908 µs) : 641, 683
.   : milestone, 662,
iast (460.16 µs) : 439, 481
.   : milestone, 460,
iast_FULL (526.092 µs) : 505, 547
.   : milestone, 526,
iast_INACTIVE (434.702 µs) : 414, 456
.   : milestone, 435,
profiling (439.358 µs) : 418, 461
.   : milestone, 439,
tracing (441.711 µs) : 421, 462
.   : milestone, 442,
section candidate
no_agent (365.239 µs) : 345, 385
.   : milestone, 365,
appsec (659.447 µs) : 639, 680
.   : milestone, 659,
iast (462.273 µs) : 442, 483
.   : milestone, 462,
iast_FULL (524.414 µs) : 503, 545
.   : milestone, 524,
iast_INACTIVE (442.486 µs) : 421, 464
.   : milestone, 442,
profiling (436.733 µs) : 416, 457
.   : milestone, 437,
tracing (441.962 µs) : 420, 464
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.837 µs [340.902 µs, 380.772 µs] -
appsec 661.908 µs [641.242 µs, 682.574 µs] 301.071 µs (83.4%)
iast 460.16 µs [438.846 µs, 481.475 µs] 99.324 µs (27.5%)
iast_FULL 526.092 µs [505.345 µs, 546.839 µs] 165.255 µs (45.8%)
iast_INACTIVE 434.702 µs [413.638 µs, 455.765 µs] 73.865 µs (20.5%)
profiling 439.358 µs [417.678 µs, 461.038 µs] 78.521 µs (21.8%)
tracing 441.711 µs [421.025 µs, 462.397 µs] 80.874 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.239 µs [345.244 µs, 385.234 µs] -
appsec 659.447 µs [639.016 µs, 679.877 µs] 294.208 µs (80.6%)
iast 462.273 µs [441.694 µs, 482.853 µs] 97.034 µs (26.6%)
iast_FULL 524.414 µs [503.445 µs, 545.382 µs] 159.174 µs (43.6%)
iast_INACTIVE 442.486 µs [420.914 µs, 464.057 µs] 77.247 µs (21.1%)
profiling 436.733 µs [416.221 µs, 457.245 µs] 71.494 µs (19.6%)
tracing 441.962 µs [419.925 µs, 464.0 µs] 76.723 µs (21.0%)

nayeem-kamal
nayeem-kamal approved these changes Aug 10, 2023
View reviewed changes

@nayeem-kamal nayeem-kamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinsba
devinsba merged commit d4ab230 into master Aug 10, 2023
@devinsba
devinsba deleted the bds/reactor-rabbitmq branch August 10, 2023 19:07
@github-actions github-actions Bot added this to the 1.20.0 milestone Aug 10, 2023
@devinsba devinsba removed the comp: core Tracer core label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inst: rabbitmq RabbitMQ instrumentation inst: reactor Reactor instrumentation type: bug fix Bug fix

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

Reactor RabbitMQ Sender throws Exception when using DD agent

2 participants

@devinsba @nayeem-kamal