Skip to content

add _dd.base_service to disambiguate service map#5701

Merged
amarziali merged 1 commit into
masterfrom
andrea.marziali/dd_base_service
Aug 16, 2023
Merged

add _dd.base_service to disambiguate service map#5701
amarziali merged 1 commit into
masterfrom
andrea.marziali/dd_base_service

Conversation

@amarziali

@amarziali amarziali commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

What Does This Do

When the service name is different to the configured one (DD_SERVICE) we add a tag _dd.base_service that's used internally to improve the service map

Motivation

Additional Notes

@amarziali
amarziali requested a review from a team as a code owner August 9, 2023 09:43
@amarziali
amarziali force-pushed the andrea.marziali/dd_base_service branch 3 times, most recently from eac62ce to e91a1ee Compare August 9, 2023 12:58
@pr-commenter

pr-commenter Bot commented Aug 9, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~78d3f137c8 1.20.0-SNAPSHOT~b1b3f37f7c
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 61 cases.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:petclinic:iast:IAST better
[-1093.600µs; -493.097µs] or [-7.744%; -3.492%]		 13.328ms 14.121ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~b1b3f37f7c, baseline=1.20.0-SNAPSHOT~78d3f137c8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (997.685 ms) : 0, 997685
Total [baseline] (8.714 s) : 0, 8713947
Agent [candidate] (987.765 ms) : 0, 987765
Total [candidate] (8.636 s) : 0, 8636108
section appsec
Agent [baseline] (1.071 s) : 0, 1071132
Total [baseline] (8.736 s) : 0, 8735722
Agent [candidate] (1.071 s) : 0, 1071354
Total [candidate] (8.712 s) : 0, 8711889
section iast
Agent [baseline] (1.085 s) : 0, 1085185
Total [baseline] (9.181 s) : 0, 9180577
Agent [candidate] (1.093 s) : 0, 1093239
Total [candidate] (9.174 s) : 0, 9174390
section profiling
Agent [baseline] (1.154 s) : 0, 1153847
Total [baseline] (8.884 s) : 0, 8883883
Agent [candidate] (1.153 s) : 0, 1152876
Total [candidate] (8.881 s) : 0, 8880713
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 997.685 ms -
Agent appsec 1.071 s 73.447 ms (7.4%)
Agent iast 1.085 s 87.5 ms (8.8%)
Agent profiling 1.154 s 156.162 ms (15.7%)
Total tracing 8.714 s -
Total appsec 8.736 s 21.774 ms (0.2%)
Total iast 9.181 s 466.63 ms (5.4%)
Total profiling 8.884 s 169.935 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 987.765 ms -
Agent appsec 1.071 s 83.59 ms (8.5%)
Agent iast 1.093 s 105.474 ms (10.7%)
Agent profiling 1.153 s 165.112 ms (16.7%)
Total tracing 8.636 s -
Total appsec 8.712 s 75.781 ms (0.9%)
Total iast 9.174 s 538.282 ms (6.2%)
Total profiling 8.881 s 244.605 ms (2.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~b1b3f37f7c, baseline=1.20.0-SNAPSHOT~78d3f137c8

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (616.482 ms) : 0, 616482
BytebuddyAgent [candidate] (611.376 ms) : 0, 611376
GlobalTracer [baseline] (289.807 ms) : 0, 289807
GlobalTracer [candidate] (285.206 ms) : 0, 285206
AppSec [baseline] (50.563 ms) : 0, 50563
AppSec [candidate] (50.672 ms) : 0, 50672
Remote Config [baseline] (686.655 µs) : 0, 687
Remote Config [candidate] (673.901 µs) : 0, 674
Telemetry [baseline] (5.514 ms) : 0, 5514
Telemetry [candidate] (5.46 ms) : 0, 5460
section appsec
BytebuddyAgent [baseline] (610.482 ms) : 0, 610482
BytebuddyAgent [candidate] (611.202 ms) : 0, 611202
GlobalTracer [baseline] (284.602 ms) : 0, 284602
GlobalTracer [candidate] (284.446 ms) : 0, 284446
AppSec [baseline] (135.846 ms) : 0, 135846
AppSec [candidate] (135.485 ms) : 0, 135485
Remote Config [baseline] (726.021 µs) : 0, 726
Remote Config [candidate] (727.101 µs) : 0, 727
Telemetry [baseline] (5.18 ms) : 0, 5180
Telemetry [candidate] (5.212 ms) : 0, 5212
section iast
BytebuddyAgent [baseline] (713.21 ms) : 0, 713210
BytebuddyAgent [candidate] (718.408 ms) : 0, 718408
GlobalTracer [baseline] (270.412 ms) : 0, 270412
GlobalTracer [candidate] (273.656 ms) : 0, 273656
AppSec [baseline] (47.072 ms) : 0, 47072
AppSec [candidate] (47.082 ms) : 0, 47082
Remote Config [baseline] (636.262 µs) : 0, 636
Remote Config [candidate] (636.589 µs) : 0, 637
Telemetry [baseline] (5.564 ms) : 0, 5564
Telemetry [candidate] (5.53 ms) : 0, 5530
IAST [baseline] (13.941 ms) : 0, 13941
IAST [candidate] (13.378 ms) : 0, 13378
section profiling
ProfilingAgent [baseline] (76.04 ms) : 0, 76040
ProfilingAgent [candidate] (74.829 ms) : 0, 74829
BytebuddyAgent [baseline] (621.17 ms) : 0, 621170
BytebuddyAgent [candidate] (621.711 ms) : 0, 621711
GlobalTracer [baseline] (348.673 ms) : 0, 348673
GlobalTracer [candidate] (348.631 ms) : 0, 348631
AppSec [baseline] (49.281 ms) : 0, 49281
AppSec [candidate] (49.094 ms) : 0, 49094
Remote Config [baseline] (655.222 µs) : 0, 655
Remote Config [candidate] (657.048 µs) : 0, 657
Telemetry [baseline] (5.355 ms) : 0, 5355
Telemetry [candidate] (5.361 ms) : 0, 5361
Profiling [baseline] (76.064 ms) : 0, 76064
Profiling [candidate] (74.853 ms) : 0, 74853
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~b1b3f37f7c, baseline=1.20.0-SNAPSHOT~78d3f137c8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (990.493 ms) : 0, 990493
Total [baseline] (9.187 s) : 0, 9187374
Agent [candidate] (986.407 ms) : 0, 986407
Total [candidate] (9.157 s) : 0, 9156749
section appsec
Agent [baseline] (1.07 s) : 0, 1070347
Total [baseline] (9.264 s) : 0, 9264097
Agent [candidate] (1.071 s) : 0, 1070767
Total [candidate] (9.255 s) : 0, 9255447
section iast
Agent [baseline] (1.092 s) : 0, 1091859
Total [baseline] (9.465 s) : 0, 9464909
Agent [candidate] (1.087 s) : 0, 1086582
Total [candidate] (9.485 s) : 0, 9484758
section profiling
Agent [baseline] (1.157 s) : 0, 1156794
Total [baseline] (9.506 s) : 0, 9506236
Agent [candidate] (1.155 s) : 0, 1155425
Total [candidate] (9.461 s) : 0, 9461360
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 990.493 ms -
Agent appsec 1.07 s 79.853 ms (8.1%)
Agent iast 1.092 s 101.365 ms (10.2%)
Agent profiling 1.157 s 166.301 ms (16.8%)
Total tracing 9.187 s -
Total appsec 9.264 s 76.723 ms (0.8%)
Total iast 9.465 s 277.535 ms (3.0%)
Total profiling 9.506 s 318.862 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 986.407 ms -
Agent appsec 1.071 s 84.36 ms (8.6%)
Agent iast 1.087 s 100.175 ms (10.2%)
Agent profiling 1.155 s 169.018 ms (17.1%)
Total tracing 9.157 s -
Total appsec 9.255 s 98.698 ms (1.1%)
Total iast 9.485 s 328.009 ms (3.6%)
Total profiling 9.461 s 304.612 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~b1b3f37f7c, baseline=1.20.0-SNAPSHOT~78d3f137c8

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (614.331 ms) : 0, 614331
BytebuddyAgent [candidate] (610.479 ms) : 0, 610479
GlobalTracer [baseline] (285.587 ms) : 0, 285587
GlobalTracer [candidate] (285.154 ms) : 0, 285154
AppSec [baseline] (50.055 ms) : 0, 50055
AppSec [candidate] (50.474 ms) : 0, 50474
Remote Config [baseline] (660.415 µs) : 0, 660
Remote Config [candidate] (661.634 µs) : 0, 662
Telemetry [baseline] (5.411 ms) : 0, 5411
Telemetry [candidate] (5.383 ms) : 0, 5383
section appsec
BytebuddyAgent [baseline] (610.877 ms) : 0, 610877
BytebuddyAgent [candidate] (610.37 ms) : 0, 610370
GlobalTracer [baseline] (284.05 ms) : 0, 284050
GlobalTracer [candidate] (284.896 ms) : 0, 284896
AppSec [baseline] (135.328 ms) : 0, 135328
AppSec [candidate] (135.419 ms) : 0, 135419
Remote Config [baseline] (724.391 µs) : 0, 724
Remote Config [candidate] (722.505 µs) : 0, 723
Telemetry [baseline] (5.142 ms) : 0, 5142
Telemetry [candidate] (5.146 ms) : 0, 5146
section iast
BytebuddyAgent [baseline] (717.126 ms) : 0, 717126
BytebuddyAgent [candidate] (713.708 ms) : 0, 713708
GlobalTracer [baseline] (272.521 ms) : 0, 272521
GlobalTracer [candidate] (271.69 ms) : 0, 271690
AppSec [baseline] (47.458 ms) : 0, 47458
AppSec [candidate] (47.273 ms) : 0, 47273
Remote Config [baseline] (642.841 µs) : 0, 643
Remote Config [candidate] (644.937 µs) : 0, 645
Telemetry [baseline] (5.554 ms) : 0, 5554
Telemetry [candidate] (5.557 ms) : 0, 5557
IAST [baseline] (14.121 ms) : 0, 14121
IAST [candidate] (13.328 ms) : 0, 13328
section profiling
ProfilingAgent [baseline] (76.335 ms) : 0, 76335
ProfilingAgent [candidate] (75.49 ms) : 0, 75490
BytebuddyAgent [baseline] (623.082 ms) : 0, 623082
BytebuddyAgent [candidate] (622.195 ms) : 0, 622195
GlobalTracer [baseline] (349.429 ms) : 0, 349429
GlobalTracer [candidate] (349.874 ms) : 0, 349874
AppSec [baseline] (49.12 ms) : 0, 49120
AppSec [candidate] (49.188 ms) : 0, 49188
Remote Config [baseline] (651.115 µs) : 0, 651
Remote Config [candidate] (649.07 µs) : 0, 649
Telemetry [baseline] (5.372 ms) : 0, 5372
Telemetry [candidate] (5.362 ms) : 0, 5362
Profiling [baseline] (76.359 ms) : 0, 76359
Profiling [candidate] (75.513 ms) : 0, 75513
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~78d3f137c8 1.20.0-SNAPSHOT~b1b3f37f7c
config baseline candidate
end_time 2023-08-16T09:51:00 2023-08-16T10:09:06
start_time 2023-08-16T09:50:43 2023-08-16T10:08:48
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~b1b3f37f7c, baseline=1.20.0-SNAPSHOT~78d3f137c8
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.428 µs) : 345, 386
.   : milestone, 365,
appsec (660.987 µs) : 640, 682
.   : milestone, 661,
iast (466.344 µs) : 445, 487
.   : milestone, 466,
iast_FULL (526.437 µs) : 506, 547
.   : milestone, 526,
iast_INACTIVE (434.184 µs) : 413, 455
.   : milestone, 434,
profiling (443.415 µs) : 422, 465
.   : milestone, 443,
tracing (439.429 µs) : 418, 461
.   : milestone, 439,
section candidate
no_agent (367.673 µs) : 348, 388
.   : milestone, 368,
appsec (665.622 µs) : 645, 686
.   : milestone, 666,
iast (455.022 µs) : 434, 476
.   : milestone, 455,
iast_FULL (524.029 µs) : 503, 545
.   : milestone, 524,
iast_INACTIVE (435.76 µs) : 415, 456
.   : milestone, 436,
profiling (443.012 µs) : 421, 465
.   : milestone, 443,
tracing (434.251 µs) : 414, 455
.   : milestone, 434,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.428 µs [345.03 µs, 385.826 µs] -
appsec 660.987 µs [640.454 µs, 681.52 µs] 295.559 µs (80.9%)
iast 466.344 µs [445.342 µs, 487.346 µs] 100.916 µs (27.6%)
iast_FULL 526.437 µs [505.591 µs, 547.282 µs] 161.009 µs (44.1%)
iast_INACTIVE 434.184 µs [413.259 µs, 455.108 µs] 68.756 µs (18.8%)
profiling 443.415 µs [422.043 µs, 464.788 µs] 77.987 µs (21.3%)
tracing 439.429 µs [418.336 µs, 460.522 µs] 74.001 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.673 µs [347.703 µs, 387.644 µs] -
appsec 665.622 µs [645.432 µs, 685.813 µs] 297.949 µs (81.0%)
iast 455.022 µs [433.847 µs, 476.197 µs] 87.349 µs (23.8%)
iast_FULL 524.029 µs [503.309 µs, 544.749 µs] 156.355 µs (42.5%)
iast_INACTIVE 435.76 µs [415.081 µs, 456.44 µs] 68.087 µs (18.5%)
profiling 443.012 µs [421.413 µs, 464.611 µs] 75.338 µs (20.5%)
tracing 434.251 µs [413.796 µs, 454.707 µs] 66.578 µs (18.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~b1b3f37f7c, baseline=1.20.0-SNAPSHOT~78d3f137c8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.316 ms) : 1297, 1336
.   : milestone, 1316,
appsec (1.666 ms) : 1642, 1690
.   : milestone, 1666,
iast (1.467 ms) : 1443, 1491
.   : milestone, 1467,
profiling (1.476 ms) : 1450, 1502
.   : milestone, 1476,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
section candidate
no_agent (1.354 ms) : 1334, 1373
.   : milestone, 1354,
appsec (1.7 ms) : 1675, 1724
.   : milestone, 1700,
iast (1.47 ms) : 1446, 1494
.   : milestone, 1470,
profiling (1.458 ms) : 1432, 1483
.   : milestone, 1458,
tracing (1.448 ms) : 1423, 1472
.   : milestone, 1448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.316 ms [1.297 ms, 1.336 ms] -
appsec 1.666 ms [1.642 ms, 1.69 ms] 349.543 µs (26.6%)
iast 1.467 ms [1.443 ms, 1.491 ms] 150.254 µs (11.4%)
profiling 1.476 ms [1.45 ms, 1.502 ms] 159.922 µs (12.1%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 154.417 µs (11.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.334 ms, 1.373 ms] -
appsec 1.7 ms [1.675 ms, 1.724 ms] 345.817 µs (25.5%)
iast 1.47 ms [1.446 ms, 1.494 ms] 116.114 µs (8.6%)
profiling 1.458 ms [1.432 ms, 1.483 ms] 104.074 µs (7.7%)
tracing 1.448 ms [1.423 ms, 1.472 ms] 94.17 µs (7.0%)

@amarziali amarziali added the comp: core Tracer core label Aug 10, 2023
devinsba
devinsba approved these changes Aug 14, 2023
View reviewed changes
Comment thread dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java Outdated
@amarziali
amarziali force-pushed the andrea.marziali/dd_base_service branch from e91a1ee to b1b3f37 Compare August 16, 2023 09:28
@amarziali
amarziali merged commit ab13938 into master Aug 16, 2023
@amarziali
amarziali deleted the andrea.marziali/dd_base_service branch August 16, 2023 14:24
@github-actions github-actions Bot added this to the 1.20.0 milestone Aug 16, 2023
@ValentinZakharov ValentinZakharov added the tag: no release notes Changes to exclude from release notes label Aug 30, 2023
@smola smola removed the tag: no release notes Changes to exclude from release notes label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@devinsba devinsba devinsba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: core Tracer core

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amarziali @devinsba @smola @ValentinZakharov