Add more org.owasp.esapi.Encoder escape functions tainting support#5624
Merged
Conversation
jandro996
changed the title
BenchmarksParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 21 cases.
|
jandro996
marked this pull request as ready for review
July 24, 2023 11:42
| return result; | ||
| } | ||
|
|
||
| @CallSite.After("java.lang.String org.owasp.esapi.Encoder.canonicalize(java.lang.String)") |
There was a problem hiding this comment.
I miss some smoke tests to validate that we don't trigger XSS vulnerabilities when the encoder is used
Member
Author
There was a problem hiding this comment.
Probably the best place to test that are smoke test as each piece of code is unitary tested. I will extend this comment to all the escape function instrumentation PRs so maybe the best approach is to create a new PR with this new smoke tests. @smola do you agree with that?
manuel-alvarez-alvarez
approved these changes
Jul 29, 2023
smola
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add taint tracking support to:
Motivation
Additional Notes