Fix log template issue for duplicated line probes#5620
Merged
Conversation
Having 2 line probes on the same location with same template or accessing the same field, arg or var result in an error evaluating the template. With line probe, the freeze/commit of the data is done just after the evaluation per probe id. The fix is to perform 2 loops on the probe ids, first only evaluation and then commit.
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
shatzi
approved these changes
Aug 21, 2023
shatzi
left a comment
shatzi
left a comment
Contributor
There was a problem hiding this comment.
should we assert not call evaluate if the probed was committed already? or the unit test is enough?
Member
Author
unit test is enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
With line probe, the freeze/commit of the data is done just after the evaluation per probe id.
The fix is to perform 2 loops on the probe ids, first only evaluation and then commit.
Motivation
Having 2 line probes on the same location with same template or accessing the same field, arg or var result in an error evaluating the template.
Additional Notes