Skip to content

Fix :dd-smoke-tests:wildfly build#5230

Merged
smola merged 1 commit into
masterfrom
smola/fix-wildfly-smoke-test-build
May 18, 2023
Merged

Fix :dd-smoke-tests:wildfly build#5230
smola merged 1 commit into
masterfrom
smola/fix-wildfly-smoke-test-build

Conversation

@smola

@smola smola commented May 17, 2023

Copy link
Copy Markdown
Member

What Does This Do

Motivation

See:

A problem was found with the configuration of task ':dd-smoke-tests:wildfly:unzip' (type 'Copy').
  - Gradle detected a problem with the following location: '/home/circleci/dd-trace-java/workspace/dd-smoke-tests/wildfly/build'.

    Reason: Task ':dd-smoke-tests:wildfly:compileTestGroovy' uses this output of task ':dd-smoke-tests:wildfly:unzip' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':dd-smoke-tests:wildfly:unzip' as an input of ':dd-smoke-tests:wildfly:compileTestGroovy'.
      2. Declare an explicit dependency on ':dd-smoke-tests:wildfly:unzip' from ':dd-smoke-tests:wildfly:compileTestGroovy' using Task#dependsOn. 3. Declare an explicit dependency on ':dd-smoke-tests:wildfly:unzip' from ':dd-smoke-tests:wildfly:compileTestGroovy' using Task#mustRunAfter.

    Please refer to https://docs.gradle.org/8.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Additional Notes

See:
A problem was found with the configuration of task ':dd-smoke-tests:wildfly:unzip' (type 'Copy').
  - Gradle detected a problem with the following location: '/home/circleci/dd-trace-java/workspace/dd-smoke-tests/wildfly/build'.

    Reason: Task ':dd-smoke-tests:wildfly:compileTestGroovy' uses this output of task ':dd-smoke-tests:wildfly:unzip' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':dd-smoke-tests:wildfly:unzip' as an input of ':dd-smoke-tests:wildfly:compileTestGroovy'.
      2. Declare an explicit dependency on ':dd-smoke-tests:wildfly:unzip' from ':dd-smoke-tests:wildfly:compileTestGroovy' using Task#dependsOn.
      3. Declare an explicit dependency on ':dd-smoke-tests:wildfly:unzip' from ':dd-smoke-tests:wildfly:compileTestGroovy' using Task#mustRunAfter.

    Please refer to https://docs.gradle.org/8.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
@smola smola added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels May 17, 2023
@smola
smola requested a review from a team as a code owner May 17, 2023 16:16
@pr-commenter

pr-commenter Bot commented May 17, 2023

Copy link
Copy Markdown

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~8fecf56edd 1.15.0-SNAPSHOT~59234c25d1
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@smola
smola merged commit 2bf5072 into master May 18, 2023
@smola
smola deleted the smola/fix-wildfly-smoke-test-build branch May 18, 2023 08:02
@github-actions github-actions Bot added this to the 1.15.0 milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants