Fix SessionStateTest#5229
Merged
Merged
Conversation
In #5015 the meaning of the boolean flag to SessionState constructor was inverted, but it was not updated in tests.
smola
added
comp: testing
bantonsson
approved these changes
May 17, 2023
bantonsson
left a comment
bantonsson
left a comment
Contributor
There was a problem hiding this comment.
You beat me to it. Was just about to open a PR.
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
In #5015 the meaning of the boolean flag to SessionState constructor was inverted, but it was not updated in tests.
Additional Notes
Note that this test is currently not running in CI. See #5213