Skip to content

Fix HealthMetricsTest flaky tests#5217

Merged
smola merged 1 commit into
masterfrom
smola/fix-HealthMetricsTest-onLongRunningUpdate
May 17, 2023
Merged

Fix HealthMetricsTest flaky tests#5217
smola merged 1 commit into
masterfrom
smola/fix-HealthMetricsTest-onLongRunningUpdate

Conversation

@smola

@smola smola commented May 16, 2023

Copy link
Copy Markdown
Member

What Does This Do

Motivation

CountDownLatch was initialized to 1 but we needed to wait for 3 calls.

Additional Notes

Test introduced at #4966

@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels May 16, 2023
@smola
smola requested a review from raphaelgavache May 16, 2023 14:36
@smola
smola requested a review from a team as a code owner May 16, 2023 14:36
@smola smola mentioned this pull request May 16, 2023
Merged
@raphaelgavache

raphaelgavache commented May 16, 2023

Copy link
Copy Markdown
Member

Thanks for catching this and sorry for the additional flaky test.
There's actually a few other tests above with the same problem and with a @flaky annotation

  • onPartialPublish
  • onFailedPublish

@smola
Fix HealthMetricsTest flaky tests
d7be917 
CountDownLatch was initialized to 1 but some tests need to wait for 2 or
3.
@smola
smola force-pushed the smola/fix-HealthMetricsTest-onLongRunningUpdate branch from 8b0811e to d7be917 Compare May 16, 2023 15:25
@smola smola changed the title Fix HealthMetricsTest.test onLongRunningUpdate Fix HealthMetricsTest flaky tests May 16, 2023
@smola

smola commented May 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@raphaelgavache Thank you. Fixed these two cases too.

@pr-commenter

pr-commenter Bot commented May 16, 2023

Copy link
Copy Markdown

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~a5c1744e0d 1.15.0-SNAPSHOT~d7be917e49
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@smola
smola merged commit cad9b13 into master May 17, 2023
@smola
smola deleted the smola/fix-HealthMetricsTest-onLongRunningUpdate branch May 17, 2023 09:20
@github-actions github-actions Bot added this to the 1.15.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raphaelgavache raphaelgavache raphaelgavache approved these changes

Assignees

No one assigned

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@smola @raphaelgavache