Skip to content

Fix job partitioning in CI#5213

Merged
smola merged 10 commits into
masterfrom
smola/fix-ci-partitioning
May 18, 2023
Merged

Fix job partitioning in CI#5213
smola merged 10 commits into
masterfrom
smola/fix-ci-partitioning

Conversation

@smola

@smola smola commented May 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What Does This Do

Fix test partitioning, which used project path hashCode without considering it can be negative.

Motivation

Additional Notes

Disabled tests

Tests that are disabled by this PR:

  • PowerWAFModuleSpecification.rule toggling data given through configuration which was disabled until recently anyway.

Related PRs

PRs fixing issues that were previously masked by this:

Affected modules

Effectively, some removed from this list since they run in non-parallelized jobs):

:dd-java-agent:agent-bootstrap
:dd-java-agent:agent-iast
:dd-java-agent:agent-jmxfetch
:dd-java-agent:agent-tooling
:dd-java-agent:appsec
:dd-java-agent:appsec:weblog
:dd-java-agent:benchmark-integration:play-perftest
:dd-java-agent:instrumentation
:dd-java-agent:instrumentation:akka-concurrent
:dd-java-agent:instrumentation:akka-http-10.0
:dd-java-agent:instrumentation:apache-httpclient-5
:dd-java-agent:instrumentation:caffeine
:dd-java-agent:instrumentation:cdi-1.2
:dd-java-agent:instrumentation:datanucleus-4
:dd-java-agent:instrumentation:dropwizard:dropwizard-views
:dd-java-agent:instrumentation:elasticsearch:rest-6.4
:dd-java-agent:instrumentation:google-http-client
:dd-java-agent:instrumentation:graal:native-image
:dd-java-agent:instrumentation:grizzly-2
:dd-java-agent:instrumentation:grizzly-http-2.3.20
:dd-java-agent:instrumentation:grpc-1.5
:dd-java-agent:instrumentation:hibernate
:dd-java-agent:instrumentation:ignite-2.0
:dd-java-agent:instrumentation:jackson-core
:dd-java-agent:instrumentation:java-concurrent
:dd-java-agent:instrumentation:java-lang:java-lang-9
:dd-java-agent:instrumentation:java-security
:dd-java-agent:instrumentation:jax-rs-annotations-1
:dd-java-agent:instrumentation:jax-rs-annotations-2
:dd-java-agent:instrumentation:jax-rs-client-2.0:connection-error-handling-jersey
:dd-java-agent:instrumentation:jax-ws-annotations-2
:dd-java-agent:instrumentation:jedis-3.0
:dd-java-agent:instrumentation:jedis-4.0
:dd-java-agent:instrumentation:jersey
:dd-java-agent:instrumentation:jersey-2-appsec
:dd-java-agent:instrumentation:jetty-appsec-9.3
:dd-java-agent:instrumentation:jetty-client-9.1
:dd-java-agent:instrumentation:junit-4.10
:dd-java-agent:instrumentation:kafka-clients-0.11
:dd-java-agent:instrumentation:kotlin-coroutines:coroutines-1.5
:dd-java-agent:instrumentation:liberty-20
:dd-java-agent:instrumentation:log4j2
:dd-java-agent:instrumentation:logback-1
:dd-java-agent:instrumentation:micronaut:http-server-netty-2.0
:dd-java-agent:instrumentation:mongo
:dd-java-agent:instrumentation:mongo:common
:dd-java-agent:instrumentation:mongo:driver-3.4
:dd-java-agent:instrumentation:mongo:driver-3.7-core-test
:dd-java-agent:instrumentation:mule-4
:dd-java-agent:instrumentation:netty-3.8
:dd-java-agent:instrumentation:netty-4.0
:dd-java-agent:instrumentation:netty-4.1
:dd-java-agent:instrumentation:netty-buffer-4
:dd-java-agent:instrumentation:netty-promise-4
:dd-java-agent:instrumentation:opentelemetry:opentelemetry-0.3
:dd-java-agent:instrumentation:opentelemetry:opentelemetry-1.4
:dd-java-agent:instrumentation:opentracing:api-0.31
:dd-java-agent:instrumentation:opentracing:api-0.32
:dd-java-agent:instrumentation:play-ws-2
:dd-java-agent:instrumentation:reactor-netty-1
:dd-java-agent:instrumentation:redisson-2.0.0
:dd-java-agent:instrumentation:renaissance
:dd-java-agent:instrumentation:resteasy-appsec
:dd-java-agent:instrumentation:servlet:request-2
:dd-java-agent:instrumentation:servlet:request-3
:dd-java-agent:instrumentation:servlet:request-5
:dd-java-agent:instrumentation:shutdown
:dd-java-agent:instrumentation:slick
:dd-java-agent:instrumentation:spring-cloud-zuul-2
:dd-java-agent:instrumentation:testng:testng-7.5
:dd-java-agent:instrumentation:tomcat-appsec-5.5
:dd-java-agent:instrumentation:tomcat-appsec-6
:dd-java-agent:instrumentation:twilio
:dd-java-agent:instrumentation:undertow
:dd-java-agent:instrumentation:vertx-mysql-client-3.9
:dd-java-agent:instrumentation:vertx-redis-client-3.9
:dd-java-agent:load-generator
:dd-smoke-tests:appsec
:dd-smoke-tests:appsec:springboot
:dd-smoke-tests:gradle
:dd-smoke-tests:jboss-modules
:dd-smoke-tests:jersey
:dd-smoke-tests:jersey-2
:dd-smoke-tests:opentracing
:dd-smoke-tests:play-2.8-split-routes
:dd-smoke-tests:profiling-integration-tests
:dd-smoke-tests:spring-boot-2.3-webmvc-jetty
:dd-smoke-tests:spring-boot-2.6-webmvc
:dd-smoke-tests:springboot-grpc
:dd-smoke-tests:springboot-openliberty
:dd-smoke-tests:spring-boot-rabbit
:dd-smoke-tests:spring-security
:dd-smoke-tests:wildfly
:dd-trace-core
:dd-trace-ot:correlation-id-injection
:remote-config
:telemetry
:utils:container-utils
:utils:socket-utils
:utils:test-utils

@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels May 16, 2023
@smola
smola requested a review from a team as a code owner May 16, 2023 13:27
richardstartin
richardstartin reviewed May 16, 2023
View reviewed changes
Comment thread build.gradle Outdated
@pr-commenter

pr-commenter Bot commented May 16, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~05f9c53c29 1.15.0-SNAPSHOT~3aa446b193
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 21 cases.

scenario Δ mean execution_time
scenario:Startup-iast-Remote Config better
[-54.001µs; -8.834µs] or [-8.156%; -1.334%]
See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST unsure
[-0.780ms; -0.008ms] or [-6.392%; -0.063%]
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@smola smola mentioned this pull request May 16, 2023
Merged
@smola
smola force-pushed the smola/fix-ci-partitioning branch from b1d28fe to 545dd76 Compare May 16, 2023 14:41
@smola
smola requested a review from a team as a code owner May 16, 2023 14:41
@smola
smola force-pushed the smola/fix-ci-partitioning branch from 9a48b82 to 037b999 Compare May 17, 2023 09:48
@smola
smola requested a review from a team as a code owner May 17, 2023 09:48
@smola
smola force-pushed the smola/fix-ci-partitioning branch 4 times, most recently from 92d1921 to 8ab87dd Compare May 17, 2023 15:58
@smola smola mentioned this pull request May 17, 2023
Merged
@smola
smola force-pushed the smola/fix-ci-partitioning branch from 4e8f0fc to bbbafc7 Compare May 18, 2023 08:51
@smola
smola force-pushed the smola/fix-ci-partitioning branch from bbbafc7 to 9c17c0f Compare May 18, 2023 08:55
@smola
smola force-pushed the smola/fix-ci-partitioning branch from 9c17c0f to 783f32b Compare May 18, 2023 08:58
@smola
smola requested a review from a team May 18, 2023 09:32
smola added 4 commits May 18, 2023 11:52
@smola
Fix resource names in RedissonClientTest
295a56e
@smola
Clean up servlet IAST test
c979b2f
@smola
Fix RedissonClientTest for peer_host tag
d8adac9 
The test expects peer host to be localhost, but unless localhost is used
in the connection configuration, 127.0.0.1 will be used.
@smola
Avoid Scala malformed class name in IAST tests
3aa446b
@smola
smola force-pushed the smola/fix-ci-partitioning branch from 693d8e0 to 3aa446b Compare May 18, 2023 09:53
@smola
smola merged commit 0430b67 into master May 18, 2023
@smola
smola deleted the smola/fix-ci-partitioning branch May 18, 2023 12:23
@github-actions github-actions Bot added this to the 1.15.0 milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes
+1 more reviewer
@richardstartin richardstartin richardstartin left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@smola @manuel-alvarez-alvarez @richardstartin