Skip to content

Fix InsecureCookieModuleTest#5212

Merged
smola merged 1 commit into
masterfrom
jsantos/insecure-cookie-server-test-fix
May 16, 2023
Merged

Fix InsecureCookieModuleTest#5212
smola merged 1 commit into
masterfrom
jsantos/insecure-cookie-server-test-fix

Conversation

@DDJavierSantos

Copy link
Copy Markdown
Contributor

What Does This Do

Fix a mistake on a unit test in iast-agent. The test is failing, but CI is not reporting it as failed. It passes after the fix.

Motivation

To make sure that all tests work in master

Additional Notes

@smola smola changed the title test fixed Fix InsecureCookieModuleTest May 16, 2023
@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes comp: asm iast Application Security Management (IAST) labels May 16, 2023
@pr-commenter

pr-commenter Bot commented May 16, 2023

Copy link
Copy Markdown

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~e3a8b92168 1.15.0-SNAPSHOT~013fdfb15e
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@smola
smola marked this pull request as ready for review May 16, 2023 14:01
@smola
smola requested a review from a team May 16, 2023 14:01
@smola
smola merged commit d5325f8 into master May 16, 2023
@smola
smola deleted the jsantos/insecure-cookie-server-test-fix branch May 16, 2023 14:06
@github-actions github-actions Bot added this to the 1.15.0 milestone May 16, 2023
@DDJavierSantos
DDJavierSantos restored the jsantos/insecure-cookie-server-test-fix branch May 16, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm iast Application Security Management (IAST) comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants