Fix timestamp units in WAF telemetry metrics#5125
Merged
Merged
Conversation
| public WafMetric(String metricName, long counter, final String... tags) { | ||
| this.metricName = metricName; | ||
| this.timestamp = System.currentTimeMillis(); | ||
| this.timestamp = System.currentTimeMillis() / 1000; |
There was a problem hiding this comment.
Same thing happened to me while building IAST metrics 🤦
manuel-alvarez-alvarez
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Convert timestamps in WAF telemetry metric points from milliseconds to seconds.
Motivation
Timestamps for telemetry metrics are defined in seconds (as a double). We can just encode it as an integer, since the sub-second resolution seems to be pointless here.
Additional Notes