Improvements for WAF telemetry metrics#5113
Merged
Merged
Conversation
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
smola
force-pushed
the
smola/waf-missing-metric-tags
branch
2 times, most recently
from
April 25, 2023 14:47
0ef7c63 to
ffaa8f9
Compare
* Prefix `MetricCollector` and related classes with `Waf`. These are currently strongly coupled to WAF metrics. * Add missing tags for waf.updates and waf.requests. * Whenever there is a rules update, flush waf.requests, since further requests need a new event_rules_version tag. * Do not double count blocked requests.
smola
force-pushed
the
smola/waf-missing-metric-tags
branch
from
April 26, 2023 07:45
ffaa8f9 to
7ac3c72
Compare
PerfectSlayer
approved these changes
Apr 26, 2023
PerfectSlayer
left a comment
PerfectSlayer
left a comment
Contributor
There was a problem hiding this comment.
Weird that git fails to detect file rename 🤷
ValentinZakharov
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Improvements for WAF telemetry metrics
MetricCollectorand related classes withWaf. These are currently strongly coupled to WAF metrics.Motivation
Get our WAF telemetry up to date with the spec.
Additional Notes
It might be a good idea to unify some of the code to collect IAST and WAF telemetry metrics, but that's out of scope for this PR.