[data streams] Remove partition tag from latency metrics#5109
Merged
Conversation
piochelepiotr
force-pushed
the
piotr-wolski/remove-partition-tag
branch
from
April 25, 2023 04:02
19f107c to
9280100
Compare
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
PerfectSlayer
approved these changes
Apr 25, 2023
hokitam
approved these changes
Apr 25, 2023
kr-igor
reviewed
Apr 25, 2023
Contributor
There was a problem hiding this comment.
Not sure why GROUP_TAG removed here, I believe this is "Consumer group"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
partition tag on this metric is making cardinality really high.
We have data by partition on consumer lag, so removing it from here.
We also don't use that information in the UI.
Motivation
Additional Notes