Improve OpenTelemetry instrumentation#5096
Merged
Merged
Conversation
PerfectSlayer
force-pushed
the
bbujon/otel-tracer
branch
from
April 21, 2023 12:44
ff434fd to
c168bac
Compare
PerfectSlayer
marked this pull request as ready for review
April 21, 2023 12:52
PerfectSlayer
added
inst: opentelemetry
bantonsson
reviewed
Apr 21, 2023
bantonsson
approved these changes
Apr 21, 2023
PerfectSlayer
force-pushed
the
bbujon/otel-tracer
branch
from
April 21, 2023 16:02
c168bac to
bb39e8e
Compare
PerfectSlayer
force-pushed
the
bbujon/otel-tracer
branch
from
April 24, 2023 06:55
bb39e8e to
1076918
Compare
bantonsson
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add empty string value support for span attribute,
Fix span context sampling flag,
Fix tests after RFC change.
Motivation
Empty string value is a meaningful attribute value for OTel span.
So it should not be ignored nor cleared from span tags.
Additional Notes