Use well-know crashlog name if not specified#5094
Merged
Merged
Conversation
richardstartin
approved these changes
Apr 21, 2023
jbachorik
force-pushed
the
jb/crash_tracking_init
branch
2 times, most recently
from
April 21, 2023 12:01
81e0460 to
4abab6b
Compare
jbachorik
force-pushed
the
jb/crash_tracking_init
branch
from
April 24, 2023 06:52
4abab6b to
3c24e4c
Compare
richardstartin
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Makes the crash upload script initializer to use a well known value for the JVM crash log file if
-XX:ErrorFileis not specified.Motivation
This is done in order to make the crash tracking config less complex such that it is enough to specify
-XX:OnError=<path_to>/dd_crash_uploader.shand the agent would take care of generating the crash upload script at the given location if it already does not exist.Additional Notes