Skip to content

When the OpenTracing wrapper is closed, flush any traces but keep the wrapped tracer open#5091

Merged
mcculls merged 1 commit into
masterfrom
mcculls/dont-close-wrapped-tracer-via-ot-api
Apr 20, 2023
Merged

When the OpenTracing wrapper is closed, flush any traces but keep the wrapped tracer open#5091
mcculls merged 1 commit into
masterfrom
mcculls/dont-close-wrapped-tracer-via-ot-api

Conversation

@mcculls

@mcculls mcculls commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

Motivation

Avoids a situation when the OpenTracing Tracer.close() method is called when Wildfly applications are re-deployed, prematurely closing the wrapped Datadog tracer.

@mcculls mcculls added the inst: others All other instrumentations label Apr 20, 2023
@mcculls
mcculls requested a review from a team as a code owner April 20, 2023 09:56
@mcculls
mcculls merged commit 90f7e69 into master Apr 20, 2023
@mcculls
mcculls deleted the mcculls/dont-close-wrapped-tracer-via-ot-api branch April 20, 2023 13:29
@github-actions github-actions Bot added this to the 1.13.0 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: others All other instrumentations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants