Support AWS Lambda parent inheritance#5089
Merged
Merged
Conversation
maxday
reviewed
Apr 19, 2023
maxday
self-requested a review
April 24, 2023 18:23
maxday
self-requested a review
April 24, 2023 18:23
maxday
approved these changes
Apr 24, 2023
bantonsson
approved these changes
Apr 25, 2023
Contributor
|
@DarcyRaynerDD could you please squash the commits when you merge the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes a bug with Lambda span generation, when using an abstract base class.
Also fixes a bug where com.amazonaws.services.lambda.runtime.RequestStreamHandler was not being wrapped correctly, because it has a void return type, which the ExtensionAdvice class wasn't matching properly. I've added a test case for this.
Before:
After:
Motivation
If a customer creates an Abstract Base Class, which implements the
com.amazonaws.services.lambda.runtime.RequestHandler, currently our instrumentation won't correctly wrap thehandleRequestmethod, leading to broken traces. This changes the instrumentation matcher to find all classes in the hierachy which implement the RequestHandler interface.Additional Notes