Skip to content

Add kafka bootstrap server to producer span#5052

Merged
amarziali merged 1 commit into
masterfrom
andrea.marziali/kafka-producer-bootstrap-servers
May 2, 2023
Merged

Add kafka bootstrap server to producer span#5052
amarziali merged 1 commit into
masterfrom
andrea.marziali/kafka-producer-bootstrap-servers

Conversation

@amarziali

@amarziali amarziali commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

What Does This Do

Adds kafka bootstrap servers list (tag messaging.kafka.bootstrap.servers to the kafka producer span (used to compute later peer.service).

Motivation

Additional Notes

@amarziali
amarziali requested a review from a team as a code owner April 12, 2023 11:56
@amarziali amarziali added the inst: kafka Kafka instrumentation label Apr 12, 2023
@amarziali
amarziali force-pushed the andrea.marziali/kafka-producer-bootstrap-servers branch from c7f3a37 to 17fe520 Compare April 24, 2023 12:35
@pr-commenter

pr-commenter Bot commented Apr 24, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Parameters

Baseline Candidate
commit 1.13.0-SNAPSHOT~6dd932c714 1.13.0-SNAPSHOT~17fe520937
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 19 cases.

scenario Δ mean execution_time
scenario:Startup-base-Remote Config worse
[+17.562µs; +55.830µs] or [+2.788%; +8.862%]
scenario:Startup-base-Telemetry worse
[+0.183ms; +0.422ms] or [+3.032%; +7.004%]
scenario:Startup-iast-BytebuddyAgent better
[-11.860ms; -7.440ms] or [-1.826%; -1.146%]
See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-iast-Agent unsure
[-0.143s; -0.014s] or [-1.495%; -0.149%]
scenario:Startup-iast-Agent.start unsure
[-0.013s; -0.006s] or [-1.259%; -0.622%]
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config unsure
[-18.574µs; -4.744µs] or [-3.087%; -0.788%]
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start unsure
[-0.009s; -0.001s] or [-0.844%; -0.078%]
scenario:Startup-waf-BytebuddyAgent unsure
[-6.671ms; -2.120ms] or [-1.136%; -0.361%]
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

ygree
ygree reviewed Apr 28, 2023
View reviewed changes
Comment thread ...a-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/KafkaDecorator.java Outdated

@ygree ygree Apr 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

ygree
ygree approved these changes Apr 28, 2023
View reviewed changes

@ygree ygree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali
amarziali force-pushed the andrea.marziali/kafka-producer-bootstrap-servers branch from c66f974 to 17fe520 Compare May 2, 2023 09:45
@amarziali
amarziali merged commit f0c46b9 into master May 2, 2023
@amarziali
amarziali deleted the andrea.marziali/kafka-producer-bootstrap-servers branch May 2, 2023 12:12
@github-actions github-actions Bot added this to the 1.13.0 milestone May 2, 2023
@richardstartin richardstartin changed the title add kafka bootstrap server to producer span Add kafka bootstrap server to producer span May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bantonsson bantonsson bantonsson approved these changes
@ygree ygree ygree approved these changes

Assignees

No one assigned

Labels

inst: kafka Kafka instrumentation

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @bantonsson @ygree