Add support for SSRF vulnerabilities#5051
Merged
Merged
Conversation
manuel-alvarez-alvarez
added
the
comp: asm iast
Member
Author
There was a problem hiding this comment.
I think it might make sense to build a different module (aka UrlModule) to deal with the propagation in URLs
manuel-alvarez-alvarez
force-pushed
the
malvarez/ssrf
branch
6 times, most recently
from
April 12, 2023 16:43
e87d2b2 to
f1841a7
Compare
smola
reviewed
Apr 21, 2023
manuel-alvarez-alvarez
force-pushed
the
malvarez/ssrf
branch
from
April 21, 2023 16:17
f1841a7 to
53476ce
Compare
manuel-alvarez-alvarez
marked this pull request as ready for review
April 21, 2023 16:17
manuel-alvarez-alvarez
force-pushed
the
malvarez/ssrf
branch
from
April 24, 2023 08:47
53476ce to
3a39357
Compare
smola
requested changes
Apr 24, 2023
Member
Author
There was a problem hiding this comment.
The class has the annotation:
@IastAdvice.Propagation(PropagationTypes.URI)
@CallSite(spi = IastAdvice.class)
public class URICallSite {
...
}Method annotations take precedence over the type annotation so you can override the telemetry annotation.
manuel-alvarez-alvarez
force-pushed
the
malvarez/ssrf
branch
from
April 24, 2023 09:47
3a39357 to
e03b5d2
Compare
smola
approved these changes
Apr 24, 2023
manuel-alvarez-alvarez
force-pushed
the
malvarez/ssrf
branch
from
April 25, 2023 07:14
e03b5d2 to
1146797
Compare
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
manuel-alvarez-alvarez
force-pushed
the
malvarez/ssrf
branch
from
April 26, 2023 09:27
1146797 to
88235df
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/ssrf
branch
from
April 26, 2023 11:25
88235df to
28b8238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds support for SSRF detection via jdk (URL/URI), okhttp (versions 2 and 3) and commons httpclient (versions 1 and 2)
Motivation
Additional Notes
Support for other frameworks like apache commons (4 and 5), spring rest-template will come later