Extract remote host info from spymemecached#5049
Merged
Merged
Conversation
amarziali
changed the title
amarziali
force-pushed
the
andrea.marziali/memcached-peer-info
branch
3 times, most recently
from
April 12, 2023 12:08
644a917 to
216c409
Compare
amarziali
force-pushed
the
andrea.marziali/memcached-peer-info
branch
from
April 24, 2023 12:33
216c409 to
2aca3df
Compare
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
ygree
reviewed
Apr 27, 2023
| } | ||
|
|
||
| public static void muzzleCheck(OperationFuture operationFuture) { | ||
| // before 2.10.4 futures are not completing correctly. We stick at this as minimum version |
Contributor
There was a problem hiding this comment.
Still nice to have 2.10.4+ support vs 2.12+
ygree
reviewed
Apr 27, 2023
| try (final AgentScope scope = activateSpan(span)) { | ||
| DECORATE.afterStart(span); | ||
| DECORATE.onConnection(span, connection); |
Contributor
There was a problem hiding this comment.
With this change it's nice to have on a connection decoration in a more appropriate place than within this listener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Extract remote peer connection info for memecached spans:
Motivation
Additional Notes