Decouple time in queue from legacy tracing#5015
Merged
Merged
Conversation
amarziali
force-pushed
the
andrea.marziali/v1-queue-time
branch
from
April 24, 2023 12:07
3e929b5 to
d429ade
Compare
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
amarziali
added
inst: others
ygree
reviewed
Apr 27, 2023
ygree
reviewed
Apr 27, 2023
amarziali
force-pushed
the
andrea.marziali/v1-queue-time
branch
from
April 28, 2023 08:46
d429ade to
fdf9a02
Compare
smola
added a commit
that referenced
this pull request
May 17, 2023
In #5015 the meaning of the boolean flag to SessionState constructor was inverted, but it was not updated in tests.
Merged
smola
added a commit
that referenced
this pull request
May 18, 2023
In #5015 the meaning of the boolean flag to SessionState constructor was inverted, but it was not updated in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Decouple time in queue tracking from legacy tracing.
The time in queue can be driven independently with the parameter
dd.<instrumentation>.time-in-queue.enabledBy default it will be enabled if legacy tracing is disabled (as today)
Quick note: for the v1 naming schema, time in queue is disabled by default because synthetic spans should not be present in the service map
Motivation
Additional Notes