[6to7] Add support for 128-bit TraceId logging#4938
Merged
Conversation
PerfectSlayer
added
tag: do not merge
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-logging
branch
from
March 22, 2023 12:27
43a670a to
ec06287
Compare
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-next
branch
3 times, most recently
from
March 24, 2023 12:09
9885c2c to
28f98fb
Compare
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-logging
branch
5 times, most recently
from
March 27, 2023 14:51
a82eaf4 to
b5c8d1a
Compare
bantonsson
reviewed
Mar 28, 2023
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-next
branch
from
March 28, 2023 17:12
24794dd to
c61b07b
Compare
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-logging
branch
from
March 28, 2023 18:06
f0eafa8 to
79534e3
Compare
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-next
branch
6 times, most recently
from
April 3, 2023 07:10
8593279 to
95f05ae
Compare
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-logging
branch
2 times, most recently
from
April 3, 2023 11:30
f0381d0 to
e36e8d2
Compare
PerfectSlayer
marked this pull request as ready for review
April 3, 2023 12:05
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-logging
branch
2 times, most recently
from
April 4, 2023 04:45
91ace5a to
a197e18
Compare
bantonsson
reviewed
Apr 4, 2023
jpbempel
approved these changes
Apr 4, 2023
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-logging
branch
from
April 4, 2023 09:02
a197e18 to
e36e8d2
Compare
PerfectSlayer
changed the title
bantonsson
approved these changes
Apr 4, 2023
PerfectSlayer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR add logging correlation support for 128-bit TraceIds.
It adds a new flag
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED(disabled by default) to control whether 64-bit or 128-bit will be logged.When enabled, it will change the TraceId correlation value from "decimal" to "hexadecimal zero-padded" number for 128-bit TraceId only.
Motivation
Additional Notes
This PR follows the initial support for 128-bit TraceId #4918