Initial version of the vert.x 4.x instrumentation#4922
Merged
Conversation
manuel-alvarez-alvarez
added
the
comp: asm iast
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx-support
branch
from
March 20, 2023 11:59
730d148 to
012980f
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
March 20, 2023 12:16
1f9dab3 to
fb4401f
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx-support
branch
from
March 27, 2023 09:25
012980f to
5774d75
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
March 27, 2023 09:38
fb4401f to
fb90479
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx-support
branch
from
March 27, 2023 10:25
5774d75 to
1bb6918
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
March 27, 2023 10:29
fb90479 to
e959aae
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx-support
branch
2 times, most recently
from
March 27, 2023 17:09
073ca08 to
bf45af7
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
March 27, 2023 17:27
e959aae to
93755de
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
March 29, 2023 09:08
93755de to
266b455
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx-support
branch
from
March 30, 2023 11:26
bf45af7 to
9b0f8ea
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
2 times, most recently
from
March 30, 2023 14:15
cf52eb0 to
9a05677
Compare
manuel-alvarez-alvarez
marked this pull request as ready for review
March 30, 2023 14:17
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
5 times, most recently
from
April 5, 2023 07:23
3ff626d to
350f67f
Compare
smola
reviewed
Apr 10, 2023
Member
There was a problem hiding this comment.
It's about time we add preventive checks (taintedMap.get) to avoid tainting the same object multiple times.
Member
Author
There was a problem hiding this comment.
Sure, I'll update the PR and add the required checks.
Member
Author
There was a problem hiding this comment.
I've added them at the level of the propagation module (if we keep the web module we probably want to add them there as well)
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
April 10, 2023 09:58
350f67f to
6db78e5
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
3 times, most recently
from
April 14, 2023 07:50
3b6518a to
7689fbc
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
2 times, most recently
from
April 20, 2023 19:02
13d8ee4 to
66138f6
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
April 24, 2023 08:03
66138f6 to
a87fc81
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-vertx4-support
branch
from
April 24, 2023 08:48
a87fc81 to
9fb7ee7
Compare
smola
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Includes the required instrumentation points to add support for IAST in vert.x 4.x
Motivation
Additional Notes