Jackson 1 instrumentation for IAST#4783
Merged
Merged
Conversation
smola
requested changes
Feb 24, 2023
DDJavierSantos
force-pushed
the
jsantos/jackson-1-instrumentation
branch
from
March 23, 2023 16:52
196cd70 to
05bfa00
Compare
smola
requested changes
Mar 24, 2023
smola
requested changes
Mar 29, 2023
manuel-alvarez-alvarez
approved these changes
Apr 3, 2023
DDJavierSantos
force-pushed
the
jsantos/jackson-1-instrumentation
branch
from
April 18, 2023 16:52
4229846 to
83bdc02
Compare
smola
requested changes
Apr 19, 2023
DDJavierSantos
force-pushed
the
jsantos/jackson-1-instrumentation
branch
from
April 21, 2023 07:43
b8c329c to
1f04c26
Compare
smola
reviewed
Apr 24, 2023
smola
left a comment
smola
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Just one comment about iast-instrumenter dependency.
smola
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Instrument the older versions of the jackson library.
Motivation
org.codehaus.jackson is used by Jersey 2 to deserialize json objects. We need to instrument the parser calls so we can achieve propagation in IAST.
Additional Notes